From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754427AbbC3X6I (ORCPT ); Mon, 30 Mar 2015 19:58:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:14917 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754022AbbC3X6E convert rfc822-to-8bit (ORCPT ); Mon, 30 Mar 2015 19:58:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,497,1422950400"; d="scan'208";a="474668839" From: "Ong, Boon Leong" To: "Zhang, Rui" , "edubezval@gmail.com" CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ong, Boon Leong" , "pure.logic@nexus-software.ie" , "Kweh, Hock Leong" , "andy.shevchenko@gmail.com" Subject: RE: [PATCHv3 0/1] Intel Quark X1000 DTS thermal driver Thread-Topic: [PATCHv3 0/1] Intel Quark X1000 DTS thermal driver Thread-Index: AQHQWj0RuFBl66vTHkGt4bJR3KGQ45011aDg Date: Mon, 30 Mar 2015 23:57:57 +0000 Message-ID: References: <1425886977-31078-1-git-send-email-boon.leong.ong@intel.com> In-Reply-To: <1425886977-31078-1-git-send-email-boon.leong.ong@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear maintainer, gentle ping if this driver is ready for more review/inclusion into Linux v4.1 ? Thank you very much. >-----Original Message----- >From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >owner@vger.kernel.org] On Behalf Of Ong Boon Leong >Sent: Monday, March 9, 2015 3:43 PM >To: Zhang, Rui; edubezval@gmail.com; pure.logic@nexus-software.ie; Kweh, >Hock Leong; andy.shevchenko@gmail.com >Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org >Subject: [PATCHv3 0/1] Intel Quark X1000 DTS thermal driver > >Dear maintainers & communities, > >This patch introduces DTS thermal driver for Intel Quark X1000. >The code implementation is based on intel_soc_dts_thermal.c. > >Intel Quark X1000 has one on-die DTS with two configurable trip points: >critical and hot trip points. However, todate, UEFI BIOS for Quark X1000 uses >only critical trip point. UEFI BIOS always lock DTS register before hand-over to >Linux kernel. > >The minimalist thermal design is meant to trigger Linux distro to gracefully >power-down the system when its DTS temperature exceeds the configured >critical trip point. > >In anticipation that other variant of Quark platform may come with UEFI BIOS >that does not lock DTS register during hand-over, this DTS driver is built with >logics to handle such case too. > >I have tested v1 of the patch on Intel Galileo Gen v2 board and found it >satisfactory with logs below: > > root@quark:/sys/class/thermal/thermal_zone0# echo disabled > mode > [ 46.276881] intel_quark_dts_thermal: DTS is locked. Cannot disable DTS > -sh: echo: write error: Operation not permitted > root@quark:/sys/class/thermal/thermal_zone0# > root@quark:/sys/class/thermal/thermal_zone0# cat temp > 53 > root@quark:/sys/class/thermal/thermal_zone0# cat trip_point_0_temp > 105 > root@quark:/sys/class/thermal/thermal_zone0# cat trip_point_0_type > critical > root@quark:/sys/class/thermal/thermal_zone0# cat trip_point_1_temp > 20 > root@quark:/sys/class/thermal/thermal_zone0# cat trip_point_1_type > hot > root@quark:/sys/class/thermal/thermal_zone0# cat type > quark_dts > > root@quark:/sys/class/thermal/thermal_zone0# echo 105 > emul_temp > [ 179.372981] thermal thermal_zone0: critical temperature reached(0 >C),shutting down > root@quark:/sys/class/thermal/thermal_zone0# > [ OK ] Stopped target Multi-User System. > Stopping Telephony service... > Stopping Lightning Fast Webserver With Light System Requirements... > Stopping Target Communication Framework agent... > Stopping Galileo Arduino Layer... > [ OK ] Stopped target Login Prompts. > Stopping Getty on tty1... > Stopping Serial Getty on ttyS1... > Stopping Login Service... > Stopping D-Bus System Message Bus... > Starting Store Sound Card State... > [ OK ] Stopped Telephony service. > [ OK ] Stopped Galileo Arduino Layer. > [ OK ] Stopped Login Service. > [ OK ] Stopped D-Bus System Message Bus. > [ OK ] Stopped Target Communication Framework agent. > [ OK ] Stopped Lightning Fast Webserver With Light System Requirements. > [ OK ] Stopped WPA supplicant. > [ OK ] Stopped Getty on tty1. > [ OK ] Stopped Serial Getty on ttyS1. > >Please kindly review the patch at your convenient time and provide me feedback >for improvement. Appreciate your time and effort. > >Thank You >Ong Boon Leong >Intel Corp. > >--- >Changes in v3: >* Kconfig dependency changed to X86_INTEL_QUARK > >Changes in v2: >* Fix several commit write-up grammar, choice of words. >* Ensure "int ret" in correct order >* Add comment to explain DTS register field read/write bit operation >* Change to Dual BSD/GPL license >* Add logic to ensure safe trip point threshold value being set > >Ong Boon Leong (1): > thermal: intel Quark SoC X1000 DTS thermal driver > > drivers/thermal/Kconfig | 10 > drivers/thermal/Makefile | 1 > drivers/thermal/intel_quark_dts_thermal.c | 434 >+++++++++++++++++++++++++++++ > 3 files changed, 445 insertions(+) > create mode 100644 drivers/thermal/intel_quark_dts_thermal.c > >-- >1.7.9.5 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body >of a message to majordomo@vger.kernel.org More majordomo info at >http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/