From: weizhenliang <weizhenliang@huawei.com>
To: Christian Brauner <christian@brauner.io>
Cc: Oleg Nesterov <oleg@redhat.com>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"colona@arista.com" <colona@arista.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"deepa.kernel@gmail.com" <deepa.kernel@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit
Date: Tue, 23 Apr 2019 14:02:21 +0000 [thread overview]
Message-ID: <AF4D908CC0E2A24EB308A26962C8C3BDEB16D1@DGGEMI530-MBX.china.huawei.com> (raw)
On Tue, Apr 23, 2019 at 09:41 PM Christian wrote:
>On Tue, Apr 23, 2019 at 01:10:52PM +0000, weizhenliang wrote:
>> On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov <oleg@redhat.com> wrote:
>> >On 04/22, Zhenliang Wei wrote:
>> >>
>> >> --- a/kernel/signal.c
>> >> +++ b/kernel/signal.c
>> >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
>> >> if (signal_group_exit(signal)) {
>> >> ksig->info.si_signo = signr = SIGKILL;
>> >> sigdelset(¤t->pending.signal, SIGKILL);
>> >> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
>> >> recalc_sigpending();
>> >> goto fatal;
>> >> }
>> >
>> >Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>>
>> Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'.
>
>Sigh, I should've caught that in the first commit.
>Although it suggests you didn't even compile your patch...
>
>>
>> How about
>> trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr
>> - 1]); ?
>
>That should work, yes.
Sorry about that, I was too focused on the functionality and didn't notice the compile warning.
And thanks for your reply, I will pay more attention to it in the future.
Zhenliang Wei
next reply other threads:[~2019-04-23 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:02 weizhenliang [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-23 14:25 [PATCH v3] signal: trace_signal_deliver when signal_group_exit weizhenliang
2019-04-23 14:13 weizhenliang
2019-04-23 13:10 weizhenliang
2019-04-23 13:33 ` Christian Brauner
2019-04-23 13:35 ` Oleg Nesterov
2019-04-22 14:59 Zhenliang Wei
2019-04-22 15:25 ` Oleg Nesterov
2019-04-22 20:41 ` Greg KH
2019-04-22 23:01 ` kbuild test robot
2019-04-23 1:09 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF4D908CC0E2A24EB308A26962C8C3BDEB16D1@DGGEMI530-MBX.china.huawei.com \
--to=weizhenliang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=colona@arista.com \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.