From mboxrd@z Thu Jan 1 00:00:00 1970 From: Noah Watkins Subject: Re: [RFC] v2 separate otw data from host data Date: Fri, 6 Nov 2009 12:04:03 -0800 Message-ID: References: <3A19C8FD-BDC5-41A5-BBED-8C8CE47FBEFC@soe.ucsc.edu> <1826697A-2DAB-4532-99B1-E1247AFDAD64@soe.ucsc.edu> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ceph-devel-bounces@lists.sourceforge.net To: Sage Weil Cc: Noah Watkins , ceph-devel@lists.sourceforge.net List-Id: ceph-devel.vger.kernel.org > - should use 'wire' instead of 'otw' consistently? Up vote from me. I like 'wire' better than 'otw'. > - the layout validation func is used by userspace, and should > eventually > be used by the kclient Ahh, I'll restore this. And ceph_ioctl_set_layout does some basic layout validation. These could be merged? > - lost the comments on the struct in ceph_fs.h I bumped the inline comments to a block comment above the struct. Or did you mean 'lose them' instead of 'lost' ? > >> Looking over it again, perhaps just using some accessor macros is >> the best. > > Yeah... Well, at some point we should probably add a 'wire' suffix > (prefix?) to all the disk/wire types, though. (I'll stick that in the > TODO. It needs to be coordinated with the userspace change.) This > can > come after? If this is overall a step in the right direction then starting with this patch, and re-visiting the topic as a larger iterative clean-up seems reasonable. This brings up a good point about the level at which nested structures are labeled as 'wire'. For example, ceph_mds_reply_inode is a struct that should be labeled as 'wire', but it would be ugly to label all members of that struct as 'wire'. -n ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july