From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B198C43460 for ; Thu, 6 May 2021 16:21:52 +0000 (UTC) Received: from mail.server123.net (mail.server123.net [78.46.64.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D49A610D2 for ; Thu, 6 May 2021 16:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D49A610D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=sap.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dm-crypt-bounces@saout.de X-Virus-Scanned: amavisd-new at saout.de Authentication-Results: mail.server123.net (amavisd-new); dkim=pass (2048-bit key) header.d=sap.com header.b=a9lktbaw; dkim=pass (1024-bit key) header.d=sap.onmicrosoft.com header.b=NXL5vSa0 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=216.71.157.144; helo=esa5.sap.c3s2.iphmx.com; envelope-from=robert.schneider03@sap.com; receiver= X-Greylist: delayed 185 seconds by postgrey-1.37 at siona; Thu, 06 May 2021 18:19:15 CEST Received: from esa5.sap.c3s2.iphmx.com (esa5.sap.c3s2.iphmx.com [216.71.157.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.server123.net (Postfix) with ESMTPS for ; Thu, 6 May 2021 18:19:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sap.com; i=@sap.com; q=dns/txt; s=it-20200722; t=1620317955; x=1651853955; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=2TfuI705147bk/7/A4gWvciPe6ewp2+mLziNur3LNZs=; b=a9lktbaw+gRjuA3lo3+/knogWAyv9TOqv7pRpKTZA5KronmQ07ATUbNV +iJo7Vz8DCnTrPcIRy8vcDp0pkJGhedNiphqZvX7mVUR3XK+Ox4cgBb2q GknBYTSDLnxsYaJX3Oq1ae/bY1/ouBIO4Dz6vq7lQGt7l4p/HXM2oQXjN 21SFcL7s+Ru9Ls9zJbsU0UmS3zLSC4Rp4KTUiNnHuoMUieBz9xIebz+S6 eMGhbv/oCu+eAPC4DT0G643wx57P8+ZIEnZCleznmGznwdtbuyxgA/Xo8 yk/pPxe4BPJJrNzrvtQUCCfhpfBropy2moNAFHteycv6QlyCdAIO7gmxo w==; IronPort-SDR: PScRVGaIPkrJ96l8qjIQdR4F/cimrNip1cVU8YxMvPIcANRjbPN8HEFWoZzdOScCn+LRGoYLqj ekD5y/4wvpWbgXJ8uFDYkqn/fIJ0IotkRLSrba8D/4mVKg44AXigH57rL255yNOMWNpyhDoYgs fEy+ej0yo/uwLKaMDqnlpKYKN8xW3db7QnB5uny92HvPBDwXriiqd/iWBCmwn2WfGIJ+gBfn+W WNU2Fk68tzSpzs3D3h2672m/NhgRq3V1Jbt6LSqN5muITEUVmJ5hgvXX83yKLuWMXKvYwQ68sU YUb5t/0wHHXtbaXtS0mfw20A X-Amp-Result: SKIPPED(no attachment in message) Received: from smtpgw04.mail.net.sap (HELO smtpgw.sap-ag.de) ([155.56.66.99]) by esa5.sap.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA384; 06 May 2021 18:16:08 +0200 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (104.47.17.174) by smtpgw04.mail.net.sap (155.56.66.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 6 May 2021 18:16:05 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kO8Foeqr0fmXytNZAePUf4sGjVx5f4LXbtGJpq9oX7Ccd/ziNEb0DdC4blaizc2UkpGEDpcMKY/WvOkC9u+KBZABKaDkOwwJ5CWjZBB6dvt0GsHuRHCrOYtiNKVnkszg3NH9IS8qwOElHTCIJ1frPomVCM4V1tjIJjTs9eIGFBNDzt3yEvsN/hKI6cS5s7cG29ar+Cr/ECqSAXDGslJ4F7SaWIYnsFQuA98loX3V5yeeE+CBnWCyRSUncc9mnLLkoyjxda2gdsZXjB48iSFZEBQY+iZBow/Oj7CcG42ZGrcbmnAQnGRirLeCsZhGrmswL//LUD7AAOqXWS1+YFgaoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TfuI705147bk/7/A4gWvciPe6ewp2+mLziNur3LNZs=; b=KNlOHGzWPBmaSbo8Opl6pNfy2wpc7WcdWhOcT1DB29fB2+hRZZpHsKAAOOEnSIB1ioOPTMsRc7yXAut/0zp5GmAZ+ayTLJ+czJXfnPjVDU/IhMSmfiAcZTr+8MsZVFCu1QifoihKJMggqcKfOjIMfQfo14Lf65tspTwnzOuouEO42C3n9RiyyQQZaTQKL0o5gjQj2f6UvsLXbFsWsWlkZTljg8mueL3cKxd4pUlFodr9OsrKp6zxY1Lz+DR320UG/CNu4wzKC8OT3PCDNUAHBoLBWSm/xVeahXMyN7FuZ4NYwDxLDZyj4ekXTTvyhiGGLryD7h7CvA6spwPQzisBBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sap.onmicrosoft.com; s=selector2-sap-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TfuI705147bk/7/A4gWvciPe6ewp2+mLziNur3LNZs=; b=NXL5vSa0lRJZ62nsc6tfy3YVGvgeaDyNxjAFvmd3Bz0aqEPE0tvMVe8BNOfWekQ3yAcZNWE96mjcOUKMVJV355Ng18fK8WzoawwBxG/4m3ykxs3IVZV8yg0ytkHZ65DDviYqK2ECB0o+lGeOUsD4uCWldCTlrYP5hCxfDbFLf70= Received: from AM0PR02MB5585.eurprd02.prod.outlook.com (2603:10a6:208:164::23) by AM4PR0202MB2932.eurprd02.prod.outlook.com (2603:10a6:200:8d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 16:16:03 +0000 Received: from AM0PR02MB5585.eurprd02.prod.outlook.com ([fe80::b9a4:8809:fd03:52a6]) by AM0PR02MB5585.eurprd02.prod.outlook.com ([fe80::b9a4:8809:fd03:52a6%3]) with mapi id 15.20.4108.026; Thu, 6 May 2021 16:16:03 +0000 From: "Schneider, Robert" To: Milan Broz , "dm-crypt@saout.de" Thread-Topic: [dm-crypt] Coding/style guidelines for cryptsetup? Thread-Index: AddCaZs67Uu8T6zIReKLyNZTM2GQ4QAHWo2AAAHv8oA= Date: Thu, 6 May 2021 16:16:03 +0000 Message-ID: References:

In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [208.127.57.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b27f1e75-3488-4386-172e-08d910aa3f0b x-ms-traffictypediagnostic: AM4PR0202MB2932: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AmqW/gkgc++2z4s+HevOA5iR3Q8XDV2AZPNNcUcaq4qzFVGTWJVHEA+xyEy5xhx5fx4VixtHw8m2GR+d9PnlkoUT/QWHBBIa/RgfSVUhVRjwhq1JXcl3FHETvaNcmTp2S8J6BQyE9RJDuNh54l07xiaPgLa4QrEtGbbgr3qQDCKVqzlgjkSDgeAok/8l+auTaTPE9M383LiydQB+kErlgg8Z6rOWTIZ0b8l4TPI3Jq0yYzoMZxE+xaxiEJoPKJ3xPXGWIEWJKMlDtq+hNzD6P4Jklyh5L+Cg7tBRbDa2gtKG08wXVwEp+p8ECV2GKLsVfZx9/ikMtX96YIIVznC3+PUw8wiiEDu4J6Yibj3A8b9DZIlR57Lcb8nuT+PASoJg2+9Cf+TilUSzXEPLqeQXgoP0pGN1Wr5XhBHbvmj6vfcpwEfDn+8qKsAZax0r0sJk134wC6cEkNmeDGWq0LxPSd/BMjBsgI8o1SdDWND6X1d/nZIr1W2DhKqNwwWmADYaO953z5+DapzR7YuqQR6ASN/uHz/np/vinVGVpwgJz1C6rUe67SkJTToR7mZR56JCkoBK5XWyc2Q/dJGQ1Ck1ADOMR5EmC4sJNnxNp2yw0/o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR02MB5585.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(66946007)(8936002)(8676002)(83380400001)(186003)(52536014)(478600001)(66446008)(66556008)(64756008)(66476007)(5660300002)(26005)(110136005)(9686003)(7696005)(55016002)(71200400001)(122000001)(38100700002)(33656002)(86362001)(316002)(2906002)(6506007)(76116006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UTBlMU1IdWFnb1U4T0hsRzRodEdTSEhNcG5PMVRUOEozT2VTVEJZVSt5d09o?= =?utf-8?B?azR5b3RGVGtKVzBkV3hZd3ZTV1ltR2MxSmtuYVREYWxrVS94aFpQelE1WCti?= =?utf-8?B?SEIxeW1HWk8vbjIzaDh0ZHdBTjdrUnZUOEIyeDBndmRxZlNrOWNDNnRZQmQ3?= =?utf-8?B?ZWNoeUp5K0k5clhLcm9OcFh5aFdCbTZqRHhWb0NNVi9WNVQyLzRaeWFBczVI?= =?utf-8?B?U0dZVTI0S3M4N1diSTVUbExFdDFvMk9wcTdtdTJ5UU1MOUFvU1liMit6a2dU?= =?utf-8?B?dmNwMkR6dzVxL1A2VjJuSzJ1MFpXM3hhSDRvYnFwWnhKMUZwVFV2bmVzeTBP?= =?utf-8?B?dVp1dzBpanJKU3k3MFk4YzhOWjVCeE5wcXN3ellyQXNxQ054YkljV3RweUk2?= =?utf-8?B?cTc2bllhVmRaRVRZVUtzTm9GU2loK2g5dC9oZVFQKzdJcExSby9aT3RtZmxk?= =?utf-8?B?VWJTUWF0ejEyUXcwQ0NXRWp3QlhOUlErbVdlMVNrNTVvcnU5Z05Dc0ZEcmYw?= =?utf-8?B?eStMZXJHU055YTNpMldPTEp4ZUl6ejl5NzdQUjcveGJ6R25hamxHeU9lY25R?= =?utf-8?B?OWdUS3dSS2JnRXBvVm12NkpHenJhaXZ5c3lVckJEMXB3NXdPbzdhQVBZTGpB?= =?utf-8?B?L0ZzSFlqK2tLU2JsMm9sSDVYa2MzY3hUc3kvWUJxZW4rMG1CcUNqaDJNcVQz?= =?utf-8?B?cWNlN3ByR2RNeWdVREc5Z0t0dG5DQ2VVWDZxWEdPVXAvR0k0TjBGK2NRRllo?= =?utf-8?B?OFNEUGZLOW9tMXlUVlFvbGFzdjl6L2JPRWYycGhoVVpwbzE4NXdYTnM3WE9C?= =?utf-8?B?RjUrTWt1RXZab0ZwZU1vSmRMU1MrS0pQNndTSGhUWEhiS1pyNDNYaE0zNmho?= =?utf-8?B?NVJudkZQNHZQVnkyQllSUXFKdmpvRUttTDVlQ1g3VW9aTEdKVFF4YnRVVTVS?= =?utf-8?B?NmJlczVFcWJlTXhBRHNhaThNRGQ4c3NibitOSFRTRlNKKzBwamtXUVZmd0dG?= =?utf-8?B?OWI2NnBUb2g4V1JsQ2Fqb1JwdW1Fb2tCVG9hRW0yeVA1SEZtSkY0SWVCVFho?= =?utf-8?B?b0hmZVpWZWV3b29haWp5dytFMVA4NXhFSG04VFJCV0psNTQ2K2R1bW9lNWNH?= =?utf-8?B?bFhvWWxEaEdTd1VwOUtBV05UdGxCekN0anRKa0xIVnZvYzFpUktkeEl4YjhK?= =?utf-8?B?eWJvMnU1bVUrRkd1RXBnVEV5bVZJbDM5dnI2SVJZWVM5ZVd0K0kzRDBjTW9Q?= =?utf-8?B?OVlDd3k5cEtDemdwVTJsQ245MURwN1RpY3JjZEpobURKQURWdlZUSXhab3VL?= =?utf-8?B?REdWTFNzVVdyTUtoS2NMSkxiVitRNkthcVhhL0VwZmxzQ3NYeVdac2Rxcm9L?= =?utf-8?B?TW1KVVAxdjd1VHovSEQvUndrZ1VrOE9JdjlGbmp6eXJDbjlwamh3QUNmQk1x?= =?utf-8?B?emlwQkpxMExKOUpMc00zeXZvRlZBY09RZmk4eUp5emFvZm4yUituZWwxdEZz?= =?utf-8?B?WVZuOXEzVXpnb0dZWWlKY0xuMWMwdUdwV05GR0lJMkdPMHpqeE9JY0I1dW9s?= =?utf-8?B?QWlHUzBESUhpV3NLZmlhYVYyRzROMUlESXlyQkZWek5YdzVqNDVITG5pa05T?= =?utf-8?B?TUhzQVZMMTlTaW04UHJnNmtIb2hrTWVYcW1rTHhYK01IeWNYdGRZeFhZajZr?= =?utf-8?B?M2RXek9sTHhSeDgxdi9YQytEVGw1R3lLczZjRmtiUk9wRXdrRlROZnQrblhz?= =?utf-8?Q?qiNwaVKzS5pc8GQxTAZeoUrRzub85lhb0B/5QYX?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB5585.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b27f1e75-3488-4386-172e-08d910aa3f0b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2021 16:16:03.6572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 42f7676c-f455-423c-82f6-dc2d99791af7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5yIb6yc6tyI3tiJhH9V02wNZPcQrTNbbUBoJli9KDHdQXyZEWIEfiltj5zSR3+N1UKfF5UJYf7e8QGHdzt/xcZRembpfz6gMBltPVSmCxNk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0202MB2932 Message-ID-Hash: 35OM76UGF5JH7U27AVPJJ6WFDW22SH65 X-Message-ID-Hash: 35OM76UGF5JH7U27AVPJJ6WFDW22SH65 X-MailFrom: robert.schneider03@sap.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dm-crypt.saout.de-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.2 Precedence: list Subject: [dm-crypt] Re: Coding/style guidelines for cryptsetup? List-Id: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Thank you very much! > IMO source code is for people, not for machines enforcing rulesets. Quite a refreshing take on that topic. I've also seen rulesets being enforced to stop discussions. > Anyway, if you plan to write something more sophisticated, better report issue > and discuss it first, please. I've drafted an atomic header restore. Not entirely finished yet, but the basic functionality seems to be working. Yes I'm that guy with the overengineered transactions ;) > > -> do we have to declare variables at the top of functions? > > yes I'm curious what the rationale is, if you don't mind. I just have not seen this yet in post-C90 code. > > - would adding -pedantic in GCC be acceptable? (not sure how that would work in autotools) > > Not for now. I use many extra warnings for tests, but pedantic is producing really garbage sometimes. Ah, I thought that would influence pointer conversion warnings, but it doesn't. I usually write C++ and I was bitten in cryptsetup code by making silly typing mistakes like passing a void* to a void** parameter. > But why do you need to add source code files? I would like to add some LUKS2 unit tests. There's already unit-utils-io and api-test-2 where I could add them. Api-test-2 unfortunately has some start-up time due to device initializations, and also needs to be run as root because of that. Unit-utils-io only links against libutils_io at the moment, not against libcryptsetup. Thanks again, Robert _______________________________________________ dm-crypt mailing list -- dm-crypt@saout.de To unsubscribe send an email to dm-crypt-leave@saout.de