All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuldeep Singh <kuldeep.singh@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI controller
Date: Wed, 6 Nov 2019 10:19:27 +0000	[thread overview]
Message-ID: <AM0PR0402MB35562E7712355D078F4B9405E0790@AM0PR0402MB3556.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191105230323.27284-1-michael@walle.cc>

Hi,

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, November 6, 2019 4:33 AM
> To: u-boot at lists.denx.de
> Cc: Vignesh R <vigneshr@ti.com>; Prabhakar X
> <prabhakar.kushwaha@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com>;
> Michael Walle <michael@walle.cc>; Jagan Teki
> <jagan@amarulasolutions.com>
> Subject: [EXT] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI
> controller
> 
> Caution: EXT Email
> 
> This is a port of the kernel's spi-nxp-fspi driver. It uses the new spi-mem
> interface and does not expose the more generic spi-xfer interface. The source
> was taken from the v5.3-rc3 tag.
> 
> The port was straightforward:
>  - remove the interrupt handling and the completion by busy polling the
>    controller
>  - remove locks
>  - move the setup of the memory windows into claim_bus()
>  - move the setup of the speed into set_speed()
>  - port the device tree bindings from the original fspi_probe() to
>    ofdata_to_platdata()
> 
> There were only some style change fixes, no change in any logic. For example,
> there are busy loops where the return code is not handled correctly, eg. only
> prints a warning with WARN_ON(). This port intentionally left most functions
> unchanged to ease future bugfixes.
> 
> This was tested on a custom LS1028A board. Because the LS1028A doesn't
> have proper clock framework support, changing the clock speed was not
> tested. This also means that it is not possible to change the SPI speed on
> LS1028A for now (neither is it possible in the linux driver).
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>

Tested on LS1028A-RDB and LX2160A-RDB
Tested-by: Kuldeep Singh <kuldeep.singh@nxp.com>

Regards,
Kuldeep

  parent reply	other threads:[~2019-11-06 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 23:03 [U-Boot] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI controller Michael Walle
2019-11-05 23:03 ` [U-Boot] [PATCH v3 2/3] arm: ls1028a: use the new flexspi driver Michael Walle
2019-11-05 23:03 ` [U-Boot] [PATCH v3 3/3] arm: dts: ls1028a: fix interrupt properties Michael Walle
2019-11-06 10:19 ` Kuldeep Singh [this message]
2019-11-21 12:47 ` [U-Boot] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI controller Michael Walle
2019-11-25  3:50   ` Priyanka Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0402MB35562E7712355D078F4B9405E0790@AM0PR0402MB3556.eurprd04.prod.outlook.com \
    --to=kuldeep.singh@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.