From mboxrd@z Thu Jan 1 00:00:00 1970 From: "A.s. Dong" Subject: RE: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit Date: Wed, 1 Aug 2018 07:44:43 +0000 Message-ID: References: <20180731141146.10788-1-o.rempel@pengutronix.de> <20180731141146.10788-5-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jassi Brar , Oleksij Rempel Cc: Mark Rutland , Devicetree List , Rob Herring , ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" , ", Sascha Hauer" , Fabio Estevam , Shawn Guo , Vladimir Zapolskiy , dl-linux-imx List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar@gmail.com] [...] > > + > > +static void imx_mu_txdb_work(struct work_struct *work) { > > + struct imx_mu_con_priv *cp = > > + container_of(work, struct imx_mu_con_priv, work); > > + mbox_chan_txdone(cp->chan, 0); } > > > The api assumes a controller have same type of channels. So we are having > to do this here. > I am not sure, but would declaring two mailbox controllers (one with > doorbells and the other data channels) work? > If not, at least we could use a tasklet instead of a work queue? > I'm also a bit curious what the meaning of calling mbox_chan_txdone for a doorbell mailbox? Is there any recommended way to use it? Regards Dong Aisheng From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong@nxp.com (A.s. Dong) Date: Wed, 1 Aug 2018 07:44:43 +0000 Subject: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit In-Reply-To: References: <20180731141146.10788-1-o.rempel@pengutronix.de> <20180731141146.10788-5-o.rempel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar at gmail.com] [...] > > + > > +static void imx_mu_txdb_work(struct work_struct *work) { > > + struct imx_mu_con_priv *cp = > > + container_of(work, struct imx_mu_con_priv, work); > > + mbox_chan_txdone(cp->chan, 0); } > > > The api assumes a controller have same type of channels. So we are having > to do this here. > I am not sure, but would declaring two mailbox controllers (one with > doorbells and the other data channels) work? > If not, at least we could use a tasklet instead of a work queue? > I'm also a bit curious what the meaning of calling mbox_chan_txdone for a doorbell mailbox? Is there any recommended way to use it? Regards Dong Aisheng