From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965594AbeEYJs6 (ORCPT ); Fri, 25 May 2018 05:48:58 -0400 Received: from mail-he1eur01on0081.outbound.protection.outlook.com ([104.47.0.81]:24312 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965287AbeEYJsw (ORCPT ); Fri, 25 May 2018 05:48:52 -0400 From: "A.s. Dong" To: Stephen Boyd , "linux-clk@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mturquette@baylibre.com" , "hdegoede@redhat.com" , "b.zolnierkie@samsung.com" , "linux@armlinux.org.uk" , "linux-fbdev@vger.kernel.org" , dl-linux-imx , Stephen Boyd , Russell King Subject: RE: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() Thread-Topic: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() Thread-Index: AQHTwMOS+d4Y5SGS00il8JKLQTZXlaPeDVWAgGKL63A= Date: Fri, 25 May 2018 09:48:48 +0000 Message-ID: References: <1521602391-30356-1-git-send-email-aisheng.dong@nxp.com> <1521602391-30356-2-git-send-email-aisheng.dong@nxp.com> <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> In-Reply-To: <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM0PR04MB4210;7:EZMb4JRW85DplmRB5VkdyeNtRHH5Yb1Xjji9zCHie/v/iJm+a9bM0w/qUJtmdlXVvyIT6CwCGmEqAr77ShXleZaFDCerRE0qAREoLYJ6Q6YEzpqEznV9jp49wW0Y6lCUSoZi1rJBd4cV/eGMxwXYn1EuvGfps/dfa6Zi+6J6wPD9eUCSqufLwgbbBrSh5h6PgpNaLT4z9MMpo/jmIrQwDPueD5v+p5r1/XveskmOlXtkN48v4LOdev311PPpoQOS x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB4210; x-ms-traffictypediagnostic: AM0PR04MB4210: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335)(7411616537696); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:AM0PR04MB4210;BCL:0;PCL:0;RULEID:;SRVR:AM0PR04MB4210; x-forefront-prvs: 06833C6A67 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(39380400002)(366004)(39860400002)(376002)(346002)(377424004)(199004)(189003)(13464003)(57704003)(8936002)(6246003)(478600001)(3846002)(6116002)(53936002)(2906002)(14454004)(6436002)(66066001)(53546011)(7696005)(68736007)(3280700002)(76176011)(229853002)(99286004)(102836004)(6506007)(9686003)(81166006)(81156014)(55016002)(8676002)(3660700001)(25786009)(4326008)(2501003)(7416002)(7736002)(305945005)(105586002)(106356001)(86362001)(5660300001)(5250100002)(74316002)(97736004)(476003)(26005)(2900100001)(486006)(110136005)(186003)(54906003)(316002)(33656002)(446003)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4210;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-microsoft-antispam-message-info: aFaoILEFMpdgiaLikNqUC8hD5TfPSEYj8g289/O5YBqhBFHKuqI5K2wS9RQCKpCx4TQ3uI/g7TcntftaV+SZ8k8rXba7OflDzdsnx7dP/B6XsA7oeRq0CDiHaUikM5tAYFpdckUuqz0/pTxgK8GLD7swAgkOmfj/J5434Ry3v14fp0/jlSwetnaEm8B70mxJ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 74113800-4675-4425-1834-08d5c224b702 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74113800-4675-4425-1834-08d5c224b702 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2018 09:48:48.6990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w4P9n3Db010503 Hi Stephen, > -----Original Message----- > From: Stephen Boyd [mailto:sboyd@kernel.org] > Sent: Saturday, March 24, 2018 12:53 AM > To: A.s. Dong ; linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > mturquette@baylibre.com; hdegoede@redhat.com; > b.zolnierkie@samsung.com; linux@armlinux.org.uk; linux- > fbdev@vger.kernel.org; dl-linux-imx ; A.s. Dong > ; Stephen Boyd ; Russell > King > Subject: Re: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() > > Quoting Dong Aisheng (2018-03-20 20:19:48) > > diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index > > 4c10456..4b357b2 100644 > > --- a/drivers/clk/clk-bulk.c > > +++ b/drivers/clk/clk-bulk.c > > @@ -19,6 +19,38 @@ > > #include > > #include > > #include > > +#include > > + > > +#if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) > > Do we need these defines? of_clk_get() is a stub function when these > configs are false. > You're right. Will drop it. > > +static int __must_check of_clk_bulk_get(struct device_node *np, int > num_clks, > > + struct clk_bulk_data *clks) { > > + int ret; > > + int i; > > + > > + for (i = 0; i < num_clks; i++) > > + clks[i].clk = NULL; > > + > > + for (i = 0; i < num_clks; i++) { > > + clks[i].clk = of_clk_get(np, i); > > + if (IS_ERR(clks[i].clk)) { > > + ret = PTR_ERR(clks[i].clk); > > + pr_err("%pOF: Failed to get clk index: %d ret: %d\n", > > + np, i, ret); > > + clks[i].clk = NULL; > > + goto err; > > + } > > + } > > + > > + return 0; > > + > > +err: > > + clk_bulk_put(i, clks); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL(of_clk_bulk_get); > > It's static, so don't export it. Got it. Sorry for such mistake. Will fix and sent V3. Regards Dong Aisheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "A.s. Dong" To: Stephen Boyd , "linux-clk@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mturquette@baylibre.com" , "hdegoede@redhat.com" , "b.zolnierkie@samsung.com" , "linux@armlinux.org.uk" , "linux-fbdev@vger.kernel.org" , dl-linux-imx , Stephen Boyd , Russell King Subject: RE: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() Date: Fri, 25 May 2018 09:48:48 +0000 Message-ID: References: <1521602391-30356-1-git-send-email-aisheng.dong@nxp.com> <1521602391-30356-2-git-send-email-aisheng.dong@nxp.com> <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> In-Reply-To: <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: SGkgU3RlcGhlbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVw aGVuIEJveWQgW21haWx0bzpzYm95ZEBrZXJuZWwub3JnXQ0KPiBTZW50OiBTYXR1cmRheSwgTWFy Y2ggMjQsIDIwMTggMTI6NTMgQU0NCj4gVG86IEEucy4gRG9uZyA8YWlzaGVuZy5kb25nQG54cC5j b20+OyBsaW51eC1jbGtAdmdlci5rZXJuZWwub3JnDQo+IENjOiBsaW51eC1rZXJuZWxAdmdlci5r ZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7DQo+IG10dXJx dWV0dGVAYmF5bGlicmUuY29tOyBoZGVnb2VkZUByZWRoYXQuY29tOw0KPiBiLnpvbG5pZXJraWVA c2Ftc3VuZy5jb207IGxpbnV4QGFybWxpbnV4Lm9yZy51azsgbGludXgtDQo+IGZiZGV2QHZnZXIu a2VybmVsLm9yZzsgZGwtbGludXgtaW14IDxsaW51eC1pbXhAbnhwLmNvbT47IEEucy4gRG9uZw0K PiA8YWlzaGVuZy5kb25nQG54cC5jb20+OyBTdGVwaGVuIEJveWQgPHNib3lkQGNvZGVhdXJvcmEu b3JnPjsgUnVzc2VsbA0KPiBLaW5nIDxsaW51eEBhcm0ubGludXgub3JnLnVrPg0KPiBTdWJqZWN0 OiBSZTogW1BBVENIIFYyIDEvNF0gY2xrOiBidWxrOiBhZGQgb2ZfY2xrX2J1bGtfZ2V0KCkNCj4g DQo+IFF1b3RpbmcgRG9uZyBBaXNoZW5nICgyMDE4LTAzLTIwIDIwOjE5OjQ4KQ0KPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2Nsay9jbGstYnVsay5jIGIvZHJpdmVycy9jbGsvY2xrLWJ1bGsuYyBp bmRleA0KPiA+IDRjMTA0NTYuLjRiMzU3YjIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9jbGsv Y2xrLWJ1bGsuYw0KPiA+ICsrKyBiL2RyaXZlcnMvY2xrL2Nsay1idWxrLmMNCj4gPiBAQCAtMTks NiArMTksMzggQEANCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2Nsay5oPg0KPiA+ICAjaW5jbHVkZSA8 bGludXgvZGV2aWNlLmg+DQo+ID4gICNpbmNsdWRlIDxsaW51eC9leHBvcnQuaD4NCj4gPiArI2lu Y2x1ZGUgPGxpbnV4L29mLmg+DQo+ID4gKw0KPiA+ICsjaWYgZGVmaW5lZChDT05GSUdfT0YpICYm IGRlZmluZWQoQ09ORklHX0NPTU1PTl9DTEspDQo+IA0KPiBEbyB3ZSBuZWVkIHRoZXNlIGRlZmlu ZXM/IG9mX2Nsa19nZXQoKSBpcyBhIHN0dWIgZnVuY3Rpb24gd2hlbiB0aGVzZQ0KPiBjb25maWdz IGFyZSBmYWxzZS4NCj4gDQoNCllvdSdyZSByaWdodC4gV2lsbCBkcm9wIGl0Lg0KDQo+ID4gK3N0 YXRpYyBpbnQgX19tdXN0X2NoZWNrIG9mX2Nsa19idWxrX2dldChzdHJ1Y3QgZGV2aWNlX25vZGUg Km5wLCBpbnQNCj4gbnVtX2Nsa3MsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cnVjdCBjbGtfYnVsa19kYXRhICpjbGtzKSB7DQo+ID4gKyAgICAgICBpbnQg cmV0Ow0KPiA+ICsgICAgICAgaW50IGk7DQo+ID4gKw0KPiA+ICsgICAgICAgZm9yIChpID0gMDsg aSA8IG51bV9jbGtzOyBpKyspDQo+ID4gKyAgICAgICAgICAgICAgIGNsa3NbaV0uY2xrID0gTlVM TDsNCj4gPiArDQo+ID4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgbnVtX2Nsa3M7IGkrKykgew0K PiA+ICsgICAgICAgICAgICAgICBjbGtzW2ldLmNsayA9IG9mX2Nsa19nZXQobnAsIGkpOw0KPiA+ ICsgICAgICAgICAgICAgICBpZiAoSVNfRVJSKGNsa3NbaV0uY2xrKSkgew0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIHJldCA9IFBUUl9FUlIoY2xrc1tpXS5jbGspOw0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIHByX2VycigiJXBPRjogRmFpbGVkIHRvIGdldCBjbGsgaW5kZXg6ICVk IHJldDogJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5wLCBpLCBy ZXQpOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNsa3NbaV0uY2xrID0gTlVMTDsNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVycjsNCj4gPiArICAgICAgICAgICAgICAg fQ0KPiA+ICsgICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgIHJldHVybiAwOw0KPiA+ICsNCj4g PiArZXJyOg0KPiA+ICsgICAgICAgY2xrX2J1bGtfcHV0KGksIGNsa3MpOw0KPiA+ICsNCj4gPiAr ICAgICAgIHJldHVybiByZXQ7DQo+ID4gK30NCj4gPiArRVhQT1JUX1NZTUJPTChvZl9jbGtfYnVs a19nZXQpOw0KPiANCj4gSXQncyBzdGF0aWMsIHNvIGRvbid0IGV4cG9ydCBpdC4NCg0KR290IGl0 Lg0KU29ycnkgZm9yIHN1Y2ggbWlzdGFrZS4NCg0KV2lsbCBmaXggYW5kIHNlbnQgVjMuDQoNClJl Z2FyZHMNCkRvbmcgQWlzaGVuZw0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: "A.s. Dong" Date: Fri, 25 May 2018 09:48:48 +0000 Subject: RE: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() Message-Id: List-Id: References: <1521602391-30356-1-git-send-email-aisheng.dong@nxp.com> <1521602391-30356-2-git-send-email-aisheng.dong@nxp.com> <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> In-Reply-To: <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org SGkgU3RlcGhlbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVw aGVuIEJveWQgW21haWx0bzpzYm95ZEBrZXJuZWwub3JnXQ0KPiBTZW50OiBTYXR1cmRheSwgTWFy Y2ggMjQsIDIwMTggMTI6NTMgQU0NCj4gVG86IEEucy4gRG9uZyA8YWlzaGVuZy5kb25nQG54cC5j b20+OyBsaW51eC1jbGtAdmdlci5rZXJuZWwub3JnDQo+IENjOiBsaW51eC1rZXJuZWxAdmdlci5r ZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7DQo+IG10dXJx dWV0dGVAYmF5bGlicmUuY29tOyBoZGVnb2VkZUByZWRoYXQuY29tOw0KPiBiLnpvbG5pZXJraWVA c2Ftc3VuZy5jb207IGxpbnV4QGFybWxpbnV4Lm9yZy51azsgbGludXgtDQo+IGZiZGV2QHZnZXIu a2VybmVsLm9yZzsgZGwtbGludXgtaW14IDxsaW51eC1pbXhAbnhwLmNvbT47IEEucy4gRG9uZw0K PiA8YWlzaGVuZy5kb25nQG54cC5jb20+OyBTdGVwaGVuIEJveWQgPHNib3lkQGNvZGVhdXJvcmEu b3JnPjsgUnVzc2VsbA0KPiBLaW5nIDxsaW51eEBhcm0ubGludXgub3JnLnVrPg0KPiBTdWJqZWN0 OiBSZTogW1BBVENIIFYyIDEvNF0gY2xrOiBidWxrOiBhZGQgb2ZfY2xrX2J1bGtfZ2V0KCkNCj4g DQo+IFF1b3RpbmcgRG9uZyBBaXNoZW5nICgyMDE4LTAzLTIwIDIwOjE5OjQ4KQ0KPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2Nsay9jbGstYnVsay5jIGIvZHJpdmVycy9jbGsvY2xrLWJ1bGsuYyBp bmRleA0KPiA+IDRjMTA0NTYuLjRiMzU3YjIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9jbGsv Y2xrLWJ1bGsuYw0KPiA+ICsrKyBiL2RyaXZlcnMvY2xrL2Nsay1idWxrLmMNCj4gPiBAQCAtMTks NiArMTksMzggQEANCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2Nsay5oPg0KPiA+ICAjaW5jbHVkZSA8 bGludXgvZGV2aWNlLmg+DQo+ID4gICNpbmNsdWRlIDxsaW51eC9leHBvcnQuaD4NCj4gPiArI2lu Y2x1ZGUgPGxpbnV4L29mLmg+DQo+ID4gKw0KPiA+ICsjaWYgZGVmaW5lZChDT05GSUdfT0YpICYm IGRlZmluZWQoQ09ORklHX0NPTU1PTl9DTEspDQo+IA0KPiBEbyB3ZSBuZWVkIHRoZXNlIGRlZmlu ZXM/IG9mX2Nsa19nZXQoKSBpcyBhIHN0dWIgZnVuY3Rpb24gd2hlbiB0aGVzZQ0KPiBjb25maWdz IGFyZSBmYWxzZS4NCj4gDQoNCllvdSdyZSByaWdodC4gV2lsbCBkcm9wIGl0Lg0KDQo+ID4gK3N0 YXRpYyBpbnQgX19tdXN0X2NoZWNrIG9mX2Nsa19idWxrX2dldChzdHJ1Y3QgZGV2aWNlX25vZGUg Km5wLCBpbnQNCj4gbnVtX2Nsa3MsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHN0cnVjdCBjbGtfYnVsa19kYXRhICpjbGtzKSB7DQo+ID4gKyAgICAgICBpbnQg cmV0Ow0KPiA+ICsgICAgICAgaW50IGk7DQo+ID4gKw0KPiA+ICsgICAgICAgZm9yIChpID0gMDsg aSA8IG51bV9jbGtzOyBpKyspDQo+ID4gKyAgICAgICAgICAgICAgIGNsa3NbaV0uY2xrID0gTlVM TDsNCj4gPiArDQo+ID4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgbnVtX2Nsa3M7IGkrKykgew0K PiA+ICsgICAgICAgICAgICAgICBjbGtzW2ldLmNsayA9IG9mX2Nsa19nZXQobnAsIGkpOw0KPiA+ ICsgICAgICAgICAgICAgICBpZiAoSVNfRVJSKGNsa3NbaV0uY2xrKSkgew0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIHJldCA9IFBUUl9FUlIoY2xrc1tpXS5jbGspOw0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIHByX2VycigiJXBPRjogRmFpbGVkIHRvIGdldCBjbGsgaW5kZXg6ICVk IHJldDogJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5wLCBpLCBy ZXQpOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNsa3NbaV0uY2xrID0gTlVMTDsNCj4g PiArICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVycjsNCj4gPiArICAgICAgICAgICAgICAg fQ0KPiA+ICsgICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgIHJldHVybiAwOw0KPiA+ICsNCj4g PiArZXJyOg0KPiA+ICsgICAgICAgY2xrX2J1bGtfcHV0KGksIGNsa3MpOw0KPiA+ICsNCj4gPiAr ICAgICAgIHJldHVybiByZXQ7DQo+ID4gK30NCj4gPiArRVhQT1JUX1NZTUJPTChvZl9jbGtfYnVs a19nZXQpOw0KPiANCj4gSXQncyBzdGF0aWMsIHNvIGRvbid0IGV4cG9ydCBpdC4NCg0KR290IGl0 Lg0KU29ycnkgZm9yIHN1Y2ggbWlzdGFrZS4NCg0KV2lsbCBmaXggYW5kIHNlbnQgVjMuDQoNClJl Z2FyZHMNCkRvbmcgQWlzaGVuZw0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong@nxp.com (A.s. Dong) Date: Fri, 25 May 2018 09:48:48 +0000 Subject: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() In-Reply-To: <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> References: <1521602391-30356-1-git-send-email-aisheng.dong@nxp.com> <1521602391-30356-2-git-send-email-aisheng.dong@nxp.com> <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stephen, > -----Original Message----- > From: Stephen Boyd [mailto:sboyd at kernel.org] > Sent: Saturday, March 24, 2018 12:53 AM > To: A.s. Dong ; linux-clk at vger.kernel.org > Cc: linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; > mturquette at baylibre.com; hdegoede at redhat.com; > b.zolnierkie at samsung.com; linux at armlinux.org.uk; linux- > fbdev at vger.kernel.org; dl-linux-imx ; A.s. Dong > ; Stephen Boyd ; Russell > King > Subject: Re: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get() > > Quoting Dong Aisheng (2018-03-20 20:19:48) > > diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index > > 4c10456..4b357b2 100644 > > --- a/drivers/clk/clk-bulk.c > > +++ b/drivers/clk/clk-bulk.c > > @@ -19,6 +19,38 @@ > > #include > > #include > > #include > > +#include > > + > > +#if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) > > Do we need these defines? of_clk_get() is a stub function when these > configs are false. > You're right. Will drop it. > > +static int __must_check of_clk_bulk_get(struct device_node *np, int > num_clks, > > + struct clk_bulk_data *clks) { > > + int ret; > > + int i; > > + > > + for (i = 0; i < num_clks; i++) > > + clks[i].clk = NULL; > > + > > + for (i = 0; i < num_clks; i++) { > > + clks[i].clk = of_clk_get(np, i); > > + if (IS_ERR(clks[i].clk)) { > > + ret = PTR_ERR(clks[i].clk); > > + pr_err("%pOF: Failed to get clk index: %d ret: %d\n", > > + np, i, ret); > > + clks[i].clk = NULL; > > + goto err; > > + } > > + } > > + > > + return 0; > > + > > +err: > > + clk_bulk_put(i, clks); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL(of_clk_bulk_get); > > It's static, so don't export it. Got it. Sorry for such mistake. Will fix and sent V3. Regards Dong Aisheng