All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded
Date: Tue, 30 Jul 2019 07:01:41 +0000	[thread overview]
Message-ID: <AM0PR04MB448107A1B241F1EB25B3513888DC0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190730085832.24195a23@jawa>


Hi Lukasz,
> Subject: Re: [PATCH 01/16] clk: introduce clk_dev_binded
> 
> Hi Peng,
> 
> > Hi Peng,
> >
> > > Hi Lukasz,
> > >
> > > > Subject: [PATCH 01/16] clk: introduce clk_dev_binded
> > >
> > > Do you have time to review the patchset? Patches were delegated to
> > > you.
> >
> > The i.MX related PR (with base CCF) has been pulled to mainline just
> > yesteday, so I'm going to rewiew and test your code on top of it (with
> > buildman) today.
> >
> > I shall send PR for -clk tomorrow.
> >
> 
> The patches from this series causes the sandbox travis-ci to break:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/565204559

I ran qcheck before posting patches.

> 
> Please fix those errors.
> 
> You can also reproduce this issue with:
> 
> ./tools/buildman/buildman.py --branch=HEAD sandbox  --show_errors
> --force-build --count=16 --output-dir=../BUILD/

I'll fix soon.

Thanks,
Peng.

> 
> run on this series.
> 
> > Thanks for your patches.
> >
> > >
> > > Thanks,
> > > Peng.
> > >
> > > >
> > > > When support Clock Common Framework, U-Boot use dev for clk tree
> > > > information, there is no clk->parent. When support composite clk,
> > > > it contains mux/gate/divider, but the mux/gate/divider is not
> > > > binded with device. So we could not use dev_get_uclass_priv to get
> > > > the correct clk_mux/gate/divider. So add clk_dev_binded to let
> > > > choose the correct method.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  drivers/clk/clk.c | 8 ++++++++
> > > >  include/clk.h     | 9 +++++++++
> > > >  2 files changed, 17 insertions(+)
> > > >
> > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index
> > > > 7d748c9fc7..39b3087067 100644
> > > > --- a/drivers/clk/clk.c
> > > > +++ b/drivers/clk/clk.c
> > > > @@ -55,3 +55,11 @@ const char *clk_hw_get_name(const struct clk
> > > > *hw) {
> > > >  	return hw->dev->name;
> > > >  }
> > > > +
> > > > +bool clk_dev_binded(struct clk *clk) {
> > > > +	if (clk->dev && (clk->dev->flags & DM_FLAG_BOUND))
> > > > +		return true;
> > > > +
> > > > +	return false;
> > > > +}
> > > > diff --git a/include/clk.h b/include/clk.h index
> > > > f8f56d9cf0..2ebc905e04 100644
> > > > --- a/include/clk.h
> > > > +++ b/include/clk.h
> > > > @@ -356,4 +356,13 @@ static inline bool clk_valid(struct clk *clk)
> > > >   * @return zero on success, or -ENOENT on error
> > > >   */
> > > >  int clk_get_by_id(ulong id, struct clk **clkp);
> > > > +
> > > > +/**
> > > > + * clk_dev_binded() - Check whether the clk has a device binded
> > > > + *
> > > > + * @clk		A pointer to the clk
> > > > + *
> > > > + * @return true on binded, or false on no  */ bool
> > > > +clk_dev_binded(struct clk *clk);
> > > >  #endif
> > > > --
> > > > 2.16.4
> > >
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma at denx.de
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de

  reply	other threads:[~2019-07-30  7:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23  3:15 [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 02/16] clk: use clk_dev_binded Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 03/16] clk: mux: add set parent support Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 04/16] clk: export mux/divider ops Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 05/16] clk: add clk-gate support Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 06/16] clk: divider set rate supporrt Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 07/16] clk: fixed_rate: export clk_fixed_rate Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 08/16] clk: imx: import clk heplers Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 09/16] clk: imx: gate2 add set rate Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 10/16] dm: clk: ignore default settings when node not valid Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 11/16] clk: add composite clk support Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 12/16] clk-provider: include clk-uclass.h Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 13/16] clk: gate: support sandbox Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 14/16] clk: sandbox: add composite clk Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 15/16] test: dm: clk_ccf: test " Peng Fan
2019-07-23  3:15 ` [U-Boot] [PATCH 16/16] configs: sandbox: Enable " Peng Fan
2019-07-29  8:31 ` [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded Peng Fan
2019-07-29  8:57   ` Lukasz Majewski
2019-07-29  8:59     ` Peng Fan
2019-07-30  6:58     ` Lukasz Majewski
2019-07-30  7:01       ` Peng Fan [this message]
2019-07-30  7:54         ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB448107A1B241F1EB25B3513888DC0@AM0PR04MB4481.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.