From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Sun, 19 Jan 2020 07:48:20 +0000 Subject: [RFC PATCH] imx: imx8mm-evk/imx8mn-evk: enable sysreset driver for SPL In-Reply-To: <3b3c46f0-e99a-2d06-be9c-a122ce343227@denx.de> References: <65d46ac8-a5f5-505c-4991-59fe4d946341@denx.de> <20200115144938.730627-1-ch@denx.de> <30f81d50-5470-bc41-b074-91e12782989a@denx.de> <3b3c46f0-e99a-2d06-be9c-a122ce343227@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Subject: Re: [RFC PATCH] imx: imx8mm-evk/imx8mn-evk: enable sysreset > driver for SPL > > On 1/17/20 3:33 AM, Peng Fan wrote: > > Hi Marek, > > Hi, > > >> Subject: Re: [RFC PATCH] imx: imx8mm-evk/imx8mn-evk: enable sysreset > >> driver for SPL > >> > >> On 1/16/20 3:21 AM, Peng Fan wrote: > >> > >> Hello Peng, > >> > >>>> Subject: [RFC PATCH] imx: imx8mm-evk/imx8mn-evk: enable sysreset > >>>> driver for SPL > >>>> > >>> > >>> NAK, this will not work on i.MX8MM/N. > >>> > >>> Currently sysreset psci is enabled, however psci will not work for > >>> SPL, because SPL boots before BL31. > >> > >> Thank you for the constructive feedback. > >> > >> So basically , what we need is a real sysreset driver for iMX8MM , > >> which can work with bare-bones hardware interface, that is, poking > >> some register, correct ? > > > > Yes. > > > >> > >> So, either you or Claudius needs to implement a driver in > >> drivers/sysreset, which will bind in SPL and if needed, do some > >> writel() into some registers to reset the board, correct ? > > > > Yes. > > > >> > >> Because, I believe we can both agree that dumping such ad-hoc code > >> which implements reset in board code is not the right way, esp. > >> nowadays with all the DM/DT stuff in. > > > > Alought we still have ocram space, but our SPL is huge now, 100KB+ > > How so ? > > How much does DM sysreset add to that ? currently I am a bit hesitated about DM SPL, but it let us not to maintain two drivers for one module. Just some complaining words:) I am fine to add DM sysreset currently. Not sure how much it will add after DM usb. Regards, Peng.