From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Thu, 25 Oct 2018 08:45:05 +0000 Subject: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists In-Reply-To: <5bfa3050-8b82-f99e-c561-2e2d300ab0fc@denx.de> References: <20181024095456.27486-1-peng.fan@nxp.com> <20181025014337.762f7ec9@crub> <61b66811-a143-f1f6-dd56-141a5802cbd3@denx.de> <5bfa3050-8b82-f99e-c561-2e2d300ab0fc@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Stefano, > -----Original Message----- > From: Stefano Babic [mailto:sbabic at denx.de] > Sent: 2018年10月25日 16:35 > To: Peng Fan ; Stefano Babic ; Anatolij > Gustschin > Cc: u-boot at lists.denx.de > Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files > not exists > > On 25/10/18 10:27, Peng Fan wrote: > > > > > >> -----Original Message----- > >> From: Stefano Babic [mailto:sbabic at denx.de] > >> Sent: 2018年10月25日 16:26 > >> To: Peng Fan ; Anatolij Gustschin > >> Cc: sbabic at denx.de; u-boot at lists.denx.de > >> Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when > >> required files not exists > >> > >> Hi Peng, > >> > >> On 25/10/18 03:14, Peng Fan wrote: > >>> > >>> > >>>> -----Original Message----- > >>>> From: Anatolij Gustschin [mailto:agust at denx.de] > >>>> Sent: 2018年10月25日 7:44 > >>>> To: Peng Fan > >>>> Cc: sbabic at denx.de; u-boot at lists.denx.de > >>>> Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when > >>>> required files not exists > >>>> > >>>> Hi Peng, > >>>> > >>>> On Wed, 24 Oct 2018 09:49:04 +0000 > >>>> Peng Fan peng.fan at nxp.com wrote: > >>>> ... > >>>>> --- /dev/null > >>>>> +++ b/tools/imx8_cntr_image.sh > >>>>> @@ -0,0 +1,32 @@ > >>>>> +#!/bin/sh > >>>>> +# SPDX-License-Identifier: GPL-2.0+ # # script to generate FIT > >>>>> +image source for K3 Family boards with # ATF, OPTEE, SPL and > >>>>> +multiple device trees (given on the command line). > >>>>> +# Inspired from board/sunxi/mksunxi_fit_atf.sh > >>>> > >>>> Please drop this comment, it doesn't describe what the script is > >>>> actually > >> doing. > >>> > >>> Thanks. Fix in V2. > >> > >> I wanted to send my PR as soon as possible to Tom. I didn't want to > >> block i.MX8 merge just for this, and I merged V1 and sent PR. > > > > No, please not use v1. > > > > V2 patch will be out soon. It is under CI test. I'll send out now. > > Ok, I drop from server and I wait for it. V2 has been out. CI: https://travis-ci.org/MrVan/u-boot/builds/446043677 There is a build warning because of dts, I also send a follow up patch to fix dts build warning, but not kick a new CI build, because it is only i.mx8qxp related. In my local, with ahah image removed. ./tools/buildman/buildman imx8qxp_mek mx6sabresd Building current source for 2 boards (2 threads, 2 jobs per thread) 2 0 0 /2 mx6sabresd I think it should be fine to be merged into your tree for the v2 and dts fix now. Thanks, Peng. > > Thanks, > Stefano > > > > > Thanks, > > Peng. > > > >> > >> Can you send then a follow-up patch instead of V2 ? V1 is on > >> u-boot-imx, and Tom will merge the tree soon. > >> > >> Best regards, > >> Stefano > >> > >>> > >>>> > >>>> ... > >>>>> +file=$1 > >>>>> + > >>>>> +linecount=`cat ${file} | wc -l` > >>>>> + > >>>>> +for ((i=1; i<=${linecount}; i++)); do > >>>> [ snip ] > >>>> > >>>> blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}' > >>>> $file` for f in $blobs; do > >>>> if [ ! -f $f ]; then > >>>> echo "WARNING '$f' not found, resulting binary is not-functional" > >>>> fi; > >>>> done > >>>> > >>>> will do the checks more efficiently. > >>> > >>> Yes. Simpiler. > >>> > >>> Thanks, > >>> Peng. > >>> > >>>> > >>>> Thanks, > >>>> > >>>> Anatolij > >> > >> > >> -- > >> > ================================================================ > >> ===== > >> DENX Software Engineering GmbH, Managing Director: Wolfgang > Denk > >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > >> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de > >> > ================================================================ > >> ===== > > > -- > ================================================================ > ===== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de > ================================================================ > =====