From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <peng.fan@nxp.com>
Date: Tue, 30 Jul 2019 07:54:01 +0000
Subject: [U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded
In-Reply-To: <AM0PR04MB448107A1B241F1EB25B3513888DC0@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <20190723033031.12404-1-peng.fan@nxp.com>
 <AM0PR04MB448169E6A81FC26E0573883A88DD0@AM0PR04MB4481.eurprd04.prod.outlook.com>
 <20190729105733.7483f49f@jawa> <20190730085832.24195a23@jawa>
 <AM0PR04MB448107A1B241F1EB25B3513888DC0@AM0PR04MB4481.eurprd04.prod.outlook.com>
Message-ID: <AM0PR04MB4481563D565D38A238E32A4C88DC0@AM0PR04MB4481.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Lukasz,

> Subject: RE: [PATCH 01/16] clk: introduce clk_dev_binded
> 
> 
> Hi Lukasz,
> > Subject: Re: [PATCH 01/16] clk: introduce clk_dev_binded
> >
> > Hi Peng,
> >
> > > Hi Peng,
> > >
> > > > Hi Lukasz,
> > > >
> > > > > Subject: [PATCH 01/16] clk: introduce clk_dev_binded
> > > >
> > > > Do you have time to review the patchset? Patches were delegated to
> > > > you.
> > >
> > > The i.MX related PR (with base CCF) has been pulled to mainline just
> > > yesteday, so I'm going to rewiew and test your code on top of it
> > > (with
> > > buildman) today.
> > >
> > > I shall send PR for -clk tomorrow.
> > >
> >
> > The patches from this series causes the sandbox travis-ci to break:
> > https://travis-ci.org/lmajewski/u-boot-dfu/builds/565204559
> 
> I ran qcheck before posting patches.

Missed a build warning when ran qcheck.

It was divider_recalc_rate missed add to clk-provider.h.
Just posted out v2.

Thanks,
Peng.

> 
> >
> > Please fix those errors.
> >
> > You can also reproduce this issue with:
> >
> > ./tools/buildman/buildman.py --branch=HEAD sandbox  --show_errors
> > --force-build --count=16 --output-dir=../BUILD/
> 
> I'll fix soon.
> 
> Thanks,
> Peng.
> 
> >
> > run on this series.
> >
> > > Thanks for your patches.
> > >
> > > >
> > > > Thanks,
> > > > Peng.
> > > >
> > > > >
> > > > > When support Clock Common Framework, U-Boot use dev for clk tree
> > > > > information, there is no clk->parent. When support composite
> > > > > clk, it contains mux/gate/divider, but the mux/gate/divider is
> > > > > not binded with device. So we could not use dev_get_uclass_priv
> > > > > to get the correct clk_mux/gate/divider. So add clk_dev_binded
> > > > > to let choose the correct method.
> > > > >
> > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > > ---
> > > > >  drivers/clk/clk.c | 8 ++++++++
> > > > >  include/clk.h     | 9 +++++++++
> > > > >  2 files changed, 17 insertions(+)
> > > > >
> > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index
> > > > > 7d748c9fc7..39b3087067 100644
> > > > > --- a/drivers/clk/clk.c
> > > > > +++ b/drivers/clk/clk.c
> > > > > @@ -55,3 +55,11 @@ const char *clk_hw_get_name(const struct clk
> > > > > *hw) {
> > > > >  	return hw->dev->name;
> > > > >  }
> > > > > +
> > > > > +bool clk_dev_binded(struct clk *clk) {
> > > > > +	if (clk->dev && (clk->dev->flags & DM_FLAG_BOUND))
> > > > > +		return true;
> > > > > +
> > > > > +	return false;
> > > > > +}
> > > > > diff --git a/include/clk.h b/include/clk.h index
> > > > > f8f56d9cf0..2ebc905e04 100644
> > > > > --- a/include/clk.h
> > > > > +++ b/include/clk.h
> > > > > @@ -356,4 +356,13 @@ static inline bool clk_valid(struct clk *clk)
> > > > >   * @return zero on success, or -ENOENT on error
> > > > >   */
> > > > >  int clk_get_by_id(ulong id, struct clk **clkp);
> > > > > +
> > > > > +/**
> > > > > + * clk_dev_binded() - Check whether the clk has a device binded
> > > > > + *
> > > > > + * @clk		A pointer to the clk
> > > > > + *
> > > > > + * @return true on binded, or false on no  */ bool
> > > > > +clk_dev_binded(struct clk *clk);
> > > > >  #endif
> > > > > --
> > > > > 2.16.4
> > > >
> > >
> > >
> > >
> > >
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > --
> > >
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany
> > > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > > lukma at denx.de
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma at denx.de