[U-Boot] [PATCH v2 00/32] spi: DM_SPI migration timeout, remainder(2)

From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 00/32] spi: DM_SPI migration timeout, remainder(2)
Date: Mon, 26 Nov 2018 07:18:52 +0000	[thread overview]
Message-ID: <AM0PR04MB4481583F3F0385E44A3B825088D70@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181125172853.20491-1-jagan@amarulasolutions.com>

Hi Jagan,

Just have a quick question here.

After dropping non-DM code, for SPL use non-DM code should switch to SPL_DM and use SPL OF CONTROL?

Thanks,
Peng.

> -----Original Message-----
> From: Jagan Teki [mailto:jagan at amarulasolutions.com]
> Sent: 2018年11月26日 1:28
> To: Adam Ford <aford173@gmail.com>; Vitaly Andrianov <vitalya@ti.com>;
> Stefano Babic <sbabic@denx.de>; Peter Howard <phoward@gme.net.au>;
> Tom Rini <trini@konsulko.com>; Walter Schweizer
> <swwa@users.sourceforge.net>; Valentin Longchamp
> <valentin.longchamp@keymile.com>; Phil Sutter <phil@nwl.cc>; Stefan
> Roese <sr@denx.de>; Simon Glass <sjg@chromium.org>; Tuomas Tynkkynen
> <tuomas@tuxera.com>; Sam Protsenko <semen.protsenko@linaro.org>; Dirk
> Eibach <dirk.eibach@gdsys.cc>; Mario Six <mario.six@gdsys.cc>; Simon
> Guinot <simon.guinot@sequanux.org>; Konstantin Porotchkin
> <kostap@marvell.com>; Jason Cooper <u-boot@lakedaemon.net>; Marek
> Behún <marek.behun@nic.cz>; Lokesh Vutla <lokeshvutla@ti.com>; Andrew
> F . Davis <afd@ti.com>; Uri Mashiach <uri.mashiach@compulab.co.il>; Heiko
> Schocher <hs@denx.de>; Tc Liew <tsi-chung.liew@nxp.com>; Joe
> Hershberger <joe.hershberger@ni.com>; Angelo Dureghello
> <angelo@sysam.it>; Vladimir Zapolskiy <vz@mleia.com>; Albert ARIBAUD
> <albert.aribaud@3adev.fr>; Marek Vasut <marex@denx.de>; Fabio Estevam
> <fabio.estevam@nxp.com>; Nikita Kiryanov <nikita@compulab.co.il>; Lukasz
> Majewski <lukma@denx.de>; Markus Niebel
> <Markus.Niebel@tq-group.com>; Troy Kisky
> <troy.kisky@boundarydevices.com>; Akshay Bhat
> <akshaybhat@timesys.com>; Ken Lin <Ken.Lin@advantech.com.tw>; Peng
> Fan <peng.fan@nxp.com>; Magnus Lilja <lilja.magnus@gmail.com>; Christian
> Gmeiner <christian.gmeiner@gmail.com>; Eric Bénard <eric@eukrea.com>;
> Ian Ray <ian.ray@ge.com>; Otavio Salvador <otavio@ossystems.com.br>;
> Andreas Geisreiter <ageisreiter@dh-electronics.de>; Ludwig Zenz
> <lzenz@dh-electronics.de>; Dmitry Lifshitz <lifshitz@compulab.co.il>; Roger
> Meier <r.meier@siemens.com>; Gilles Gameiro <gilles@gigadevices.com>;
> Lothar Felten <lothar.felten@gmail.com>; Tapani Utriainen
> <linuxfae@technexion.com>; Steve Sakoman <sakoman@gmail.com>; Pali
> Rohár <pali.rohar@gmail.com>; Marcin Niestroj
> <m.niestroj@grinn-global.com>; Nishanth Menon <nm@ti.com>; Lars
> Poeschel <poeschel@lemonage.de>; Enric Balletbo i Serra
> <eballetbo@gmail.com>; Yegor Yefremov <yegorslists@googlemail.com>; Ash
> Charles <ash@gumstix.com>; Grazvydas Ignotas <notasas@gmail.com>; Igor
> Grinberg <grinberg@compulab.co.il>; Derald D . Woods
> <woods.technical@gmail.com>; Hannes Schmelzer
> <hannes.schmelzer@br-automation.com>; Eugen Hristev
> <eugen.hristev@microchip.com>; Ludovic Desroches
> <ludovic.desroches@microchip.com>; Stelian Pop <stelian@popies.net>;
> Mateusz Kulikowski <mateusz.kulikowski@gmail.com>; Ilko Iliev
> <iliev@ronetix.at>; Daniel Gorsulowski <daniel.gorsulowski@esd.eu>; Ben
> Whitten <ben.whitten@lairdtech.com>; Andreas Bießmann
> <andreas@biessmann.org>; Erik van Luijk <evanluijk@interact.nl>; Gregory
> CLEMENT <gregory.clement@free-electrons.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Sumit Garg <sumit.garg@nxp.com>; York
> Sun <york.sun@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>; Priyanka Jain
> <priyanka.jain@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; Alison Wang
> <alison.wang@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com>; Udit
> Agarwal <udit.agarwal@nxp.com>; VINITHA V PILLAI
> <vinitha.pillai@nxp.com>; Feng Li <feng.li_2@nxp.com>; Qiang Zhao
> <qiang.zhao@nxp.com>; Naveen Burmi <naveen.burmi@nxp.com>;
> Shengzhou Liu <shengzhou.liu@nxp.com>; Ruchika Gupta
> <ruchika.gupta@nxp.com>; Poonam Aggrwal <poonam.aggrwal@nxp.com>;
> Timur Tabi <timur@tabi.org>; Xiaobo Xie <xiaobo.xie@nxp.com>; PO LIU
> <po.liu@nxp.com>
> Cc: u-boot at lists.denx.de; Jagan Teki <jagan@amarulasolutions.com>
> Subject: [PATCH v2 00/32] spi: DM_SPI migration timeout, remainder(2)
> 
> This series fix, build issues and comments from previous series [1].
> 
> We have not heard any positive feed back about dm-conversion on spi drivers
> along with no response for the work done by Akash and me.
> 
> Plan is to send the same series remainder recursively based on the dm
> conversion updates and finally merged into v2019.04 MW.
> 
> So expecting inputs from relevant developers to move their board/drivers to
> support DM_SPI.
> 
> - cf_spi, lpc32xx_ssp, mxs_spi, sh_spi, soft_spi_legacy, fsl_espi drivers are
> drooped with their respective CONFIG items.
> the spi/spi-flash usage commands still build but the used spi core function
> calls return 0.
> - non-dm code in davinci, kirkwood, ti_qspi, mpc8xxx, mxc, omap3, atmel,
> fsl_dspi drivers were drooped and u-boot build system will trigger warning for
> the same.
> 
> Note:
> - Let's discuss if any foot-print issues?
> 
> Any inputs,
> Jagan.
> 
> [1]
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.ozlabs.org%2Fcover%2F1000444%2F&amp;data=02%7C01%7Cpeng.fa
> n%40nxp.com%7C575d95c25be74fc237bb08d652fb8b34%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C636787637664212094&amp;sdata=Wy
> H54iAVB%2BRPIVvgpQsw1T3cG5UUtNRKbFR08wibgOg%3D&amp;reserved=
> 0
> 
> Jagan Teki (15):
>   spi: davinci: Full dm conversion
>   spi: kirkwood: Full dm conversion
>   spi: ti_qspi: Full dm conversion
>   spi: mpc8xxx: Convert to DM
>   spi: Zap cf_spi driver-related code
>   spi: Zap lpc32xx_ssp driver-related code
>   spi: Zap mxs_spi driver-related code
>   spi: Zap sh_spi driver-related code
>   spi: Zap soft_spi_legacy driver-related code
>   spi: mxc: Drop non-dm code
>   spi: omap3: Drop non-dm code
>   spi: atmel: Drop non-dm code
>   spi: Zap fsl_espi driver-related code
>   spi: fsl_dspi: Drop non-dm code
>   dm: MIGRATION: spi: Update SPI driver status
> 
> Mario Six (17):
>   spi: mpc8xxx: Use short type names
>   spi: mpc8xxx: Fix comments
>   spi: mpc8xxx: Rename camel-case variables
>   spi: mpc8xxx: Fix space after cast
>   spi: mpc8xxx: Fix function names in strings
>   spi: mpc8xxx: Replace defines with enums
>   spi: mpc8xxx: Use IO accessors
>   spi: mpc8xxx: Simplify if
>   spi: mpc8xxx: Get rid of is_read
>   spi: mpc8xxx: Simplify logic a bit
>   spi: mpc8xxx: Reduce scope of loop variables
>   spi: mpc8xxx: Make code more readable
>   spi: mpc8xxx: Rename variable
>   spi: mpc8xxx: Document LEN setting better
>   spi: mpc8xxx: Re-order transfer setup
>   spi: mpc8xxx: Fix if check
>   spi: mpc8xxx: Use get_timer
> 
>  Makefile                                      |  11 +
>  arch/m68k/cpu/mcf5227x/cpu_init.c             |  54 --
>  arch/m68k/cpu/mcf5445x/cpu_init.c             | 113 ----
>  board/Arcturus/ucp1020/ucp1020.c              |   6 +
>  configs/M52277EVB_defconfig                   |   1 -
>  configs/M52277EVB_stmicro_defconfig           |   1 -
>  configs/M54418TWR_defconfig                   |   1 -
>  configs/M54418TWR_nand_mii_defconfig          |   1 -
>  configs/M54418TWR_nand_rmii_defconfig         |   1 -
>  configs/M54418TWR_nand_rmii_lowfreq_defconfig |   1 -
>  configs/M54418TWR_serial_mii_defconfig        |   1 -
>  configs/M54418TWR_serial_rmii_defconfig       |   1 -
>  configs/M54451EVB_defconfig                   |   1 -
>  configs/M54451EVB_stmicro_defconfig           |   1 -
>  configs/M54455EVB_a66_defconfig               |   1 -
>  configs/M54455EVB_defconfig                   |   1 -
>  configs/M54455EVB_i66_defconfig               |   1 -
>  configs/M54455EVB_intel_defconfig             |   1 -
>  configs/M54455EVB_stm33_defconfig             |   1 -
>  configs/bg0900_defconfig                      |   1 -
>  configs/devkit3250_defconfig                  |   1 -
>  configs/mx28evk_auart_console_defconfig       |   1 -
>  configs/mx28evk_defconfig                     |   1 -
>  configs/mx28evk_nand_defconfig                |   1 -
>  configs/mx28evk_spi_defconfig                 |   1 -
>  configs/sh7752evb_defconfig                   |   1 -
>  configs/sh7753evb_defconfig                   |   1 -
>  configs/sh7757lcr_defconfig                   |   1 -
>  configs/stmark2_defconfig                     |   1 -
>  configs/work_92105_defconfig                  |   1 -
>  doc/driver-model/MIGRATION.txt                |  18 +-
>  drivers/spi/Kconfig                           |  42 +-
>  drivers/spi/Makefile                          |  22 +-
>  drivers/spi/atmel_spi.c                       | 198 -------
>  drivers/spi/cf_spi.c                          | 335 ------------
>  drivers/spi/davinci_spi.c                     | 157 ------
>  drivers/spi/fsl_dspi.c                        | 132 -----
>  drivers/spi/fsl_espi.c                        | 383 --------------
>  drivers/spi/kirkwood_spi.c                    | 218 ++------
>  drivers/spi/lpc32xx_ssp.c                     | 134 -----
>  drivers/spi/mpc8xxx_spi.c                     | 279 ++++++----
>  drivers/spi/mxc_spi.c                         | 123 +----
>  drivers/spi/mxs_spi.c                         | 358 -------------
>  drivers/spi/omap3_spi.c                       | 126 -----
>  drivers/spi/sh_spi.c                          | 249 ---------
>  drivers/spi/sh_spi.h                          |  67 ---
>  drivers/spi/soft_spi_legacy.c                 | 168 ------
>  drivers/spi/spi.c                             |  38 ++
>  drivers/spi/ti_qspi.c                         | 490 +++++++-----------
>  include/configs/M52277EVB.h                   |   1 -
>  include/configs/M54418TWR.h                   |   1 -
>  include/configs/M54451EVB.h                   |   1 -
>  include/configs/M54455EVB.h                   |   1 -
>  include/configs/MPC8349EMDS.h                 |   3 -
>  include/configs/devkit3250.h                  |   5 -
>  include/configs/sh7752evb.h                   |   3 -
>  include/configs/sh7753evb.h                   |   3 -
>  include/configs/sh7757lcr.h                   |   3 -
>  include/configs/stmark2.h                     |   1 -
>  include/configs/work_92105.h                  |   5 -
>  include/configs/zipitz2.h                     |   1 -
>  include/dm/platform_data/spi_kirkwood.h       |  15 +
>  include/dm/platform_data/spi_ti_qspi.h        |  19 +
>  scripts/config_whitelist.txt                  |   3 -
>  64 files changed, 502 insertions(+), 3310 deletions(-)  delete mode 100644
> drivers/spi/cf_spi.c  delete mode 100644 drivers/spi/fsl_espi.c  delete
> mode 100644 drivers/spi/lpc32xx_ssp.c  delete mode 100644
> drivers/spi/mxs_spi.c  delete mode 100644 drivers/spi/sh_spi.c  delete
> mode 100644 drivers/spi/sh_spi.h  delete mode 100644
> drivers/spi/soft_spi_legacy.c  create mode 100644
> include/dm/platform_data/spi_kirkwood.h
>  create mode 100644 include/dm/platform_data/spi_ti_qspi.h
> 
> --
> 2.18.0.321.gffc6fa0e3