From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Fri, 9 Aug 2019 07:07:58 +0000 Subject: [U-Boot] [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers when setting ENET clock In-Reply-To: <20190730071213.11238-6-lukma@denx.de> References: <20190730071213.11238-1-lukma@denx.de> <20190730071213.11238-6-lukma@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Subject: [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers > when setting ENET clock > > This is a cosmetic change, just to use proper define instead of magic numbers. > > Signed-off-by: Lukasz Majewski > --- > > board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c > b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c > index 7bdc64b1be..1dbd03efd8 100644 > --- a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c > +++ b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c > @@ -118,7 +118,8 @@ static int setup_fec_clock(void) > struct iomuxc *iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR; > > /* set gpr1[21] to select anatop clock */ > - clrsetbits_le32(&iomuxc_regs->gpr[1], 0x1 << 21, 0x1 << 21); > + clrsetbits_le32(&iomuxc_regs->gpr[1], > IOMUXC_GPR1_ENET_CLK_SEL_MASK, > + IOMUXC_GPR1_ENET_CLK_SEL_MASK); Would setbits_le32 work here? Regards, Peng. > > return enable_fec_anatop_clock(0, ENET_50MHZ); } > -- > 2.11.0