All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 1/4] clk: introduce enable_count
Date: Mon, 26 Aug 2019 01:08:21 +0000	[thread overview]
Message-ID: <AM0PR04MB4481BAAE8900C22D62B5B64B88A10@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAPnjgZ2i1Wvq_-4nTWXVuyzCiQ_VJ_1SL2TK90z33mLu=WEdZQ@mail.gmail.com>

Hi Simon,

> Subject: Re: [PATCH V3 1/4] clk: introduce enable_count
> 
> Hi Peng,
> 
> On Wed, 21 Aug 2019 at 07:35, Peng Fan <peng.fan@nxp.com> wrote:
> >
> > As what Linux Kernel 5.3.0 provides when enable/disable clk, there is
> > an enable_count in clk_core_disable/enable. Introduce enable_count to
> > track the clk enable/disable count when clk_enable/disable for CCF.
> > And Initialize enable_count to 0 when register the clk.
> >
> > And clk tree dump with enable_count will be supported, it will be easy
> > for us to check the clk status with enable_count
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V3:
> >  None
> >  CI:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrav
> >
> is-ci.org%2FMrVan%2Fu-boot%2Fbuilds%2F574753709&amp;data=02%7C01
> %7Cpen
> >
> g.fan%40nxp.com%7C626abf64d2f8431f2bcc08d72813bbb2%7C686ea1d3bc
> 2b4c6fa
> >
> 92cd99c5c301635%7C0%7C0%7C637021937522749993&amp;sdata=PQs59S
> 1gAK8P%2B
> > HGOfXKweJlVHqKGJDZ11jM%2F45%2BCz7E%3D&amp;reserved=0
> > V2:
> >  Improve commit log
> >  Rename enable_cnt to enable_count following Linux Kernel
> >
> >  drivers/clk/clk.c            | 1 +
> >  drivers/clk/clk_fixed_rate.c | 1 +
> >  include/clk.h                | 1 +
> >  3 files changed, 3 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Do you think it would be worth making this a u8 to save space?

The structured is not marked __packed, so u8 would not save space.

> 
> Or perhaps this feature could be optional?

I'll try.

Thanks,
Peng.

> 
> Regards,
> Simon

      reply	other threads:[~2019-08-26  1:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 13:35 [U-Boot] [PATCH V3 1/4] clk: introduce enable_count Peng Fan
2019-08-21 13:35 ` [U-Boot] [PATCH V3 2/4] clk: prograte clk enable/disable to parent Peng Fan
2019-08-21 13:35 ` [U-Boot] [PATCH V3 3/4] clk: support clk tree dump Peng Fan
2019-08-23 21:48   ` Simon Glass
2019-08-26  1:08     ` Peng Fan
2019-08-21 13:35 ` [U-Boot] [PATCH V3 4/4] sandbox: clk: add clk enable/disable test code Peng Fan
2019-08-23 21:49   ` Simon Glass
2019-08-23 21:48 ` [U-Boot] [PATCH V3 1/4] clk: introduce enable_count Simon Glass
2019-08-26  1:08   ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB4481BAAE8900C22D62B5B64B88A10@AM0PR04MB4481.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.