From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <peng.fan@nxp.com>
Date: Wed, 19 Jun 2019 02:17:59 +0000
Subject: [U-Boot] [PATCH V2 1/3] test: dm: adc: use the real device name
In-Reply-To: <20190522072201.5130-1-peng.fan@nxp.com>
References: <20190522072201.5130-1-peng.fan@nxp.com>
Message-ID: <AM0PR04MB4481E6626F10B9C3C794724A88E50@AM0PR04MB4481.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon, Tom
> Subject: [PATCH V2 1/3] test: dm: adc: use the real device name
> 
> "adc" is not the real device name, "adc at 0" is.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Will you pick up this patchset?
https://patchwork.ozlabs.org/patch/1103212/
https://patchwork.ozlabs.org/patch/1103213/
https://patchwork.ozlabs.org/patch/1103214/

Thanks,
Peng.

> ---
> 
> V2:
>  new
> 
>  test/dm/adc.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/test/dm/adc.c b/test/dm/adc.c index 1f82304f41..da7bd4bf1f
> 100644
> --- a/test/dm/adc.c
> +++ b/test/dm/adc.c
> @@ -24,7 +24,7 @@ static int dm_test_adc_bind(struct unit_test_state *uts)
>  	struct udevice *dev;
>  	unsigned int channel_mask;
> 
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
>  	ut_asserteq_str(SANDBOX_ADC_DEVNAME, dev->name);
> 
>  	ut_assertok(adc_channel_mask(dev, &channel_mask)); @@ -38,7 +38,7
> @@ static int dm_test_adc_wrong_channel_selection(struct unit_test_state
> *uts)  {
>  	struct udevice *dev;
> 
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
>  	ut_asserteq(-EINVAL, adc_start_channel(dev,
> SANDBOX_ADC_CHANNELS));
> 
>  	return 0;
> @@ -51,7 +51,7 @@ static int dm_test_adc_supply(struct unit_test_state
> *uts)
>  	struct udevice *dev;
>  	int uV;
> 
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
> 
>  	/* Test Vss value - predefined 0 uV */
>  	ut_assertok(adc_vss_value(dev, &uV));
> @@ -94,7 +94,7 @@ static int
> dm_test_adc_single_channel_conversion(struct unit_test_state *uts)
>  	unsigned int i, data;
>  	struct udevice *dev;
> 
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
>  	/* Test each ADC channel's value */
>  	for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) {
>  		ut_assertok(adc_start_channel(dev, tdata->id)); @@ -117,7 +117,7
> @@ static int dm_test_adc_multi_channel_conversion(struct unit_test_state
> *uts)
>  		       ADC_CHANNEL(2) | ADC_CHANNEL(3);
> 
>  	/* Start multi channel conversion */
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
>  	ut_assertok(adc_start_channels(dev, channel_mask));
>  	ut_assertok(adc_channels_data(dev, channel_mask, channels));
> 
> @@ -136,7 +136,7 @@ static int dm_test_adc_single_channel_shot(struct
> unit_test_state *uts)
> 
>  	for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) {
>  		/* Start single channel conversion */
> -		ut_assertok(adc_channel_single_shot("adc", tdata->id, &data));
> +		ut_assertok(adc_channel_single_shot("adc at 0", tdata->id, &data));
>  		/* Compare the expected and returned conversion data. */
>  		ut_asserteq(tdata->data, data);
>  	}
> @@ -155,7 +155,7 @@ static int dm_test_adc_multi_channel_shot(struct
> unit_test_state *uts)
>  		       ADC_CHANNEL(2) | ADC_CHANNEL(3);
> 
>  	/* Start single call and multi channel conversion */
> -	ut_assertok(adc_channels_single_shot("adc", channel_mask, channels));
> +	ut_assertok(adc_channels_single_shot("adc at 0", channel_mask,
> +channels));
> 
>  	/* Compare the expected and returned conversion data. */
>  	for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) @@ -183,7
> +183,7 @@ static int dm_test_adc_raw_to_uV(struct unit_test_state *uts)
>  	struct udevice *dev;
>  	int uV;
> 
> -	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev));
> +	ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc at 0",
> &dev));
>  	/* Test each ADC channel's value in microvolts */
>  	for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) {
>  		ut_assertok(adc_start_channel(dev, tdata->id));
> --
> 2.16.4