From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBA7C433E7 for ; Fri, 9 Oct 2020 07:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5C7322275 for ; Fri, 9 Oct 2020 07:54:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="kUz2uK3a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbgJIHyH (ORCPT ); Fri, 9 Oct 2020 03:54:07 -0400 Received: from mail-eopbgr30079.outbound.protection.outlook.com ([40.107.3.79]:57411 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725908AbgJIHyH (ORCPT ); Fri, 9 Oct 2020 03:54:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kR3Cusb3Txwsr4I1JXVRnJ9FIYmWOKz/Ozly/7dkORgPwbiPqgD3QDfmYdchTevbXEEjLpmcM9mUzfOGqzhJsGlfm/nCmSx+TOOiSE0LJaNqQ6CEE85CGt+dyr0PDmX81gepWHKX1XZkS0aRrs8IV+/1JqPiUA08gHiaR44f/kweD8/ZjKCMgctVD4dT+NgmXQ3H4RH6nstG4EV9QsWbfYuMuA36z9Rrm0UnzAK1MbVZMheW40eIxVL4EZwAgMlAVbNshcY4uFhWlYGL/IxFkN0sGnO+JipS9lYnXwzfBNfSr1thFPEPtLMjPnFNmvk7kBr5sKXy7mowNrbYUlr4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhGLlWU5oyNKkoNCTknMh7NBDkiywTG7alGMuo3AZik=; b=gyUvGe6XpPsdWSYdJuhtYZIWplQKw1mW3MzSpFgc4AAmsGkCkXmYekufmXBomtLYLbySBEBHL1kCq/CiOUevSWnwjrNSoAocsgcYXW4/s/6CQoxURDoeMxiVOWLPviAbOJjNWiFSJNcbcSp/FWL9Ji57kr2u4kS5e6EYg/JkOwR2VYjgRmdU8BJJv4pD9WFCpCJ2DfCO+eMOuVKKxuUZ1+yZuU2iqSCwAHzA98iYJlac2BJ16Fa6DXD/RUr3h06tQ/3RbVZ0CTv4caM37BosPz99gb78hDJ6bPVrezzSPefzz/CYDTA4LncUqZnuiS6ipL08+kQh5lhLSMOBgJL6EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhGLlWU5oyNKkoNCTknMh7NBDkiywTG7alGMuo3AZik=; b=kUz2uK3aWJIaTe9MUaOVtCMMhnd2d8xIlufQ9vQnk1IpuFA4XfoiJW9zTDFmMMOuh1l878PONP4C5CUpsegGtWKBdDMHZNfaViRm6hEEZDpVM+StHyJWSQsn3IimceGjEksEsaKbKdazQrYP0PMHNKaXSkyCD4z4qSQXkr6ecxw= Received: from AM0PR04MB4915.eurprd04.prod.outlook.com (2603:10a6:208:c5::20) by AM8PR04MB7828.eurprd04.prod.outlook.com (2603:10a6:20b:24e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Fri, 9 Oct 2020 07:54:00 +0000 Received: from AM0PR04MB4915.eurprd04.prod.outlook.com ([fe80::8de5:80f:f11a:5fa3]) by AM0PR04MB4915.eurprd04.prod.outlook.com ([fe80::8de5:80f:f11a:5fa3%7]) with mapi id 15.20.3455.024; Fri, 9 Oct 2020 07:54:00 +0000 From: Jacky Bai To: Lucas Stach , Shawn Guo , Rob Herring CC: dl-linux-imx , Fabio Estevam , Frieder Schrempf , Marek Vasut , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" , "patchwork-lst@pengutronix.de" Subject: RE: [PATCH 06/11] soc: imx: gpcv2: allow domains without power-sequence control Thread-Topic: [PATCH 06/11] soc: imx: gpcv2: allow domains without power-sequence control Thread-Index: AQHWl0Fo+PE1TNISW0yJPYfXXF8E36mO8ZRA Date: Fri, 9 Oct 2020 07:54:00 +0000 Message-ID: References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-7-l.stach@pengutronix.de> In-Reply-To: <20200930155006.535712-7-l.stach@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2f7f8fb4-5ede-4e97-7019-08d86c287bdc x-ms-traffictypediagnostic: AM8PR04MB7828: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b6rPX27BFA+CwvEUZJtyRuiF+w8YKK347Bo1gaOC3cxL4jFY5TC6VSKcPUH6dU3cdKbHo2v2j58Ykpx1wKcrDw4vHNi/F/8DNh1R0XgaJVbVMHCMMoeOE+H33t4/0yVfrbe3LUaZH2ZneAxw63rfpmRY+p09kpFecPMzNRL34MRbqnHJNYcjLa2cNsquORzKy/n8LfjxXIs5vaBeuL4QSoSCqLinLg2D0vxvnKPha5glHb9QJkxwduemKUWpbxtZhdEhKs6rIw4z7MN9Kj3Pi6wjtMmnMRRU7lfuKHjJSf/KmHpoP/VzHjxgr5t2kM0pSaJ0GN5/PcBlTLPLBE6frg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB4915.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(9686003)(478600001)(316002)(52536014)(110136005)(76116006)(66946007)(55016002)(54906003)(33656002)(8676002)(8936002)(26005)(71200400001)(4326008)(53546011)(6506007)(66476007)(83380400001)(64756008)(66556008)(86362001)(2906002)(186003)(7416002)(5660300002)(7696005)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: gB7ayDTqK+6w18MnAdG9cB1M+sMpW75mmVkDN4Gh0Yv06ZpImu9kPd16mX++DqJpkvJwf0mNwTPkvKXGwfH1LPclinUNDQLvCSo8Fyi6fJTZPm+oz2b0UL4129p1oqNTq6wDMxhzTzHGJqwyn8EcH/JkxQkK5RWI5esY3eQpcGAZJILoEvp59nWV6KXrgYhyfi6Vt0Z6aszpHXQuCMeDHWbcp6A9dCbLoFCSKgTQm1j1L8YDsKZsvfp3wyZ9PSmRhJ4qAe+eSrf2rBtD8MeYMyht8mQzUE5Ro4yzsGb9IXbSAPOiGjSP1mh4evx4tTOEe9KQJTDuY1AzSuBB/uWnS+PI/TLcn7QjKCaiRCDWxrapZt97Kgu3vdiCEF2v7SQ0u/b5B6LcLOw8Ii60DKKARShob4NnIgzUKuoP/XQLZPXNn+5D1Zcd1Nc4OcvJOFGKoVNDK/2/B0yAT9YLvu+K8UpL+D0e/v7VUXOKYT3Q0ZR6bX1i/zxlGqydlWqkZQVkeuA9/W04045pcYuj8i46Ytl9XuslF7K0XO/+tJnX/8wTRQR0hjjgp9asPgf1V50pfKs6oMe5f6leXB2k+SNDS/zyEcb++OsWexNDKndtmdKfsAB7zyv9ex378R3D5iu+Hkj0uLJzgYmPzpYaPWqQKA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4915.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7f8fb4-5ede-4e97-7019-08d86c287bdc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 07:54:00.4031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JX4ip/z0ZAV56MxLdETQSsaKgq7HBAH4JY+P4AopsMfdh700/YpjDEejivWwVLa0epJj3Xe2wGPnHK3TzIC0cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7828 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMdWNhcyBTdGFjaCBbbWFpbHRv Omwuc3RhY2hAcGVuZ3V0cm9uaXguZGVdDQo+IFNlbnQ6IFdlZG5lc2RheSwgU2VwdGVtYmVyIDMw LCAyMDIwIDExOjUwIFBNDQo+IFRvOiBTaGF3biBHdW8gPHNoYXduZ3VvQGtlcm5lbC5vcmc+OyBS b2IgSGVycmluZyA8cm9iaCtkdEBrZXJuZWwub3JnPg0KPiBDYzogZGwtbGludXgtaW14IDxsaW51 eC1pbXhAbnhwLmNvbT47IEZhYmlvIEVzdGV2YW0NCj4gPGZlc3RldmFtQGdtYWlsLmNvbT47IEZy aWVkZXIgU2NocmVtcGYgPGZyaWVkZXIuc2NocmVtcGZAa29udHJvbi5kZT47DQo+IE1hcmVrIFZh c3V0IDxtYXJleEBkZW54LmRlPjsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Ow0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsga2VybmVsQHBlbmd1dHJvbml4LmRlOw0K PiBwYXRjaHdvcmstbHN0QHBlbmd1dHJvbml4LmRlDQo+IFN1YmplY3Q6IFtQQVRDSCAwNi8xMV0g c29jOiBpbXg6IGdwY3YyOiBhbGxvdyBkb21haW5zIHdpdGhvdXQNCj4gcG93ZXItc2VxdWVuY2Ug Y29udHJvbA0KPiANCj4gU29tZSBvZiB0aGUgUEdDIGRvbWFpbnMgb25seSBjb250cm9sIHRoZSBo YW5kc2hha2Ugd2l0aCB0aGUgQURCNDAwIGFuZA0KPiBkb24ndCBoYXZlIGFueSBwb3dlciBzZXF1 ZW5jZSBjb250cm9scy4gTWFrZSBzdWNoIGRvbWFpbnMgd29yayBieQ0KPiBhbGxvd2luZyB0aGUg cHh4IGFuZCBtYXAgYml0cyB0byBiZSBlbXB0eSBhbmQgc2tpcCBhbGwgYWN0aW9ucyB1c2luZyB0 aG9zZQ0KPiBjb250cm9scy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2FzIFN0YWNoIDxsLnN0 YWNoQHBlbmd1dHJvbml4LmRlPg0KPiAtLS0NCj4gIGRyaXZlcnMvc29jL2lteC9ncGN2Mi5jIHwg ODkgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBj aGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCA0MCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3NvYy9pbXgvZ3BjdjIuYyBiL2RyaXZlcnMvc29jL2lteC9ncGN2Mi5jIGlu ZGV4DQo+IDViYjdiMWNjN2MxMC4uZGI5M2ZlZjBjNzZiIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJz L3NvYy9pbXgvZ3BjdjIuYw0KPiArKysgYi9kcml2ZXJzL3NvYy9pbXgvZ3BjdjIuYw0KPiBAQCAt MTY3LDI0ICsxNjcsMjcgQEAgc3RhdGljIGludCBpbXhfcGdjX3Bvd2VyX3VwKHN0cnVjdA0KPiBn ZW5lcmljX3BtX2RvbWFpbiAqZ2VucGQpDQo+ICAJCX0NCj4gIAl9DQo+IA0KPiAtCS8qIHJlcXVl c3QgdGhlIGRvbWFpbiB0byBwb3dlciB1cCAqLw0KPiAtCXJlZ21hcF91cGRhdGVfYml0cyhkb21h aW4tPnJlZ21hcCwgR1BDX1BVX1BHQ19TV19QVVBfUkVRLA0KPiAtCQkJICAgZG9tYWluLT5iaXRz LnB4eCwgZG9tYWluLT5iaXRzLnB4eCk7DQo+IC0JLyoNCj4gLQkgKiBBcyBwZXIgIjUuNS45LjQg RXhhbXBsZSBDb2RlIDQiIGluIElNWDdEUk0ucGRmIHdhaXQNCj4gLQkgKiBmb3IgUFVQX1JFUS9Q RE5fUkVRIGJpdCB0byBiZSBjbGVhcmVkDQo+IC0JICovDQo+IC0JcmV0ID0gcmVnbWFwX3JlYWRf cG9sbF90aW1lb3V0KGRvbWFpbi0+cmVnbWFwLA0KPiBHUENfUFVfUEdDX1NXX1BVUF9SRVEsDQo+ IC0JCQkJICAgICAgIHJlZ192YWwsICEocmVnX3ZhbCAmIGRvbWFpbi0+Yml0cy5weHgpLA0KPiAt CQkJCSAgICAgICAwLCBVU0VDX1BFUl9NU0VDKTsNCj4gLQlpZiAocmV0KSB7DQo+IC0JCWRldl9l cnIoZG9tYWluLT5kZXYsICJmYWlsZWQgdG8gY29tbWFuZCBQR0NcbiIpOw0KPiAtCQlnb3RvIG91 dF9jbGtfZGlzYWJsZTsNCj4gLQl9DQo+ICsJaWYgKGRvbWFpbi0+Yml0cy5weHgpIHsNCg0KV2hh dCBpZiB0aGUgcG93ZXIgZG9tYWluJ3MgUFVQL1BETiBjb250cm9sIGJpdCBkZWZpbmUgaXMgemVy bywgZm9yIGV4YW1wbGUsIElNWDhNX01JUElfU1dfUHh4X1JFUT8gDQoNCkJSDQpKYWNreSBCYWkN Cg0KPiArCQkvKiByZXF1ZXN0IHRoZSBkb21haW4gdG8gcG93ZXIgdXAgKi8NCj4gKwkJcmVnbWFw X3VwZGF0ZV9iaXRzKGRvbWFpbi0+cmVnbWFwLA0KPiBHUENfUFVfUEdDX1NXX1BVUF9SRVEsDQo+ ICsJCQkJICAgZG9tYWluLT5iaXRzLnB4eCwgZG9tYWluLT5iaXRzLnB4eCk7DQo+ICsJCS8qDQo+ ICsJCSAqIEFzIHBlciAiNS41LjkuNCBFeGFtcGxlIENvZGUgNCIgaW4gSU1YN0RSTS5wZGYgd2Fp dA0KPiArCQkgKiBmb3IgUFVQX1JFUS9QRE5fUkVRIGJpdCB0byBiZSBjbGVhcmVkDQo+ICsJCSAq Lw0KPiArCQlyZXQgPSByZWdtYXBfcmVhZF9wb2xsX3RpbWVvdXQoZG9tYWluLT5yZWdtYXAsDQo+ ICsJCQkJCSAgICAgICBHUENfUFVfUEdDX1NXX1BVUF9SRVEsIHJlZ192YWwsDQo+ICsJCQkJCSAg ICAgICAhKHJlZ192YWwgJiBkb21haW4tPmJpdHMucHh4KSwNCj4gKwkJCQkJICAgICAgIDAsIFVT RUNfUEVSX01TRUMpOw0KPiArCQlpZiAocmV0KSB7DQo+ICsJCQlkZXZfZXJyKGRvbWFpbi0+ZGV2 LCAiZmFpbGVkIHRvIGNvbW1hbmQgUEdDXG4iKTsNCj4gKwkJCWdvdG8gb3V0X2Nsa19kaXNhYmxl Ow0KPiArCQl9DQo+IA0KPiAtCS8qIGRpc2FibGUgcG93ZXIgY29udHJvbCAqLw0KPiAtCXJlZ21h cF91cGRhdGVfYml0cyhkb21haW4tPnJlZ21hcCwgR1BDX1BHQ19DVFJMKGRvbWFpbi0+cGdjKSwN Cj4gLQkJCSAgIEdQQ19QR0NfQ1RSTF9QQ1IsIDApOw0KPiArCQkvKiBkaXNhYmxlIHBvd2VyIGNv bnRyb2wgKi8NCj4gKwkJcmVnbWFwX3VwZGF0ZV9iaXRzKGRvbWFpbi0+cmVnbWFwLA0KPiBHUENf UEdDX0NUUkwoZG9tYWluLT5wZ2MpLA0KPiArCQkJCSAgIEdQQ19QR0NfQ1RSTF9QQ1IsIDApOw0K PiArCX0NCj4gDQo+ICAJLyogcmVxdWVzdCB0aGUgQURCNDAwIHRvIHBvd2VyIHVwICovDQo+ICAJ aWYgKGRvbWFpbi0+Yml0cy5oc2tyZXEpIHsNCj4gQEAgLTI0OCwyMyArMjUxLDI2IEBAIHN0YXRp YyBpbnQgaW14X3BnY19wb3dlcl9kb3duKHN0cnVjdA0KPiBnZW5lcmljX3BtX2RvbWFpbiAqZ2Vu cGQpDQo+ICAJCX0NCj4gIAl9DQo+IA0KPiAtCS8qIGVuYWJsZSBwb3dlciBjb250cm9sICovDQo+ IC0JcmVnbWFwX3VwZGF0ZV9iaXRzKGRvbWFpbi0+cmVnbWFwLCBHUENfUEdDX0NUUkwoZG9tYWlu LT5wZ2MpLA0KPiAtCQkJICAgR1BDX1BHQ19DVFJMX1BDUiwgR1BDX1BHQ19DVFJMX1BDUik7DQo+ IC0NCj4gLQkvKiByZXF1ZXN0IHRoZSBkb21haW4gdG8gcG93ZXIgZG93biAqLw0KPiAtCXJlZ21h cF91cGRhdGVfYml0cyhkb21haW4tPnJlZ21hcCwgR1BDX1BVX1BHQ19TV19QRE5fUkVRLA0KPiAt CQkJICAgZG9tYWluLT5iaXRzLnB4eCwgZG9tYWluLT5iaXRzLnB4eCk7DQo+IC0JLyoNCj4gLQkg KiBBcyBwZXIgIjUuNS45LjQgRXhhbXBsZSBDb2RlIDQiIGluIElNWDdEUk0ucGRmIHdhaXQNCj4g LQkgKiBmb3IgUFVQX1JFUS9QRE5fUkVRIGJpdCB0byBiZSBjbGVhcmVkDQo+IC0JICovDQo+IC0J cmV0ID0gcmVnbWFwX3JlYWRfcG9sbF90aW1lb3V0KGRvbWFpbi0+cmVnbWFwLA0KPiBHUENfUFVf UEdDX1NXX1BETl9SRVEsDQo+IC0JCQkJICAgICAgIHJlZ192YWwsICEocmVnX3ZhbCAmIGRvbWFp bi0+Yml0cy5weHgpLA0KPiAtCQkJCSAgICAgICAwLCBVU0VDX1BFUl9NU0VDKTsNCj4gLQlpZiAo cmV0KSB7DQo+IC0JCWRldl9lcnIoZG9tYWluLT5kZXYsICJmYWlsZWQgdG8gY29tbWFuZCBQR0Nc biIpOw0KPiAtCQlnb3RvIG91dF9jbGtfZGlzYWJsZTsNCj4gKwlpZiAoZG9tYWluLT5iaXRzLnB4 eCkgew0KPiArCQkvKiBlbmFibGUgcG93ZXIgY29udHJvbCAqLw0KPiArCQlyZWdtYXBfdXBkYXRl X2JpdHMoZG9tYWluLT5yZWdtYXAsDQo+IEdQQ19QR0NfQ1RSTChkb21haW4tPnBnYyksDQo+ICsJ CQkJICAgR1BDX1BHQ19DVFJMX1BDUiwgR1BDX1BHQ19DVFJMX1BDUik7DQo+ICsNCj4gKwkJLyog cmVxdWVzdCB0aGUgZG9tYWluIHRvIHBvd2VyIGRvd24gKi8NCj4gKwkJcmVnbWFwX3VwZGF0ZV9i aXRzKGRvbWFpbi0+cmVnbWFwLA0KPiBHUENfUFVfUEdDX1NXX1BETl9SRVEsDQo+ICsJCQkJICAg ZG9tYWluLT5iaXRzLnB4eCwgZG9tYWluLT5iaXRzLnB4eCk7DQo+ICsJCS8qDQo+ICsJCSAqIEFz IHBlciAiNS41LjkuNCBFeGFtcGxlIENvZGUgNCIgaW4gSU1YN0RSTS5wZGYgd2FpdA0KPiArCQkg KiBmb3IgUFVQX1JFUS9QRE5fUkVRIGJpdCB0byBiZSBjbGVhcmVkDQo+ICsJCSAqLw0KPiArCQly ZXQgPSByZWdtYXBfcmVhZF9wb2xsX3RpbWVvdXQoZG9tYWluLT5yZWdtYXAsDQo+ICsJCQkJCSAg ICAgICBHUENfUFVfUEdDX1NXX1BETl9SRVEsIHJlZ192YWwsDQo+ICsJCQkJCSAgICAgICAhKHJl Z192YWwgJiBkb21haW4tPmJpdHMucHh4KSwNCj4gKwkJCQkJICAgICAgIDAsIFVTRUNfUEVSX01T RUMpOw0KPiArCQlpZiAocmV0KSB7DQo+ICsJCQlkZXZfZXJyKGRvbWFpbi0+ZGV2LCAiZmFpbGVk IHRvIGNvbW1hbmQgUEdDXG4iKTsNCj4gKwkJCWdvdG8gb3V0X2Nsa19kaXNhYmxlOw0KPiArCQl9 DQo+ICAJfQ0KPiANCj4gIAkvKiBEaXNhYmxlIHJlc2V0IGNsb2NrcyBmb3IgYWxsIGRldmljZXMg aW4gdGhlIGRvbWFpbiAqLyBAQCAtNTgwLDgNCj4gKzU4Niw5IEBAIHN0YXRpYyBpbnQgaW14X3Bn Y19kb21haW5fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gDQo+ICAJcG1f cnVudGltZV9lbmFibGUoZG9tYWluLT5kZXYpOw0KPiANCj4gLQlyZWdtYXBfdXBkYXRlX2JpdHMo ZG9tYWluLT5yZWdtYXAsIEdQQ19QR0NfQ1BVX01BUFBJTkcsDQo+IC0JCQkgICBkb21haW4tPmJp dHMubWFwLCBkb21haW4tPmJpdHMubWFwKTsNCj4gKwlpZiAoZG9tYWluLT5iaXRzLm1hcCkNCj4g KwkJcmVnbWFwX3VwZGF0ZV9iaXRzKGRvbWFpbi0+cmVnbWFwLCBHUENfUEdDX0NQVV9NQVBQSU5H LA0KPiArCQkJCSAgIGRvbWFpbi0+Yml0cy5tYXAsIGRvbWFpbi0+Yml0cy5tYXApOw0KPiANCj4g IAlyZXQgPSBwbV9nZW5wZF9pbml0KCZkb21haW4tPmdlbnBkLCBOVUxMLCB0cnVlKTsNCj4gIAlp ZiAocmV0KSB7DQo+IEBAIC02MDEsOCArNjA4LDkgQEAgc3RhdGljIGludCBpbXhfcGdjX2RvbWFp bl9wcm9iZShzdHJ1Y3QNCj4gcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiAgb3V0X2dlbnBkX3Jl bW92ZToNCj4gIAlwbV9nZW5wZF9yZW1vdmUoJmRvbWFpbi0+Z2VucGQpOw0KPiAgb3V0X2RvbWFp bl91bm1hcDoNCj4gLQlyZWdtYXBfdXBkYXRlX2JpdHMoZG9tYWluLT5yZWdtYXAsIEdQQ19QR0Nf Q1BVX01BUFBJTkcsDQo+IC0JCQkgICBkb21haW4tPmJpdHMubWFwLCAwKTsNCj4gKwlpZiAoZG9t YWluLT5iaXRzLm1hcCkNCj4gKwkJcmVnbWFwX3VwZGF0ZV9iaXRzKGRvbWFpbi0+cmVnbWFwLCBH UENfUEdDX0NQVV9NQVBQSU5HLA0KPiArCQkJCSAgIGRvbWFpbi0+Yml0cy5tYXAsIDApOw0KPiAg CXBtX3J1bnRpbWVfZGlzYWJsZShkb21haW4tPmRldik7DQo+ICAJaW14X3BnY19wdXRfY2xvY2tz KGRvbWFpbik7DQo+IA0KPiBAQCAtNjE2LDggKzYyNCw5IEBAIHN0YXRpYyBpbnQgaW14X3BnY19k b21haW5fcmVtb3ZlKHN0cnVjdA0KPiBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ICAJb2ZfZ2Vu cGRfZGVsX3Byb3ZpZGVyKGRvbWFpbi0+ZGV2LT5vZl9ub2RlKTsNCj4gIAlwbV9nZW5wZF9yZW1v dmUoJmRvbWFpbi0+Z2VucGQpOw0KPiANCj4gLQlyZWdtYXBfdXBkYXRlX2JpdHMoZG9tYWluLT5y ZWdtYXAsIEdQQ19QR0NfQ1BVX01BUFBJTkcsDQo+IC0JCQkgICBkb21haW4tPmJpdHMubWFwLCAw KTsNCj4gKwlpZiAoZG9tYWluLT5iaXRzLm1hcCkNCj4gKwkJcmVnbWFwX3VwZGF0ZV9iaXRzKGRv bWFpbi0+cmVnbWFwLCBHUENfUEdDX0NQVV9NQVBQSU5HLA0KPiArCQkJCSAgIGRvbWFpbi0+Yml0 cy5tYXAsIDApOw0KPiANCj4gIAlwbV9ydW50aW1lX2Rpc2FibGUoZG9tYWluLT5kZXYpOw0KPiAN Cj4gLS0NCj4gMi4yMC4xDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5DCC433E7 for ; Fri, 9 Oct 2020 07:55:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9993F22267 for ; Fri, 9 Oct 2020 07:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JjD0J1cn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="kUz2uK3a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9993F22267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UWZV7gtyN8x/ccxa9ySTQWAtVw6saCENhi5rRHqc6Go=; b=JjD0J1cnCjMFwJRddC57jKlUz JP3T3sxtQWVwELNa3eyyKiJ9XNH8voE+pCak0h3M80qvsyn66U5GLoInScN6VjR606tmPQcksSqyK drUIycrWfpZYK6mXGeo/egoZzCpKztbk4f1z25Ar5nspuO/b0QAtii9NvLQcnBltw/ie2iMKR33K3 T9DlTUqB0Bapzv3DkiPxE5oAvZu22no6I2oCFHkh7g9G90n3ySd5+NK/5EAw5sZ5VayZH4lP+bWRn m0cXZBkzl/7gx0D/3MsR2aT6Tou9rKcxxwWgbqrdPUAvzQd0IFAUEF8Q3lWkw0mM1/RPHTHEYFQ3U mEGHZpzyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnE7-0000AV-5w; Fri, 09 Oct 2020 07:54:07 +0000 Received: from mail-db8eur05on2064.outbound.protection.outlook.com ([40.107.20.64] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnE3-00008O-QG for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 07:54:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kR3Cusb3Txwsr4I1JXVRnJ9FIYmWOKz/Ozly/7dkORgPwbiPqgD3QDfmYdchTevbXEEjLpmcM9mUzfOGqzhJsGlfm/nCmSx+TOOiSE0LJaNqQ6CEE85CGt+dyr0PDmX81gepWHKX1XZkS0aRrs8IV+/1JqPiUA08gHiaR44f/kweD8/ZjKCMgctVD4dT+NgmXQ3H4RH6nstG4EV9QsWbfYuMuA36z9Rrm0UnzAK1MbVZMheW40eIxVL4EZwAgMlAVbNshcY4uFhWlYGL/IxFkN0sGnO+JipS9lYnXwzfBNfSr1thFPEPtLMjPnFNmvk7kBr5sKXy7mowNrbYUlr4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhGLlWU5oyNKkoNCTknMh7NBDkiywTG7alGMuo3AZik=; b=gyUvGe6XpPsdWSYdJuhtYZIWplQKw1mW3MzSpFgc4AAmsGkCkXmYekufmXBomtLYLbySBEBHL1kCq/CiOUevSWnwjrNSoAocsgcYXW4/s/6CQoxURDoeMxiVOWLPviAbOJjNWiFSJNcbcSp/FWL9Ji57kr2u4kS5e6EYg/JkOwR2VYjgRmdU8BJJv4pD9WFCpCJ2DfCO+eMOuVKKxuUZ1+yZuU2iqSCwAHzA98iYJlac2BJ16Fa6DXD/RUr3h06tQ/3RbVZ0CTv4caM37BosPz99gb78hDJ6bPVrezzSPefzz/CYDTA4LncUqZnuiS6ipL08+kQh5lhLSMOBgJL6EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhGLlWU5oyNKkoNCTknMh7NBDkiywTG7alGMuo3AZik=; b=kUz2uK3aWJIaTe9MUaOVtCMMhnd2d8xIlufQ9vQnk1IpuFA4XfoiJW9zTDFmMMOuh1l878PONP4C5CUpsegGtWKBdDMHZNfaViRm6hEEZDpVM+StHyJWSQsn3IimceGjEksEsaKbKdazQrYP0PMHNKaXSkyCD4z4qSQXkr6ecxw= Received: from AM0PR04MB4915.eurprd04.prod.outlook.com (2603:10a6:208:c5::20) by AM8PR04MB7828.eurprd04.prod.outlook.com (2603:10a6:20b:24e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Fri, 9 Oct 2020 07:54:00 +0000 Received: from AM0PR04MB4915.eurprd04.prod.outlook.com ([fe80::8de5:80f:f11a:5fa3]) by AM0PR04MB4915.eurprd04.prod.outlook.com ([fe80::8de5:80f:f11a:5fa3%7]) with mapi id 15.20.3455.024; Fri, 9 Oct 2020 07:54:00 +0000 From: Jacky Bai To: Lucas Stach , Shawn Guo , Rob Herring Subject: RE: [PATCH 06/11] soc: imx: gpcv2: allow domains without power-sequence control Thread-Topic: [PATCH 06/11] soc: imx: gpcv2: allow domains without power-sequence control Thread-Index: AQHWl0Fo+PE1TNISW0yJPYfXXF8E36mO8ZRA Date: Fri, 9 Oct 2020 07:54:00 +0000 Message-ID: References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-7-l.stach@pengutronix.de> In-Reply-To: <20200930155006.535712-7-l.stach@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2f7f8fb4-5ede-4e97-7019-08d86c287bdc x-ms-traffictypediagnostic: AM8PR04MB7828: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b6rPX27BFA+CwvEUZJtyRuiF+w8YKK347Bo1gaOC3cxL4jFY5TC6VSKcPUH6dU3cdKbHo2v2j58Ykpx1wKcrDw4vHNi/F/8DNh1R0XgaJVbVMHCMMoeOE+H33t4/0yVfrbe3LUaZH2ZneAxw63rfpmRY+p09kpFecPMzNRL34MRbqnHJNYcjLa2cNsquORzKy/n8LfjxXIs5vaBeuL4QSoSCqLinLg2D0vxvnKPha5glHb9QJkxwduemKUWpbxtZhdEhKs6rIw4z7MN9Kj3Pi6wjtMmnMRRU7lfuKHjJSf/KmHpoP/VzHjxgr5t2kM0pSaJ0GN5/PcBlTLPLBE6frg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4915.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(9686003)(478600001)(316002)(52536014)(110136005)(76116006)(66946007)(55016002)(54906003)(33656002)(8676002)(8936002)(26005)(71200400001)(4326008)(53546011)(6506007)(66476007)(83380400001)(64756008)(66556008)(86362001)(2906002)(186003)(7416002)(5660300002)(7696005)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: gB7ayDTqK+6w18MnAdG9cB1M+sMpW75mmVkDN4Gh0Yv06ZpImu9kPd16mX++DqJpkvJwf0mNwTPkvKXGwfH1LPclinUNDQLvCSo8Fyi6fJTZPm+oz2b0UL4129p1oqNTq6wDMxhzTzHGJqwyn8EcH/JkxQkK5RWI5esY3eQpcGAZJILoEvp59nWV6KXrgYhyfi6Vt0Z6aszpHXQuCMeDHWbcp6A9dCbLoFCSKgTQm1j1L8YDsKZsvfp3wyZ9PSmRhJ4qAe+eSrf2rBtD8MeYMyht8mQzUE5Ro4yzsGb9IXbSAPOiGjSP1mh4evx4tTOEe9KQJTDuY1AzSuBB/uWnS+PI/TLcn7QjKCaiRCDWxrapZt97Kgu3vdiCEF2v7SQ0u/b5B6LcLOw8Ii60DKKARShob4NnIgzUKuoP/XQLZPXNn+5D1Zcd1Nc4OcvJOFGKoVNDK/2/B0yAT9YLvu+K8UpL+D0e/v7VUXOKYT3Q0ZR6bX1i/zxlGqydlWqkZQVkeuA9/W04045pcYuj8i46Ytl9XuslF7K0XO/+tJnX/8wTRQR0hjjgp9asPgf1V50pfKs6oMe5f6leXB2k+SNDS/zyEcb++OsWexNDKndtmdKfsAB7zyv9ex378R3D5iu+Hkj0uLJzgYmPzpYaPWqQKA== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4915.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7f8fb4-5ede-4e97-7019-08d86c287bdc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 07:54:00.4031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JX4ip/z0ZAV56MxLdETQSsaKgq7HBAH4JY+P4AopsMfdh700/YpjDEejivWwVLa0epJj3Xe2wGPnHK3TzIC0cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7828 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_035403_861573_0FC54BC0 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , "devicetree@vger.kernel.org" , Frieder Schrempf , "patchwork-lst@pengutronix.de" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Lucas Stach [mailto:l.stach@pengutronix.de] > Sent: Wednesday, September 30, 2020 11:50 PM > To: Shawn Guo ; Rob Herring > Cc: dl-linux-imx ; Fabio Estevam > ; Frieder Schrempf ; > Marek Vasut ; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; kernel@pengutronix.de; > patchwork-lst@pengutronix.de > Subject: [PATCH 06/11] soc: imx: gpcv2: allow domains without > power-sequence control > > Some of the PGC domains only control the handshake with the ADB400 and > don't have any power sequence controls. Make such domains work by > allowing the pxx and map bits to be empty and skip all actions using those > controls. > > Signed-off-by: Lucas Stach > --- > drivers/soc/imx/gpcv2.c | 89 +++++++++++++++++++++++------------------ > 1 file changed, 49 insertions(+), 40 deletions(-) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index > 5bb7b1cc7c10..db93fef0c76b 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -167,24 +167,27 @@ static int imx_pgc_power_up(struct > generic_pm_domain *genpd) > } > } > > - /* request the domain to power up */ > - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, > - domain->bits.pxx, domain->bits.pxx); > - /* > - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait > - * for PUP_REQ/PDN_REQ bit to be cleared > - */ > - ret = regmap_read_poll_timeout(domain->regmap, > GPC_PU_PGC_SW_PUP_REQ, > - reg_val, !(reg_val & domain->bits.pxx), > - 0, USEC_PER_MSEC); > - if (ret) { > - dev_err(domain->dev, "failed to command PGC\n"); > - goto out_clk_disable; > - } > + if (domain->bits.pxx) { What if the power domain's PUP/PDN control bit define is zero, for example, IMX8M_MIPI_SW_Pxx_REQ? BR Jacky Bai > + /* request the domain to power up */ > + regmap_update_bits(domain->regmap, > GPC_PU_PGC_SW_PUP_REQ, > + domain->bits.pxx, domain->bits.pxx); > + /* > + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait > + * for PUP_REQ/PDN_REQ bit to be cleared > + */ > + ret = regmap_read_poll_timeout(domain->regmap, > + GPC_PU_PGC_SW_PUP_REQ, reg_val, > + !(reg_val & domain->bits.pxx), > + 0, USEC_PER_MSEC); > + if (ret) { > + dev_err(domain->dev, "failed to command PGC\n"); > + goto out_clk_disable; > + } > > - /* disable power control */ > - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), > - GPC_PGC_CTRL_PCR, 0); > + /* disable power control */ > + regmap_update_bits(domain->regmap, > GPC_PGC_CTRL(domain->pgc), > + GPC_PGC_CTRL_PCR, 0); > + } > > /* request the ADB400 to power up */ > if (domain->bits.hskreq) { > @@ -248,23 +251,26 @@ static int imx_pgc_power_down(struct > generic_pm_domain *genpd) > } > } > > - /* enable power control */ > - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), > - GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); > - > - /* request the domain to power down */ > - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, > - domain->bits.pxx, domain->bits.pxx); > - /* > - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait > - * for PUP_REQ/PDN_REQ bit to be cleared > - */ > - ret = regmap_read_poll_timeout(domain->regmap, > GPC_PU_PGC_SW_PDN_REQ, > - reg_val, !(reg_val & domain->bits.pxx), > - 0, USEC_PER_MSEC); > - if (ret) { > - dev_err(domain->dev, "failed to command PGC\n"); > - goto out_clk_disable; > + if (domain->bits.pxx) { > + /* enable power control */ > + regmap_update_bits(domain->regmap, > GPC_PGC_CTRL(domain->pgc), > + GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); > + > + /* request the domain to power down */ > + regmap_update_bits(domain->regmap, > GPC_PU_PGC_SW_PDN_REQ, > + domain->bits.pxx, domain->bits.pxx); > + /* > + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait > + * for PUP_REQ/PDN_REQ bit to be cleared > + */ > + ret = regmap_read_poll_timeout(domain->regmap, > + GPC_PU_PGC_SW_PDN_REQ, reg_val, > + !(reg_val & domain->bits.pxx), > + 0, USEC_PER_MSEC); > + if (ret) { > + dev_err(domain->dev, "failed to command PGC\n"); > + goto out_clk_disable; > + } > } > > /* Disable reset clocks for all devices in the domain */ @@ -580,8 > +586,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > > pm_runtime_enable(domain->dev); > > - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > - domain->bits.map, domain->bits.map); > + if (domain->bits.map) > + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > + domain->bits.map, domain->bits.map); > > ret = pm_genpd_init(&domain->genpd, NULL, true); > if (ret) { > @@ -601,8 +608,9 @@ static int imx_pgc_domain_probe(struct > platform_device *pdev) > out_genpd_remove: > pm_genpd_remove(&domain->genpd); > out_domain_unmap: > - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > - domain->bits.map, 0); > + if (domain->bits.map) > + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > + domain->bits.map, 0); > pm_runtime_disable(domain->dev); > imx_pgc_put_clocks(domain); > > @@ -616,8 +624,9 @@ static int imx_pgc_domain_remove(struct > platform_device *pdev) > of_genpd_del_provider(domain->dev->of_node); > pm_genpd_remove(&domain->genpd); > > - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > - domain->bits.map, 0); > + if (domain->bits.map) > + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, > + domain->bits.map, 0); > > pm_runtime_disable(domain->dev); > > -- > 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel