From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound Date: Thu, 14 Mar 2019 09:08:57 +0000 Message-ID: References: <20190310081410.94830-1-shahafs@mellanox.com> <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: Yongseok Koh Return-path: In-Reply-To: <44AC735D-DF85-4883-A612-979D6D6DD59C@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Monday, March 11, 2019 9:58 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound >=20 >=20 > > On Mar 10, 2019, at 12:14 AM, Shahaf Shuler > wrote: > > > > Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE > > starts on the end of the ring and ends on the beginning, is not > > supported and blocked by the data path logic. > > > > However, in case of TSO, an extra inline header is required before > > inlining. This inline header is not taken into account when checking > > if there is enough room left for the required inline size. > > On some corner cases were > > (ring_tailroom - inline header) < inline size < ring_tailroom , this > > can lead to WQE being written outsize of the ring buffer. > > > > Fixing it by always assuming the worse case that inline of packet will > > require the inline header. > > > > Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahaf Shuler > > --- >=20 > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20