From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mordechay Haimovsky <motih@mellanox.com>
Subject: Re: [PATCH v2 1/3] net/mlx5: fix shared counter
	allocation	logic
Date: Wed, 2 Jan 2019 06:58:58 +0000
Message-ID: <AM0PR05MB4435E9A24E81C68602CAD7C7D28C0@AM0PR05MB4435.eurprd05.prod.outlook.com>
References: <1545748697-3385-4-git-send-email-motih@mellanox.com>
 <1545949196-3355-2-git-send-email-motih@mellanox.com>
 <AM4PR05MB3265CC1646D0DA09E6346B77D2B00@AM4PR05MB3265.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "stable@dpdk.org" <stable@dpdk.org>
To: Slava Ovsiienko <viacheslavo@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <AM4PR05MB3265CC1646D0DA09E6346B77D2B00@AM4PR05MB3265.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,
 Every counter that is created (shared or not) is added to the counters lis=
t=20
Therefore every counter destined for  removal (i.e. ref_count =3D=3D 0) sho=
uld also be=20
Removed from this list.

What am I missing ?

Moti

> -----Original Message-----
> From: Slava Ovsiienko
> Sent: Saturday, December 29, 2018 10:13 PM
> To: Mordechay Haimovsky <motih@mellanox.com>; dev@dpdk.org
> Cc: Mordechay Haimovsky <motih@mellanox.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> allocation logic
>=20
> Moti, don't you forget to update flow_verbs_counter_release() ?
> Only shared counters should be removed from the list.
>=20
> WBR,
> Slava
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Mordechay Haimovsky
> > Sent: Friday, December 28, 2018 0:20
> > To: dev@dpdk.org
> > Cc: Mordechay Haimovsky <motih@mellanox.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> > allocation logic
> >
> > This commit fixes the logic for searching and allocating a shared
> > counter in mlx5_flow_verbs.
> > Now only the shared counters in the counters list are checked for a
> > match and not all the counters as before.
> >
> > Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> > ---
> > v2:
> > * Modified commit header
> > ---
> >  drivers/net/mlx5/mlx5_flow_verbs.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c
> > b/drivers/net/mlx5/mlx5_flow_verbs.c
> > index 81ec59d..409e1cd 100644
> > --- a/drivers/net/mlx5/mlx5_flow_verbs.c
> > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c
> > @@ -121,13 +121,13 @@
> >  	struct mlx5_flow_counter *cnt;
> >  	int ret;
> >
> > -	LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > -		if (!cnt->shared || cnt->shared !=3D shared)
> > -			continue;
> > -		if (cnt->id !=3D id)
> > -			continue;
> > -		cnt->ref_cnt++;
> > -		return cnt;
> > +	if (shared) {
> > +		LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > +			if (cnt->shared && cnt->id =3D=3D id) {
> > +				cnt->ref_cnt++;
> > +				return cnt;
> > +			}
> > +		}
> >  	}
> >  	cnt =3D rte_calloc(__func__, 1, sizeof(*cnt), 0);
> >  	if (!cnt) {
> > --
> > 1.8.3.1