All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix dlopen meson build
Date: Thu, 13 Feb 2020 13:56:07 +0000	[thread overview]
Message-ID: <AM0PR05MB670776F2A19CF6335F590D26C21A0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1581337654-7893-1-git-send-email-matan@mellanox.com>

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Monday, February 10, 2020 2:28 PM
> To: dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: [dpdk-dev] [PATCH] common/mlx5: fix dlopen meson build
> 
> The glue shared library name was created by the common class FMT name,
> driver_name_fmt = 'rte_common_@0@', which is not correlated with
> LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'.
> 
> This causes the dynamic linkage of the glue library to fail what
> remained mlx5 drivers outside the PCI driver list.
> 
> The command:
> MLX5_GLUE_PATH=$(pwd)/build-meson/drivers/common/mlx5
> build-meson/app/dpdk-testpmd -n 4  -w 0000:00:05.0 -w 0000:00:06.0 -- -i
> 
> The log:
> common_mlx5: Cannot load glue library:
> /usr/local/lib64/dpdk/pmds-20.0.1-glue/librte_pmd_mlx5_glue.so.20.02.0:
> cannot open shared object file: No such file or directory
> 
> Adjust the shared library name to the LIB_GLUE_BASE definition.
> 
> Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/common/mlx5/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/mlx5/meson.build
> b/drivers/common/mlx5/meson.build
> index 2b70410..9cbd527 100644
> --- a/drivers/common/mlx5/meson.build
> +++ b/drivers/common/mlx5/meson.build
> @@ -185,7 +185,7 @@ endif
>  # Build Glue Library
>  if pmd_dlopen and build
>  	dlopen_name = 'mlx5_glue'
> -	dlopen_lib_name = driver_name_fmt.format(dlopen_name)
> +	dlopen_lib_name = 'rte_pmd_@0@'.format(dlopen_name)
>  	dlopen_so_version = LIB_GLUE_VERSION
>  	dlopen_sources = files('mlx5_glue.c')
>  	dlopen_install_dir = [ eal_pmd_path + '-glue' ]
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-02-13 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 12:27 [dpdk-dev] [PATCH] common/mlx5: fix dlopen meson build Matan Azrad
2020-02-13 13:56 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB670776F2A19CF6335F590D26C21A0@AM0PR05MB6707.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.