All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: Scott Branden <scott.branden@broadcom.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [RFC] checkpatch: don't complain about SPDX tag	format
Date: Thu, 19 Apr 2018 12:42:40 +0000	[thread overview]
Message-ID: <AM2PR04MB075359F718D6A485073C476189B50@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2245312.U4dFV0f5su@xps>


> 18/04/2018 10:56, Bruce Richardson:
> > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote:
> > > 18/04/2018 00:11, Scott Branden:
> > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote:
> > > > > 17/04/2018 23:49, Stephen Hemminger:
> > > > >> IMHO would have been better to use the kernel SPDX style and
> > > > >> keep the check but that appears to be a minority opinion.
> > > > >
> > > > > I think it is better to work on checkpatch itself.
> > > > > When defining our SPDX style, Linux one was not definitive.
> > > > > Do you think we can ask the Linux community to support our SPDX style?
> > > > >
> > > > I think it better to simply follow the Linux community defacto
> > > > style rather than go your own way.
> > >
> > > But our way is better! :)
> > > And it has been decided in the Technical Board.
> > >
> >
> > As a general issue, I think we could do with having our own
> > checkpatch-like script for performing addition DPDK-specific
> > code-checks *after* Linux checkpatch ones. That is, reuse Linux check
> > patch checks as much as possible, but have other checks too.
> 
> +1 to call more scripts in checkpatches.sh.
> We need to find the right language to do code checks.
> Coccinelle looks to be a good candidate for some checks.
> 
> > For example, check for use of strcpy or strncpy (or snprintf with
> > "%s") and suggest replacing with strlcpy. If we did have our own
> > extension script, we could put our own SPDX format check there too.
> >
> > Thoughts, or any volunteers to look into this?
> 
> I am not volunteer to start the work but I would be glad to contribute later.
> 
> Any motivated volunteer?
> 
[Hemant] yes, we need volunteer 😊 

In DPDK we have following requirements
1. Check the SPDX tag on the files.
2. Validate the valid license SPDX tag. (BSD-3 and Dual for all except kernel folder). 

Regards,
Hemant

  parent reply	other threads:[~2018-04-19 12:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 21:49 [RFC] checkpatch: don't complain about SPDX tag format Stephen Hemminger
2018-04-17 22:06 ` Thomas Monjalon
2018-04-17 22:11   ` Scott Branden
2018-04-17 22:19     ` Thomas Monjalon
2018-04-18  8:56       ` Bruce Richardson
2018-04-18 10:49         ` Kuusisaari, Juhamatti
2018-04-18 13:28           ` Bruce Richardson
2018-04-18 13:50         ` Thomas Monjalon
2018-04-18 15:25           ` Wiles, Keith
2018-04-19 12:42           ` Hemant Agrawal [this message]
2018-06-08 19:41 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM2PR04MB075359F718D6A485073C476189B50@AM2PR04MB0753.eurprd04.prod.outlook.com \
    --to=hemant.agrawal@nxp.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=scott.branden@broadcom.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.