From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH 1/2] build: fix kernel compile on cross-build
Date: Thu, 19 Apr 2018 15:46:14 +0000
Message-ID: <AM2PR04MB0753DEEC62764C112BD9D2C989B50@AM2PR04MB0753.eurprd04.prod.outlook.com>
References: <20180418210521.277384-1-bruce.richardson@intel.com>
 <20180418210521.277384-2-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: Bruce Richardson <bruce.richardson@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0049.outbound.protection.outlook.com [104.47.0.49])
 by dpdk.org (Postfix) with ESMTP id 9D87AAAB7
 for <dev@dpdk.org>; Thu, 19 Apr 2018 17:46:15 +0200 (CEST)
In-Reply-To: <20180418210521.277384-2-bruce.richardson@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
>=20
> When cross-compiling, if no kernel_dir was specified, then the kernel mod=
ules
> were still being compiled for the build machine. Fix this by only buildin=
g modules
> on cross-compile when we have a kernel_dir value set.
>=20
> Fixes: a52f4574f798 ("igb_uio: build with meson")
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  meson.build | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/meson.build b/meson.build
> index cc16595cb..9e3b44931 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -26,10 +26,14 @@ subdir('config')
>=20
>  # build libs and drivers
>  subdir('lib')
> -subdir('kernel')
>  subdir('buildtools')
>  subdir('drivers')
>=20
> +# build kernel modules if we have a kernel path, or we are not cross
> +compiling if get_option('kernel_dir') !=3D '' or not meson.is_cross_buil=
d()
> +	subdir('kernel')
> +endif

[Hemant] actually kernel_dir may not be always available on host.
 So unless kernel_dir is available - irrespective of host/cross - it=20
 shall not try kernel compilation.=20

> +
>  # build binaries and installable tools
>  subdir('usertools')
>  subdir('app')
> --
> 2.14.3