* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-26 10:27 ` Bhaskar Upadhaya
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar Upadhaya @ 2016-08-26 10:27 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: stuart.yoder-3arQi8VN3Tc, oss-fOR+EgIDQEHk1uMJSBkQmQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ, Bhaskar Upadhaya,
Prabhakar Kushwaha, Pratiyush Mohan Srivastava
Add the device tree support for FSL LS1012A SoC.
Following levels of DTSI/DTS files have been created for the LS1012A
SoC family:
- fsl-ls1012a.dtsi:
DTS-Include file for FSL LS1012A SoC.
- fsl-ls1012a-frdm.dts:
DTS file for FSL LS1012A FRDM board.
- fsl-ls1012a-qds.dts:
DTS file for FSL LS1012A QDS board.
- fsl-ls1012a-rdb.dts:
DTS file for FSL LS1012A RDB board.
Changes vs version1:
- Consistent Licensing for dts files
- Removed the PFE node
- Update reset node with reboot node
- Update clocks property in codec node
- Update regulators node
- Update timer node
- Update compatible property of clockgen with "fsl,ls1012a-clockgen" only
- Update compatible property of scfg with "fsl,ls1012a-scfg" only
- Update compatible property with proper ordering in tmu node
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava-3arQi8VN3Tc@public.gmane.org>
Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/Makefile | 3 +
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480 +++++++++++++++++++++
5 files changed, 892 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 1b7783d..3503c46 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -1,3 +1,6 @@
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
new file mode 100644
index 0000000..dc6df47
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
@@ -0,0 +1,150 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A Freedom Board";
+ compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+
+ sys_mclk: clock-mclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
+ regulators {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg_1p8v: regulator@0 {
+ compatible = "regulator-fixed";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ reg = <0>;
+ regulator-name = "1P8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "Speaker Ext",
+ "Line", "Line In Jack";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "Microphone Jack", "Mic Bias",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "Speaker Ext", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai2>;
+ frame-master;
+ bitclock-master;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&codec>;
+ frame-master;
+ bitclock-master;
+ system-clock-frequency = <25000000>;
+ };
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+ fsl,ddr-sampling-point = <4>;
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+
+ codec: sgtl5000@a {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ VDDA-supply = <®_1p8v>;
+ VDDIO-supply = <®_1p8v>;
+ clocks = <&sys_mclk>;
+ };
+};
+
+&duart0 {
+ status = "okay";
+};
+
+&esdhc0 {
+ status = "disabled";
+};
+
+&esdhc1 {
+ status = "disabled";
+};
+
+&sai2 {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
new file mode 100644
index 0000000..382d070
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
@@ -0,0 +1,180 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A QDS Board";
+ compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+
+ sys_mclk: clock-mclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <24576000>;
+ };
+
+ regulators {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg_3p3v: regulator@0 {
+ compatible = "regulator-fixed";
+ reg = <0x0>;
+ regulator-name = "3P3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "Speaker Ext",
+ "Line", "Line In Jack";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "Microphone Jack", "Mic Bias",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "Speaker Ext", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai2>;
+ frame-master;
+ bitclock-master;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&codec>;
+ frame-master;
+ bitclock-master;
+ system-clock-frequency = <24576000>;
+ };
+ };
+};
+
+&dspi0 {
+ bus-num = <0>;
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
+ reg = <0>;
+ spi-max-frequency = <10000000>; /* input clock */
+ };
+
+ flash@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
+ reg = <1>;
+ spi-max-frequency = <35000000>; /* input clock */
+ };
+
+ flash@2 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
+ reg = <2>;
+ spi-max-frequency = <35000000>; /* input clock */
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+ pca9547@77 {
+ compatible = "nxp,pca9547";
+ reg = <0x77>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c@4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x4>;
+
+ codec: sgtl5000@a {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ VDDA-supply = <®_3p3v>;
+ VDDIO-supply = <®_3p3v>;
+ clocks = <&sys_mclk>;
+ };
+ };
+ };
+};
+
+&duart0 {
+ status = "okay";
+};
+
+&sai2 {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
new file mode 100644
index 0000000..b609032
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
@@ -0,0 +1,79 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A RDB Board";
+ compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+ fsl,ddr-sampling-point = <4>;
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&duart0 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
new file mode 100644
index 0000000..80fe028
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -0,0 +1,480 @@
+/*
+ * Device Tree Include file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+ compatible = "fsl,ls1012a";
+ interrupt-parent = <&gic>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu0: cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a53";
+ reg = <0x0 0x0>;
+ clocks = <&clockgen 1 0>;
+ #cooling-cells = <2>;
+ };
+ };
+
+ sysclk: sysclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "sysclk";
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <1 13 0x1>, /* Physical Secure PPI */
+ <1 14 0x1>, /* Physical Non-Secure PPI */
+ <1 11 0x1>, /* Virtual PPI */
+ <1 10 0x1>; /* Hypervisor PPI */
+ };
+
+ pmu {
+ compatible = "arm,armv8-pmuv3";
+ interrupts = <0 106 0x4>;
+ };
+
+ gic: interrupt-controller@1400000 {
+ compatible = "arm,gic-400";
+ #interrupt-cells = <3>;
+ interrupt-controller;
+ reg = <0x0 0x1401000 0 0x1000>, /* GICD */
+ <0x0 0x1402000 0 0x2000>, /* GICC */
+ <0x0 0x1404000 0 0x2000>, /* GICH */
+ <0x0 0x1406000 0 0x2000>; /* GICV */
+ interrupts = <1 9 0xf08>;
+ };
+
+ soc {
+ compatible = "simple-bus";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ clockgen: clocking@1ee1000 {
+ compatible = "fsl,ls1012a-clockgen";
+ reg = <0x0 0x1ee1000 0x0 0x1000>;
+ #clock-cells = <2>;
+ clocks = <&sysclk>;
+ };
+
+ scfg: scfg@1570000 {
+ compatible = "fsl,ls1012a-scfg", "syscon";
+ reg = <0x0 0x1570000 0x0 0x10000>;
+ big-endian;
+ };
+
+ dcfg: dcfg@1ee0000 {
+ compatible = "fsl,ls1012a-dcfg",
+ "fsl,ls1043a-dcfg",
+ "syscon";
+ reg = <0x0 0x1ee0000 0x0 0x10000>;
+ big-endian;
+ };
+
+ crypto: crypto@1700000 {
+ compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
+ "fsl,sec-v4.0";
+ fsl,sec-era = <8>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x00 0x1700000 0x100000>;
+ reg = <0x00 0x1700000 0x0 0x100000>;
+ interrupts = <0 75 0x4>;
+
+ sec_jr0: jr@10000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x10000 0x10000>;
+ interrupts = <0 71 0x4>;
+ };
+
+ sec_jr1: jr@20000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x20000 0x10000>;
+ interrupts = <0 72 0x4>;
+ };
+
+ sec_jr2: jr@30000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x30000 0x10000>;
+ interrupts = <0 73 0x4>;
+ };
+
+ sec_jr3: jr@40000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x40000 0x10000>;
+ interrupts = <0 74 0x4>;
+ };
+ };
+
+ reboot {
+ compatible ="syscon-reboot";
+ regmap = <&dcfg>;
+ offset = <0xb0>;
+ mask = <0x02>;
+ };
+
+ rcpm: rcpm@1ee2000 {
+ compatible = "fsl,ls1012a-rcpm";
+ reg = <0x0 0x1ee2000 0x0 0x10000>;
+ };
+
+ esdhc0: esdhc@1560000 {
+ compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
+ reg = <0x0 0x1560000 0x0 0x10000>;
+ interrupts = <0 62 0x4>;
+ clock-frequency = <0>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ big-endian;
+ bus-width = <4>;
+ };
+
+ esdhc1: esdhc@1580000 {
+ compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
+ reg = <0x0 0x1580000 0x0 0x10000>;
+ interrupts = <0 65 0x4>;
+ clock-frequency = <0>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ big-endian;
+ bus-width = <4>;
+ };
+
+ dspi0: dspi@2100000 {
+ compatible = "fsl,ls1012a-dspi",
+ "fsl,ls1043a-dspi",
+ "fsl,ls1021a-v1.0-dspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2100000 0x0 0x10000>;
+ interrupts = <0 64 0x4>;
+ clock-names = "dspi";
+ clocks = <&clockgen 4 0>;
+ spi-num-chipselects = <5>;
+ big-endian;
+ status = "enabled";
+ };
+
+ qspi: quadspi@1550000 {
+ compatible = "fsl,ls1012a-qspi",
+ "fsl,ls1043a-qspi",
+ "fsl,ls1021a-qspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x1550000 0x0 0x10000>,
+ <0x0 0x40000000 0x0 0x4000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <0 99 0x4>;
+ clock-names = "qspi_en", "qspi";
+ clocks = <&clockgen 4 0>, <&clockgen 4 0>;
+ big-endian;
+ amba-base = <0x42000000>;
+ };
+
+ tmu: tmu@1f00000 {
+ compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
+ reg = <0x0 0x1f00000 0x0 0x10000>;
+ interrupts = <0 33 0x4>;
+ fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
+ fsl,tmu-calibration = <0x00000000 0x00000026
+ 0x00000001 0x0000002d
+ 0x00000002 0x00000032
+ 0x00000003 0x00000039
+ 0x00000004 0x0000003f
+ 0x00000005 0x00000046
+ 0x00000006 0x0000004d
+ 0x00000007 0x00000054
+ 0x00000008 0x0000005a
+ 0x00000009 0x00000061
+ 0x0000000a 0x0000006a
+ 0x0000000b 0x00000071
+
+ 0x00010000 0x00000025
+ 0x00010001 0x0000002c
+ 0x00010002 0x00000035
+ 0x00010003 0x0000003d
+ 0x00010004 0x00000045
+ 0x00010005 0x0000004e
+ 0x00010006 0x00000057
+ 0x00010007 0x00000061
+ 0x00010008 0x0000006b
+ 0x00010009 0x00000076
+
+ 0x00020000 0x00000029
+ 0x00020001 0x00000033
+ 0x00020002 0x0000003d
+ 0x00020003 0x00000049
+ 0x00020004 0x00000056
+ 0x00020005 0x00000061
+ 0x00020006 0x0000006d
+
+ 0x00030000 0x00000021
+ 0x00030001 0x0000002a
+ 0x00030002 0x0000003c
+ 0x00030003 0x0000004e>;
+ big-endian;
+ #thermal-sensor-cells = <1>;
+ };
+
+ thermal-zones {
+ cpu_thermal: cpu-thermal {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+
+ thermal-sensors = <&tmu 0>;
+
+ trips {
+ cpu_alert: cpu-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit: cpu-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert>;
+ cooling-device =
+ <&cpu0 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
+ };
+ };
+ };
+ };
+
+ i2c0: i2c@2180000 {
+ compatible = "fsl,vf610-i2c";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2180000 0x0 0x10000>;
+ interrupts = <0 56 0x4>;
+ clock-names = "i2c";
+ clocks = <&clockgen 4 0>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@2190000 {
+ compatible = "fsl,vf610-i2c";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2190000 0x0 0x10000>;
+ interrupts = <0 57 0x4>;
+ clock-names = "i2c";
+ clocks = <&clockgen 4 0>;
+ status = "disabled";
+ };
+
+
+ duart0: serial@21c0500 {
+ compatible = "fsl,ns16550", "ns16550a";
+ reg = <0x00 0x21c0500 0x0 0x100>;
+ interrupts = <0 54 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ duart1: serial@21c0600 {
+ compatible = "fsl,ns16550", "ns16550a";
+ reg = <0x00 0x21c0600 0x0 0x100>;
+ interrupts = <0 54 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ gpio0: gpio@2300000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x0 0x2300000 0x0 0x10000>;
+ interrupts = <0 66 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpio1: gpio@2310000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x0 0x2310000 0x0 0x10000>;
+ interrupts = <0 67 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ wdog0: wdog@2ad0000 {
+ compatible = "fsl,ls1012a-wdt",
+ "fsl,ls1043a-wdt",
+ "fsl,imx21-wdt";
+ reg = <0x0 0x2ad0000 0x0 0x10000>;
+ interrupts = <0 83 0x4>;
+ clocks = <&clockgen 4 0>;
+ clock-names = "wdog";
+ big-endian;
+ };
+
+ sai1: sai@2b50000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0x2b50000 0x0 0x10000>;
+ interrupts = <0 148 0x4>;
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>,
+ <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 47>,
+ <&edma0 1 46>;
+ status = "disabled";
+ };
+
+ sai2: sai@2b60000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0x2b60000 0x0 0x10000>;
+ interrupts = <0 149 0x4>;
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>,
+ <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 45>,
+ <&edma0 1 44>;
+ status = "disabled";
+ };
+
+ edma0: edma@2c00000 {
+ #dma-cells = <2>;
+ compatible = "fsl,vf610-edma";
+ reg = <0x0 0x2c00000 0x0 0x10000>,
+ <0x0 0x2c10000 0x0 0x10000>,
+ <0x0 0x2c20000 0x0 0x10000>;
+ interrupts = <0 103 0x4>,
+ <0 103 0x4>;
+ interrupt-names = "edma-tx", "edma-err";
+ dma-channels = <32>;
+ big-endian;
+ clock-names = "dmamux0", "dmamux1";
+ clocks = <&clockgen 4 3>,
+ <&clockgen 4 3>;
+ };
+
+ sata: sata@3200000 {
+ compatible = "fsl,ls1012a-ahci";
+ reg = <0x0 0x3200000 0x0 0x10000>;
+ interrupts = <0 69 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ msi2: msi-controller2@1572000 {
+ compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
+ reg = <0x0 0x1572000 0x0 0x4>,
+ <0x0 0x1572004 0x0 0x4>;
+ reg-names = "msiir", "msir";
+ msi-controller;
+ interrupts = <0 126 0x4>;
+ };
+
+ usb@8600000 {
+ compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
+ reg = <0x0 0x8600000 0x0 0x1000>;
+ interrupts = <0 139 0x4>;
+ dr_mode = "host";
+ phy_type = "ulpi";
+ fsl,usb-erratum-a005697;
+ };
+
+ usb0: usb3@2f00000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x2f00000 0x0 0x10000>;
+ interrupts = <0 60 0x4>;
+ dr_mode = "host";
+ configure-gfladj;
+ snps,dis_rxdet_inp3_quirk;
+ };
+
+ pcie@3400000 {
+ compatible = "fsl,ls1012a-pcie",
+ "fsl,ls1043a-pcie",
+ "snps,dw-pcie";
+ reg = <0x00 0x03400000 0x0 0x00100000 /* controller registers */
+ 0x40 0x00000000 0x0 0x00002000>; /* configuration space */
+ reg-names = "regs", "config";
+ interrupts = <0 118 0x4>, /* controller interrupt */
+ <0 117 0x4>; /* PME interrupt */
+ interrupt-names = "intr", "pme";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ device_type = "pci";
+ num-lanes = <4>;
+ bus-range = <0x0 0xff>;
+ ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
+ 0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
+ msi-parent = <&msi2>;
+ #interrupt-cells = <1>;
+ interrupt-map-mask = <0 0 0 7>;
+ interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
+ <0000 0 0 2 &gic 0 111 0x4>,
+ <0000 0 0 3 &gic 0 112 0x4>,
+ <0000 0 0 4 &gic 0 113 0x4>;
+ };
+ };
+};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-26 10:27 ` Bhaskar Upadhaya
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar Upadhaya @ 2016-08-26 10:27 UTC (permalink / raw)
To: linux-arm-kernel
Add the device tree support for FSL LS1012A SoC.
Following levels of DTSI/DTS files have been created for the LS1012A
SoC family:
- fsl-ls1012a.dtsi:
DTS-Include file for FSL LS1012A SoC.
- fsl-ls1012a-frdm.dts:
DTS file for FSL LS1012A FRDM board.
- fsl-ls1012a-qds.dts:
DTS file for FSL LS1012A QDS board.
- fsl-ls1012a-rdb.dts:
DTS file for FSL LS1012A RDB board.
Changes vs version1:
- Consistent Licensing for dts files
- Removed the PFE node
- Update reset node with reboot node
- Update clocks property in codec node
- Update regulators node
- Update timer node
- Update compatible property of clockgen with "fsl,ls1012a-clockgen" only
- Update compatible property of scfg with "fsl,ls1012a-scfg" only
- Update compatible property with proper ordering in tmu node
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
---
arch/arm64/boot/dts/freescale/Makefile | 3 +
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480 +++++++++++++++++++++
5 files changed, 892 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 1b7783d..3503c46 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -1,3 +1,6 @@
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
new file mode 100644
index 0000000..dc6df47
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
@@ -0,0 +1,150 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A Freedom Board";
+ compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+
+ sys_mclk: clock-mclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
+ regulators {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg_1p8v: regulator at 0 {
+ compatible = "regulator-fixed";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ reg = <0>;
+ regulator-name = "1P8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "Speaker Ext",
+ "Line", "Line In Jack";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "Microphone Jack", "Mic Bias",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "Speaker Ext", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai2>;
+ frame-master;
+ bitclock-master;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&codec>;
+ frame-master;
+ bitclock-master;
+ system-clock-frequency = <25000000>;
+ };
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+ fsl,ddr-sampling-point = <4>;
+
+ qflash0: s25fs512s at 0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+
+ codec: sgtl5000 at a {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ VDDA-supply = <®_1p8v>;
+ VDDIO-supply = <®_1p8v>;
+ clocks = <&sys_mclk>;
+ };
+};
+
+&duart0 {
+ status = "okay";
+};
+
+&esdhc0 {
+ status = "disabled";
+};
+
+&esdhc1 {
+ status = "disabled";
+};
+
+&sai2 {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
new file mode 100644
index 0000000..382d070
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
@@ -0,0 +1,180 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A QDS Board";
+ compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+
+ sys_mclk: clock-mclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <24576000>;
+ };
+
+ regulators {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg_3p3v: regulator at 0 {
+ compatible = "regulator-fixed";
+ reg = <0x0>;
+ regulator-name = "3P3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "Speaker Ext",
+ "Line", "Line In Jack";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "Microphone Jack", "Mic Bias",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "Speaker Ext", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&sai2>;
+ frame-master;
+ bitclock-master;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&codec>;
+ frame-master;
+ bitclock-master;
+ system-clock-frequency = <24576000>;
+ };
+ };
+};
+
+&dspi0 {
+ bus-num = <0>;
+ status = "okay";
+
+ flash at 0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
+ reg = <0>;
+ spi-max-frequency = <10000000>; /* input clock */
+ };
+
+ flash at 1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
+ reg = <1>;
+ spi-max-frequency = <35000000>; /* input clock */
+ };
+
+ flash at 2 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
+ reg = <2>;
+ spi-max-frequency = <35000000>; /* input clock */
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+
+ qflash0: s25fs512s at 0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+ pca9547 at 77 {
+ compatible = "nxp,pca9547";
+ reg = <0x77>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c at 4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x4>;
+
+ codec: sgtl5000 at a {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ VDDA-supply = <®_3p3v>;
+ VDDIO-supply = <®_3p3v>;
+ clocks = <&sys_mclk>;
+ };
+ };
+ };
+};
+
+&duart0 {
+ status = "okay";
+};
+
+&sai2 {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
new file mode 100644
index 0000000..b609032
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
@@ -0,0 +1,79 @@
+/*
+ * Device Tree file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+/dts-v1/;
+
+#include "fsl-ls1012a.dtsi"
+
+/ {
+ model = "LS1012A RDB Board";
+ compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
+
+ aliases {
+ crypto = &crypto;
+ };
+};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "disabled";
+ fsl,ddr-sampling-point = <4>;
+
+ qflash0: s25fs512s at 0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+};
+
+&duart0 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
new file mode 100644
index 0000000..80fe028
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -0,0 +1,480 @@
+/*
+ * Device Tree Include file for Freescale Layerscape-1012A family SoC.
+ *
+ * Copyright 2016, Freescale Semiconductor
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPLv2 or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ * a) This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ * b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+ compatible = "fsl,ls1012a";
+ interrupt-parent = <&gic>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu0: cpu at 0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a53";
+ reg = <0x0 0x0>;
+ clocks = <&clockgen 1 0>;
+ #cooling-cells = <2>;
+ };
+ };
+
+ sysclk: sysclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "sysclk";
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <1 13 0x1>, /* Physical Secure PPI */
+ <1 14 0x1>, /* Physical Non-Secure PPI */
+ <1 11 0x1>, /* Virtual PPI */
+ <1 10 0x1>; /* Hypervisor PPI */
+ };
+
+ pmu {
+ compatible = "arm,armv8-pmuv3";
+ interrupts = <0 106 0x4>;
+ };
+
+ gic: interrupt-controller at 1400000 {
+ compatible = "arm,gic-400";
+ #interrupt-cells = <3>;
+ interrupt-controller;
+ reg = <0x0 0x1401000 0 0x1000>, /* GICD */
+ <0x0 0x1402000 0 0x2000>, /* GICC */
+ <0x0 0x1404000 0 0x2000>, /* GICH */
+ <0x0 0x1406000 0 0x2000>; /* GICV */
+ interrupts = <1 9 0xf08>;
+ };
+
+ soc {
+ compatible = "simple-bus";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ clockgen: clocking at 1ee1000 {
+ compatible = "fsl,ls1012a-clockgen";
+ reg = <0x0 0x1ee1000 0x0 0x1000>;
+ #clock-cells = <2>;
+ clocks = <&sysclk>;
+ };
+
+ scfg: scfg at 1570000 {
+ compatible = "fsl,ls1012a-scfg", "syscon";
+ reg = <0x0 0x1570000 0x0 0x10000>;
+ big-endian;
+ };
+
+ dcfg: dcfg at 1ee0000 {
+ compatible = "fsl,ls1012a-dcfg",
+ "fsl,ls1043a-dcfg",
+ "syscon";
+ reg = <0x0 0x1ee0000 0x0 0x10000>;
+ big-endian;
+ };
+
+ crypto: crypto at 1700000 {
+ compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
+ "fsl,sec-v4.0";
+ fsl,sec-era = <8>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x00 0x1700000 0x100000>;
+ reg = <0x00 0x1700000 0x0 0x100000>;
+ interrupts = <0 75 0x4>;
+
+ sec_jr0: jr at 10000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x10000 0x10000>;
+ interrupts = <0 71 0x4>;
+ };
+
+ sec_jr1: jr at 20000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x20000 0x10000>;
+ interrupts = <0 72 0x4>;
+ };
+
+ sec_jr2: jr at 30000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x30000 0x10000>;
+ interrupts = <0 73 0x4>;
+ };
+
+ sec_jr3: jr at 40000 {
+ compatible = "fsl,sec-v5.4-job-ring",
+ "fsl,sec-v5.0-job-ring",
+ "fsl,sec-v4.0-job-ring";
+ reg = <0x40000 0x10000>;
+ interrupts = <0 74 0x4>;
+ };
+ };
+
+ reboot {
+ compatible ="syscon-reboot";
+ regmap = <&dcfg>;
+ offset = <0xb0>;
+ mask = <0x02>;
+ };
+
+ rcpm: rcpm at 1ee2000 {
+ compatible = "fsl,ls1012a-rcpm";
+ reg = <0x0 0x1ee2000 0x0 0x10000>;
+ };
+
+ esdhc0: esdhc at 1560000 {
+ compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
+ reg = <0x0 0x1560000 0x0 0x10000>;
+ interrupts = <0 62 0x4>;
+ clock-frequency = <0>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ big-endian;
+ bus-width = <4>;
+ };
+
+ esdhc1: esdhc at 1580000 {
+ compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
+ reg = <0x0 0x1580000 0x0 0x10000>;
+ interrupts = <0 65 0x4>;
+ clock-frequency = <0>;
+ voltage-ranges = <1800 1800 3300 3300>;
+ sdhci,auto-cmd12;
+ big-endian;
+ bus-width = <4>;
+ };
+
+ dspi0: dspi at 2100000 {
+ compatible = "fsl,ls1012a-dspi",
+ "fsl,ls1043a-dspi",
+ "fsl,ls1021a-v1.0-dspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2100000 0x0 0x10000>;
+ interrupts = <0 64 0x4>;
+ clock-names = "dspi";
+ clocks = <&clockgen 4 0>;
+ spi-num-chipselects = <5>;
+ big-endian;
+ status = "enabled";
+ };
+
+ qspi: quadspi at 1550000 {
+ compatible = "fsl,ls1012a-qspi",
+ "fsl,ls1043a-qspi",
+ "fsl,ls1021a-qspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x1550000 0x0 0x10000>,
+ <0x0 0x40000000 0x0 0x4000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <0 99 0x4>;
+ clock-names = "qspi_en", "qspi";
+ clocks = <&clockgen 4 0>, <&clockgen 4 0>;
+ big-endian;
+ amba-base = <0x42000000>;
+ };
+
+ tmu: tmu at 1f00000 {
+ compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
+ reg = <0x0 0x1f00000 0x0 0x10000>;
+ interrupts = <0 33 0x4>;
+ fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
+ fsl,tmu-calibration = <0x00000000 0x00000026
+ 0x00000001 0x0000002d
+ 0x00000002 0x00000032
+ 0x00000003 0x00000039
+ 0x00000004 0x0000003f
+ 0x00000005 0x00000046
+ 0x00000006 0x0000004d
+ 0x00000007 0x00000054
+ 0x00000008 0x0000005a
+ 0x00000009 0x00000061
+ 0x0000000a 0x0000006a
+ 0x0000000b 0x00000071
+
+ 0x00010000 0x00000025
+ 0x00010001 0x0000002c
+ 0x00010002 0x00000035
+ 0x00010003 0x0000003d
+ 0x00010004 0x00000045
+ 0x00010005 0x0000004e
+ 0x00010006 0x00000057
+ 0x00010007 0x00000061
+ 0x00010008 0x0000006b
+ 0x00010009 0x00000076
+
+ 0x00020000 0x00000029
+ 0x00020001 0x00000033
+ 0x00020002 0x0000003d
+ 0x00020003 0x00000049
+ 0x00020004 0x00000056
+ 0x00020005 0x00000061
+ 0x00020006 0x0000006d
+
+ 0x00030000 0x00000021
+ 0x00030001 0x0000002a
+ 0x00030002 0x0000003c
+ 0x00030003 0x0000004e>;
+ big-endian;
+ #thermal-sensor-cells = <1>;
+ };
+
+ thermal-zones {
+ cpu_thermal: cpu-thermal {
+ polling-delay-passive = <1000>;
+ polling-delay = <5000>;
+
+ thermal-sensors = <&tmu 0>;
+
+ trips {
+ cpu_alert: cpu-alert {
+ temperature = <85000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ cpu_crit: cpu-crit {
+ temperature = <95000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert>;
+ cooling-device =
+ <&cpu0 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
+ };
+ };
+ };
+ };
+
+ i2c0: i2c at 2180000 {
+ compatible = "fsl,vf610-i2c";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2180000 0x0 0x10000>;
+ interrupts = <0 56 0x4>;
+ clock-names = "i2c";
+ clocks = <&clockgen 4 0>;
+ status = "disabled";
+ };
+
+ i2c1: i2c at 2190000 {
+ compatible = "fsl,vf610-i2c";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2190000 0x0 0x10000>;
+ interrupts = <0 57 0x4>;
+ clock-names = "i2c";
+ clocks = <&clockgen 4 0>;
+ status = "disabled";
+ };
+
+
+ duart0: serial at 21c0500 {
+ compatible = "fsl,ns16550", "ns16550a";
+ reg = <0x00 0x21c0500 0x0 0x100>;
+ interrupts = <0 54 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ duart1: serial at 21c0600 {
+ compatible = "fsl,ns16550", "ns16550a";
+ reg = <0x00 0x21c0600 0x0 0x100>;
+ interrupts = <0 54 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ gpio0: gpio at 2300000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x0 0x2300000 0x0 0x10000>;
+ interrupts = <0 66 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ gpio1: gpio at 2310000 {
+ compatible = "fsl,qoriq-gpio";
+ reg = <0x0 0x2310000 0x0 0x10000>;
+ interrupts = <0 67 0x4>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ wdog0: wdog at 2ad0000 {
+ compatible = "fsl,ls1012a-wdt",
+ "fsl,ls1043a-wdt",
+ "fsl,imx21-wdt";
+ reg = <0x0 0x2ad0000 0x0 0x10000>;
+ interrupts = <0 83 0x4>;
+ clocks = <&clockgen 4 0>;
+ clock-names = "wdog";
+ big-endian;
+ };
+
+ sai1: sai at 2b50000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0x2b50000 0x0 0x10000>;
+ interrupts = <0 148 0x4>;
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>,
+ <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 47>,
+ <&edma0 1 46>;
+ status = "disabled";
+ };
+
+ sai2: sai at 2b60000 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,vf610-sai";
+ reg = <0x0 0x2b60000 0x0 0x10000>;
+ interrupts = <0 149 0x4>;
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>,
+ <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 45>,
+ <&edma0 1 44>;
+ status = "disabled";
+ };
+
+ edma0: edma at 2c00000 {
+ #dma-cells = <2>;
+ compatible = "fsl,vf610-edma";
+ reg = <0x0 0x2c00000 0x0 0x10000>,
+ <0x0 0x2c10000 0x0 0x10000>,
+ <0x0 0x2c20000 0x0 0x10000>;
+ interrupts = <0 103 0x4>,
+ <0 103 0x4>;
+ interrupt-names = "edma-tx", "edma-err";
+ dma-channels = <32>;
+ big-endian;
+ clock-names = "dmamux0", "dmamux1";
+ clocks = <&clockgen 4 3>,
+ <&clockgen 4 3>;
+ };
+
+ sata: sata at 3200000 {
+ compatible = "fsl,ls1012a-ahci";
+ reg = <0x0 0x3200000 0x0 0x10000>;
+ interrupts = <0 69 0x4>;
+ clocks = <&clockgen 4 0>;
+ };
+
+ msi2: msi-controller2 at 1572000 {
+ compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
+ reg = <0x0 0x1572000 0x0 0x4>,
+ <0x0 0x1572004 0x0 0x4>;
+ reg-names = "msiir", "msir";
+ msi-controller;
+ interrupts = <0 126 0x4>;
+ };
+
+ usb at 8600000 {
+ compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
+ reg = <0x0 0x8600000 0x0 0x1000>;
+ interrupts = <0 139 0x4>;
+ dr_mode = "host";
+ phy_type = "ulpi";
+ fsl,usb-erratum-a005697;
+ };
+
+ usb0: usb3 at 2f00000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x2f00000 0x0 0x10000>;
+ interrupts = <0 60 0x4>;
+ dr_mode = "host";
+ configure-gfladj;
+ snps,dis_rxdet_inp3_quirk;
+ };
+
+ pcie at 3400000 {
+ compatible = "fsl,ls1012a-pcie",
+ "fsl,ls1043a-pcie",
+ "snps,dw-pcie";
+ reg = <0x00 0x03400000 0x0 0x00100000 /* controller registers */
+ 0x40 0x00000000 0x0 0x00002000>; /* configuration space */
+ reg-names = "regs", "config";
+ interrupts = <0 118 0x4>, /* controller interrupt */
+ <0 117 0x4>; /* PME interrupt */
+ interrupt-names = "intr", "pme";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ device_type = "pci";
+ num-lanes = <4>;
+ bus-range = <0x0 0xff>;
+ ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
+ 0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
+ msi-parent = <&msi2>;
+ #interrupt-cells = <1>;
+ interrupt-map-mask = <0 0 0 7>;
+ interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
+ <0000 0 0 2 &gic 0 111 0x4>,
+ <0000 0 0 3 &gic 0 112 0x4>,
+ <0000 0 0 4 &gic 0 113 0x4>;
+ };
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-26 10:27 ` Bhaskar Upadhaya
@ 2016-08-29 9:52 ` Shawn Guo
-1 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-08-29 9:52 UTC (permalink / raw)
To: Bhaskar Upadhaya
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, stuart.yoder-3arQi8VN3Tc,
oss-fOR+EgIDQEHk1uMJSBkQmQ, Prabhakar Kushwaha,
linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ,
Pratiyush Mohan Srivastava,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> Add the device tree support for FSL LS1012A SoC.
> Following levels of DTSI/DTS files have been created for the LS1012A
> SoC family:
>
> - fsl-ls1012a.dtsi:
> DTS-Include file for FSL LS1012A SoC.
>
> - fsl-ls1012a-frdm.dts:
> DTS file for FSL LS1012A FRDM board.
>
> - fsl-ls1012a-qds.dts:
> DTS file for FSL LS1012A QDS board.
>
> - fsl-ls1012a-rdb.dts:
> DTS file for FSL LS1012A RDB board.
>
> Changes vs version1:
> - Consistent Licensing for dts files
> - Removed the PFE node
> - Update reset node with reboot node
> - Update clocks property in codec node
> - Update regulators node
> - Update timer node
> - Update compatible property of clockgen with "fsl,ls1012a-clockgen" only
> - Update compatible property of scfg with "fsl,ls1012a-scfg" only
> - Update compatible property with proper ordering in tmu node
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava-3arQi8VN3Tc@public.gmane.org>
> Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 3 +
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480 +++++++++++++++++++++
> 5 files changed, 892 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 1b7783d..3503c46 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -1,3 +1,6 @@
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
Please try to keep the list sort alphabetically.
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> new file mode 100644
> index 0000000..dc6df47
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> @@ -0,0 +1,150 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A Freedom Board";
> + compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +
> + sys_mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
DT maintainers dislike this fake bus container node. Please get rid of
it by putting fixed regulator node directly under root, in the following
naming schema:
reg_xxx: regulator-xxx {
...
};
> + reg_1p8v: regulator@0 {
> + compatible = "regulator-fixed";
> + #address-cells = <1>;
> + #size-cells = <1>;
Why do you need #address-cells and #size-cells?
> + reg = <0>;
> + regulator-name = "1P8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "Speaker Ext",
> + "Line", "Line In Jack";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "Microphone Jack", "Mic Bias",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "Speaker Ext", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + frame-master;
> + bitclock-master;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + frame-master;
> + bitclock-master;
> + system-clock-frequency = <25000000>;
> + };
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
Why is it being disabled?
> + fsl,ddr-sampling-point = <4>;
I do not find the bindings for this property, neither how driver
supports it.
> +
> + qflash0: s25fs512s@0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + codec: sgtl5000@a {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + VDDA-supply = <®_1p8v>;
> + VDDIO-supply = <®_1p8v>;
> + clocks = <&sys_mclk>;
> + };
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> +
> +&esdhc0 {
> + status = "disabled";
We prefer to disable devices which have board level options by default
in <soc>.dtsi, and enable them per availability in <board>.dts.
> +};
> +
> +&esdhc1 {
> + status = "disabled";
> +};
> +
> +&sai2 {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> new file mode 100644
> index 0000000..382d070
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -0,0 +1,180 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A QDS Board";
> + compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +
> + sys_mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24576000>;
> + };
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg_3p3v: regulator@0 {
> + compatible = "regulator-fixed";
> + reg = <0x0>;
> + regulator-name = "3P3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "Speaker Ext",
> + "Line", "Line In Jack";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "Microphone Jack", "Mic Bias",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "Speaker Ext", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + frame-master;
> + bitclock-master;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + frame-master;
> + bitclock-master;
> + system-clock-frequency = <24576000>;
> + };
> + };
> +};
> +
> +&dspi0 {
> + bus-num = <0>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
> + reg = <0>;
> + spi-max-frequency = <10000000>; /* input clock */
> + };
> +
> + flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
> + reg = <1>;
> + spi-max-frequency = <35000000>; /* input clock */
> + };
> +
> + flash@2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
> + reg = <2>;
> + spi-max-frequency = <35000000>; /* input clock */
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
> +
> + qflash0: s25fs512s@0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
Please have a newline between property list and sub-node.
> + pca9547@77 {
> + compatible = "nxp,pca9547";
> + reg = <0x77>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@4 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x4>;
> +
> + codec: sgtl5000@a {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + VDDA-supply = <®_3p3v>;
> + VDDIO-supply = <®_3p3v>;
> + clocks = <&sys_mclk>;
> + };
> + };
> + };
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> +
> +&sai2 {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> new file mode 100644
> index 0000000..b609032
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -0,0 +1,79 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A RDB Board";
> + compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
> + fsl,ddr-sampling-point = <4>;
> +
> + qflash0: s25fs512s@0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> new file mode 100644
> index 0000000..80fe028
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -0,0 +1,480 @@
> +/*
> + * Device Tree Include file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include <dt-bindings/thermal/thermal.h>
> +
> +/ {
> + compatible = "fsl,ls1012a";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x0 0x0>;
This doesn't match the #address-cells property of 'cpus' node.
> + clocks = <&clockgen 1 0>;
> + #cooling-cells = <2>;
> + };
> + };
> +
> + sysclk: sysclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "sysclk";
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <1 13 0x1>, /* Physical Secure PPI */
> + <1 14 0x1>, /* Physical Non-Secure PPI */
> + <1 11 0x1>, /* Virtual PPI */
> + <1 10 0x1>; /* Hypervisor PPI */
Can we use the constant defined in
dt-bindings/interrupt-controller/irq.h to make them a bit more readable?
> + };
> +
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <0 106 0x4>;
> + };
> +
> + gic: interrupt-controller@1400000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x0 0x1401000 0 0x1000>, /* GICD */
> + <0x0 0x1402000 0 0x2000>, /* GICC */
> + <0x0 0x1404000 0 0x2000>, /* GICH */
> + <0x0 0x1406000 0 0x2000>; /* GICV */
> + interrupts = <1 9 0xf08>;
> + };
> +
> + soc {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + clockgen: clocking@1ee1000 {
> + compatible = "fsl,ls1012a-clockgen";
The compatible cannot be found in binding docs.
> + reg = <0x0 0x1ee1000 0x0 0x1000>;
> + #clock-cells = <2>;
> + clocks = <&sysclk>;
> + };
> +
> + scfg: scfg@1570000 {
> + compatible = "fsl,ls1012a-scfg", "syscon";
Ditto
> + reg = <0x0 0x1570000 0x0 0x10000>;
> + big-endian;
> + };
> +
> + dcfg: dcfg@1ee0000 {
> + compatible = "fsl,ls1012a-dcfg",
> + "fsl,ls1043a-dcfg",
If these compatibles are not documented or used, we can drop them? I
guess we only need "syscon" to get it work?
> + "syscon";
> + reg = <0x0 0x1ee0000 0x0 0x10000>;
> + big-endian;
> + };
> +
> + crypto: crypto@1700000 {
> + compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
> + "fsl,sec-v4.0";
> + fsl,sec-era = <8>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x00 0x1700000 0x100000>;
> + reg = <0x00 0x1700000 0x0 0x100000>;
> + interrupts = <0 75 0x4>;
> +
> + sec_jr0: jr@10000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x10000 0x10000>;
> + interrupts = <0 71 0x4>;
> + };
> +
> + sec_jr1: jr@20000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x20000 0x10000>;
> + interrupts = <0 72 0x4>;
> + };
> +
> + sec_jr2: jr@30000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x30000 0x10000>;
> + interrupts = <0 73 0x4>;
> + };
> +
> + sec_jr3: jr@40000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x40000 0x10000>;
> + interrupts = <0 74 0x4>;
> + };
> + };
> +
> + reboot {
> + compatible ="syscon-reboot";
> + regmap = <&dcfg>;
> + offset = <0xb0>;
> + mask = <0x02>;
> + };
It might make more sense to put it directly under root like what
fsl-ls1043a.dtsi does.
> +
> + rcpm: rcpm@1ee2000 {
> + compatible = "fsl,ls1012a-rcpm";
Undocumented/unsupported bindings?
> + reg = <0x0 0x1ee2000 0x0 0x10000>;
> + };
> +
> + esdhc0: esdhc@1560000 {
> + compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
> + reg = <0x0 0x1560000 0x0 0x10000>;
> + interrupts = <0 62 0x4>;
> + clock-frequency = <0>;
What does a zero of clock-frequency mean?
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + big-endian;
> + bus-width = <4>;
> + };
> +
> + esdhc1: esdhc@1580000 {
> + compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
> + reg = <0x0 0x1580000 0x0 0x10000>;
> + interrupts = <0 65 0x4>;
> + clock-frequency = <0>;
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + big-endian;
> + bus-width = <4>;
> + };
> +
> + dspi0: dspi@2100000 {
> + compatible = "fsl,ls1012a-dspi",
> + "fsl,ls1043a-dspi",
> + "fsl,ls1021a-v1.0-dspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2100000 0x0 0x10000>;
> + interrupts = <0 64 0x4>;
> + clock-names = "dspi";
> + clocks = <&clockgen 4 0>;
> + spi-num-chipselects = <5>;
> + big-endian;
> + status = "enabled";
> + };
> +
> + qspi: quadspi@1550000 {
> + compatible = "fsl,ls1012a-qspi",
> + "fsl,ls1043a-qspi",
> + "fsl,ls1021a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x1550000 0x0 0x10000>,
> + <0x0 0x40000000 0x0 0x4000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <0 99 0x4>;
> + clock-names = "qspi_en", "qspi";
> + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> + big-endian;
> + amba-base = <0x42000000>;
I can not find this property in any bindings doc.
> + };
> +
> + tmu: tmu@1f00000 {
> + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> + reg = <0x0 0x1f00000 0x0 0x10000>;
> + interrupts = <0 33 0x4>;
> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> + fsl,tmu-calibration = <0x00000000 0x00000026
> + 0x00000001 0x0000002d
> + 0x00000002 0x00000032
> + 0x00000003 0x00000039
> + 0x00000004 0x0000003f
> + 0x00000005 0x00000046
> + 0x00000006 0x0000004d
> + 0x00000007 0x00000054
> + 0x00000008 0x0000005a
> + 0x00000009 0x00000061
> + 0x0000000a 0x0000006a
> + 0x0000000b 0x00000071
> +
Drop the newline.
> + 0x00010000 0x00000025
> + 0x00010001 0x0000002c
> + 0x00010002 0x00000035
> + 0x00010003 0x0000003d
> + 0x00010004 0x00000045
> + 0x00010005 0x0000004e
> + 0x00010006 0x00000057
> + 0x00010007 0x00000061
> + 0x00010008 0x0000006b
> + 0x00010009 0x00000076
> +
Ditto
> + 0x00020000 0x00000029
> + 0x00020001 0x00000033
> + 0x00020002 0x0000003d
> + 0x00020003 0x00000049
> + 0x00020004 0x00000056
> + 0x00020005 0x00000061
> + 0x00020006 0x0000006d
> +
Ditto
> + 0x00030000 0x00000021
> + 0x00030001 0x0000002a
> + 0x00030002 0x0000003c
> + 0x00030003 0x0000004e>;
> + big-endian;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> +
Ditto
> + thermal-sensors = <&tmu 0>;
> +
> + trips {
> + cpu_alert: cpu-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
Have a newline between nodes.
> + cpu_crit: cpu-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&cpu_alert>;
> + cooling-device =
> + <&cpu0 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
> + i2c0: i2c@2180000 {
> + compatible = "fsl,vf610-i2c";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2180000 0x0 0x10000>;
> + interrupts = <0 56 0x4>;
> + clock-names = "i2c";
This property is not needed.
> + clocks = <&clockgen 4 0>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@2190000 {
> + compatible = "fsl,vf610-i2c";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2190000 0x0 0x10000>;
> + interrupts = <0 57 0x4>;
> + clock-names = "i2c";
Ditto
> + clocks = <&clockgen 4 0>;
> + status = "disabled";
> + };
> +
> +
> + duart0: serial@21c0500 {
> + compatible = "fsl,ns16550", "ns16550a";
> + reg = <0x00 0x21c0500 0x0 0x100>;
> + interrupts = <0 54 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + duart1: serial@21c0600 {
> + compatible = "fsl,ns16550", "ns16550a";
> + reg = <0x00 0x21c0600 0x0 0x100>;
> + interrupts = <0 54 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + gpio0: gpio@2300000 {
> + compatible = "fsl,qoriq-gpio";
> + reg = <0x0 0x2300000 0x0 0x10000>;
> + interrupts = <0 66 0x4>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + gpio1: gpio@2310000 {
> + compatible = "fsl,qoriq-gpio";
> + reg = <0x0 0x2310000 0x0 0x10000>;
> + interrupts = <0 67 0x4>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + wdog0: wdog@2ad0000 {
> + compatible = "fsl,ls1012a-wdt",
> + "fsl,ls1043a-wdt",
> + "fsl,imx21-wdt";
I understand "fsl,imx21-wdt" is the one that kernel driver matches, but
why do we need "fsl,ls1043a-wdt" here?
> + reg = <0x0 0x2ad0000 0x0 0x10000>;
> + interrupts = <0 83 0x4>;
> + clocks = <&clockgen 4 0>;
> + clock-names = "wdog";
clock-names is not required for fsl,imx21-wdt.
> + big-endian;
> + };
> +
> + sai1: sai@2b50000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0x2b50000 0x0 0x10000>;
> + interrupts = <0 148 0x4>;
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
> + <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 47>,
> + <&edma0 1 46>;
> + status = "disabled";
> + };
> +
> + sai2: sai@2b60000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0x2b60000 0x0 0x10000>;
> + interrupts = <0 149 0x4>;
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
> + <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 45>,
> + <&edma0 1 44>;
> + status = "disabled";
> + };
> +
> + edma0: edma@2c00000 {
> + #dma-cells = <2>;
> + compatible = "fsl,vf610-edma";
> + reg = <0x0 0x2c00000 0x0 0x10000>,
> + <0x0 0x2c10000 0x0 0x10000>,
> + <0x0 0x2c20000 0x0 0x10000>;
> + interrupts = <0 103 0x4>,
> + <0 103 0x4>;
> + interrupt-names = "edma-tx", "edma-err";
> + dma-channels = <32>;
> + big-endian;
> + clock-names = "dmamux0", "dmamux1";
> + clocks = <&clockgen 4 3>,
> + <&clockgen 4 3>;
> + };
> +
> + sata: sata@3200000 {
> + compatible = "fsl,ls1012a-ahci";
> + reg = <0x0 0x3200000 0x0 0x10000>;
> + interrupts = <0 69 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + msi2: msi-controller2@1572000 {
> + compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
> + reg = <0x0 0x1572000 0x0 0x4>,
> + <0x0 0x1572004 0x0 0x4>;
> + reg-names = "msiir", "msir";
> + msi-controller;
> + interrupts = <0 126 0x4>;
> + };
> +
> + usb@8600000 {
> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> + reg = <0x0 0x8600000 0x0 0x1000>;
> + interrupts = <0 139 0x4>;
> + dr_mode = "host";
> + phy_type = "ulpi";
> + fsl,usb-erratum-a005697;
It seems to me that fsl,usb-erratum-a005697 is neither documented or
supported by kernel driver at all.
> + };
> +
> + usb0: usb3@2f00000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x2f00000 0x0 0x10000>;
> + interrupts = <0 60 0x4>;
> + dr_mode = "host";
> + configure-gfladj;
Ditto
Shawn
> + snps,dis_rxdet_inp3_quirk;
> + };
> +
> + pcie@3400000 {
> + compatible = "fsl,ls1012a-pcie",
> + "fsl,ls1043a-pcie",
> + "snps,dw-pcie";
> + reg = <0x00 0x03400000 0x0 0x00100000 /* controller registers */
> + 0x40 0x00000000 0x0 0x00002000>; /* configuration space */
> + reg-names = "regs", "config";
> + interrupts = <0 118 0x4>, /* controller interrupt */
> + <0 117 0x4>; /* PME interrupt */
> + interrupt-names = "intr", "pme";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + num-lanes = <4>;
> + bus-range = <0x0 0xff>;
> + ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
> + 0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> + msi-parent = <&msi2>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
> + <0000 0 0 2 &gic 0 111 0x4>,
> + <0000 0 0 3 &gic 0 112 0x4>,
> + <0000 0 0 4 &gic 0 113 0x4>;
> + };
> + };
> +};
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-29 9:52 ` Shawn Guo
0 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-08-29 9:52 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> Add the device tree support for FSL LS1012A SoC.
> Following levels of DTSI/DTS files have been created for the LS1012A
> SoC family:
>
> - fsl-ls1012a.dtsi:
> DTS-Include file for FSL LS1012A SoC.
>
> - fsl-ls1012a-frdm.dts:
> DTS file for FSL LS1012A FRDM board.
>
> - fsl-ls1012a-qds.dts:
> DTS file for FSL LS1012A QDS board.
>
> - fsl-ls1012a-rdb.dts:
> DTS file for FSL LS1012A RDB board.
>
> Changes vs version1:
> - Consistent Licensing for dts files
> - Removed the PFE node
> - Update reset node with reboot node
> - Update clocks property in codec node
> - Update regulators node
> - Update timer node
> - Update compatible property of clockgen with "fsl,ls1012a-clockgen" only
> - Update compatible property of scfg with "fsl,ls1012a-scfg" only
> - Update compatible property with proper ordering in tmu node
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
> Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 3 +
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480 +++++++++++++++++++++
> 5 files changed, 892 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 1b7783d..3503c46 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -1,3 +1,6 @@
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
Please try to keep the list sort alphabetically.
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> new file mode 100644
> index 0000000..dc6df47
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
> @@ -0,0 +1,150 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A Freedom Board";
> + compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +
> + sys_mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
DT maintainers dislike this fake bus container node. Please get rid of
it by putting fixed regulator node directly under root, in the following
naming schema:
reg_xxx: regulator-xxx {
...
};
> + reg_1p8v: regulator at 0 {
> + compatible = "regulator-fixed";
> + #address-cells = <1>;
> + #size-cells = <1>;
Why do you need #address-cells and #size-cells?
> + reg = <0>;
> + regulator-name = "1P8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "Speaker Ext",
> + "Line", "Line In Jack";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "Microphone Jack", "Mic Bias",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "Speaker Ext", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + frame-master;
> + bitclock-master;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + frame-master;
> + bitclock-master;
> + system-clock-frequency = <25000000>;
> + };
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
Why is it being disabled?
> + fsl,ddr-sampling-point = <4>;
I do not find the bindings for this property, neither how driver
supports it.
> +
> + qflash0: s25fs512s at 0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + codec: sgtl5000 at a {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + VDDA-supply = <®_1p8v>;
> + VDDIO-supply = <®_1p8v>;
> + clocks = <&sys_mclk>;
> + };
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> +
> +&esdhc0 {
> + status = "disabled";
We prefer to disable devices which have board level options by default
in <soc>.dtsi, and enable them per availability in <board>.dts.
> +};
> +
> +&esdhc1 {
> + status = "disabled";
> +};
> +
> +&sai2 {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> new file mode 100644
> index 0000000..382d070
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -0,0 +1,180 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A QDS Board";
> + compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +
> + sys_mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24576000>;
> + };
> +
> + regulators {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg_3p3v: regulator at 0 {
> + compatible = "regulator-fixed";
> + reg = <0x0>;
> + regulator-name = "3P3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "Speaker Ext",
> + "Line", "Line In Jack";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "Microphone Jack", "Mic Bias",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "Speaker Ext", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&sai2>;
> + frame-master;
> + bitclock-master;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&codec>;
> + frame-master;
> + bitclock-master;
> + system-clock-frequency = <24576000>;
> + };
> + };
> +};
> +
> +&dspi0 {
> + bus-num = <0>;
> + status = "okay";
> +
> + flash at 0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
> + reg = <0>;
> + spi-max-frequency = <10000000>; /* input clock */
> + };
> +
> + flash at 1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
> + reg = <1>;
> + spi-max-frequency = <35000000>; /* input clock */
> + };
> +
> + flash at 2 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
> + reg = <2>;
> + spi-max-frequency = <35000000>; /* input clock */
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
> +
> + qflash0: s25fs512s at 0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
Please have a newline between property list and sub-node.
> + pca9547 at 77 {
> + compatible = "nxp,pca9547";
> + reg = <0x77>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c at 4 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x4>;
> +
> + codec: sgtl5000 at a {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + VDDA-supply = <®_3p3v>;
> + VDDIO-supply = <®_3p3v>;
> + clocks = <&sys_mclk>;
> + };
> + };
> + };
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> +
> +&sai2 {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> new file mode 100644
> index 0000000..b609032
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -0,0 +1,79 @@
> +/*
> + * Device Tree file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +/dts-v1/;
> +
> +#include "fsl-ls1012a.dtsi"
> +
> +/ {
> + model = "LS1012A RDB Board";
> + compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
> +
> + aliases {
> + crypto = &crypto;
> + };
> +};
> +
> +&qspi {
> + num-cs = <2>;
> + bus-num = <0>;
> + status = "disabled";
> + fsl,ddr-sampling-point = <4>;
> +
> + qflash0: s25fs512s at 0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + m25p,fast-read;
> + reg = <0>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&duart0 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> new file mode 100644
> index 0000000..80fe028
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -0,0 +1,480 @@
> +/*
> + * Device Tree Include file for Freescale Layerscape-1012A family SoC.
> + *
> + * Copyright 2016, Freescale Semiconductor
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPLv2 or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + * a) This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + * b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include <dt-bindings/thermal/thermal.h>
> +
> +/ {
> + compatible = "fsl,ls1012a";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x0 0x0>;
This doesn't match the #address-cells property of 'cpus' node.
> + clocks = <&clockgen 1 0>;
> + #cooling-cells = <2>;
> + };
> + };
> +
> + sysclk: sysclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "sysclk";
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <1 13 0x1>, /* Physical Secure PPI */
> + <1 14 0x1>, /* Physical Non-Secure PPI */
> + <1 11 0x1>, /* Virtual PPI */
> + <1 10 0x1>; /* Hypervisor PPI */
Can we use the constant defined in
dt-bindings/interrupt-controller/irq.h to make them a bit more readable?
> + };
> +
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <0 106 0x4>;
> + };
> +
> + gic: interrupt-controller at 1400000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x0 0x1401000 0 0x1000>, /* GICD */
> + <0x0 0x1402000 0 0x2000>, /* GICC */
> + <0x0 0x1404000 0 0x2000>, /* GICH */
> + <0x0 0x1406000 0 0x2000>; /* GICV */
> + interrupts = <1 9 0xf08>;
> + };
> +
> + soc {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + clockgen: clocking at 1ee1000 {
> + compatible = "fsl,ls1012a-clockgen";
The compatible cannot be found in binding docs.
> + reg = <0x0 0x1ee1000 0x0 0x1000>;
> + #clock-cells = <2>;
> + clocks = <&sysclk>;
> + };
> +
> + scfg: scfg at 1570000 {
> + compatible = "fsl,ls1012a-scfg", "syscon";
Ditto
> + reg = <0x0 0x1570000 0x0 0x10000>;
> + big-endian;
> + };
> +
> + dcfg: dcfg at 1ee0000 {
> + compatible = "fsl,ls1012a-dcfg",
> + "fsl,ls1043a-dcfg",
If these compatibles are not documented or used, we can drop them? I
guess we only need "syscon" to get it work?
> + "syscon";
> + reg = <0x0 0x1ee0000 0x0 0x10000>;
> + big-endian;
> + };
> +
> + crypto: crypto at 1700000 {
> + compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
> + "fsl,sec-v4.0";
> + fsl,sec-era = <8>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x00 0x1700000 0x100000>;
> + reg = <0x00 0x1700000 0x0 0x100000>;
> + interrupts = <0 75 0x4>;
> +
> + sec_jr0: jr at 10000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x10000 0x10000>;
> + interrupts = <0 71 0x4>;
> + };
> +
> + sec_jr1: jr at 20000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x20000 0x10000>;
> + interrupts = <0 72 0x4>;
> + };
> +
> + sec_jr2: jr at 30000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x30000 0x10000>;
> + interrupts = <0 73 0x4>;
> + };
> +
> + sec_jr3: jr at 40000 {
> + compatible = "fsl,sec-v5.4-job-ring",
> + "fsl,sec-v5.0-job-ring",
> + "fsl,sec-v4.0-job-ring";
> + reg = <0x40000 0x10000>;
> + interrupts = <0 74 0x4>;
> + };
> + };
> +
> + reboot {
> + compatible ="syscon-reboot";
> + regmap = <&dcfg>;
> + offset = <0xb0>;
> + mask = <0x02>;
> + };
It might make more sense to put it directly under root like what
fsl-ls1043a.dtsi does.
> +
> + rcpm: rcpm at 1ee2000 {
> + compatible = "fsl,ls1012a-rcpm";
Undocumented/unsupported bindings?
> + reg = <0x0 0x1ee2000 0x0 0x10000>;
> + };
> +
> + esdhc0: esdhc at 1560000 {
> + compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
> + reg = <0x0 0x1560000 0x0 0x10000>;
> + interrupts = <0 62 0x4>;
> + clock-frequency = <0>;
What does a zero of clock-frequency mean?
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + big-endian;
> + bus-width = <4>;
> + };
> +
> + esdhc1: esdhc at 1580000 {
> + compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
> + reg = <0x0 0x1580000 0x0 0x10000>;
> + interrupts = <0 65 0x4>;
> + clock-frequency = <0>;
> + voltage-ranges = <1800 1800 3300 3300>;
> + sdhci,auto-cmd12;
> + big-endian;
> + bus-width = <4>;
> + };
> +
> + dspi0: dspi at 2100000 {
> + compatible = "fsl,ls1012a-dspi",
> + "fsl,ls1043a-dspi",
> + "fsl,ls1021a-v1.0-dspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2100000 0x0 0x10000>;
> + interrupts = <0 64 0x4>;
> + clock-names = "dspi";
> + clocks = <&clockgen 4 0>;
> + spi-num-chipselects = <5>;
> + big-endian;
> + status = "enabled";
> + };
> +
> + qspi: quadspi at 1550000 {
> + compatible = "fsl,ls1012a-qspi",
> + "fsl,ls1043a-qspi",
> + "fsl,ls1021a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x1550000 0x0 0x10000>,
> + <0x0 0x40000000 0x0 0x4000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <0 99 0x4>;
> + clock-names = "qspi_en", "qspi";
> + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> + big-endian;
> + amba-base = <0x42000000>;
I can not find this property in any bindings doc.
> + };
> +
> + tmu: tmu at 1f00000 {
> + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> + reg = <0x0 0x1f00000 0x0 0x10000>;
> + interrupts = <0 33 0x4>;
> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> + fsl,tmu-calibration = <0x00000000 0x00000026
> + 0x00000001 0x0000002d
> + 0x00000002 0x00000032
> + 0x00000003 0x00000039
> + 0x00000004 0x0000003f
> + 0x00000005 0x00000046
> + 0x00000006 0x0000004d
> + 0x00000007 0x00000054
> + 0x00000008 0x0000005a
> + 0x00000009 0x00000061
> + 0x0000000a 0x0000006a
> + 0x0000000b 0x00000071
> +
Drop the newline.
> + 0x00010000 0x00000025
> + 0x00010001 0x0000002c
> + 0x00010002 0x00000035
> + 0x00010003 0x0000003d
> + 0x00010004 0x00000045
> + 0x00010005 0x0000004e
> + 0x00010006 0x00000057
> + 0x00010007 0x00000061
> + 0x00010008 0x0000006b
> + 0x00010009 0x00000076
> +
Ditto
> + 0x00020000 0x00000029
> + 0x00020001 0x00000033
> + 0x00020002 0x0000003d
> + 0x00020003 0x00000049
> + 0x00020004 0x00000056
> + 0x00020005 0x00000061
> + 0x00020006 0x0000006d
> +
Ditto
> + 0x00030000 0x00000021
> + 0x00030001 0x0000002a
> + 0x00030002 0x0000003c
> + 0x00030003 0x0000004e>;
> + big-endian;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay-passive = <1000>;
> + polling-delay = <5000>;
> +
Ditto
> + thermal-sensors = <&tmu 0>;
> +
> + trips {
> + cpu_alert: cpu-alert {
> + temperature = <85000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
Have a newline between nodes.
> + cpu_crit: cpu-crit {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&cpu_alert>;
> + cooling-device =
> + <&cpu0 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
> + i2c0: i2c at 2180000 {
> + compatible = "fsl,vf610-i2c";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2180000 0x0 0x10000>;
> + interrupts = <0 56 0x4>;
> + clock-names = "i2c";
This property is not needed.
> + clocks = <&clockgen 4 0>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c at 2190000 {
> + compatible = "fsl,vf610-i2c";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2190000 0x0 0x10000>;
> + interrupts = <0 57 0x4>;
> + clock-names = "i2c";
Ditto
> + clocks = <&clockgen 4 0>;
> + status = "disabled";
> + };
> +
> +
> + duart0: serial at 21c0500 {
> + compatible = "fsl,ns16550", "ns16550a";
> + reg = <0x00 0x21c0500 0x0 0x100>;
> + interrupts = <0 54 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + duart1: serial at 21c0600 {
> + compatible = "fsl,ns16550", "ns16550a";
> + reg = <0x00 0x21c0600 0x0 0x100>;
> + interrupts = <0 54 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + gpio0: gpio at 2300000 {
> + compatible = "fsl,qoriq-gpio";
> + reg = <0x0 0x2300000 0x0 0x10000>;
> + interrupts = <0 66 0x4>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + gpio1: gpio at 2310000 {
> + compatible = "fsl,qoriq-gpio";
> + reg = <0x0 0x2310000 0x0 0x10000>;
> + interrupts = <0 67 0x4>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + wdog0: wdog at 2ad0000 {
> + compatible = "fsl,ls1012a-wdt",
> + "fsl,ls1043a-wdt",
> + "fsl,imx21-wdt";
I understand "fsl,imx21-wdt" is the one that kernel driver matches, but
why do we need "fsl,ls1043a-wdt" here?
> + reg = <0x0 0x2ad0000 0x0 0x10000>;
> + interrupts = <0 83 0x4>;
> + clocks = <&clockgen 4 0>;
> + clock-names = "wdog";
clock-names is not required for fsl,imx21-wdt.
> + big-endian;
> + };
> +
> + sai1: sai at 2b50000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0x2b50000 0x0 0x10000>;
> + interrupts = <0 148 0x4>;
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
> + <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 47>,
> + <&edma0 1 46>;
> + status = "disabled";
> + };
> +
> + sai2: sai at 2b60000 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,vf610-sai";
> + reg = <0x0 0x2b60000 0x0 0x10000>;
> + interrupts = <0 149 0x4>;
> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
> + <&clockgen 4 3>, <&clockgen 4 3>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dma-names = "tx", "rx";
> + dmas = <&edma0 1 45>,
> + <&edma0 1 44>;
> + status = "disabled";
> + };
> +
> + edma0: edma at 2c00000 {
> + #dma-cells = <2>;
> + compatible = "fsl,vf610-edma";
> + reg = <0x0 0x2c00000 0x0 0x10000>,
> + <0x0 0x2c10000 0x0 0x10000>,
> + <0x0 0x2c20000 0x0 0x10000>;
> + interrupts = <0 103 0x4>,
> + <0 103 0x4>;
> + interrupt-names = "edma-tx", "edma-err";
> + dma-channels = <32>;
> + big-endian;
> + clock-names = "dmamux0", "dmamux1";
> + clocks = <&clockgen 4 3>,
> + <&clockgen 4 3>;
> + };
> +
> + sata: sata at 3200000 {
> + compatible = "fsl,ls1012a-ahci";
> + reg = <0x0 0x3200000 0x0 0x10000>;
> + interrupts = <0 69 0x4>;
> + clocks = <&clockgen 4 0>;
> + };
> +
> + msi2: msi-controller2 at 1572000 {
> + compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
> + reg = <0x0 0x1572000 0x0 0x4>,
> + <0x0 0x1572004 0x0 0x4>;
> + reg-names = "msiir", "msir";
> + msi-controller;
> + interrupts = <0 126 0x4>;
> + };
> +
> + usb at 8600000 {
> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> + reg = <0x0 0x8600000 0x0 0x1000>;
> + interrupts = <0 139 0x4>;
> + dr_mode = "host";
> + phy_type = "ulpi";
> + fsl,usb-erratum-a005697;
It seems to me that fsl,usb-erratum-a005697 is neither documented or
supported by kernel driver at all.
> + };
> +
> + usb0: usb3 at 2f00000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x2f00000 0x0 0x10000>;
> + interrupts = <0 60 0x4>;
> + dr_mode = "host";
> + configure-gfladj;
Ditto
Shawn
> + snps,dis_rxdet_inp3_quirk;
> + };
> +
> + pcie at 3400000 {
> + compatible = "fsl,ls1012a-pcie",
> + "fsl,ls1043a-pcie",
> + "snps,dw-pcie";
> + reg = <0x00 0x03400000 0x0 0x00100000 /* controller registers */
> + 0x40 0x00000000 0x0 0x00002000>; /* configuration space */
> + reg-names = "regs", "config";
> + interrupts = <0 118 0x4>, /* controller interrupt */
> + <0 117 0x4>; /* PME interrupt */
> + interrupt-names = "intr", "pme";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + num-lanes = <4>;
> + bus-range = <0x0 0xff>;
> + ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
> + 0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> + msi-parent = <&msi2>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
> + <0000 0 0 2 &gic 0 111 0x4>,
> + <0000 0 0 3 &gic 0 112 0x4>,
> + <0000 0 0 4 &gic 0 113 0x4>;
> + };
> + };
> +};
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-29 9:52 ` Shawn Guo
@ 2016-08-29 17:51 ` Scott Wood
-1 siblings, 0 replies; 36+ messages in thread
From: Scott Wood @ 2016-08-29 17:51 UTC (permalink / raw)
To: Shawn Guo, Bhaskar Upadhaya
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, stuart.yoder-3arQi8VN3Tc,
Prabhakar Kushwaha, linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ,
Pratiyush Mohan Srivastava,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> >
> > + clockgen: clocking@1ee1000 {
> > + compatible = "fsl,ls1012a-clockgen";
> The compatible cannot be found in binding docs.
From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
- compatible: Should contain a chip-specific clock block compatible
string and (if applicable) may contain a chassis-version clock
compatible string.
Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
* "fsl,p2041-clockgen"
* "fsl,p3041-clockgen"
* "fsl,p4080-clockgen"
* "fsl,p5020-clockgen"
* "fsl,p5040-clockgen"
* "fsl,t4240-clockgen"
* "fsl,b4420-clockgen"
* "fsl,b4860-clockgen"
* "fsl,ls1021a-clockgen"
Chassis-version clock strings include:
* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
I really hope we don't have to update every single fsl,<chip>-whatever binding
every time a new chip comes out. There are already other chips not listed,
FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
> > + scfg: scfg@1570000 {
> > + compatible = "fsl,ls1012a-scfg", "syscon";
> Ditto
>
> >
> > + reg = <0x0 0x1570000 0x0 0x10000>;
> > + big-endian;
> > + };
> > +
> > + dcfg: dcfg@1ee0000 {
> > + compatible = "fsl,ls1012a-dcfg",
> > + "fsl,ls1043a-dcfg",
> If these compatibles are not documented or used, we can drop them? I
> guess we only need "syscon" to get it work?
If you only have "syscon" then how to do the users of the node properly know
what register set they're dealing with? "syscon" should not be the only
compatible on a node.
> > +
> > + rcpm: rcpm@1ee2000 {
> > + compatible = "fsl,ls1012a-rcpm";
> Undocumented/unsupported bindings?
Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > + tmu: tmu@1f00000 {
> > + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> > + reg = <0x0 0x1f00000 0x0 0x10000>;
> > + interrupts = <0 33 0x4>;
> > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c
> > 0x30062>;
> > + fsl,tmu-calibration = <0x00000000 0x00000026
> > + 0x00000001 0x0000002d
> > + 0x00000002 0x00000032
> > + 0x00000003 0x00000039
> > + 0x00000004 0x0000003f
> > + 0x00000005 0x00000046
> > + 0x00000006 0x0000004d
> > + 0x00000007 0x00000054
> > + 0x00000008 0x0000005a
> > + 0x00000009 0x00000061
> > + 0x0000000a 0x0000006a
> > + 0x0000000b 0x00000071
> > +
> Drop the newline.
>
> >
> > + 0x00010000 0x00000025
> > + 0x00010001 0x0000002c
> > + 0x00010002 0x00000035
> > + 0x00010003 0x0000003d
> > + 0x00010004 0x00000045
> > + 0x00010005 0x0000004e
> > + 0x00010006 0x00000057
> > + 0x00010007 0x00000061
> > + 0x00010008 0x0000006b
> > + 0x00010009 0x00000076
> > +
> Ditto
This is how other instances of this property are formatted -- is it so wrong
to provide visual grouping?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-29 17:51 ` Scott Wood
0 siblings, 0 replies; 36+ messages in thread
From: Scott Wood @ 2016-08-29 17:51 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> >
> > + clockgen: clocking at 1ee1000 {
> > + compatible = "fsl,ls1012a-clockgen";
> The compatible cannot be found in binding docs.
From?Documentation/devicetree/bindings/clock/qoriq-clock.txt:
- compatible: Should contain a chip-specific clock block compatible
????????string and (if applicable) may contain a chassis-version clock
????????compatible string.
? ? ? ? Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
????????* "fsl,p2041-clockgen"
????????* "fsl,p3041-clockgen"
????????* "fsl,p4080-clockgen"
????????* "fsl,p5020-clockgen"
????????* "fsl,p5040-clockgen"
????????* "fsl,t4240-clockgen"
????????* "fsl,b4420-clockgen"
????????* "fsl,b4860-clockgen"
????????* "fsl,ls1021a-clockgen"
????????Chassis-version clock strings include:
????????* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
????????* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
I really hope we don't have to update every single fsl,<chip>-whatever binding
every time a new chip comes out. ?There are already other chips not listed,
FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says "such as".
> > + scfg: scfg at 1570000 {
> > + compatible = "fsl,ls1012a-scfg", "syscon";
> Ditto
>
> >
> > + reg = <0x0 0x1570000 0x0 0x10000>;
> > + big-endian;
> > + };
> > +
> > + dcfg: dcfg at 1ee0000 {
> > + compatible = "fsl,ls1012a-dcfg",
> > + ?????"fsl,ls1043a-dcfg",
> If these compatibles are not documented or used, we can drop them???I
> guess we only need "syscon" to get it work?
If you only have "syscon" then how to do the users of the node properly know
what register set they're dealing with? ?"syscon" should not be the only
compatible on a node.
> > +
> > + rcpm: rcpm at 1ee2000 {
> > + compatible = "fsl,ls1012a-rcpm";
> Undocumented/unsupported bindings?
Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > + tmu: tmu at 1f00000 {
> > + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> > + reg = <0x0 0x1f00000 0x0 0x10000>;
> > + interrupts = <0 33 0x4>;
> > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c
> > 0x30062>;
> > + fsl,tmu-calibration = <0x00000000 0x00000026
> > + ???????0x00000001 0x0000002d
> > + ???????0x00000002 0x00000032
> > + ???????0x00000003 0x00000039
> > + ???????0x00000004 0x0000003f
> > + ???????0x00000005 0x00000046
> > + ???????0x00000006 0x0000004d
> > + ???????0x00000007 0x00000054
> > + ???????0x00000008 0x0000005a
> > + ???????0x00000009 0x00000061
> > + ???????0x0000000a 0x0000006a
> > + ???????0x0000000b 0x00000071
> > +
> Drop the newline.
>
> >
> > + ???????0x00010000 0x00000025
> > + ???????0x00010001 0x0000002c
> > + ???????0x00010002 0x00000035
> > + ???????0x00010003 0x0000003d
> > + ???????0x00010004 0x00000045
> > + ???????0x00010005 0x0000004e
> > + ???????0x00010006 0x00000057
> > + ???????0x00010007 0x00000061
> > + ???????0x00010008 0x0000006b
> > + ???????0x00010009 0x00000076
> > +
> Ditto
This is how other instances of this property are formatted -- is it so wrong
to provide visual grouping?
-Scott
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-29 17:51 ` Scott Wood
@ 2016-08-30 12:02 ` Shawn Guo
-1 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-08-30 12:02 UTC (permalink / raw)
To: Scott Wood
Cc: Bhaskar Upadhaya, devicetree-u79uwXL29TY76Z2rM5mHXA,
Pratiyush Mohan Srivastava, stuart.yoder-3arQi8VN3Tc,
Prabhakar Kushwaha, linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > >
> > > + clockgen: clocking@1ee1000 {
> > > + compatible = "fsl,ls1012a-clockgen";
> > The compatible cannot be found in binding docs.
>
> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>
> - compatible: Should contain a chip-specific clock block compatible
> string and (if applicable) may contain a chassis-version clock
> compatible string.
>
> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> * "fsl,p2041-clockgen"
> * "fsl,p3041-clockgen"
> * "fsl,p4080-clockgen"
> * "fsl,p5020-clockgen"
> * "fsl,p5040-clockgen"
> * "fsl,t4240-clockgen"
> * "fsl,b4420-clockgen"
> * "fsl,b4860-clockgen"
> * "fsl,ls1021a-clockgen"
> Chassis-version clock strings include:
> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>
> I really hope we don't have to update every single fsl,<chip>-whatever binding
> every time a new chip comes out. There are already other chips not listed,
> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
If I remember correctly, DT maintainers want every supported compatible
string explicitly listed in bindings doc. And they even added a check
into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
compatible string documentation checks").
>
> > > + scfg: scfg@1570000 {
> > > + compatible = "fsl,ls1012a-scfg", "syscon";
> > Ditto
> >
> > >
> > > + reg = <0x0 0x1570000 0x0 0x10000>;
> > > + big-endian;
> > > + };
> > > +
> > > + dcfg: dcfg@1ee0000 {
> > > + compatible = "fsl,ls1012a-dcfg",
> > > + "fsl,ls1043a-dcfg",
> > If these compatibles are not documented or used, we can drop them? I
> > guess we only need "syscon" to get it work?
>
> If you only have "syscon" then how to do the users of the node properly know
> what register set they're dealing with? "syscon" should not be the only
> compatible on a node.
Okay, I assumed that a single user only need to deal with one particular
version of "dcfg" block, and the register set should be fixed. It seems
that's not always the case. But at least, "fsl,ls1043a-dcfg" can be
dropped here?
> > > +
> > > + rcpm: rcpm@1ee2000 {
> > > + compatible = "fsl,ls1012a-rcpm";
> > Undocumented/unsupported bindings?
>
> Documentation/devicetree/bindings/soc/fsl/rcpm.txt
I failed to grep the string in both bindings and drivers folder, so
thought this is an undocumented/unsupported compatible.
>
> > > + tmu: tmu@1f00000 {
> > > + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> > > + reg = <0x0 0x1f00000 0x0 0x10000>;
> > > + interrupts = <0 33 0x4>;
> > > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c
> > > 0x30062>;
> > > + fsl,tmu-calibration = <0x00000000 0x00000026
> > > + 0x00000001 0x0000002d
> > > + 0x00000002 0x00000032
> > > + 0x00000003 0x00000039
> > > + 0x00000004 0x0000003f
> > > + 0x00000005 0x00000046
> > > + 0x00000006 0x0000004d
> > > + 0x00000007 0x00000054
> > > + 0x00000008 0x0000005a
> > > + 0x00000009 0x00000061
> > > + 0x0000000a 0x0000006a
> > > + 0x0000000b 0x00000071
> > > +
> > Drop the newline.
> >
> > >
> > > + 0x00010000 0x00000025
> > > + 0x00010001 0x0000002c
> > > + 0x00010002 0x00000035
> > > + 0x00010003 0x0000003d
> > > + 0x00010004 0x00000045
> > > + 0x00010005 0x0000004e
> > > + 0x00010006 0x00000057
> > > + 0x00010007 0x00000061
> > > + 0x00010008 0x0000006b
> > > + 0x00010009 0x00000076
> > > +
> > Ditto
>
> This is how other instances of this property are formatted -- is it so wrong
> to provide visual grouping?
Can we replace the newline with a single line comment to tell how they
are grouped?
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-30 12:02 ` Shawn Guo
0 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-08-30 12:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > >
> > > + clockgen: clocking at 1ee1000 {
> > > + compatible = "fsl,ls1012a-clockgen";
> > The compatible cannot be found in binding docs.
>
> From?Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>
> - compatible: Should contain a chip-specific clock block compatible
> ????????string and (if applicable) may contain a chassis-version clock
> ????????compatible string.
>
> ? ? ? ? Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> ????????* "fsl,p2041-clockgen"
> ????????* "fsl,p3041-clockgen"
> ????????* "fsl,p4080-clockgen"
> ????????* "fsl,p5020-clockgen"
> ????????* "fsl,p5040-clockgen"
> ????????* "fsl,t4240-clockgen"
> ????????* "fsl,b4420-clockgen"
> ????????* "fsl,b4860-clockgen"
> ????????* "fsl,ls1021a-clockgen"
> ????????Chassis-version clock strings include:
> ????????* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> ????????* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>
> I really hope we don't have to update every single fsl,<chip>-whatever binding
> every time a new chip comes out. ?There are already other chips not listed,
> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says "such as".
If I remember correctly, DT maintainers want every supported compatible
string explicitly listed in bindings doc. And they even added a check
into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
compatible string documentation checks").
>
> > > + scfg: scfg at 1570000 {
> > > + compatible = "fsl,ls1012a-scfg", "syscon";
> > Ditto
> >
> > >
> > > + reg = <0x0 0x1570000 0x0 0x10000>;
> > > + big-endian;
> > > + };
> > > +
> > > + dcfg: dcfg at 1ee0000 {
> > > + compatible = "fsl,ls1012a-dcfg",
> > > + ?????"fsl,ls1043a-dcfg",
> > If these compatibles are not documented or used, we can drop them???I
> > guess we only need "syscon" to get it work?
>
> If you only have "syscon" then how to do the users of the node properly know
> what register set they're dealing with? ?"syscon" should not be the only
> compatible on a node.
Okay, I assumed that a single user only need to deal with one particular
version of "dcfg" block, and the register set should be fixed. It seems
that's not always the case. But at least, "fsl,ls1043a-dcfg" can be
dropped here?
> > > +
> > > + rcpm: rcpm at 1ee2000 {
> > > + compatible = "fsl,ls1012a-rcpm";
> > Undocumented/unsupported bindings?
>
> Documentation/devicetree/bindings/soc/fsl/rcpm.txt
I failed to grep the string in both bindings and drivers folder, so
thought this is an undocumented/unsupported compatible.
>
> > > + tmu: tmu at 1f00000 {
> > > + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
> > > + reg = <0x0 0x1f00000 0x0 0x10000>;
> > > + interrupts = <0 33 0x4>;
> > > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c
> > > 0x30062>;
> > > + fsl,tmu-calibration = <0x00000000 0x00000026
> > > + ???????0x00000001 0x0000002d
> > > + ???????0x00000002 0x00000032
> > > + ???????0x00000003 0x00000039
> > > + ???????0x00000004 0x0000003f
> > > + ???????0x00000005 0x00000046
> > > + ???????0x00000006 0x0000004d
> > > + ???????0x00000007 0x00000054
> > > + ???????0x00000008 0x0000005a
> > > + ???????0x00000009 0x00000061
> > > + ???????0x0000000a 0x0000006a
> > > + ???????0x0000000b 0x00000071
> > > +
> > Drop the newline.
> >
> > >
> > > + ???????0x00010000 0x00000025
> > > + ???????0x00010001 0x0000002c
> > > + ???????0x00010002 0x00000035
> > > + ???????0x00010003 0x0000003d
> > > + ???????0x00010004 0x00000045
> > > + ???????0x00010005 0x0000004e
> > > + ???????0x00010006 0x00000057
> > > + ???????0x00010007 0x00000061
> > > + ???????0x00010008 0x0000006b
> > > + ???????0x00010009 0x00000076
> > > +
> > Ditto
>
> This is how other instances of this property are formatted -- is it so wrong
> to provide visual grouping?
Can we replace the newline with a single line comment to tell how they
are grouped?
Shawn
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-30 12:02 ` Shawn Guo
@ 2016-08-30 14:07 ` Stuart Yoder
-1 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-08-30 14:07 UTC (permalink / raw)
To: Shawn Guo, Scott Wood
Cc: devicetree, Bhaskar U, Prabhakar Kushwaha, linux-devel,
Pratiyush Srivastava, linux-arm-kernel
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Tuesday, August 30, 2016 7:02 AM
> To: Scott Wood <oss@buserror.net>
> Cc: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree@vger.kernel.org; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; Stuart Yoder <stuart.yoder@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> > On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > > >
> > > > + clockgen: clocking@1ee1000 {
> > > > + compatible = "fsl,ls1012a-clockgen";
> > > The compatible cannot be found in binding docs.
> >
> > From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> >
> > - compatible: Should contain a chip-specific clock block compatible
> > string and (if applicable) may contain a chassis-version clock
> > compatible string.
> >
> > Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> > * "fsl,p2041-clockgen"
> > * "fsl,p3041-clockgen"
> > * "fsl,p4080-clockgen"
> > * "fsl,p5020-clockgen"
> > * "fsl,p5040-clockgen"
> > * "fsl,t4240-clockgen"
> > * "fsl,b4420-clockgen"
> > * "fsl,b4860-clockgen"
> > * "fsl,ls1021a-clockgen"
> > Chassis-version clock strings include:
> > * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> > * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> >
> > I really hope we don't have to update every single fsl,<chip>-whatever binding
> > every time a new chip comes out. There are already other chips not listed,
> > FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
>
> If I remember correctly, DT maintainers want every supported compatible
> string explicitly listed in bindings doc. And they even added a check
> into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
> compatible string documentation checks").
See Documentation/devicetree/bindings/submitting-patches.txt:
5) The wildcard "<chip>" may be used in compatible strings, as in
the following example:
- compatible: Must contain '"nvidia,<chip>-pcie",
"nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
As in the above example, the known values of "<chip>" should be
documented if it is used.
It _is_ allowed to use the <chip> wildcard, and so you will not find all
full compatible strings explicitly listed in bindings. However, the
chips themselves "should" be listed.
Thanks,
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-08-30 14:07 ` Stuart Yoder
0 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-08-30 14:07 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Tuesday, August 30, 2016 7:02 AM
> To: Scott Wood <oss@buserror.net>
> Cc: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree at vger.kernel.org; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; Stuart Yoder <stuart.yoder@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> > On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > > >
> > > > + clockgen: clocking at 1ee1000 {
> > > > + compatible = "fsl,ls1012a-clockgen";
> > > The compatible cannot be found in binding docs.
> >
> > From?Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> >
> > - compatible: Should contain a chip-specific clock block compatible
> > ????????string and (if applicable) may contain a chassis-version clock
> > ????????compatible string.
> >
> > ? ? ? ? Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> > ????????* "fsl,p2041-clockgen"
> > ????????* "fsl,p3041-clockgen"
> > ????????* "fsl,p4080-clockgen"
> > ????????* "fsl,p5020-clockgen"
> > ????????* "fsl,p5040-clockgen"
> > ????????* "fsl,t4240-clockgen"
> > ????????* "fsl,b4420-clockgen"
> > ????????* "fsl,b4860-clockgen"
> > ????????* "fsl,ls1021a-clockgen"
> > ????????Chassis-version clock strings include:
> > ????????* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> > ????????* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> >
> > I really hope we don't have to update every single fsl,<chip>-whatever binding
> > every time a new chip comes out. ?There are already other chips not listed,
> > FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says "such as".
>
> If I remember correctly, DT maintainers want every supported compatible
> string explicitly listed in bindings doc. And they even added a check
> into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
> compatible string documentation checks").
See Documentation/devicetree/bindings/submitting-patches.txt:
5) The wildcard "<chip>" may be used in compatible strings, as in
the following example:
- compatible: Must contain '"nvidia,<chip>-pcie",
"nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
As in the above example, the known values of "<chip>" should be
documented if it is used.
It _is_ allowed to use the <chip> wildcard, and so you will not find all
full compatible strings explicitly listed in bindings. However, the
chips themselves "should" be listed.
Thanks,
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-30 14:07 ` Stuart Yoder
@ 2016-09-05 1:46 ` Shawn Guo
-1 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-05 1:46 UTC (permalink / raw)
To: Stuart Yoder, Rob Herring, Mark Rutland
Cc: Scott Wood, devicetree-u79uwXL29TY76Z2rM5mHXA, Bhaskar U,
Prabhakar Kushwaha, linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ,
Pratiyush Srivastava,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
> > On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> > > On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > > > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > > > >
> > > > > + clockgen: clocking@1ee1000 {
> > > > > + compatible = "fsl,ls1012a-clockgen";
> > > > The compatible cannot be found in binding docs.
> > >
> > > From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> > >
> > > - compatible: Should contain a chip-specific clock block compatible
> > > string and (if applicable) may contain a chassis-version clock
> > > compatible string.
> > >
> > > Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> > > * "fsl,p2041-clockgen"
> > > * "fsl,p3041-clockgen"
> > > * "fsl,p4080-clockgen"
> > > * "fsl,p5020-clockgen"
> > > * "fsl,p5040-clockgen"
> > > * "fsl,t4240-clockgen"
> > > * "fsl,b4420-clockgen"
> > > * "fsl,b4860-clockgen"
> > > * "fsl,ls1021a-clockgen"
> > > Chassis-version clock strings include:
> > > * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> > > * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> > >
> > > I really hope we don't have to update every single fsl,<chip>-whatever binding
> > > every time a new chip comes out. There are already other chips not listed,
> > > FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
> >
> > If I remember correctly, DT maintainers want every supported compatible
> > string explicitly listed in bindings doc. And they even added a check
> > into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
> > compatible string documentation checks").
>
> See Documentation/devicetree/bindings/submitting-patches.txt:
>
> 5) The wildcard "<chip>" may be used in compatible strings, as in
> the following example:
>
> - compatible: Must contain '"nvidia,<chip>-pcie",
> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>
> As in the above example, the known values of "<chip>" should be
> documented if it is used.
>
> It _is_ allowed to use the <chip> wildcard, and so you will not find all
> full compatible strings explicitly listed in bindings. However, the
> chips themselves "should" be listed.
+ Rob and Mark
Oops, I'm not aware of this DT document. In that case, the DT document
and checkpatch is basically asking for conflicting thing. Rob, Mark,
can you guys please clarify?
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-05 1:46 ` Shawn Guo
0 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-05 1:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
> > On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> > > On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> > > > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> > > > >
> > > > > + clockgen: clocking at 1ee1000 {
> > > > > + compatible = "fsl,ls1012a-clockgen";
> > > > The compatible cannot be found in binding docs.
> > >
> > > From?Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> > >
> > > - compatible: Should contain a chip-specific clock block compatible
> > > ????????string and (if applicable) may contain a chassis-version clock
> > > ????????compatible string.
> > >
> > > ? ? ? ? Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> > > ????????* "fsl,p2041-clockgen"
> > > ????????* "fsl,p3041-clockgen"
> > > ????????* "fsl,p4080-clockgen"
> > > ????????* "fsl,p5020-clockgen"
> > > ????????* "fsl,p5040-clockgen"
> > > ????????* "fsl,t4240-clockgen"
> > > ????????* "fsl,b4420-clockgen"
> > > ????????* "fsl,b4860-clockgen"
> > > ????????* "fsl,ls1021a-clockgen"
> > > ????????Chassis-version clock strings include:
> > > ????????* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> > > ????????* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> > >
> > > I really hope we don't have to update every single fsl,<chip>-whatever binding
> > > every time a new chip comes out. ?There are already other chips not listed,
> > > FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says "such as".
> >
> > If I remember correctly, DT maintainers want every supported compatible
> > string explicitly listed in bindings doc. And they even added a check
> > into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
> > compatible string documentation checks").
>
> See Documentation/devicetree/bindings/submitting-patches.txt:
>
> 5) The wildcard "<chip>" may be used in compatible strings, as in
> the following example:
>
> - compatible: Must contain '"nvidia,<chip>-pcie",
> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>
> As in the above example, the known values of "<chip>" should be
> documented if it is used.
>
> It _is_ allowed to use the <chip> wildcard, and so you will not find all
> full compatible strings explicitly listed in bindings. However, the
> chips themselves "should" be listed.
+ Rob and Mark
Oops, I'm not aware of this DT document. In that case, the DT document
and checkpatch is basically asking for conflicting thing. Rob, Mark,
can you guys please clarify?
Shawn
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-05 1:46 ` Shawn Guo
@ 2016-09-06 17:05 ` Scott Wood
-1 siblings, 0 replies; 36+ messages in thread
From: Scott Wood @ 2016-09-06 17:05 UTC (permalink / raw)
To: Shawn Guo, Stuart Yoder, Rob Herring, Mark Rutland
Cc: devicetree, Bhaskar U, Scott Wood, Prabhakar Kushwaha,
linux-devel, Pratiyush Srivastava, linux-arm-kernel
On 09/04/2016 08:47 PM, Shawn Guo wrote:
> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>>>>>>
>>>>>> + clockgen: clocking@1ee1000 {
>>>>>> + compatible = "fsl,ls1012a-clockgen";
>>>>> The compatible cannot be found in binding docs.
>>>>
>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>>>>
>>>> - compatible: Should contain a chip-specific clock block compatible
>>>> string and (if applicable) may contain a chassis-version clock
>>>> compatible string.
>>>>
>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
>>>> * "fsl,p2041-clockgen"
>>>> * "fsl,p3041-clockgen"
>>>> * "fsl,p4080-clockgen"
>>>> * "fsl,p5020-clockgen"
>>>> * "fsl,p5040-clockgen"
>>>> * "fsl,t4240-clockgen"
>>>> * "fsl,b4420-clockgen"
>>>> * "fsl,b4860-clockgen"
>>>> * "fsl,ls1021a-clockgen"
>>>> Chassis-version clock strings include:
>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>>>>
>>>> I really hope we don't have to update every single fsl,<chip>-whatever binding
>>>> every time a new chip comes out. There are already other chips not listed,
>>>> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
>>>
>>> If I remember correctly, DT maintainers want every supported compatible
>>> string explicitly listed in bindings doc. And they even added a check
>>> into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
>>> compatible string documentation checks").
>>
>> See Documentation/devicetree/bindings/submitting-patches.txt:
>>
>> 5) The wildcard "<chip>" may be used in compatible strings, as in
>> the following example:
>>
>> - compatible: Must contain '"nvidia,<chip>-pcie",
>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>>
>> As in the above example, the known values of "<chip>" should be
>> documented if it is used.
>>
>> It _is_ allowed to use the <chip> wildcard, and so you will not find all
>> full compatible strings explicitly listed in bindings. However, the
>> chips themselves "should" be listed.
>
> + Rob and Mark
>
> Oops, I'm not aware of this DT document. In that case, the DT document
> and checkpatch is basically asking for conflicting thing. Rob, Mark,
> can you guys please clarify?
Checkpatch is a useful tool but it can't get everything right all the time.
-Scott
^ permalink raw reply [flat|nested] 36+ messages in thread
* [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-06 17:05 ` Scott Wood
0 siblings, 0 replies; 36+ messages in thread
From: Scott Wood @ 2016-09-06 17:05 UTC (permalink / raw)
To: linux-arm-kernel
On 09/04/2016 08:47 PM, Shawn Guo wrote:
> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>>>>>>
>>>>>> + clockgen: clocking at 1ee1000 {
>>>>>> + compatible = "fsl,ls1012a-clockgen";
>>>>> The compatible cannot be found in binding docs.
>>>>
>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>>>>
>>>> - compatible: Should contain a chip-specific clock block compatible
>>>> string and (if applicable) may contain a chassis-version clock
>>>> compatible string.
>>>>
>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
>>>> * "fsl,p2041-clockgen"
>>>> * "fsl,p3041-clockgen"
>>>> * "fsl,p4080-clockgen"
>>>> * "fsl,p5020-clockgen"
>>>> * "fsl,p5040-clockgen"
>>>> * "fsl,t4240-clockgen"
>>>> * "fsl,b4420-clockgen"
>>>> * "fsl,b4860-clockgen"
>>>> * "fsl,ls1021a-clockgen"
>>>> Chassis-version clock strings include:
>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>>>>
>>>> I really hope we don't have to update every single fsl,<chip>-whatever binding
>>>> every time a new chip comes out. There are already other chips not listed,
>>>> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as".
>>>
>>> If I remember correctly, DT maintainers want every supported compatible
>>> string explicitly listed in bindings doc. And they even added a check
>>> into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT
>>> compatible string documentation checks").
>>
>> See Documentation/devicetree/bindings/submitting-patches.txt:
>>
>> 5) The wildcard "<chip>" may be used in compatible strings, as in
>> the following example:
>>
>> - compatible: Must contain '"nvidia,<chip>-pcie",
>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>>
>> As in the above example, the known values of "<chip>" should be
>> documented if it is used.
>>
>> It _is_ allowed to use the <chip> wildcard, and so you will not find all
>> full compatible strings explicitly listed in bindings. However, the
>> chips themselves "should" be listed.
>
> + Rob and Mark
>
> Oops, I'm not aware of this DT document. In that case, the DT document
> and checkpatch is basically asking for conflicting thing. Rob, Mark,
> can you guys please clarify?
Checkpatch is a useful tool but it can't get everything right all the time.
-Scott
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-29 9:52 ` Shawn Guo
@ 2016-09-30 11:38 ` Bhaskar U
-1 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 11:38 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Pratiyush Srivastava, Stuart Yoder, oss,
Prabhakar Kushwaha, linux-devel, linux-arm-kernel
>-----Original Message-----
>From: Shawn Guo [mailto:shawnguo@kernel.org]
>Sent: Monday, August 29, 2016 3:23 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>
>Cc: devicetree@vger.kernel.org; Stuart Yoder <stuart.yoder@nxp.com>;
>oss@buserror.net; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; linux-
>devel@gforge.freescale.net; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>; linux-arm-kernel@lists.infradead.org
>Subject: Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>> Add the device tree support for FSL LS1012A SoC.
>> Following levels of DTSI/DTS files have been created for the LS1012A
>> SoC family:
>>
>> - fsl-ls1012a.dtsi:
>> DTS-Include file for FSL LS1012A SoC.
>>
>> - fsl-ls1012a-frdm.dts:
>> DTS file for FSL LS1012A FRDM board.
>>
>> - fsl-ls1012a-qds.dts:
>> DTS file for FSL LS1012A QDS board.
>>
>> - fsl-ls1012a-rdb.dts:
>> DTS file for FSL LS1012A RDB board.
>>
>> Changes vs version1:
>> - Consistent Licensing for dts files
>> - Removed the PFE node
>> - Update reset node with reboot node
>> - Update clocks property in codec node
>> - Update regulators node
>> - Update timer node
>> - Update compatible property of clockgen with "fsl,ls1012a-clockgen"
>only
>> - Update compatible property of scfg with "fsl,ls1012a-scfg" only
>> - Update compatible property with proper ordering in tmu node
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> Signed-off-by: Pratiyush Mohan Srivastava
>> <pratiyush.srivastava@nxp.com>
>> Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/Makefile | 3 +
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480
>+++++++++++++++++++++
>> 5 files changed, 892 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>> b/arch/arm64/boot/dts/freescale/Makefile
>> index 1b7783d..3503c46 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -1,3 +1,6 @@
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
>
>Please try to keep the list sort alphabetically.
Ok will make the sequence like below
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
>
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> new file mode 100644
>> index 0000000..dc6df47
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> @@ -0,0 +1,150 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A Freedom Board";
>> + compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +
>> + sys_mclk: clock-mclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <25000000>;
>> + };
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,widgets =
>> + "Microphone", "Microphone Jack",
>> + "Headphone", "Headphone Jack",
>> + "Speaker", "Speaker Ext",
>> + "Line", "Line In Jack";
>> + simple-audio-card,routing =
>> + "MIC_IN", "Microphone Jack",
>> + "Microphone Jack", "Mic Bias",
>> + "LINE_IN", "Line In Jack",
>> + "Headphone Jack", "HP_OUT",
>> + "Speaker Ext", "LINE_OUT";
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&sai2>;
>> + frame-master;
>> + bitclock-master;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&codec>;
>> + frame-master;
>> + bitclock-master;
>> + system-clock-frequency = <25000000>;
>> + };
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>
>Why is it being disabled?
Ok, will change like below.
status = "okay";
>
>> + fsl,ddr-sampling-point = <4>;
>
>I do not find the bindings for this property, neither how driver supports it.
Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property as of now.
>
>> +
>> + qflash0: s25fs512s@0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> +
>> + codec: sgtl5000@a {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,sgtl5000";
>> + reg = <0xa>;
>> + VDDA-supply = <®_1p8v>;
>> + VDDIO-supply = <®_1p8v>;
>> + clocks = <&sys_mclk>;
>> + };
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> +
>> +&esdhc0 {
>> + status = "disabled";
>
>We prefer to disable devices which have board level options by default in
><soc>.dtsi, and enable them per availability in <board>.dts.
Ok , will make the status as okay i.e. status = "okay";
>
>> +};
>> +
>> +&esdhc1 {
>> + status = "disabled";
>> +};
>> +
>> +&sai2 {
>> + status = "disabled";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> new file mode 100644
>> index 0000000..382d070
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> @@ -0,0 +1,180 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A QDS Board";
>> + compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +
>> + sys_mclk: clock-mclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <24576000>;
>> + };
>> +
>> + regulators {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg_3p3v: regulator@0 {
>> + compatible = "regulator-fixed";
>> + reg = <0x0>;
>> + regulator-name = "3P3V";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> + };
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,widgets =
>> + "Microphone", "Microphone Jack",
>> + "Headphone", "Headphone Jack",
>> + "Speaker", "Speaker Ext",
>> + "Line", "Line In Jack";
>> + simple-audio-card,routing =
>> + "MIC_IN", "Microphone Jack",
>> + "Microphone Jack", "Mic Bias",
>> + "LINE_IN", "Line In Jack",
>> + "Headphone Jack", "HP_OUT",
>> + "Speaker Ext", "LINE_OUT";
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&sai2>;
>> + frame-master;
>> + bitclock-master;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&codec>;
>> + frame-master;
>> + bitclock-master;
>> + system-clock-frequency = <24576000>;
>> + };
>> + };
>> +};
>> +
>> +&dspi0 {
>> + bus-num = <0>;
>> + status = "okay";
>> +
>> + flash@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
>> + reg = <0>;
>> + spi-max-frequency = <10000000>; /* input clock */
>> + };
>> +
>> + flash@1 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
>> + reg = <1>;
>> + spi-max-frequency = <35000000>; /* input clock */
>> + };
>> +
>> + flash@2 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
>> + reg = <2>;
>> + spi-max-frequency = <35000000>; /* input clock */
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>> +
>> + qflash0: s25fs512s@0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>
>Please have a newline between property list and sub-node.
OK
>
>> + pca9547@77 {
>> + compatible = "nxp,pca9547";
>> + reg = <0x77>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + i2c@4 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x4>;
>> +
>> + codec: sgtl5000@a {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,sgtl5000";
>> + reg = <0xa>;
>> + VDDA-supply = <®_3p3v>;
>> + VDDIO-supply = <®_3p3v>;
>> + clocks = <&sys_mclk>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> +
>> +&sai2 {
>> + status = "disabled";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> new file mode 100644
>> index 0000000..b609032
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> @@ -0,0 +1,79 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A RDB Board";
>> + compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>> + fsl,ddr-sampling-point = <4>;
>> +
>> + qflash0: s25fs512s@0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> new file mode 100644
>> index 0000000..80fe028
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> @@ -0,0 +1,480 @@
>> +/*
>> + * Device Tree Include file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +#include <dt-bindings/thermal/thermal.h>
>> +
>> +/ {
>> + compatible = "fsl,ls1012a";
>> + interrupt-parent = <&gic>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + cpu0: cpu@0 {
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a53";
>> + reg = <0x0 0x0>;
>
>This doesn't match the #address-cells property of 'cpus' node.
Ok will make as reg = <0x0>;
>
>> + clocks = <&clockgen 1 0>;
>> + #cooling-cells = <2>;
>> + };
>> + };
>> +
>> + sysclk: sysclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <100000000>;
>> + clock-output-names = "sysclk";
>> + };
>> +
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <1 13 0x1>, /* Physical Secure PPI */
>> + <1 14 0x1>, /* Physical Non-Secure PPI */
>> + <1 11 0x1>, /* Virtual PPI */
>> + <1 10 0x1>; /* Hypervisor PPI */
>
>Can we use the constant defined in
>dt-bindings/interrupt-controller/irq.h to make them a bit more readable?
OK, will include the #include <dt-bindings/interrupt-controller/irq.h> in fsl-ls1012a.dtsi and edit the interrupts like below
interrupts = <1 13 IRQ_TYPE_EDGE_RISING>, /* Physical Secure PPI */
<1 14 IRQ_TYPE_EDGE_RISING>, /* Physical Non-Secure PPI */
<1 11 IRQ_TYPE_EDGE_RISING>, /* Virtual PPI */
<1 10 IRQ_TYPE_EDGE_RISING>; /* Hypervisor PPI */
>
>> + };
>> +
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <0 106 0x4>;
>> + };
>> +
>> + gic: interrupt-controller@1400000 {
>> + compatible = "arm,gic-400";
>> + #interrupt-cells = <3>;
>> + interrupt-controller;
>> + reg = <0x0 0x1401000 0 0x1000>, /* GICD */
>> + <0x0 0x1402000 0 0x2000>, /* GICC */
>> + <0x0 0x1404000 0 0x2000>, /* GICH */
>> + <0x0 0x1406000 0 0x2000>; /* GICV */
>> + interrupts = <1 9 0xf08>;
>> + };
>> +
>> + soc {
>> + compatible = "simple-bus";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + clockgen: clocking@1ee1000 {
>> + compatible = "fsl,ls1012a-clockgen";
>
>The compatible cannot be found in binding docs.
Still not clear whether we need to add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt as there are contradictory thoughts that whether we need to add each compatible string in the bindings or not ?
>
>> + reg = <0x0 0x1ee1000 0x0 0x1000>;
>> + #clock-cells = <2>;
>> + clocks = <&sysclk>;
>> + };
>> +
>> + scfg: scfg@1570000 {
>> + compatible = "fsl,ls1012a-scfg", "syscon";
>
>Ditto
Same clarification needed that whether we need to add each compatible string in the bindings or not ?
If we need to add I will add [compatible = "fsl,ls1012a-scfg", "syscon";] in Documentation/devicetree/bindings/arm/fsl.txt
>
>> + reg = <0x0 0x1570000 0x0 0x10000>;
>> + big-endian;
>> + };
>> +
>> + dcfg: dcfg@1ee0000 {
>> + compatible = "fsl,ls1012a-dcfg",
>> + "fsl,ls1043a-dcfg",
>
>If these compatibles are not documented or used, we can drop them? I guess we
>only need "syscon" to get it work?
Will remove "fsl,ls1043a-dcfg" from here.
>
>> + "syscon";
>> + reg = <0x0 0x1ee0000 0x0 0x10000>;
>> + big-endian;
>> + };
>> +
>> + crypto: crypto@1700000 {
>> + compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
>> + "fsl,sec-v4.0";
>> + fsl,sec-era = <8>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x00 0x1700000 0x100000>;
>> + reg = <0x00 0x1700000 0x0 0x100000>;
>> + interrupts = <0 75 0x4>;
>> +
>> + sec_jr0: jr@10000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <0 71 0x4>;
>> + };
>> +
>> + sec_jr1: jr@20000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x20000 0x10000>;
>> + interrupts = <0 72 0x4>;
>> + };
>> +
>> + sec_jr2: jr@30000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x30000 0x10000>;
>> + interrupts = <0 73 0x4>;
>> + };
>> +
>> + sec_jr3: jr@40000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x40000 0x10000>;
>> + interrupts = <0 74 0x4>;
>> + };
>> + };
>> +
>> + reboot {
>> + compatible ="syscon-reboot";
>> + regmap = <&dcfg>;
>> + offset = <0xb0>;
>> + mask = <0x02>;
>> + };
>
>It might make more sense to put it directly under root like what fsl-ls1043a.dtsi
>does.
Ok, will follow the way fsl-ls1043a.dtsi does.
>
>> +
>> + rcpm: rcpm@1ee2000 {
>> + compatible = "fsl,ls1012a-rcpm";
>
>Undocumented/unsupported bindings?
That again need confirmation that whether we need to add each compatible string in bindings ?. If we need to add, I will add in
Documentation/devicetree/bindings/soc/fsl/rcpm.txt
>
>> + reg = <0x0 0x1ee2000 0x0 0x10000>;
>> + };
>> +
>> + esdhc0: esdhc@1560000 {
>> + compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
>> + reg = <0x0 0x1560000 0x0 0x10000>;
>> + interrupts = <0 62 0x4>;
>> + clock-frequency = <0>;
>
>What does a zero of clock-frequency mean?
The u-boot will fix up the clock-frequency property with the correct value. So we can drop this property.
>
>> + voltage-ranges = <1800 1800 3300 3300>;
>> + sdhci,auto-cmd12;
>> + big-endian;
>> + bus-width = <4>;
>> + };
>> +
>> + esdhc1: esdhc@1580000 {
>> + compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
>> + reg = <0x0 0x1580000 0x0 0x10000>;
>> + interrupts = <0 65 0x4>;
>> + clock-frequency = <0>;
>> + voltage-ranges = <1800 1800 3300 3300>;
>> + sdhci,auto-cmd12;
>> + big-endian;
>> + bus-width = <4>;
>> + };
>> +
>> + dspi0: dspi@2100000 {
>> + compatible = "fsl,ls1012a-dspi",
>> + "fsl,ls1043a-dspi",
>> + "fsl,ls1021a-v1.0-dspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2100000 0x0 0x10000>;
>> + interrupts = <0 64 0x4>;
>> + clock-names = "dspi";
>> + clocks = <&clockgen 4 0>;
>> + spi-num-chipselects = <5>;
>> + big-endian;
>> + status = "enabled";
>> + };
>> +
>> + qspi: quadspi@1550000 {
>> + compatible = "fsl,ls1012a-qspi",
>> + "fsl,ls1043a-qspi",
>> + "fsl,ls1021a-qspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x1550000 0x0 0x10000>,
>> + <0x0 0x40000000 0x0 0x4000000>;
>> + reg-names = "QuadSPI", "QuadSPI-memory";
>> + interrupts = <0 99 0x4>;
>> + clock-names = "qspi_en", "qspi";
>> + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
>> + big-endian;
>> + amba-base = <0x42000000>;
>
>I can not find this property in any bindings doc.
Amba-base is no longer used for QSPI driver in kernel, So I will remove this property.
>
>> + };
>> +
>> + tmu: tmu@1f00000 {
>> + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
>> + reg = <0x0 0x1f00000 0x0 0x10000>;
>> + interrupts = <0 33 0x4>;
>> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
>> + fsl,tmu-calibration = <0x00000000 0x00000026
>> + 0x00000001 0x0000002d
>> + 0x00000002 0x00000032
>> + 0x00000003 0x00000039
>> + 0x00000004 0x0000003f
>> + 0x00000005 0x00000046
>> + 0x00000006 0x0000004d
>> + 0x00000007 0x00000054
>> + 0x00000008 0x0000005a
>> + 0x00000009 0x00000061
>> + 0x0000000a 0x0000006a
>> + 0x0000000b 0x00000071
>> +
>
>Drop the newline.
Ok
>
>> + 0x00010000 0x00000025
>> + 0x00010001 0x0000002c
>> + 0x00010002 0x00000035
>> + 0x00010003 0x0000003d
>> + 0x00010004 0x00000045
>> + 0x00010005 0x0000004e
>> + 0x00010006 0x00000057
>> + 0x00010007 0x00000061
>> + 0x00010008 0x0000006b
>> + 0x00010009 0x00000076
>> +
>
>Ditto
OK
>
>> + 0x00020000 0x00000029
>> + 0x00020001 0x00000033
>> + 0x00020002 0x0000003d
>> + 0x00020003 0x00000049
>> + 0x00020004 0x00000056
>> + 0x00020005 0x00000061
>> + 0x00020006 0x0000006d
>> +
>
>Ditto
OK
>
>> + 0x00030000 0x00000021
>> + 0x00030001 0x0000002a
>> + 0x00030002 0x0000003c
>> + 0x00030003 0x0000004e>;
>> + big-endian;
>> + #thermal-sensor-cells = <1>;
>> + };
>> +
>> + thermal-zones {
>> + cpu_thermal: cpu-thermal {
>> + polling-delay-passive = <1000>;
>> + polling-delay = <5000>;
>> +
>
>Ditto
OK
>
>> + thermal-sensors = <&tmu 0>;
>> +
>> + trips {
>> + cpu_alert: cpu-alert {
>> + temperature = <85000>;
>> + hysteresis = <2000>;
>> + type = "passive";
>> + };
>
>Have a newline between nodes.
OK
>
>> + cpu_crit: cpu-crit {
>> + temperature = <95000>;
>> + hysteresis = <2000>;
>> + type = "critical";
>> + };
>> + };
>> +
>> + cooling-maps {
>> + map0 {
>> + trip = <&cpu_alert>;
>> + cooling-device =
>> + <&cpu0
>THERMAL_NO_LIMIT
>> + THERMAL_NO_LIMIT>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + i2c0: i2c@2180000 {
>> + compatible = "fsl,vf610-i2c";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2180000 0x0 0x10000>;
>> + interrupts = <0 56 0x4>;
>> + clock-names = "i2c";
>
>This property is not needed.
Ok, will remove this
>
>> + clocks = <&clockgen 4 0>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@2190000 {
>> + compatible = "fsl,vf610-i2c";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2190000 0x0 0x10000>;
>> + interrupts = <0 57 0x4>;
>> + clock-names = "i2c";
>
>Ditto
Ok, will remove this
>
>> + clocks = <&clockgen 4 0>;
>> + status = "disabled";
>> + };
>> +
>> +
>> + duart0: serial@21c0500 {
>> + compatible = "fsl,ns16550", "ns16550a";
>> + reg = <0x00 0x21c0500 0x0 0x100>;
>> + interrupts = <0 54 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + duart1: serial@21c0600 {
>> + compatible = "fsl,ns16550", "ns16550a";
>> + reg = <0x00 0x21c0600 0x0 0x100>;
>> + interrupts = <0 54 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + gpio0: gpio@2300000 {
>> + compatible = "fsl,qoriq-gpio";
>> + reg = <0x0 0x2300000 0x0 0x10000>;
>> + interrupts = <0 66 0x4>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> +
>> + gpio1: gpio@2310000 {
>> + compatible = "fsl,qoriq-gpio";
>> + reg = <0x0 0x2310000 0x0 0x10000>;
>> + interrupts = <0 67 0x4>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> +
>> + wdog0: wdog@2ad0000 {
>> + compatible = "fsl,ls1012a-wdt",
>> + "fsl,ls1043a-wdt",
>> + "fsl,imx21-wdt";
>
>I understand "fsl,imx21-wdt" is the one that kernel driver matches, but why do we
>need "fsl,ls1043a-wdt" here?
OK, will remove "fsl,ls1043a-wdt",
>
>> + reg = <0x0 0x2ad0000 0x0 0x10000>;
>> + interrupts = <0 83 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + clock-names = "wdog";
>
>clock-names is not required for fsl,imx21-wdt.
Ok , will remove clock-names = "wdog";
>
>> + big-endian;
>> + };
>> +
>> + sai1: sai@2b50000 {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,vf610-sai";
>> + reg = <0x0 0x2b50000 0x0 0x10000>;
>> + interrupts = <0 148 0x4>;
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
>> + <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
>> + dma-names = "tx", "rx";
>> + dmas = <&edma0 1 47>,
>> + <&edma0 1 46>;
>> + status = "disabled";
>> + };
>> +
>> + sai2: sai@2b60000 {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,vf610-sai";
>> + reg = <0x0 0x2b60000 0x0 0x10000>;
>> + interrupts = <0 149 0x4>;
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
>> + <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
>> + dma-names = "tx", "rx";
>> + dmas = <&edma0 1 45>,
>> + <&edma0 1 44>;
>> + status = "disabled";
>> + };
>> +
>> + edma0: edma@2c00000 {
>> + #dma-cells = <2>;
>> + compatible = "fsl,vf610-edma";
>> + reg = <0x0 0x2c00000 0x0 0x10000>,
>> + <0x0 0x2c10000 0x0 0x10000>,
>> + <0x0 0x2c20000 0x0 0x10000>;
>> + interrupts = <0 103 0x4>,
>> + <0 103 0x4>;
>> + interrupt-names = "edma-tx", "edma-err";
>> + dma-channels = <32>;
>> + big-endian;
>> + clock-names = "dmamux0", "dmamux1";
>> + clocks = <&clockgen 4 3>,
>> + <&clockgen 4 3>;
>> + };
>> +
>> + sata: sata@3200000 {
>> + compatible = "fsl,ls1012a-ahci";
>> + reg = <0x0 0x3200000 0x0 0x10000>;
>> + interrupts = <0 69 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + msi2: msi-controller2@1572000 {
>> + compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
>> + reg = <0x0 0x1572000 0x0 0x4>,
>> + <0x0 0x1572004 0x0 0x4>;
>> + reg-names = "msiir", "msir";
>> + msi-controller;
>> + interrupts = <0 126 0x4>;
>> + };
>> +
>> + usb@8600000 {
>> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
>> + reg = <0x0 0x8600000 0x0 0x1000>;
>> + interrupts = <0 139 0x4>;
>> + dr_mode = "host";
>> + phy_type = "ulpi";
>> + fsl,usb-erratum-a005697;
>
>It seems to me that fsl,usb-erratum-a005697 is neither documented or supported
>by kernel driver at all.
Yes the driver part using the erratum is not yet up-streamed, so will remove fsl,usb-erratum-a005697;
>
>> + };
>> +
>> + usb0: usb3@2f00000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x0 0x2f00000 0x0 0x10000>;
>> + interrupts = <0 60 0x4>;
>> + dr_mode = "host";
>> + configure-gfladj;
OK will remove this .
>
>Ditto
>
>Shawn
>
>> + snps,dis_rxdet_inp3_quirk;
>> + };
>> +
>> + pcie@3400000 {
>> + compatible = "fsl,ls1012a-pcie",
>> + "fsl,ls1043a-pcie",
>> + "snps,dw-pcie";
>> + reg = <0x00 0x03400000 0x0 0x00100000 /* controller
>registers */
>> + 0x40 0x00000000 0x0 0x00002000>; /* configuration
>space */
>> + reg-names = "regs", "config";
>> + interrupts = <0 118 0x4>, /* controller interrupt */
>> + <0 117 0x4>; /* PME interrupt */
>> + interrupt-names = "intr", "pme";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + device_type = "pci";
>> + num-lanes = <4>;
>> + bus-range = <0x0 0xff>;
>> + ranges = <0x81000000 0x0 0x00000000 0x40
>0x00010000 0x0 0x00010000 /* downstream I/O */
>> + 0x82000000 0x0 0x40000000 0x40 0x40000000
>0x0 0x40000000>; /* non-prefetchable memory */
>> + msi-parent = <&msi2>;
>> + #interrupt-cells = <1>;
>> + interrupt-map-mask = <0 0 0 7>;
>> + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
>> + <0000 0 0 2 &gic 0 111 0x4>,
>> + <0000 0 0 3 &gic 0 112 0x4>,
>> + <0000 0 0 4 &gic 0 113 0x4>;
>> + };
>> + };
>> +};
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 11:38 ` Bhaskar U
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 11:38 UTC (permalink / raw)
To: linux-arm-kernel
>-----Original Message-----
>From: Shawn Guo [mailto:shawnguo at kernel.org]
>Sent: Monday, August 29, 2016 3:23 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>
>Cc: devicetree at vger.kernel.org; Stuart Yoder <stuart.yoder@nxp.com>;
>oss at buserror.net; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; linux-
>devel at gforge.freescale.net; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>; linux-arm-kernel at lists.infradead.org
>Subject: Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>> Add the device tree support for FSL LS1012A SoC.
>> Following levels of DTSI/DTS files have been created for the LS1012A
>> SoC family:
>>
>> - fsl-ls1012a.dtsi:
>> DTS-Include file for FSL LS1012A SoC.
>>
>> - fsl-ls1012a-frdm.dts:
>> DTS file for FSL LS1012A FRDM board.
>>
>> - fsl-ls1012a-qds.dts:
>> DTS file for FSL LS1012A QDS board.
>>
>> - fsl-ls1012a-rdb.dts:
>> DTS file for FSL LS1012A RDB board.
>>
>> Changes vs version1:
>> - Consistent Licensing for dts files
>> - Removed the PFE node
>> - Update reset node with reboot node
>> - Update clocks property in codec node
>> - Update regulators node
>> - Update timer node
>> - Update compatible property of clockgen with "fsl,ls1012a-clockgen"
>only
>> - Update compatible property of scfg with "fsl,ls1012a-scfg" only
>> - Update compatible property with proper ordering in tmu node
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> Signed-off-by: Pratiyush Mohan Srivastava
>> <pratiyush.srivastava@nxp.com>
>> Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/Makefile | 3 +
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 150 +++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 180 ++++++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 79 ++++
>> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 480
>+++++++++++++++++++++
>> 5 files changed, 892 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>> b/arch/arm64/boot/dts/freescale/Makefile
>> index 1b7783d..3503c46 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -1,3 +1,6 @@
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
>
>Please try to keep the list sort alphabetically.
Ok will make the sequence like below
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
>
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb diff --git
>> a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> new file mode 100644
>> index 0000000..dc6df47
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
>> @@ -0,0 +1,150 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A Freedom Board";
>> + compatible = "fsl,ls1012a-frdm", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +
>> + sys_mclk: clock-mclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <25000000>;
>> + };
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,widgets =
>> + "Microphone", "Microphone Jack",
>> + "Headphone", "Headphone Jack",
>> + "Speaker", "Speaker Ext",
>> + "Line", "Line In Jack";
>> + simple-audio-card,routing =
>> + "MIC_IN", "Microphone Jack",
>> + "Microphone Jack", "Mic Bias",
>> + "LINE_IN", "Line In Jack",
>> + "Headphone Jack", "HP_OUT",
>> + "Speaker Ext", "LINE_OUT";
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&sai2>;
>> + frame-master;
>> + bitclock-master;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&codec>;
>> + frame-master;
>> + bitclock-master;
>> + system-clock-frequency = <25000000>;
>> + };
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>
>Why is it being disabled?
Ok, will change like below.
status = "okay";
>
>> + fsl,ddr-sampling-point = <4>;
>
>I do not find the bindings for this property, neither how driver supports it.
Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property as of now.
>
>> +
>> + qflash0: s25fs512s at 0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> +
>> + codec: sgtl5000 at a {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,sgtl5000";
>> + reg = <0xa>;
>> + VDDA-supply = <®_1p8v>;
>> + VDDIO-supply = <®_1p8v>;
>> + clocks = <&sys_mclk>;
>> + };
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> +
>> +&esdhc0 {
>> + status = "disabled";
>
>We prefer to disable devices which have board level options by default in
><soc>.dtsi, and enable them per availability in <board>.dts.
Ok , will make the status as okay i.e. status = "okay";
>
>> +};
>> +
>> +&esdhc1 {
>> + status = "disabled";
>> +};
>> +
>> +&sai2 {
>> + status = "disabled";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> new file mode 100644
>> index 0000000..382d070
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
>> @@ -0,0 +1,180 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A QDS Board";
>> + compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +
>> + sys_mclk: clock-mclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <24576000>;
>> + };
>> +
>> + regulators {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg_3p3v: regulator at 0 {
>> + compatible = "regulator-fixed";
>> + reg = <0x0>;
>> + regulator-name = "3P3V";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> + };
>> +
>> + sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,format = "i2s";
>> + simple-audio-card,widgets =
>> + "Microphone", "Microphone Jack",
>> + "Headphone", "Headphone Jack",
>> + "Speaker", "Speaker Ext",
>> + "Line", "Line In Jack";
>> + simple-audio-card,routing =
>> + "MIC_IN", "Microphone Jack",
>> + "Microphone Jack", "Mic Bias",
>> + "LINE_IN", "Line In Jack",
>> + "Headphone Jack", "HP_OUT",
>> + "Speaker Ext", "LINE_OUT";
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&sai2>;
>> + frame-master;
>> + bitclock-master;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&codec>;
>> + frame-master;
>> + bitclock-master;
>> + system-clock-frequency = <24576000>;
>> + };
>> + };
>> +};
>> +
>> +&dspi0 {
>> + bus-num = <0>;
>> + status = "okay";
>> +
>> + flash at 0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "n25q128a11", "jedec,spi-nor"; /* 16MB */
>> + reg = <0>;
>> + spi-max-frequency = <10000000>; /* input clock */
>> + };
>> +
>> + flash at 1 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "sst,sst25wf040b", "jedec,spi-nor"; /* 512KB */
>> + reg = <1>;
>> + spi-max-frequency = <35000000>; /* input clock */
>> + };
>> +
>> + flash at 2 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "eon,en25s64", "jedec,spi-nor"; /* 8MB */
>> + reg = <2>;
>> + spi-max-frequency = <35000000>; /* input clock */
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>> +
>> + qflash0: s25fs512s at 0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>
>Please have a newline between property list and sub-node.
OK
>
>> + pca9547 at 77 {
>> + compatible = "nxp,pca9547";
>> + reg = <0x77>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + i2c at 4 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x4>;
>> +
>> + codec: sgtl5000 at a {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,sgtl5000";
>> + reg = <0xa>;
>> + VDDA-supply = <®_3p3v>;
>> + VDDIO-supply = <®_3p3v>;
>> + clocks = <&sys_mclk>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> +
>> +&sai2 {
>> + status = "disabled";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> new file mode 100644
>> index 0000000..b609032
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
>> @@ -0,0 +1,79 @@
>> +/*
>> + * Device Tree file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +/dts-v1/;
>> +
>> +#include "fsl-ls1012a.dtsi"
>> +
>> +/ {
>> + model = "LS1012A RDB Board";
>> + compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
>> +
>> + aliases {
>> + crypto = &crypto;
>> + };
>> +};
>> +
>> +&qspi {
>> + num-cs = <2>;
>> + bus-num = <0>;
>> + status = "disabled";
>> + fsl,ddr-sampling-point = <4>;
>> +
>> + qflash0: s25fs512s at 0 {
>> + compatible = "spansion,m25p80";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + spi-max-frequency = <20000000>;
>> + m25p,fast-read;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> +};
>> +
>> +&duart0 {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> new file mode 100644
>> index 0000000..80fe028
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
>> @@ -0,0 +1,480 @@
>> +/*
>> + * Device Tree Include file for Freescale Layerscape-1012A family SoC.
>> + *
>> + * Copyright 2016, Freescale Semiconductor
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPLv2 or the X11 license, at your option. Note that this
>> +dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
>KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
>WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
>OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +#include <dt-bindings/thermal/thermal.h>
>> +
>> +/ {
>> + compatible = "fsl,ls1012a";
>> + interrupt-parent = <&gic>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + cpu0: cpu at 0 {
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a53";
>> + reg = <0x0 0x0>;
>
>This doesn't match the #address-cells property of 'cpus' node.
Ok will make as reg = <0x0>;
>
>> + clocks = <&clockgen 1 0>;
>> + #cooling-cells = <2>;
>> + };
>> + };
>> +
>> + sysclk: sysclk {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <100000000>;
>> + clock-output-names = "sysclk";
>> + };
>> +
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <1 13 0x1>, /* Physical Secure PPI */
>> + <1 14 0x1>, /* Physical Non-Secure PPI */
>> + <1 11 0x1>, /* Virtual PPI */
>> + <1 10 0x1>; /* Hypervisor PPI */
>
>Can we use the constant defined in
>dt-bindings/interrupt-controller/irq.h to make them a bit more readable?
OK, will include the #include <dt-bindings/interrupt-controller/irq.h> in fsl-ls1012a.dtsi and edit the interrupts like below
interrupts = <1 13 IRQ_TYPE_EDGE_RISING>, /* Physical Secure PPI */
<1 14 IRQ_TYPE_EDGE_RISING>, /* Physical Non-Secure PPI */
<1 11 IRQ_TYPE_EDGE_RISING>, /* Virtual PPI */
<1 10 IRQ_TYPE_EDGE_RISING>; /* Hypervisor PPI */
>
>> + };
>> +
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <0 106 0x4>;
>> + };
>> +
>> + gic: interrupt-controller at 1400000 {
>> + compatible = "arm,gic-400";
>> + #interrupt-cells = <3>;
>> + interrupt-controller;
>> + reg = <0x0 0x1401000 0 0x1000>, /* GICD */
>> + <0x0 0x1402000 0 0x2000>, /* GICC */
>> + <0x0 0x1404000 0 0x2000>, /* GICH */
>> + <0x0 0x1406000 0 0x2000>; /* GICV */
>> + interrupts = <1 9 0xf08>;
>> + };
>> +
>> + soc {
>> + compatible = "simple-bus";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + clockgen: clocking at 1ee1000 {
>> + compatible = "fsl,ls1012a-clockgen";
>
>The compatible cannot be found in binding docs.
Still not clear whether we need to add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt as there are contradictory thoughts that whether we need to add each compatible string in the bindings or not ?
>
>> + reg = <0x0 0x1ee1000 0x0 0x1000>;
>> + #clock-cells = <2>;
>> + clocks = <&sysclk>;
>> + };
>> +
>> + scfg: scfg at 1570000 {
>> + compatible = "fsl,ls1012a-scfg", "syscon";
>
>Ditto
Same clarification needed that whether we need to add each compatible string in the bindings or not ?
If we need to add I will add [compatible = "fsl,ls1012a-scfg", "syscon";] in Documentation/devicetree/bindings/arm/fsl.txt
>
>> + reg = <0x0 0x1570000 0x0 0x10000>;
>> + big-endian;
>> + };
>> +
>> + dcfg: dcfg at 1ee0000 {
>> + compatible = "fsl,ls1012a-dcfg",
>> + "fsl,ls1043a-dcfg",
>
>If these compatibles are not documented or used, we can drop them? I guess we
>only need "syscon" to get it work?
Will remove "fsl,ls1043a-dcfg" from here.
>
>> + "syscon";
>> + reg = <0x0 0x1ee0000 0x0 0x10000>;
>> + big-endian;
>> + };
>> +
>> + crypto: crypto at 1700000 {
>> + compatible = "fsl,sec-v5.4", "fsl,sec-v5.0",
>> + "fsl,sec-v4.0";
>> + fsl,sec-era = <8>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x00 0x1700000 0x100000>;
>> + reg = <0x00 0x1700000 0x0 0x100000>;
>> + interrupts = <0 75 0x4>;
>> +
>> + sec_jr0: jr at 10000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <0 71 0x4>;
>> + };
>> +
>> + sec_jr1: jr at 20000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x20000 0x10000>;
>> + interrupts = <0 72 0x4>;
>> + };
>> +
>> + sec_jr2: jr at 30000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x30000 0x10000>;
>> + interrupts = <0 73 0x4>;
>> + };
>> +
>> + sec_jr3: jr at 40000 {
>> + compatible = "fsl,sec-v5.4-job-ring",
>> + "fsl,sec-v5.0-job-ring",
>> + "fsl,sec-v4.0-job-ring";
>> + reg = <0x40000 0x10000>;
>> + interrupts = <0 74 0x4>;
>> + };
>> + };
>> +
>> + reboot {
>> + compatible ="syscon-reboot";
>> + regmap = <&dcfg>;
>> + offset = <0xb0>;
>> + mask = <0x02>;
>> + };
>
>It might make more sense to put it directly under root like what fsl-ls1043a.dtsi
>does.
Ok, will follow the way fsl-ls1043a.dtsi does.
>
>> +
>> + rcpm: rcpm at 1ee2000 {
>> + compatible = "fsl,ls1012a-rcpm";
>
>Undocumented/unsupported bindings?
That again need confirmation that whether we need to add each compatible string in bindings ?. If we need to add, I will add in
Documentation/devicetree/bindings/soc/fsl/rcpm.txt
>
>> + reg = <0x0 0x1ee2000 0x0 0x10000>;
>> + };
>> +
>> + esdhc0: esdhc at 1560000 {
>> + compatible = "fsl,ls1012a-esdhc0", "fsl,esdhc";
>> + reg = <0x0 0x1560000 0x0 0x10000>;
>> + interrupts = <0 62 0x4>;
>> + clock-frequency = <0>;
>
>What does a zero of clock-frequency mean?
The u-boot will fix up the clock-frequency property with the correct value. So we can drop this property.
>
>> + voltage-ranges = <1800 1800 3300 3300>;
>> + sdhci,auto-cmd12;
>> + big-endian;
>> + bus-width = <4>;
>> + };
>> +
>> + esdhc1: esdhc at 1580000 {
>> + compatible = "fsl,ls1012a-esdhc1", "fsl,esdhc";
>> + reg = <0x0 0x1580000 0x0 0x10000>;
>> + interrupts = <0 65 0x4>;
>> + clock-frequency = <0>;
>> + voltage-ranges = <1800 1800 3300 3300>;
>> + sdhci,auto-cmd12;
>> + big-endian;
>> + bus-width = <4>;
>> + };
>> +
>> + dspi0: dspi at 2100000 {
>> + compatible = "fsl,ls1012a-dspi",
>> + "fsl,ls1043a-dspi",
>> + "fsl,ls1021a-v1.0-dspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2100000 0x0 0x10000>;
>> + interrupts = <0 64 0x4>;
>> + clock-names = "dspi";
>> + clocks = <&clockgen 4 0>;
>> + spi-num-chipselects = <5>;
>> + big-endian;
>> + status = "enabled";
>> + };
>> +
>> + qspi: quadspi at 1550000 {
>> + compatible = "fsl,ls1012a-qspi",
>> + "fsl,ls1043a-qspi",
>> + "fsl,ls1021a-qspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x1550000 0x0 0x10000>,
>> + <0x0 0x40000000 0x0 0x4000000>;
>> + reg-names = "QuadSPI", "QuadSPI-memory";
>> + interrupts = <0 99 0x4>;
>> + clock-names = "qspi_en", "qspi";
>> + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
>> + big-endian;
>> + amba-base = <0x42000000>;
>
>I can not find this property in any bindings doc.
Amba-base is no longer used for QSPI driver in kernel, So I will remove this property.
>
>> + };
>> +
>> + tmu: tmu at 1f00000 {
>> + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu";
>> + reg = <0x0 0x1f00000 0x0 0x10000>;
>> + interrupts = <0 33 0x4>;
>> + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
>> + fsl,tmu-calibration = <0x00000000 0x00000026
>> + 0x00000001 0x0000002d
>> + 0x00000002 0x00000032
>> + 0x00000003 0x00000039
>> + 0x00000004 0x0000003f
>> + 0x00000005 0x00000046
>> + 0x00000006 0x0000004d
>> + 0x00000007 0x00000054
>> + 0x00000008 0x0000005a
>> + 0x00000009 0x00000061
>> + 0x0000000a 0x0000006a
>> + 0x0000000b 0x00000071
>> +
>
>Drop the newline.
Ok
>
>> + 0x00010000 0x00000025
>> + 0x00010001 0x0000002c
>> + 0x00010002 0x00000035
>> + 0x00010003 0x0000003d
>> + 0x00010004 0x00000045
>> + 0x00010005 0x0000004e
>> + 0x00010006 0x00000057
>> + 0x00010007 0x00000061
>> + 0x00010008 0x0000006b
>> + 0x00010009 0x00000076
>> +
>
>Ditto
OK
>
>> + 0x00020000 0x00000029
>> + 0x00020001 0x00000033
>> + 0x00020002 0x0000003d
>> + 0x00020003 0x00000049
>> + 0x00020004 0x00000056
>> + 0x00020005 0x00000061
>> + 0x00020006 0x0000006d
>> +
>
>Ditto
OK
>
>> + 0x00030000 0x00000021
>> + 0x00030001 0x0000002a
>> + 0x00030002 0x0000003c
>> + 0x00030003 0x0000004e>;
>> + big-endian;
>> + #thermal-sensor-cells = <1>;
>> + };
>> +
>> + thermal-zones {
>> + cpu_thermal: cpu-thermal {
>> + polling-delay-passive = <1000>;
>> + polling-delay = <5000>;
>> +
>
>Ditto
OK
>
>> + thermal-sensors = <&tmu 0>;
>> +
>> + trips {
>> + cpu_alert: cpu-alert {
>> + temperature = <85000>;
>> + hysteresis = <2000>;
>> + type = "passive";
>> + };
>
>Have a newline between nodes.
OK
>
>> + cpu_crit: cpu-crit {
>> + temperature = <95000>;
>> + hysteresis = <2000>;
>> + type = "critical";
>> + };
>> + };
>> +
>> + cooling-maps {
>> + map0 {
>> + trip = <&cpu_alert>;
>> + cooling-device =
>> + <&cpu0
>THERMAL_NO_LIMIT
>> + THERMAL_NO_LIMIT>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + i2c0: i2c at 2180000 {
>> + compatible = "fsl,vf610-i2c";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2180000 0x0 0x10000>;
>> + interrupts = <0 56 0x4>;
>> + clock-names = "i2c";
>
>This property is not needed.
Ok, will remove this
>
>> + clocks = <&clockgen 4 0>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c at 2190000 {
>> + compatible = "fsl,vf610-i2c";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2190000 0x0 0x10000>;
>> + interrupts = <0 57 0x4>;
>> + clock-names = "i2c";
>
>Ditto
Ok, will remove this
>
>> + clocks = <&clockgen 4 0>;
>> + status = "disabled";
>> + };
>> +
>> +
>> + duart0: serial at 21c0500 {
>> + compatible = "fsl,ns16550", "ns16550a";
>> + reg = <0x00 0x21c0500 0x0 0x100>;
>> + interrupts = <0 54 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + duart1: serial at 21c0600 {
>> + compatible = "fsl,ns16550", "ns16550a";
>> + reg = <0x00 0x21c0600 0x0 0x100>;
>> + interrupts = <0 54 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + gpio0: gpio at 2300000 {
>> + compatible = "fsl,qoriq-gpio";
>> + reg = <0x0 0x2300000 0x0 0x10000>;
>> + interrupts = <0 66 0x4>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> +
>> + gpio1: gpio at 2310000 {
>> + compatible = "fsl,qoriq-gpio";
>> + reg = <0x0 0x2310000 0x0 0x10000>;
>> + interrupts = <0 67 0x4>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> +
>> + wdog0: wdog at 2ad0000 {
>> + compatible = "fsl,ls1012a-wdt",
>> + "fsl,ls1043a-wdt",
>> + "fsl,imx21-wdt";
>
>I understand "fsl,imx21-wdt" is the one that kernel driver matches, but why do we
>need "fsl,ls1043a-wdt" here?
OK, will remove "fsl,ls1043a-wdt",
>
>> + reg = <0x0 0x2ad0000 0x0 0x10000>;
>> + interrupts = <0 83 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + clock-names = "wdog";
>
>clock-names is not required for fsl,imx21-wdt.
Ok , will remove clock-names = "wdog";
>
>> + big-endian;
>> + };
>> +
>> + sai1: sai at 2b50000 {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,vf610-sai";
>> + reg = <0x0 0x2b50000 0x0 0x10000>;
>> + interrupts = <0 148 0x4>;
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
>> + <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
>> + dma-names = "tx", "rx";
>> + dmas = <&edma0 1 47>,
>> + <&edma0 1 46>;
>> + status = "disabled";
>> + };
>> +
>> + sai2: sai at 2b60000 {
>> + #sound-dai-cells = <0>;
>> + compatible = "fsl,vf610-sai";
>> + reg = <0x0 0x2b60000 0x0 0x10000>;
>> + interrupts = <0 149 0x4>;
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>,
>> + <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
>> + dma-names = "tx", "rx";
>> + dmas = <&edma0 1 45>,
>> + <&edma0 1 44>;
>> + status = "disabled";
>> + };
>> +
>> + edma0: edma at 2c00000 {
>> + #dma-cells = <2>;
>> + compatible = "fsl,vf610-edma";
>> + reg = <0x0 0x2c00000 0x0 0x10000>,
>> + <0x0 0x2c10000 0x0 0x10000>,
>> + <0x0 0x2c20000 0x0 0x10000>;
>> + interrupts = <0 103 0x4>,
>> + <0 103 0x4>;
>> + interrupt-names = "edma-tx", "edma-err";
>> + dma-channels = <32>;
>> + big-endian;
>> + clock-names = "dmamux0", "dmamux1";
>> + clocks = <&clockgen 4 3>,
>> + <&clockgen 4 3>;
>> + };
>> +
>> + sata: sata at 3200000 {
>> + compatible = "fsl,ls1012a-ahci";
>> + reg = <0x0 0x3200000 0x0 0x10000>;
>> + interrupts = <0 69 0x4>;
>> + clocks = <&clockgen 4 0>;
>> + };
>> +
>> + msi2: msi-controller2 at 1572000 {
>> + compatible ="fsl,1s1012a-msi", "fsl,1s1021a-msi";
>> + reg = <0x0 0x1572000 0x0 0x4>,
>> + <0x0 0x1572004 0x0 0x4>;
>> + reg-names = "msiir", "msir";
>> + msi-controller;
>> + interrupts = <0 126 0x4>;
>> + };
>> +
>> + usb at 8600000 {
>> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
>> + reg = <0x0 0x8600000 0x0 0x1000>;
>> + interrupts = <0 139 0x4>;
>> + dr_mode = "host";
>> + phy_type = "ulpi";
>> + fsl,usb-erratum-a005697;
>
>It seems to me that fsl,usb-erratum-a005697 is neither documented or supported
>by kernel driver at all.
Yes the driver part using the erratum is not yet up-streamed, so will remove fsl,usb-erratum-a005697;
>
>> + };
>> +
>> + usb0: usb3 at 2f00000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x0 0x2f00000 0x0 0x10000>;
>> + interrupts = <0 60 0x4>;
>> + dr_mode = "host";
>> + configure-gfladj;
OK will remove this .
>
>Ditto
>
>Shawn
>
>> + snps,dis_rxdet_inp3_quirk;
>> + };
>> +
>> + pcie at 3400000 {
>> + compatible = "fsl,ls1012a-pcie",
>> + "fsl,ls1043a-pcie",
>> + "snps,dw-pcie";
>> + reg = <0x00 0x03400000 0x0 0x00100000 /* controller
>registers */
>> + 0x40 0x00000000 0x0 0x00002000>; /* configuration
>space */
>> + reg-names = "regs", "config";
>> + interrupts = <0 118 0x4>, /* controller interrupt */
>> + <0 117 0x4>; /* PME interrupt */
>> + interrupt-names = "intr", "pme";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + device_type = "pci";
>> + num-lanes = <4>;
>> + bus-range = <0x0 0xff>;
>> + ranges = <0x81000000 0x0 0x00000000 0x40
>0x00010000 0x0 0x00010000 /* downstream I/O */
>> + 0x82000000 0x0 0x40000000 0x40 0x40000000
>0x0 0x40000000>; /* non-prefetchable memory */
>> + msi-parent = <&msi2>;
>> + #interrupt-cells = <1>;
>> + interrupt-map-mask = <0 0 0 7>;
>> + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
>> + <0000 0 0 2 &gic 0 111 0x4>,
>> + <0000 0 0 3 &gic 0 112 0x4>,
>> + <0000 0 0 4 &gic 0 113 0x4>;
>> + };
>> + };
>> +};
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-06 17:05 ` Scott Wood
@ 2016-09-30 11:38 ` Bhaskar U
-1 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 11:38 UTC (permalink / raw)
To: Scott Wood, Shawn Guo, Stuart Yoder, Rob Herring, Mark Rutland
Cc: devicetree, Pratiyush Srivastava, Scott Wood, Prabhakar Kushwaha,
linux-devel, linux-arm-kernel
>-----Original Message-----
>From: Scott Wood
>Sent: Tuesday, September 06, 2016 10:36 PM
>To: Shawn Guo <shawnguo@kernel.org>; Stuart Yoder <stuart.yoder@nxp.com>;
>Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
>Cc: devicetree@vger.kernel.org; Bhaskar U <bhaskar.upadhaya@nxp.com>; Scott
>Wood <oss@buserror.net>; Prabhakar Kushwaha
><prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; Pratiyush
>Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
>kernel@lists.infradead.org
>Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
>LS1012A SoC
>
>On 09/04/2016 08:47 PM, Shawn Guo wrote:
>> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
>>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
>>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
>>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>>>>>>>
>>>>>>> + clockgen: clocking@1ee1000 {
>>>>>>> + compatible = "fsl,ls1012a-clockgen";
>>>>>> The compatible cannot be found in binding docs.
>>>>>
>>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>>>>>
>>>>> - compatible: Should contain a chip-specific clock block compatible
>>>>> string and (if applicable) may contain a chassis-version clock
>>>>> compatible string.
>>>>>
>>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
>>>>> * "fsl,p2041-clockgen"
>>>>> * "fsl,p3041-clockgen"
>>>>> * "fsl,p4080-clockgen"
>>>>> * "fsl,p5020-clockgen"
>>>>> * "fsl,p5040-clockgen"
>>>>> * "fsl,t4240-clockgen"
>>>>> * "fsl,b4420-clockgen"
>>>>> * "fsl,b4860-clockgen"
>>>>> * "fsl,ls1021a-clockgen"
>>>>> Chassis-version clock strings include:
>>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
>>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>>>>>
>>>>> I really hope we don't have to update every single
>>>>> fsl,<chip>-whatever binding every time a new chip comes out. There
>>>>> are already other chips not listed, FWIW (e.g. t1040, t2080, ls1043a, and
>ls2080a). That's why it says "such as".
>>>>
>>>> If I remember correctly, DT maintainers want every supported
>>>> compatible string explicitly listed in bindings doc. And they even
>>>> added a check into checkpatch.pl with commit bff5da433525
>>>> ("checkpatch: add DT compatible string documentation checks").
>>>
>>> See Documentation/devicetree/bindings/submitting-patches.txt:
>>>
>>> 5) The wildcard "<chip>" may be used in compatible strings, as in
>>> the following example:
>>>
>>> - compatible: Must contain '"nvidia,<chip>-pcie",
>>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>>>
>>> As in the above example, the known values of "<chip>" should be
>>> documented if it is used.
>>>
>>> It _is_ allowed to use the <chip> wildcard, and so you will not find
>>> all full compatible strings explicitly listed in bindings. However,
>>> the chips themselves "should" be listed.
>>
>> + Rob and Mark
>>
>> Oops, I'm not aware of this DT document. In that case, the DT
>> document and checkpatch is basically asking for conflicting thing.
>> Rob, Mark, can you guys please clarify?
>
>Checkpatch is a useful tool but it can't get everything right all the time.
>
So what should we do, shall I add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt ?
>-Scott
^ permalink raw reply [flat|nested] 36+ messages in thread
* [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 11:38 ` Bhaskar U
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 11:38 UTC (permalink / raw)
To: linux-arm-kernel
>-----Original Message-----
>From: Scott Wood
>Sent: Tuesday, September 06, 2016 10:36 PM
>To: Shawn Guo <shawnguo@kernel.org>; Stuart Yoder <stuart.yoder@nxp.com>;
>Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
>Cc: devicetree at vger.kernel.org; Bhaskar U <bhaskar.upadhaya@nxp.com>; Scott
>Wood <oss@buserror.net>; Prabhakar Kushwaha
><prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; Pratiyush
>Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
>kernel at lists.infradead.org
>Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
>LS1012A SoC
>
>On 09/04/2016 08:47 PM, Shawn Guo wrote:
>> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
>>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
>>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
>>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
>>>>>>>
>>>>>>> + clockgen: clocking at 1ee1000 {
>>>>>>> + compatible = "fsl,ls1012a-clockgen";
>>>>>> The compatible cannot be found in binding docs.
>>>>>
>>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
>>>>>
>>>>> - compatible: Should contain a chip-specific clock block compatible
>>>>> string and (if applicable) may contain a chassis-version clock
>>>>> compatible string.
>>>>>
>>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
>>>>> * "fsl,p2041-clockgen"
>>>>> * "fsl,p3041-clockgen"
>>>>> * "fsl,p4080-clockgen"
>>>>> * "fsl,p5020-clockgen"
>>>>> * "fsl,p5040-clockgen"
>>>>> * "fsl,t4240-clockgen"
>>>>> * "fsl,b4420-clockgen"
>>>>> * "fsl,b4860-clockgen"
>>>>> * "fsl,ls1021a-clockgen"
>>>>> Chassis-version clock strings include:
>>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
>>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
>>>>>
>>>>> I really hope we don't have to update every single
>>>>> fsl,<chip>-whatever binding every time a new chip comes out. There
>>>>> are already other chips not listed, FWIW (e.g. t1040, t2080, ls1043a, and
>ls2080a). That's why it says "such as".
>>>>
>>>> If I remember correctly, DT maintainers want every supported
>>>> compatible string explicitly listed in bindings doc. And they even
>>>> added a check into checkpatch.pl with commit bff5da433525
>>>> ("checkpatch: add DT compatible string documentation checks").
>>>
>>> See Documentation/devicetree/bindings/submitting-patches.txt:
>>>
>>> 5) The wildcard "<chip>" may be used in compatible strings, as in
>>> the following example:
>>>
>>> - compatible: Must contain '"nvidia,<chip>-pcie",
>>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
>>>
>>> As in the above example, the known values of "<chip>" should be
>>> documented if it is used.
>>>
>>> It _is_ allowed to use the <chip> wildcard, and so you will not find
>>> all full compatible strings explicitly listed in bindings. However,
>>> the chips themselves "should" be listed.
>>
>> + Rob and Mark
>>
>> Oops, I'm not aware of this DT document. In that case, the DT
>> document and checkpatch is basically asking for conflicting thing.
>> Rob, Mark, can you guys please clarify?
>
>Checkpatch is a useful tool but it can't get everything right all the time.
>
So what should we do, shall I add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt ?
>-Scott
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 11:38 ` Bhaskar U
@ 2016-09-30 13:55 ` Stuart Yoder
-1 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 13:55 UTC (permalink / raw)
To: Bhaskar U, Shawn Guo
Cc: devicetree, Pratiyush Srivastava, oss, Prabhakar Kushwaha,
linux-devel, linux-arm-kernel
> >> +&qspi {
> >> + num-cs = <2>;
> >> + bus-num = <0>;
> >> + status = "disabled";
> >
> >Why is it being disabled?
>
> Ok, will change like below.
> status = "okay";
The comment was not "change this to okay". The question is why is this disabled?
Can you explain why it was disabled? Should it have been disasbled? Is qspi
working and tested on this board?
>
> >
> >> + fsl,ddr-sampling-point = <4>;
> >
> >I do not find the bindings for this property, neither how driver supports it.
>
> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property as of now.
>
> >
> >> +
> >> + qflash0: s25fs512s@0 {
> >> + compatible = "spansion,m25p80";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + spi-max-frequency = <20000000>;
> >> + m25p,fast-read;
> >> + reg = <0>;
> >> + };
> >> +};
> >> +
> >> +&i2c0 {
> >> + status = "okay";
> >> +
> >> + codec: sgtl5000@a {
> >> + #sound-dai-cells = <0>;
> >> + compatible = "fsl,sgtl5000";
> >> + reg = <0xa>;
> >> + VDDA-supply = <®_1p8v>;
> >> + VDDIO-supply = <®_1p8v>;
> >> + clocks = <&sys_mclk>;
> >> + };
> >> +};
> >> +
> >> +&duart0 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&esdhc0 {
> >> + status = "disabled";
> >
> >We prefer to disable devices which have board level options by default in
> ><soc>.dtsi, and enable them per availability in <board>.dts.
>
> Ok , will make the status as okay i.e. status = "okay";
Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
here in the first place? Was there a reason?
The comment is that if there are certain boards where esdhc0 is not available,
then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
override it.
> >
> >> +};
> >> +
> >> +&esdhc1 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +&sai2 {
> >> + status = "disabled";
> >> +};
Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
disabled and any .dts file should override with "ok" if applicable.
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 13:55 ` Stuart Yoder
0 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 13:55 UTC (permalink / raw)
To: linux-arm-kernel
> >> +&qspi {
> >> + num-cs = <2>;
> >> + bus-num = <0>;
> >> + status = "disabled";
> >
> >Why is it being disabled?
>
> Ok, will change like below.
> status = "okay";
The comment was not "change this to okay". The question is why is this disabled?
Can you explain why it was disabled? Should it have been disasbled? Is qspi
working and tested on this board?
>
> >
> >> + fsl,ddr-sampling-point = <4>;
> >
> >I do not find the bindings for this property, neither how driver supports it.
>
> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property as of now.
>
> >
> >> +
> >> + qflash0: s25fs512s at 0 {
> >> + compatible = "spansion,m25p80";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + spi-max-frequency = <20000000>;
> >> + m25p,fast-read;
> >> + reg = <0>;
> >> + };
> >> +};
> >> +
> >> +&i2c0 {
> >> + status = "okay";
> >> +
> >> + codec: sgtl5000 at a {
> >> + #sound-dai-cells = <0>;
> >> + compatible = "fsl,sgtl5000";
> >> + reg = <0xa>;
> >> + VDDA-supply = <®_1p8v>;
> >> + VDDIO-supply = <®_1p8v>;
> >> + clocks = <&sys_mclk>;
> >> + };
> >> +};
> >> +
> >> +&duart0 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&esdhc0 {
> >> + status = "disabled";
> >
> >We prefer to disable devices which have board level options by default in
> ><soc>.dtsi, and enable them per availability in <board>.dts.
>
> Ok , will make the status as okay i.e. status = "okay";
Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
here in the first place? Was there a reason?
The comment is that if there are certain boards where esdhc0 is not available,
then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
override it.
> >
> >> +};
> >> +
> >> +&esdhc1 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +&sai2 {
> >> + status = "disabled";
> >> +};
Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
disabled and any .dts file should override with "ok" if applicable.
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-08-26 10:27 ` Bhaskar Upadhaya
@ 2016-09-30 13:57 ` Stuart Yoder
-1 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 13:57 UTC (permalink / raw)
To: devicetree, shawnguo
Cc: Bhaskar U, oss, Prabhakar Kushwaha, linux-devel,
Pratiyush Srivastava, linux-arm-kernel
> + dspi0: dspi@2100000 {
> + compatible = "fsl,ls1012a-dspi",
> + "fsl,ls1043a-dspi",
> + "fsl,ls1021a-v1.0-dspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2100000 0x0 0x10000>;
> + interrupts = <0 64 0x4>;
> + clock-names = "dspi";
> + clocks = <&clockgen 4 0>;
> + spi-num-chipselects = <5>;
> + big-endian;
> + status = "enabled";
"enabled" is not a valid status value.
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 13:57 ` Stuart Yoder
0 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 13:57 UTC (permalink / raw)
To: linux-arm-kernel
> + dspi0: dspi at 2100000 {
> + compatible = "fsl,ls1012a-dspi",
> + "fsl,ls1043a-dspi",
> + "fsl,ls1021a-v1.0-dspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x2100000 0x0 0x10000>;
> + interrupts = <0 64 0x4>;
> + clock-names = "dspi";
> + clocks = <&clockgen 4 0>;
> + spi-num-chipselects = <5>;
> + big-endian;
> + status = "enabled";
"enabled" is not a valid status value.
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 13:55 ` Stuart Yoder
@ 2016-09-30 21:13 ` Bhaskar U
-1 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 21:13 UTC (permalink / raw)
To: Stuart Yoder, Shawn Guo
Cc: devicetree, Pratiyush Srivastava, oss, Prabhakar Kushwaha,
linux-devel, linux-arm-kernel
>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:26 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
><shawnguo@kernel.org>
>Cc: devicetree@vger.kernel.org; oss@buserror.net; Prabhakar Kushwaha
><prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; Pratiyush
>Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
>kernel@lists.infradead.org
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> >> +&qspi {
>> >> + num-cs = <2>;
>> >> + bus-num = <0>;
>> >> + status = "disabled";
>> >
>> >Why is it being disabled?
>>
>> Ok, will change like below.
>> status = "okay";
>
>The comment was not "change this to okay". The question is why is this disabled?
>Can you explain why it was disabled? Should it have been disasbled? Is qspi
>working and tested on this board?
The intension of putting the status in disabled state is that the qspi functionality is not tested with the up-streamed kernel.
Yes qspi is working and tested on this board with 4.1 kernel version.
>
>>
>> >
>> >> + fsl,ddr-sampling-point = <4>;
>> >
>> >I do not find the bindings for this property, neither how driver supports it.
>>
>> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property
>as of now.
>>
>> >
>> >> +
>> >> + qflash0: s25fs512s@0 {
>> >> + compatible = "spansion,m25p80";
>> >> + #address-cells = <1>;
>> >> + #size-cells = <1>;
>> >> + spi-max-frequency = <20000000>;
>> >> + m25p,fast-read;
>> >> + reg = <0>;
>> >> + };
>> >> +};
>> >> +
>> >> +&i2c0 {
>> >> + status = "okay";
>> >> +
>> >> + codec: sgtl5000@a {
>> >> + #sound-dai-cells = <0>;
>> >> + compatible = "fsl,sgtl5000";
>> >> + reg = <0xa>;
>> >> + VDDA-supply = <®_1p8v>;
>> >> + VDDIO-supply = <®_1p8v>;
>> >> + clocks = <&sys_mclk>;
>> >> + };
>> >> +};
>> >> +
>> >> +&duart0 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&esdhc0 {
>> >> + status = "disabled";
>> >
>> >We prefer to disable devices which have board level options by
>> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
>>
>> Ok , will make the status as okay i.e. status = "okay";
>
>Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
>here in the first place? Was there a reason?
>
>The comment is that if there are certain boards where esdhc0 is not available,
>then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
>override it.
esdhc0 is not there on this board so shall we mark the status in disabled state ?
>
>> >
>> >> +};
>> >> +
>> >> +&esdhc1 {
>> >> + status = "disabled";
>> >> +};
>> >> +
>> >> +&sai2 {
>> >> + status = "disabled";
>> >> +};
>
>Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
>disabled and any .dts file should override with "ok" if applicable.
esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working fine.
>
>Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:13 ` Bhaskar U
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 21:13 UTC (permalink / raw)
To: linux-arm-kernel
>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:26 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
><shawnguo@kernel.org>
>Cc: devicetree at vger.kernel.org; oss at buserror.net; Prabhakar Kushwaha
><prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; Pratiyush
>Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
>kernel at lists.infradead.org
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> >> +&qspi {
>> >> + num-cs = <2>;
>> >> + bus-num = <0>;
>> >> + status = "disabled";
>> >
>> >Why is it being disabled?
>>
>> Ok, will change like below.
>> status = "okay";
>
>The comment was not "change this to okay". The question is why is this disabled?
>Can you explain why it was disabled? Should it have been disasbled? Is qspi
>working and tested on this board?
The intension of putting the status in disabled state is that the qspi functionality is not tested with the up-streamed kernel.
Yes qspi is working and tested on this board with 4.1 kernel version.
>
>>
>> >
>> >> + fsl,ddr-sampling-point = <4>;
>> >
>> >I do not find the bindings for this property, neither how driver supports it.
>>
>> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property
>as of now.
>>
>> >
>> >> +
>> >> + qflash0: s25fs512s at 0 {
>> >> + compatible = "spansion,m25p80";
>> >> + #address-cells = <1>;
>> >> + #size-cells = <1>;
>> >> + spi-max-frequency = <20000000>;
>> >> + m25p,fast-read;
>> >> + reg = <0>;
>> >> + };
>> >> +};
>> >> +
>> >> +&i2c0 {
>> >> + status = "okay";
>> >> +
>> >> + codec: sgtl5000 at a {
>> >> + #sound-dai-cells = <0>;
>> >> + compatible = "fsl,sgtl5000";
>> >> + reg = <0xa>;
>> >> + VDDA-supply = <®_1p8v>;
>> >> + VDDIO-supply = <®_1p8v>;
>> >> + clocks = <&sys_mclk>;
>> >> + };
>> >> +};
>> >> +
>> >> +&duart0 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&esdhc0 {
>> >> + status = "disabled";
>> >
>> >We prefer to disable devices which have board level options by
>> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
>>
>> Ok , will make the status as okay i.e. status = "okay";
>
>Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
>here in the first place? Was there a reason?
>
>The comment is that if there are certain boards where esdhc0 is not available,
>then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
>override it.
esdhc0 is not there on this board so shall we mark the status in disabled state ?
>
>> >
>> >> +};
>> >> +
>> >> +&esdhc1 {
>> >> + status = "disabled";
>> >> +};
>> >> +
>> >> +&sai2 {
>> >> + status = "disabled";
>> >> +};
>
>Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
>disabled and any .dts file should override with "ok" if applicable.
esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working fine.
>
>Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 13:57 ` Stuart Yoder
@ 2016-09-30 21:19 ` Bhaskar U
-1 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 21:19 UTC (permalink / raw)
To: Stuart Yoder, devicetree, shawnguo
Cc: oss, linux-devel, Pratiyush Srivastava, Prabhakar Kushwaha,
linux-arm-kernel
>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:28 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree@vger.kernel.org;
>shawnguo@kernel.org
>Cc: oss@buserror.net; linux-arm-kernel@lists.infradead.org; linux-
>devel@gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
>Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> + dspi0: dspi@2100000 {
>> + compatible = "fsl,ls1012a-dspi",
>> + "fsl,ls1043a-dspi",
>> + "fsl,ls1021a-v1.0-dspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2100000 0x0 0x10000>;
>> + interrupts = <0 64 0x4>;
>> + clock-names = "dspi";
>> + clocks = <&clockgen 4 0>;
>> + spi-num-chipselects = <5>;
>> + big-endian;
>> + status = "enabled";
>
>"enabled" is not a valid status value.
>
So shall I put the status = "okay" ?
But there are other nodes like i2c below having status = "enabled", so do we need to edit them also ? If yes then what should be written in the status ?
i2c0: i2c@2180000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2180000 0x0 0x10000>;
interrupts = <0 56 0x4>;
clock-names = "i2c";
clocks = <&clockgen 4 0>;
status = "enabled";
};
i2c1: i2c@2190000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2190000 0x0 0x10000>;
interrupts = <0 57 0x4>;
clock-names = "i2c";
clocks = <&clockgen 4 0>;
status = "enabled";
};
>Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:19 ` Bhaskar U
0 siblings, 0 replies; 36+ messages in thread
From: Bhaskar U @ 2016-09-30 21:19 UTC (permalink / raw)
To: linux-arm-kernel
>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:28 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree at vger.kernel.org;
>shawnguo at kernel.org
>Cc: oss at buserror.net; linux-arm-kernel at lists.infradead.org; linux-
>devel at gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
>Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> + dspi0: dspi at 2100000 {
>> + compatible = "fsl,ls1012a-dspi",
>> + "fsl,ls1043a-dspi",
>> + "fsl,ls1021a-v1.0-dspi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x0 0x2100000 0x0 0x10000>;
>> + interrupts = <0 64 0x4>;
>> + clock-names = "dspi";
>> + clocks = <&clockgen 4 0>;
>> + spi-num-chipselects = <5>;
>> + big-endian;
>> + status = "enabled";
>
>"enabled" is not a valid status value.
>
So shall I put the status = "okay" ?
But there are other nodes like i2c below having status = "enabled", so do we need to edit them also ? If yes then what should be written in the status ?
i2c0: i2c at 2180000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2180000 0x0 0x10000>;
interrupts = <0 56 0x4>;
clock-names = "i2c";
clocks = <&clockgen 4 0>;
status = "enabled";
};
i2c1: i2c at 2190000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2190000 0x0 0x10000>;
interrupts = <0 57 0x4>;
clock-names = "i2c";
clocks = <&clockgen 4 0>;
status = "enabled";
};
>Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 21:19 ` Bhaskar U
@ 2016-09-30 21:29 ` Leo Li
-1 siblings, 0 replies; 36+ messages in thread
From: Leo Li @ 2016-09-30 21:29 UTC (permalink / raw)
To: Bhaskar U, Stuart Yoder, devicetree, shawnguo
Cc: oss, linux-devel, Pratiyush Srivastava, Prabhakar Kushwaha,
linux-arm-kernel
> -----Original Message-----
> From: linux-devel-bounces@gforge.freescale.net [mailto:linux-devel-
> bounces@gforge.freescale.net] On Behalf Of Bhaskar U
> Sent: Friday, September 30, 2016 4:19 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; devicetree@vger.kernel.org;
> shawnguo@kernel.org
> Cc: oss@buserror.net; linux-devel@gforge.freescale.net; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:28 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree@vger.kernel.org;
> >shawnguo@kernel.org
> >Cc: oss@buserror.net; linux-arm-kernel@lists.infradead.org; linux-
> >devel@gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
> >Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
> ><pratiyush.srivastava@nxp.com>
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A
> >SoC
> >
> >> + dspi0: dspi@2100000 {
> >> + compatible = "fsl,ls1012a-dspi",
> >> + "fsl,ls1043a-dspi",
> >> + "fsl,ls1021a-v1.0-dspi";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = <0x0 0x2100000 0x0 0x10000>;
> >> + interrupts = <0 64 0x4>;
> >> + clock-names = "dspi";
> >> + clocks = <&clockgen 4 0>;
> >> + spi-num-chipselects = <5>;
> >> + big-endian;
> >> + status = "enabled";
> >
> >"enabled" is not a valid status value.
> >
>
> So shall I put the status = "okay" ?
>
> But there are other nodes like i2c below having status = "enabled", so do we
> need to edit them also ? If yes then what should be written in the status ?
> i2c0: i2c@2180000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x2180000 0x0 0x10000>;
> interrupts = <0 56 0x4>;
> clock-names = "i2c";
> clocks = <&clockgen 4 0>;
> status = "enabled";
> };
>
> i2c1: i2c@2190000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x2190000 0x0 0x10000>;
> interrupts = <0 57 0x4>;
> clock-names = "i2c";
> clocks = <&clockgen 4 0>;
> status = "enabled";
> };
The default is "okay". You should just remove these status properties.
Regards,
Leo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:29 ` Leo Li
0 siblings, 0 replies; 36+ messages in thread
From: Leo Li @ 2016-09-30 21:29 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: linux-devel-bounces at gforge.freescale.net [mailto:linux-devel-
> bounces at gforge.freescale.net] On Behalf Of Bhaskar U
> Sent: Friday, September 30, 2016 4:19 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; devicetree at vger.kernel.org;
> shawnguo at kernel.org
> Cc: oss at buserror.net; linux-devel at gforge.freescale.net; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-arm-kernel at lists.infradead.org
> Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:28 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree at vger.kernel.org;
> >shawnguo at kernel.org
> >Cc: oss at buserror.net; linux-arm-kernel at lists.infradead.org; linux-
> >devel at gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
> >Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
> ><pratiyush.srivastava@nxp.com>
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A
> >SoC
> >
> >> + dspi0: dspi at 2100000 {
> >> + compatible = "fsl,ls1012a-dspi",
> >> + "fsl,ls1043a-dspi",
> >> + "fsl,ls1021a-v1.0-dspi";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = <0x0 0x2100000 0x0 0x10000>;
> >> + interrupts = <0 64 0x4>;
> >> + clock-names = "dspi";
> >> + clocks = <&clockgen 4 0>;
> >> + spi-num-chipselects = <5>;
> >> + big-endian;
> >> + status = "enabled";
> >
> >"enabled" is not a valid status value.
> >
>
> So shall I put the status = "okay" ?
>
> But there are other nodes like i2c below having status = "enabled", so do we
> need to edit them also ? If yes then what should be written in the status ?
> i2c0: i2c at 2180000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x2180000 0x0 0x10000>;
> interrupts = <0 56 0x4>;
> clock-names = "i2c";
> clocks = <&clockgen 4 0>;
> status = "enabled";
> };
>
> i2c1: i2c at 2190000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x2190000 0x0 0x10000>;
> interrupts = <0 57 0x4>;
> clock-names = "i2c";
> clocks = <&clockgen 4 0>;
> status = "enabled";
> };
The default is "okay". You should just remove these status properties.
Regards,
Leo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 11:38 ` Bhaskar U
@ 2016-09-30 21:30 ` Shawn Guo
-1 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-30 21:30 UTC (permalink / raw)
To: Bhaskar U
Cc: Mark Rutland, devicetree, Pratiyush Srivastava,
Prabhakar Kushwaha, Stuart Yoder, Scott Wood, Scott Wood,
Rob Herring, linux-devel, linux-arm-kernel
On Fri, Sep 30, 2016 at 11:38:29AM +0000, Bhaskar U wrote:
>
>
> >-----Original Message-----
> >From: Scott Wood
> >Sent: Tuesday, September 06, 2016 10:36 PM
> >To: Shawn Guo <shawnguo@kernel.org>; Stuart Yoder <stuart.yoder@nxp.com>;
> >Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> >Cc: devicetree@vger.kernel.org; Bhaskar U <bhaskar.upadhaya@nxp.com>; Scott
> >Wood <oss@buserror.net>; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; Pratiyush
> >Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel@lists.infradead.org
> >Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> >LS1012A SoC
> >
> >On 09/04/2016 08:47 PM, Shawn Guo wrote:
> >> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
> >>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> >>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> >>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> >>>>>>>
> >>>>>>> + clockgen: clocking@1ee1000 {
> >>>>>>> + compatible = "fsl,ls1012a-clockgen";
> >>>>>> The compatible cannot be found in binding docs.
> >>>>>
> >>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> >>>>>
> >>>>> - compatible: Should contain a chip-specific clock block compatible
> >>>>> string and (if applicable) may contain a chassis-version clock
> >>>>> compatible string.
> >>>>>
> >>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> >>>>> * "fsl,p2041-clockgen"
> >>>>> * "fsl,p3041-clockgen"
> >>>>> * "fsl,p4080-clockgen"
> >>>>> * "fsl,p5020-clockgen"
> >>>>> * "fsl,p5040-clockgen"
> >>>>> * "fsl,t4240-clockgen"
> >>>>> * "fsl,b4420-clockgen"
> >>>>> * "fsl,b4860-clockgen"
> >>>>> * "fsl,ls1021a-clockgen"
> >>>>> Chassis-version clock strings include:
> >>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> >>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> >>>>>
> >>>>> I really hope we don't have to update every single
> >>>>> fsl,<chip>-whatever binding every time a new chip comes out. There
> >>>>> are already other chips not listed, FWIW (e.g. t1040, t2080, ls1043a, and
> >ls2080a). That's why it says "such as".
> >>>>
> >>>> If I remember correctly, DT maintainers want every supported
> >>>> compatible string explicitly listed in bindings doc. And they even
> >>>> added a check into checkpatch.pl with commit bff5da433525
> >>>> ("checkpatch: add DT compatible string documentation checks").
> >>>
> >>> See Documentation/devicetree/bindings/submitting-patches.txt:
> >>>
> >>> 5) The wildcard "<chip>" may be used in compatible strings, as in
> >>> the following example:
> >>>
> >>> - compatible: Must contain '"nvidia,<chip>-pcie",
> >>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
> >>>
> >>> As in the above example, the known values of "<chip>" should be
> >>> documented if it is used.
> >>>
> >>> It _is_ allowed to use the <chip> wildcard, and so you will not find
> >>> all full compatible strings explicitly listed in bindings. However,
> >>> the chips themselves "should" be listed.
> >>
> >> + Rob and Mark
> >>
> >> Oops, I'm not aware of this DT document. In that case, the DT
> >> document and checkpatch is basically asking for conflicting thing.
> >> Rob, Mark, can you guys please clarify?
> >
> >Checkpatch is a useful tool but it can't get everything right all the time.
> >
>
> So what should we do, shall I add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt ?
I would encourage you to do that.
Shawn
^ permalink raw reply [flat|nested] 36+ messages in thread
* [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:30 ` Shawn Guo
0 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-30 21:30 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 30, 2016 at 11:38:29AM +0000, Bhaskar U wrote:
>
>
> >-----Original Message-----
> >From: Scott Wood
> >Sent: Tuesday, September 06, 2016 10:36 PM
> >To: Shawn Guo <shawnguo@kernel.org>; Stuart Yoder <stuart.yoder@nxp.com>;
> >Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> >Cc: devicetree at vger.kernel.org; Bhaskar U <bhaskar.upadhaya@nxp.com>; Scott
> >Wood <oss@buserror.net>; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; Pratiyush
> >Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel at lists.infradead.org
> >Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> >LS1012A SoC
> >
> >On 09/04/2016 08:47 PM, Shawn Guo wrote:
> >> On Tue, Aug 30, 2016 at 02:07:17PM +0000, Stuart Yoder wrote:
> >>>> On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:
> >>>>> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:
> >>>>>> On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:
> >>>>>>>
> >>>>>>> + clockgen: clocking at 1ee1000 {
> >>>>>>> + compatible = "fsl,ls1012a-clockgen";
> >>>>>> The compatible cannot be found in binding docs.
> >>>>>
> >>>>> From Documentation/devicetree/bindings/clock/qoriq-clock.txt:
> >>>>>
> >>>>> - compatible: Should contain a chip-specific clock block compatible
> >>>>> string and (if applicable) may contain a chassis-version clock
> >>>>> compatible string.
> >>>>>
> >>>>> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as:
> >>>>> * "fsl,p2041-clockgen"
> >>>>> * "fsl,p3041-clockgen"
> >>>>> * "fsl,p4080-clockgen"
> >>>>> * "fsl,p5020-clockgen"
> >>>>> * "fsl,p5040-clockgen"
> >>>>> * "fsl,t4240-clockgen"
> >>>>> * "fsl,b4420-clockgen"
> >>>>> * "fsl,b4860-clockgen"
> >>>>> * "fsl,ls1021a-clockgen"
> >>>>> Chassis-version clock strings include:
> >>>>> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
> >>>>> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
> >>>>>
> >>>>> I really hope we don't have to update every single
> >>>>> fsl,<chip>-whatever binding every time a new chip comes out. There
> >>>>> are already other chips not listed, FWIW (e.g. t1040, t2080, ls1043a, and
> >ls2080a). That's why it says "such as".
> >>>>
> >>>> If I remember correctly, DT maintainers want every supported
> >>>> compatible string explicitly listed in bindings doc. And they even
> >>>> added a check into checkpatch.pl with commit bff5da433525
> >>>> ("checkpatch: add DT compatible string documentation checks").
> >>>
> >>> See Documentation/devicetree/bindings/submitting-patches.txt:
> >>>
> >>> 5) The wildcard "<chip>" may be used in compatible strings, as in
> >>> the following example:
> >>>
> >>> - compatible: Must contain '"nvidia,<chip>-pcie",
> >>> "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ...
> >>>
> >>> As in the above example, the known values of "<chip>" should be
> >>> documented if it is used.
> >>>
> >>> It _is_ allowed to use the <chip> wildcard, and so you will not find
> >>> all full compatible strings explicitly listed in bindings. However,
> >>> the chips themselves "should" be listed.
> >>
> >> + Rob and Mark
> >>
> >> Oops, I'm not aware of this DT document. In that case, the DT
> >> document and checkpatch is basically asking for conflicting thing.
> >> Rob, Mark, can you guys please clarify?
> >
> >Checkpatch is a useful tool but it can't get everything right all the time.
> >
>
> So what should we do, shall I add "compatible = "fsl,ls1012a-clockgen";" in Documentation/devicetree/bindings/clock/qoriq-clock.txt ?
I would encourage you to do that.
Shawn
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 21:13 ` Bhaskar U
@ 2016-09-30 21:45 ` Leo Li
-1 siblings, 0 replies; 36+ messages in thread
From: Leo Li @ 2016-09-30 21:45 UTC (permalink / raw)
To: Bhaskar U, Stuart Yoder, Shawn Guo
Cc: oss, devicetree, Pratiyush Srivastava, Prabhakar Kushwaha,
linux-arm-kernel
> -----Original Message-----
> From: linux-devel-bounces@gforge.freescale.net [mailto:linux-devel-
> bounces@gforge.freescale.net] On Behalf Of Bhaskar U
> Sent: Friday, September 30, 2016 4:13 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; oss@buserror.net; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:26 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
> ><shawnguo@kernel.org>
> >Cc: devicetree@vger.kernel.org; oss@buserror.net; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net;
> >Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel@lists.infradead.org
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A
> >SoC
> >
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this
> disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality
> is not tested with the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
> >
> >>
> >> >
> >> >> + fsl,ddr-sampling-point = <4>;
> >> >
> >> >I do not find the bindings for this property, neither how driver supports it.
> >>
> >> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this
> >> property
> >as of now.
> >>
> >> >
> >> >> +
> >> >> + qflash0: s25fs512s@0 {
> >> >> + compatible = "spansion,m25p80";
> >> >> + #address-cells = <1>;
> >> >> + #size-cells = <1>;
> >> >> + spi-max-frequency = <20000000>;
> >> >> + m25p,fast-read;
> >> >> + reg = <0>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&i2c0 {
> >> >> + status = "okay";
> >> >> +
> >> >> + codec: sgtl5000@a {
> >> >> + #sound-dai-cells = <0>;
> >> >> + compatible = "fsl,sgtl5000";
> >> >> + reg = <0xa>;
> >> >> + VDDA-supply = <®_1p8v>;
> >> >> + VDDIO-supply = <®_1p8v>;
> >> >> + clocks = <&sys_mclk>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&duart0 {
> >> >> + status = "okay";
> >> >> +};
> >> >> +
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to
> "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not
> >available, then fsl-ls1012a.dtsi should set this to "disabled" and
> >board .dts files should override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
>
> >
> >> >
> >> >> +};
> >> >> +
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them
> >to disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in
> disabled state ?
> sai2 is working and tested on this board, so shall we put the sai2 status as
> "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but
> now it is working fine.
The convention is to set the status of these optional nodes to "disabled" in the SoC dtsi. And enable the nodes needed in board dts by overwriting the status to "okay". It could be confusing if you use both "disabled" and "okay" in the board dts file.
Regards,
Leo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:45 ` Leo Li
0 siblings, 0 replies; 36+ messages in thread
From: Leo Li @ 2016-09-30 21:45 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: linux-devel-bounces at gforge.freescale.net [mailto:linux-devel-
> bounces at gforge.freescale.net] On Behalf Of Bhaskar U
> Sent: Friday, September 30, 2016 4:13 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree at vger.kernel.org; Pratiyush Srivastava
> <pratiyush.srivastava@nxp.com>; oss at buserror.net; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [linux-devel] [PATCH v2 1/1] arm64: Add DTS support for FSL's
> LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:26 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
> ><shawnguo@kernel.org>
> >Cc: devicetree at vger.kernel.org; oss at buserror.net; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net;
> >Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel at lists.infradead.org
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A
> >SoC
> >
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this
> disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality
> is not tested with the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
> >
> >>
> >> >
> >> >> + fsl,ddr-sampling-point = <4>;
> >> >
> >> >I do not find the bindings for this property, neither how driver supports it.
> >>
> >> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this
> >> property
> >as of now.
> >>
> >> >
> >> >> +
> >> >> + qflash0: s25fs512s at 0 {
> >> >> + compatible = "spansion,m25p80";
> >> >> + #address-cells = <1>;
> >> >> + #size-cells = <1>;
> >> >> + spi-max-frequency = <20000000>;
> >> >> + m25p,fast-read;
> >> >> + reg = <0>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&i2c0 {
> >> >> + status = "okay";
> >> >> +
> >> >> + codec: sgtl5000 at a {
> >> >> + #sound-dai-cells = <0>;
> >> >> + compatible = "fsl,sgtl5000";
> >> >> + reg = <0xa>;
> >> >> + VDDA-supply = <®_1p8v>;
> >> >> + VDDIO-supply = <®_1p8v>;
> >> >> + clocks = <&sys_mclk>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&duart0 {
> >> >> + status = "okay";
> >> >> +};
> >> >> +
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to
> "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not
> >available, then fsl-ls1012a.dtsi should set this to "disabled" and
> >board .dts files should override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
>
> >
> >> >
> >> >> +};
> >> >> +
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them
> >to disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in
> disabled state ?
> sai2 is working and tested on this board, so shall we put the sai2 status as
> "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but
> now it is working fine.
The convention is to set the status of these optional nodes to "disabled" in the SoC dtsi. And enable the nodes needed in board dts by overwriting the status to "okay". It could be confusing if you use both "disabled" and "okay" in the board dts file.
Regards,
Leo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 21:13 ` Bhaskar U
@ 2016-09-30 21:55 ` Shawn Guo
-1 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-30 21:55 UTC (permalink / raw)
To: Bhaskar U
Cc: Stuart Yoder, devicetree-u79uwXL29TY76Z2rM5mHXA,
Pratiyush Srivastava, oss-fOR+EgIDQEHk1uMJSBkQmQ,
Prabhakar Kushwaha, linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Fri, Sep 30, 2016 at 09:13:11PM +0000, Bhaskar U wrote:
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality is not tested with the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
Please only add those board level device node after it's been tested on
the board.
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not available,
> >then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
> >override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
For device that has pin-out on board, we should mark it disabled in
<soc>.dtsi by default, and enable it in <board>.dts.
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
> >disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
With esdhc1 being marked "disabled" in <soc>.dtsi by default, we need
to do nothing for board that doesn't have the device.
> sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working fine.
With sai2 being marked "disabled" in <soc>.dtsi by default, you add
board level node with "okay" after you test the device working.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 21:55 ` Shawn Guo
0 siblings, 0 replies; 36+ messages in thread
From: Shawn Guo @ 2016-09-30 21:55 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 30, 2016 at 09:13:11PM +0000, Bhaskar U wrote:
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality is not tested with the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
Please only add those board level device node after it's been tested on
the board.
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not available,
> >then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
> >override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
For device that has pin-out on board, we should mark it disabled in
<soc>.dtsi by default, and enable it in <board>.dts.
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
> >disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
With esdhc1 being marked "disabled" in <soc>.dtsi by default, we need
to do nothing for board that doesn't have the device.
> sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working fine.
With sai2 being marked "disabled" in <soc>.dtsi by default, you add
board level node with "okay" after you test the device working.
Shawn
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
2016-09-30 21:13 ` Bhaskar U
@ 2016-09-30 22:42 ` Stuart Yoder
-1 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 22:42 UTC (permalink / raw)
To: Bhaskar U, Shawn Guo
Cc: devicetree, Pratiyush Srivastava, oss, Prabhakar Kushwaha,
linux-devel, linux-arm-kernel
> -----Original Message-----
> From: Bhaskar U
> Sent: Friday, September 30, 2016 4:13 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org; oss@buserror.net; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>;
> linux-devel@gforge.freescale.net; Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> kernel@lists.infradead.org
> Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:26 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
> ><shawnguo@kernel.org>
> >Cc: devicetree@vger.kernel.org; oss@buserror.net; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel@gforge.freescale.net; Pratiyush
> >Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel@lists.infradead.org
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
> >
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality is not tested with
> the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
If the qspi is supported and you have a high degree of confidence that the
node is correct based on testing on 4.1, I would say keep the node and
mark it as "ok".
> >>
> >> >
> >> >> + fsl,ddr-sampling-point = <4>;
> >> >
> >> >I do not find the bindings for this property, neither how driver supports it.
> >>
> >> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property
> >as of now.
> >>
> >> >
> >> >> +
> >> >> + qflash0: s25fs512s@0 {
> >> >> + compatible = "spansion,m25p80";
> >> >> + #address-cells = <1>;
> >> >> + #size-cells = <1>;
> >> >> + spi-max-frequency = <20000000>;
> >> >> + m25p,fast-read;
> >> >> + reg = <0>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&i2c0 {
> >> >> + status = "okay";
> >> >> +
> >> >> + codec: sgtl5000@a {
> >> >> + #sound-dai-cells = <0>;
> >> >> + compatible = "fsl,sgtl5000";
> >> >> + reg = <0xa>;
> >> >> + VDDA-supply = <®_1p8v>;
> >> >> + VDDIO-supply = <®_1p8v>;
> >> >> + clocks = <&sys_mclk>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&duart0 {
> >> >> + status = "okay";
> >> >> +};
> >> >> +
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not available,
> >then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
> >override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
If it's not there then it should be disabled, but it should be set to disabled
in the dtsi file (not the dts).
> >
> >> >
> >> >> +};
> >> >> +
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
> >disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
If it's not there on the board, then yes, mark as disabled.
> sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working
> fine.
If the board supports it and it's been tested, then yes mark as "okay".
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
@ 2016-09-30 22:42 ` Stuart Yoder
0 siblings, 0 replies; 36+ messages in thread
From: Stuart Yoder @ 2016-09-30 22:42 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Bhaskar U
> Sent: Friday, September 30, 2016 4:13 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree at vger.kernel.org; oss at buserror.net; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>;
> linux-devel at gforge.freescale.net; Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> kernel at lists.infradead.org
> Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>
>
> >-----Original Message-----
> >From: Stuart Yoder
> >Sent: Friday, September 30, 2016 7:26 PM
> >To: Bhaskar U <bhaskar.upadhaya@nxp.com>; Shawn Guo
> ><shawnguo@kernel.org>
> >Cc: devicetree at vger.kernel.org; oss at buserror.net; Prabhakar Kushwaha
> ><prabhakar.kushwaha@nxp.com>; linux-devel at gforge.freescale.net; Pratiyush
> >Srivastava <pratiyush.srivastava@nxp.com>; linux-arm-
> >kernel at lists.infradead.org
> >Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
> >
> >> >> +&qspi {
> >> >> + num-cs = <2>;
> >> >> + bus-num = <0>;
> >> >> + status = "disabled";
> >> >
> >> >Why is it being disabled?
> >>
> >> Ok, will change like below.
> >> status = "okay";
> >
> >The comment was not "change this to okay". The question is why is this disabled?
> >Can you explain why it was disabled? Should it have been disasbled? Is qspi
> >working and tested on this board?
>
> The intension of putting the status in disabled state is that the qspi functionality is not tested with
> the up-streamed kernel.
> Yes qspi is working and tested on this board with 4.1 kernel version.
If the qspi is supported and you have a high degree of confidence that the
node is correct based on testing on 4.1, I would say keep the node and
mark it as "ok".
> >>
> >> >
> >> >> + fsl,ddr-sampling-point = <4>;
> >> >
> >> >I do not find the bindings for this property, neither how driver supports it.
> >>
> >> Yes the QSPI DDR mode is not yet up-streamed, so I will remove this property
> >as of now.
> >>
> >> >
> >> >> +
> >> >> + qflash0: s25fs512s at 0 {
> >> >> + compatible = "spansion,m25p80";
> >> >> + #address-cells = <1>;
> >> >> + #size-cells = <1>;
> >> >> + spi-max-frequency = <20000000>;
> >> >> + m25p,fast-read;
> >> >> + reg = <0>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&i2c0 {
> >> >> + status = "okay";
> >> >> +
> >> >> + codec: sgtl5000 at a {
> >> >> + #sound-dai-cells = <0>;
> >> >> + compatible = "fsl,sgtl5000";
> >> >> + reg = <0xa>;
> >> >> + VDDA-supply = <®_1p8v>;
> >> >> + VDDIO-supply = <®_1p8v>;
> >> >> + clocks = <&sys_mclk>;
> >> >> + };
> >> >> +};
> >> >> +
> >> >> +&duart0 {
> >> >> + status = "okay";
> >> >> +};
> >> >> +
> >> >> +&esdhc0 {
> >> >> + status = "disabled";
> >> >
> >> >We prefer to disable devices which have board level options by
> >> >default in <soc>.dtsi, and enable them per availability in <board>.dts.
> >>
> >> Ok , will make the status as okay i.e. status = "okay";
> >
> >Again, the feedback was not "set this to okay". Why was esdhc0 set to "disabled"
> >here in the first place? Was there a reason?
> >
> >The comment is that if there are certain boards where esdhc0 is not available,
> >then fsl-ls1012a.dtsi should set this to "disabled" and board .dts files should
> >override it.
>
> esdhc0 is not there on this board so shall we mark the status in disabled state ?
If it's not there then it should be disabled, but it should be set to disabled
in the dtsi file (not the dts).
> >
> >> >
> >> >> +};
> >> >> +
> >> >> +&esdhc1 {
> >> >> + status = "disabled";
> >> >> +};
> >> >> +
> >> >> +&sai2 {
> >> >> + status = "disabled";
> >> >> +};
> >
> >Same comment for the above nodes. The fsl-ls1012a.dtsi should set them to
> >disabled and any .dts file should override with "ok" if applicable.
>
> esdhc1 is not there on the board, so shall we keep the status of esdhc1 in disabled state ?
If it's not there on the board, then yes, mark as disabled.
> sai2 is working and tested on this board, so shall we put the sai2 status as "okay" ?
> Earlier when we kept sai2 status as disabled, by that time sai2 was not tested but now it is working
> fine.
If the board supports it and it's been tested, then yes mark as "okay".
Stuart
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2016-09-30 22:42 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 10:27 [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC Bhaskar Upadhaya
2016-08-26 10:27 ` Bhaskar Upadhaya
[not found] ` <1472207241-18461-1-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-29 9:52 ` Shawn Guo
2016-08-29 9:52 ` Shawn Guo
2016-08-29 17:51 ` Scott Wood
2016-08-29 17:51 ` Scott Wood
[not found] ` <1472493061.13245.39.camel-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
2016-08-30 12:02 ` Shawn Guo
2016-08-30 12:02 ` Shawn Guo
2016-08-30 14:07 ` Stuart Yoder
2016-08-30 14:07 ` Stuart Yoder
[not found] ` <HE1PR0401MB2636B40376255680B6A58CFB8DE00-B0v07Ae2tarUYqUkpow3g43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-05 1:46 ` Shawn Guo
2016-09-05 1:46 ` Shawn Guo
2016-09-06 17:05 ` [linux-devel] " Scott Wood
2016-09-06 17:05 ` Scott Wood
2016-09-30 11:38 ` Bhaskar U
2016-09-30 11:38 ` Bhaskar U
2016-09-30 21:30 ` Shawn Guo
2016-09-30 21:30 ` Shawn Guo
2016-09-30 11:38 ` Bhaskar U
2016-09-30 11:38 ` Bhaskar U
2016-09-30 13:55 ` Stuart Yoder
2016-09-30 13:55 ` Stuart Yoder
2016-09-30 21:13 ` Bhaskar U
2016-09-30 21:13 ` Bhaskar U
2016-09-30 21:45 ` [linux-devel] " Leo Li
2016-09-30 21:45 ` Leo Li
[not found] ` <AM4PR0401MB2275F9FBAE954BD420AA67F98CC10-4rsfagO7TJwHfFjNQjRPfY3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-30 21:55 ` Shawn Guo
2016-09-30 21:55 ` Shawn Guo
2016-09-30 22:42 ` Stuart Yoder
2016-09-30 22:42 ` Stuart Yoder
2016-09-30 13:57 ` Stuart Yoder
2016-09-30 13:57 ` Stuart Yoder
2016-09-30 21:19 ` Bhaskar U
2016-09-30 21:19 ` Bhaskar U
2016-09-30 21:29 ` [linux-devel] " Leo Li
2016-09-30 21:29 ` Leo Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.