From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qianyu Gong Date: Thu, 28 Jan 2016 08:55:34 +0000 Subject: [U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI In-Reply-To: References: <1453965300-24844-1-git-send-email-Qianyu.Gong@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > -----Original Message----- > From: Bin Meng [mailto:bmeng.cn at gmail.com] > Sent: Thursday, January 28, 2016 4:02 PM > To: Qianyu Gong > Cc: u-boot at lists.denx.de > Subject: Re: [U-Boot] [PATCH] pci: gate print info of reading vender id with > CONFIG_DM_PCI > > On Thu, Jan 28, 2016 at 3:43 PM, Qianyu Gong wrote: > > Hi, > > > >> -----Original Message----- > >> From: Bin Meng [mailto:bmeng.cn at gmail.com] > >> Sent: Thursday, January 28, 2016 3:30 PM > >> To: Qianyu Gong > >> Cc: U-Boot Mailing List > >> Subject: Re: [U-Boot] [PATCH] pci: gate print info of reading vender > >> id with CONFIG_DM_PCI > >> > >> On Thu, Jan 28, 2016 at 3:15 PM, Gong Qianyu wrote: > >> > From: Mingkai Hu > >> > > >> > Referring to 'commit ff3e077bd23c ("dm: pci: Add a uclass for PCI")'. > >> > > >> > For legacy PCIe driver, it needs loop to read the vender_id from > >> > devie > >> > 0 to devie 255 to check if there is device available. > >> > Reading non-existen device will trigger the "Cannot read bus > >> > configuration: -1" information. > >> > > >> > Signed-off-by: Mingkai Hu > >> > Signed-off-by: Gong Qianyu > >> > --- > >> > >> Which pci controller are you testing? > >> > >> [snip] > >> > >> Regards, > >> Bin > > > > Designware PCIe controller on LS2085A. > > > > Please check commit 7ba34ff09f1ef105521f914e4ad4e4ac19975bac "pci: > layerscape: Adjust the return value when ls_pcie_addr_valid() fails" > which is already in mainline. > > Regards, > Bin Ok. That's nice of you. And we also find another commit cab24b3407189a12 "dm: pci: Convert 'pci' command to driver model" submitted by Simon has fixed the issue. So no need of this patch. Thanks a lot. Regards, Qianyu