From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Date: Mon, 22 Feb 2016 11:51:12 +0000
Subject: [U-Boot] [PATCH] armv8/fsl-layerscape: add IFC fixup for
	LS1043A	with QSPI enabled
In-Reply-To: <1456135520-48373-1-git-send-email-Qianyu.Gong@nxp.com>
References: <1456135520-48373-1-git-send-email-Qianyu.Gong@nxp.com>
Message-ID: <AM2PR04MB1121D92E47724F45A8E5427497A30@AM2PR04MB1121.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Gong
> Qianyu
> Sent: Monday, February 22, 2016 3:35 PM
> To: u-boot at lists.denx.de; york sun <york.sun@nxp.com>; oss at buserror.net
> Cc: Qianyu Gong <qianyu.gong@nxp.com>; Mingkai Hu
> <mingkai.hu@nxp.com>
> Subject: [U-Boot] [PATCH] armv8/fsl-layerscape: add IFC fixup for LS1043A
> with QSPI enabled
> 
> QSPI and IFC are pin-multiplexed on LS1043A. So if QSPI is enabled, IFC
> should be disabled.
> But just disable IFC driver in LS1043A Linux is not enough because mdio-mux
> will access IFC address space -- actually it accesses FPGA which is connected
> to IFC CS3. So disable the whole IFC node in Linux device tree.
> 

FPGA and NAND access are valid use-case during QSPI boot

So why IFC controller is being disabled from device tree. 

> Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> index 4e4861d..5bb3048 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> @@ -204,4 +204,11 @@ void ft_cpu_setup(void *blob, bd_t *bd)  #ifdef
> CONFIG_FSL_LSCH3
>  	fdt_fixup_smmu(blob);
>  #endif
> +
> +#ifdef CONFIG_LS1043A

I will suggest to avoid SoC specific defines

--prabhakar