All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liming Sun <lsun@mellanox.com>
To: Rob Herring <robh@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC
Date: Tue, 1 May 2018 14:36:06 +0000	[thread overview]
Message-ID: <AM2PR05MB07537F51DC0670BF67E79AD2A1810@AM2PR05MB0753.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180501124800.GA6206@rob-hp-laptop>

Sorry, my mistake. I missed the last one in the v3 comments.
Fixed it in v4 2/3.

Thanks,
Liming

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, May 1, 2018 8:48 AM
> To: Liming Sun <lsun@mellanox.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>; Mark Rutland
> <mark.rutland@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>;
> Catalin Marinas <catalin.marinas@arm.com>; Will Deacon
> <will.deacon@arm.com>; linux-mmc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC
> 
> On Mon, Apr 30, 2018 at 10:51:07AM -0400, Liming Sun wrote:
> > This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver
> > extension on Mellanox BlueField SoC platform.
> >
> > Signed-off-by: Liming Sun <lsun@mellanox.com>
> > ---
> >  .../devicetree/bindings/mmc/bluefield-dw-mshc.txt  | 29
> ++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mmc/bluefield-
> dw-mshc.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/bluefield-dw-
> mshc.txt b/Documentation/devicetree/bindings/mmc/bluefield-dw-
> mshc.txt
> > new file mode 100644
> > index 0000000..ee0dd61
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt
> > @@ -0,0 +1,29 @@
> > +* Mellanox Bluefield SoC specific extensions to the Synopsys Designware
> > +  Mobile Storage Host Controller
> > +
> > +Read synopsys-dw-mshc.txt for more details
> > +
> > +The Synopsys designware mobile storage host controller is used to
> interface
> > +a SoC with storage medium such as eMMC or SD/MMC cards. This file
> documents
> > +differences between the core Synopsys dw mshc controller properties
> described
> > +by synopsys-dw-mshc.txt and the properties used by the Mellanox
> Bluefield SoC
> > +specific extensions to the Synopsys Designware Mobile Storage Host
> Controller.
> > +
> > +Required Properties:
> > +
> > +* compatible: should be one of the following.
> > +  - "mellanox,bluefield-dw-mshc": for controllers with Mellanox Bluefield
> SoC
> > +    specific extensions.
> > +
> > +Example:
> > +
> > +	/* Mellanox Bluefield SoC MMC */
> > +	dwmmc0@4,0 {
> 
> Still the same issues.
> 
> mmc@...
> 
> And the unit-address looks wrong.
> 
> > +		compatible = "mellanox,bluefield-dw-mshc";
> > +		reg = <4 0x8000 0x400>;
> > +		interrupts = <32>;
> > +		fifo-depth = <0x100>;
> > +		clock-frequency = <24000000>;
> > +		bus-width = <8>;
> > +		cap-mmc-highspeed;
> > +	};
> > --
> > 1.8.3.1
> >

  reply	other threads:[~2018-05-01 14:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 15:32 [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-04-23 15:32 ` [PATCH v2 2/3] Documentation: bluefield-dw-mshc: add DT description Liming Sun
2018-04-27 19:50   ` Rob Herring
2018-04-30 14:57     ` Liming Sun
2018-04-23 15:32 ` [PATCH v2 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-04-24  1:11 ` [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension Shawn Lin
2018-05-08 13:06   ` Liming Sun
2018-05-08 18:55   ` Liming Sun
2018-04-30 14:51 ` [PATCH v3 " Liming Sun
2018-04-30 14:51 ` [PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 12:48   ` Rob Herring
2018-05-01 14:36     ` Liming Sun [this message]
2018-04-30 14:51 ` [PATCH v3 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-01 14:32 ` [PATCH v4 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-01 14:32 ` [PATCH v4 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 16:24   ` Rob Herring
2018-05-01 19:10     ` Liming Sun
2018-05-01 14:32 ` [PATCH v4 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-01 18:19 ` [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-02  1:02   ` Shawn Lin
2018-05-02 12:45     ` Liming Sun
2018-05-03  7:25       ` Shawn Lin
2018-05-03 14:35         ` Liming Sun
2018-05-02  8:16   ` Jaehoon Chung
2018-05-03 15:52     ` Liming Sun
2018-05-01 18:19 ` [PATCH v5 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 18:19 ` [PATCH v5 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-03 15:45 ` [PATCH v6 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-03 15:45 ` [PATCH v6 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-03 15:45 ` [PATCH v6 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-08 18:46 ` [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-09  1:45   ` Shawn Lin
2018-05-21 11:36   ` Ulf Hansson
2019-01-18 10:06   ` Thomas Gleixner
2019-01-18 18:14     ` Liming Sun
2018-05-08 18:46 ` [PATCH v7 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-21 11:36   ` Ulf Hansson
2018-05-08 18:46 ` [PATCH v7 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-21 11:36   ` Ulf Hansson
2018-05-21 19:35     ` Liming Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM2PR05MB07537F51DC0670BF67E79AD2A1810@AM2PR05MB0753.eurprd05.prod.outlook.com \
    --to=lsun@mellanox.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.