From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbcI0Fqx (ORCPT ); Tue, 27 Sep 2016 01:46:53 -0400 Received: from mail-db5eur01on0073.outbound.protection.outlook.com ([104.47.2.73]:3360 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750961AbcI0Fqn (ORCPT ); Tue, 27 Sep 2016 01:46:43 -0400 From: Qiang Zhao To: Scott Wood CC: "linuxppc-dev@lists.ozlabs.org" , "pku.leo@gmail.com" , "X.B. Xie" , "linux-kernel@vger.kernel.org" Subject: RE: [v6,2/2] QE: remove PPCisms for QE Thread-Topic: [v6,2/2] QE: remove PPCisms for QE Thread-Index: AQHSFuNMOuwKsTJCKk+lsdjyrD1KeqCJmiIAgAFmmNCAAWgmgIAAQx4g Date: Tue, 27 Sep 2016 03:13:01 +0000 Message-ID: References: <1474597232-33397-2-git-send-email-qiang.zhao@nxp.com> <20160925041411.GA16092@home.buserror.net> <20160925041906.GA16719@home.buserror.net> <1474931495.4283.44.camel@buserror.net> In-Reply-To: <1474931495.4283.44.camel@buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@nxp.com; x-originating-ip: [199.59.230.102] x-ms-office365-filtering-correlation-id: 261d115d-c3c7-4274-2b0c-08d3e6843111 x-microsoft-exchange-diagnostics: 1;HE1PR0401MB2428;7:qu0+iWZEPJ7s60aa9j3ihvKn+mQ6EghchQo0pEM96zrcKU9Y0IiXholQUZiqmbK7SLXS+shS+n5geuHxQq348TwRxiwHZF4fuCCCg5CrmhpQ2MvWmS5W7NF69R+MCpkekPoW0JEWaS0NKODImTT1iPJpkIjmIwKgwm/joOIqODh+9oTG4vBwD9t2bFhNHzhlDp+V3Ahj+OnVLWvF7EiK6vdkreeRjC/q4BEFsOaF9+e1olPD1qWFtHPVlRGJHsZ6mP26izONYwBfq9qwR/fCM8h8hlJQFTaNSdKc+Dc+QG7Ef5p12CzxTtAq0lHtpY6gf4maIjaQc4lN+zaS6u+yHQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0401MB2428; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:HE1PR0401MB2428;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0401MB2428; x-forefront-prvs: 007814487B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(7916002)(24454002)(377424004)(189002)(13464003)(199003)(377454003)(54356999)(50986999)(76176999)(9686002)(2906002)(93886004)(189998001)(3660700001)(74316002)(7846002)(305945005)(7736002)(3280700002)(101416001)(105586002)(68736007)(81156014)(106356001)(106116001)(81166006)(76576001)(6916009)(66066001)(19580395003)(8936002)(345774005)(97736004)(19580405001)(8676002)(33656002)(11100500001)(5660300001)(2950100002)(2900100001)(586003)(7696004)(15975445007)(110136003)(87936001)(5002640100001)(6116002)(4326007)(86362001)(92566002)(5250100002)(102836003)(3846002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0401MB2428;H:AM3PR04MB1185.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2016 03:13:01.9699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2428 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8R5kwEA006688 On Tue, Sep 27, 2016 at 7:12AM -0500, Scott Wood wrote: > -----Original Message----- > From: Scott Wood [mailto:oss@buserror.net] > Sent: Tuesday, September 27, 2016 7:12 AM > To: Qiang Zhao > Cc: linuxppc-dev@lists.ozlabs.org; pku.leo@gmail.com; X.B. Xie > ; linux-kernel@vger.kernel.org > Subject: Re: [v6,2/2] QE: remove PPCisms for QE > > On Mon, 2016-09-26 at 01:46 +0000, Qiang Zhao wrote: > > On Sun, Sep 25, 2016 at 12:19PM -0500, Scott Wood wrote: > > > > > > > > -----Original Message----- > > > From: Scott Wood [mailto:oss@buserror.net] > > > Sent: Sunday, September 25, 2016 12:19 PM > > > To: Qiang Zhao > > > Cc: linuxppc-dev@lists.ozlabs.org; pku.leo@gmail.com; X.B. Xie > > > ; linux-kernel@vger.kernel.org > > > Subject: Re: [v6,2/2] QE: remove PPCisms for QE > > > > > > On Sat, Sep 24, 2016 at 11:14:11PM -0500, Scott Wood wrote: > > > > > > > > On Fri, Sep 23, 2016 at 10:20:32AM +0800, Zhao Qiang wrote: > > > > > > > > > > QE was supported on PowerPC, and dependent on PPC, Now it is > > > > > supported on other platforms. so remove PPCisms. > > > > > > > > > > Signed-off-by: Zhao Qiang > > > > > --- > > > > > Changes for v2: > > > > > - na > > > > > Changes for v3: > > > > > - add NO_IRQ > > > > > Changes for v4: > > > > > - modify spin_event_timeout to opencoded timeout loop > > > > > - remove NO_IRQ > > > > > - modify virq_to_hw to opencoed code Changes for v5: > > > > > - modify commit msg > > > > > - modify depends of QUICC_ENGINE > > > > > - add kerneldoc header for qe_issue_cmd Changes for v6: > > > > > - add dependency on FSL_SOC and PPC32 for drivers > > > > >   depending on QUICC_ENGING but not available on ARM > > > > > > > > > >  drivers/irqchip/qe_ic.c                | 28 +++++++----- > > > > >  drivers/net/ethernet/freescale/Kconfig | 10 ++--- > > > > >  drivers/soc/fsl/qe/Kconfig             |  2 +- > > > > >  drivers/soc/fsl/qe/qe.c                | 80 > > > > > ++++++++++++++++++++----- > > > > > --------- > > > > >  drivers/soc/fsl/qe/qe_io.c             | 42 ++++++++---------- > > > > >  drivers/soc/fsl/qe/qe_tdm.c            |  8 ++-- > > > > >  drivers/soc/fsl/qe/ucc.c               | 10 ++--- > > > > >  drivers/soc/fsl/qe/ucc_fast.c          | 68 > > > > > ++++++++++++++----------- > > > > > ---- > > > > >  drivers/tty/serial/Kconfig             |  2 +- > > > > >  drivers/usb/gadget/udc/Kconfig         |  2 +- > > > > >  drivers/usb/host/Kconfig               |  2 +- > > > > >  include/soc/fsl/qe/qe.h                |  1 - > > > > >  include/soc/fsl/qe/qe_ic.h             | 12 ++--- > > > > >  13 files changed, 141 insertions(+), 126 deletions(-) > > > > I assume this means you'll be updating > > > > http://patchwork.ozlabs.org/patch/654473/ > > > > to be based on top of this... > > > Apparently that assumption was wrong, since I now see that you're > > > patching drivers/irqchip/qe_ic.c rather than drivers/soc/fsl/qe/qe_ic.c. > > > Please keep the drivers/irqchip stuff separate and send to the > > > appropriate maintainers. > > > > > You means separate drivers/irqchip/qe_ic.c part from this patch and > > send it with the other qe_ic patches? > > Is it acceptable if I modify qe_ic.c with drivers/soc/fsl/qe/qe_ic.c, > > then send qe_ic patches to move qe_ic to drivers/irqchip? > > I'd recommend against it.  It would complicate getting the drivers/irqchip > patchset merged.  In any case, it's too late for 4.9. Ok, thank you for your recommend. BR -Zhao Qiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0070.outbound.protection.outlook.com [104.47.2.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sjm9w1rZxzDrKW for ; Tue, 27 Sep 2016 13:13:07 +1000 (AEST) From: Qiang Zhao To: Scott Wood CC: "linuxppc-dev@lists.ozlabs.org" , "pku.leo@gmail.com" , "X.B. Xie" , "linux-kernel@vger.kernel.org" Subject: RE: [v6,2/2] QE: remove PPCisms for QE Date: Tue, 27 Sep 2016 03:13:01 +0000 Message-ID: References: <1474597232-33397-2-git-send-email-qiang.zhao@nxp.com> <20160925041411.GA16092@home.buserror.net> <20160925041906.GA16719@home.buserror.net> <1474931495.4283.44.camel@buserror.net> In-Reply-To: <1474931495.4283.44.camel@buserror.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , T24gVHVlLCBTZXAgMjcsIDIwMTYgYXQgNzoxMkFNIC0wNTAwLCBTY290dCBXb29kIHdyb3RlOg0K DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFNjb3R0IFdvb2QgW21haWx0 bzpvc3NAYnVzZXJyb3IubmV0XQ0KPiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMjcsIDIwMTYg NzoxMiBBTQ0KPiBUbzogUWlhbmcgWmhhbyA8cWlhbmcuemhhb0BueHAuY29tPg0KPiBDYzogbGlu dXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IHBrdS5sZW9AZ21haWwuY29tOyBYLkIuIFhpZQ0K PiA8eGlhb2JvLnhpZUBueHAuY29tPjsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KPiBT dWJqZWN0OiBSZTogW3Y2LDIvMl0gUUU6IHJlbW92ZSBQUENpc21zIGZvciBRRQ0KPiANCj4gT24g TW9uLCAyMDE2LTA5LTI2IGF0IDAxOjQ2ICswMDAwLCBRaWFuZyBaaGFvIHdyb3RlOg0KPiA+IE9u IFN1biwgU2VwIDI1LCAyMDE2IGF0IDEyOjE5UE0gLTA1MDAsIFNjb3R0IFdvb2Qgd3JvdGU6DQo+ ID4NCj4gPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTog U2NvdHQgV29vZCBbbWFpbHRvOm9zc0BidXNlcnJvci5uZXRdDQo+ID4gPiBTZW50OiBTdW5kYXks IFNlcHRlbWJlciAyNSwgMjAxNiAxMjoxOSBQTQ0KPiA+ID4gVG86IFFpYW5nIFpoYW8gPHFpYW5n LnpoYW9AbnhwLmNvbT4NCj4gPiA+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsg cGt1Lmxlb0BnbWFpbC5jb207IFguQi4gWGllDQo+ID4gPiA8eGlhb2JvLnhpZUBueHAuY29tPjsg bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KPiA+ID4gU3ViamVjdDogUmU6IFt2NiwyLzJd IFFFOiByZW1vdmUgUFBDaXNtcyBmb3IgUUUNCj4gPiA+DQo+ID4gPiBPbiBTYXQsIFNlcCAyNCwg MjAxNiBhdCAxMToxNDoxMVBNIC0wNTAwLCBTY290dCBXb29kIHdyb3RlOg0KPiA+ID4gPg0KPiA+ ID4gPiBPbiBGcmksIFNlcCAyMywgMjAxNiBhdCAxMDoyMDozMkFNICswODAwLCBaaGFvIFFpYW5n IHdyb3RlOg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gUUUgd2FzIHN1cHBvcnRlZCBvbiBQb3dlclBD LCBhbmQgZGVwZW5kZW50IG9uIFBQQywgTm93IGl0IGlzDQo+ID4gPiA+ID4gc3VwcG9ydGVkIG9u IG90aGVyIHBsYXRmb3Jtcy4gc28gcmVtb3ZlIFBQQ2lzbXMuDQo+ID4gPiA+ID4NCj4gPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBaaGFvIFFpYW5nIDxxaWFuZy56aGFvQG54cC5jb20+DQo+ID4gPiA+ ID4gLS0tDQo+ID4gPiA+ID4gQ2hhbmdlcyBmb3IgdjI6DQo+ID4gPiA+ID4gCS0gbmENCj4gPiA+ ID4gPiBDaGFuZ2VzIGZvciB2MzoNCj4gPiA+ID4gPiAJLSBhZGQgTk9fSVJRDQo+ID4gPiA+ID4g Q2hhbmdlcyBmb3IgdjQ6DQo+ID4gPiA+ID4gCS0gbW9kaWZ5IHNwaW5fZXZlbnRfdGltZW91dCB0 byBvcGVuY29kZWQgdGltZW91dCBsb29wDQo+ID4gPiA+ID4gCS0gcmVtb3ZlIE5PX0lSUQ0KPiA+ ID4gPiA+IAktIG1vZGlmeSB2aXJxX3RvX2h3IHRvIG9wZW5jb2VkIGNvZGUgQ2hhbmdlcyBmb3Ig djU6DQo+ID4gPiA+ID4gCS0gbW9kaWZ5IGNvbW1pdCBtc2cNCj4gPiA+ID4gPiAJLSBtb2RpZnkg ZGVwZW5kcyBvZiBRVUlDQ19FTkdJTkUNCj4gPiA+ID4gPiAJLSBhZGQga2VybmVsZG9jIGhlYWRl ciBmb3IgcWVfaXNzdWVfY21kIENoYW5nZXMgZm9yIHY2Og0KPiA+ID4gPiA+IAktIGFkZCBkZXBl bmRlbmN5IG9uIEZTTF9TT0MgYW5kIFBQQzMyIGZvciBkcml2ZXJzDQo+ID4gPiA+ID4gCcKgwqBk ZXBlbmRpbmcgb24gUVVJQ0NfRU5HSU5HIGJ1dCBub3QgYXZhaWxhYmxlIG9uIEFSTQ0KPiA+ID4g PiA+DQo+ID4gPiA+ID4gwqBkcml2ZXJzL2lycWNoaXAvcWVfaWMuY8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgfCAyOCArKysrKysrLS0tLS0NCj4gPiA+ID4gPiDCoGRyaXZlcnMvbmV0 L2V0aGVybmV0L2ZyZWVzY2FsZS9LY29uZmlnIHwgMTAgKystLS0NCj4gPiA+ID4gPiDCoGRyaXZl cnMvc29jL2ZzbC9xZS9LY29uZmlnwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8wqDCoDIgKy0N Cj4gPiA+ID4gPiDCoGRyaXZlcnMvc29jL2ZzbC9xZS9xZS5jwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqB8IDgwDQo+ID4gPiA+ID4gKysrKysrKysrKysrKysrKysrKystLS0tLQ0KPiA+ ID4gPiA+IC0tLS0tLS0tLQ0KPiA+ID4gPiA+IMKgZHJpdmVycy9zb2MvZnNsL3FlL3FlX2lvLmPC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwgNDIgKysrKysrKystLS0tLS0tLS0tDQo+ID4gPiA+ ID4gwqBkcml2ZXJzL3NvYy9mc2wvcWUvcWVfdGRtLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8 wqDCoDggKystLQ0KPiA+ID4gPiA+IMKgZHJpdmVycy9zb2MvZnNsL3FlL3VjYy5jwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgfCAxMCArKy0tLQ0KPiA+ID4gPiA+IMKgZHJpdmVycy9zb2Mv ZnNsL3FlL3VjY19mYXN0LmPCoMKgwqDCoMKgwqDCoMKgwqDCoHwgNjgNCj4gPiA+ID4gPiArKysr KysrKysrKysrKy0tLS0tLS0tLS0tDQo+ID4gPiA+ID4gLS0tLQ0KPiA+ID4gPiA+IMKgZHJpdmVy cy90dHkvc2VyaWFsL0tjb25maWfCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgMiArLQ0K PiA+ID4gPiA+IMKgZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9LY29uZmlnwqDCoMKgwqDCoMKgwqDC oMKgfMKgwqAyICstDQo+ID4gPiA+ID4gwqBkcml2ZXJzL3VzYi9ob3N0L0tjb25maWfCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8wqDCoDIgKy0NCj4gPiA+ID4gPiDCoGluY2x1ZGUvc29j L2ZzbC9xZS9xZS5owqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8wqDCoDEgLQ0KPiA+ ID4gPiA+IMKgaW5jbHVkZS9zb2MvZnNsL3FlL3FlX2ljLmjCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoHwgMTIgKystLS0NCj4gPiA+ID4gPiDCoDEzIGZpbGVzIGNoYW5nZWQsIDE0MSBpbnNlcnRp b25zKCspLCAxMjYgZGVsZXRpb25zKC0pDQo+ID4gPiA+IEkgYXNzdW1lIHRoaXMgbWVhbnMgeW91 J2xsIGJlIHVwZGF0aW5nDQo+ID4gPiA+IGh0dHA6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRj aC82NTQ0NzMvDQo+ID4gPiA+IHRvIGJlIGJhc2VkIG9uIHRvcCBvZiB0aGlzLi4uDQo+ID4gPiBB cHBhcmVudGx5IHRoYXQgYXNzdW1wdGlvbiB3YXMgd3JvbmcsIHNpbmNlIEkgbm93IHNlZSB0aGF0 IHlvdSdyZQ0KPiA+ID4gcGF0Y2hpbmcgZHJpdmVycy9pcnFjaGlwL3FlX2ljLmMgcmF0aGVyIHRo YW4gZHJpdmVycy9zb2MvZnNsL3FlL3FlX2ljLmMuDQo+ID4gPiBQbGVhc2Uga2VlcCB0aGUgZHJp dmVycy9pcnFjaGlwIHN0dWZmIHNlcGFyYXRlIGFuZCBzZW5kIHRvIHRoZQ0KPiA+ID4gYXBwcm9w cmlhdGUgbWFpbnRhaW5lcnMuDQo+ID4gPg0KPiA+IFlvdSBtZWFucyBzZXBhcmF0ZSBkcml2ZXJz L2lycWNoaXAvcWVfaWMuYyBwYXJ0IGZyb20gdGhpcyBwYXRjaCBhbmQNCj4gPiBzZW5kIGl0IHdp dGggdGhlIG90aGVyIHFlX2ljIHBhdGNoZXM/DQo+ID4gSXMgaXQgYWNjZXB0YWJsZSBpZiBJIG1v ZGlmeSBxZV9pYy5jIHdpdGggZHJpdmVycy9zb2MvZnNsL3FlL3FlX2ljLmMsDQo+ID4gdGhlbiBz ZW5kIHFlX2ljIHBhdGNoZXMgdG8gbW92ZSBxZV9pYyB0byBkcml2ZXJzL2lycWNoaXA/DQo+IA0K PiBJJ2QgcmVjb21tZW5kIGFnYWluc3QgaXQuIMKgSXQgd291bGQgY29tcGxpY2F0ZSBnZXR0aW5n IHRoZSBkcml2ZXJzL2lycWNoaXANCj4gcGF0Y2hzZXQgbWVyZ2VkLiDCoEluIGFueSBjYXNlLCBp dCdzIHRvbyBsYXRlIGZvciA0LjkuDQoNCk9rLCB0aGFuayB5b3UgZm9yIHlvdXIgcmVjb21tZW5k Lg0KDQpCUg0KLVpoYW8gUWlhbmcNCg==