From mboxrd@z Thu Jan 1 00:00:00 1970 From: "A.s. Dong" Subject: RE: [PATCH V4 1/7] dt-bindings: pinctrl: extend the pinmux property to support integers array Date: Thu, 22 Jun 2017 14:35:02 +0000 Message-ID: References: <1498046395-30001-1-git-send-email-aisheng.dong@nxp.com> <1498046395-30001-2-git-send-email-aisheng.dong@nxp.com> <20170621215059.GA14826@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ve1eur01on0070.outbound.protection.outlook.com ([104.47.1.70]:57952 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750812AbdFVOfG (ORCPT ); Thu, 22 Jun 2017 10:35:06 -0400 In-Reply-To: <20170621215059.GA14826@w540> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: jmondi Cc: "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linus.walleij@linaro.org" , "shawnguo@kernel.org" , "stefan@agner.ch" , Jacky Bai , Andy Duan , "kernel@pengutronix.de" , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , Jacopo Mondi SGkgSmFjb3BvLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IGptb25k aSBbbWFpbHRvOmphY29wb0BqbW9uZGkub3JnXQ0KPiBTZW50OiBUaHVyc2RheSwgSnVuZSAyMiwg MjAxNyA1OjUxIEFNDQo+IFRvOiBBLnMuIERvbmcNCj4gQ2M6IGxpbnV4LWdwaW9Admdlci5rZXJu ZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7DQo+IGxpbnVzLndh bGxlaWpAbGluYXJvLm9yZzsgc2hhd25ndW9Aa2VybmVsLm9yZzsgc3RlZmFuQGFnbmVyLmNoOyBK YWNreSBCYWk7DQo+IEFuZHkgRHVhbjsga2VybmVsQHBlbmd1dHJvbml4LmRlOyBSb2IgSGVycmlu ZzsgTWFyayBSdXRsYW5kOw0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgSmFjb3BvIE1v bmRpDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggVjQgMS83XSBkdC1iaW5kaW5nczogcGluY3RybDog ZXh0ZW5kIHRoZSBwaW5tdXgNCj4gcHJvcGVydHkgdG8gc3VwcG9ydCBpbnRlZ2VycyBhcnJheQ0K PiANCj4gSGkgRG9uZywNCj4gICAgdGhhbmtzIGZvciB0aGlzDQo+IA0KPiBPbiBXZWQsIEp1biAy MSwgMjAxNyBhdCAwNzo1OTo0OVBNICswODAwLCBEb25nIEFpc2hlbmcgd3JvdGU6DQo+ID4gU29t ZSBwbGF0Zm9ybXMgbWF5IG5lZWQgbW9yZSB0aGFuIG9uZSBpbnRlZ2VyIHRvIHJlcHJlc2VudCBh IGNvbXBsZXRlDQo+ID4gcGlubXV4IGJpbmRpbmcsIHNvIGxldCdzIGV4dGVuZCB0aGUgcGlubXV4 IHByb3BlcnR5IHRvIGFsbG93IHRvIGFjY2VwdA0KPiA+IGludGVnZXIgYXJyYXkgaW5zdGVhZCBv ZiBvbmx5IGEgc2luZ2xlIGludGVnZXIuDQo+ID4NCj4gPiBDYzogUm9iIEhlcnJpbmcgPHJvYmgr ZHRAa2VybmVsLm9yZz4NCj4gPiBDYzogTWFyayBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNv bT4NCj4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmcNCj4gPiBDYzogTGludXMgV2Fs bGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPg0KPiA+IENjOiBTaGF3biBHdW8gPHNoYXdu Z3VvQGtlcm5lbC5vcmc+DQo+ID4gQ2M6IEphY29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1v bmRpLm9yZz4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBEb25nIEFpc2hlbmcgPGFpc2hlbmcuZG9uZ0Bu eHAuY29tPg0KPiA+DQo+ID4gLS0tDQo+ID4gQ2hhbmdlTG9nOg0KPiA+ICAqIG5ldyBwYXRjaA0K PiA+IC0tLQ0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGluY3RybC9w aW5jdHJsLWJpbmRpbmdzLnR4dCB8IDkNCj4gPiArKysrKy0tLS0NCj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQN Cj4gPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waW5jdHJsL3BpbmN0cmwt YmluZGluZ3MudHh0DQo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGlu Y3RybC9waW5jdHJsLWJpbmRpbmdzLnR4dA0KPiA+IGluZGV4IGYwMWQxNTQuLjFiOTU0YjUgMTAw NjQ0DQo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BpbmN0cmwv cGluY3RybC1iaW5kaW5ncy50eHQNCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvcGluY3RybC9waW5jdHJsLWJpbmRpbmdzLnR4dA0KPiA+IEBAIC0yMDUsMTAgKzIw NSwxMSBAQCBtYWludGFpbi4NCj4gPg0KPiA+ICBGb3IgY2FzZXMgbGlrZSB0aGlzLCB0aGUgcGlu IGNvbnRyb2xsZXIgZHJpdmVyIG1heSB1c2UgdGhlIHBpbm11eA0KPiA+IGhlbHBlciAgcHJvcGVy dHksIHdoZXJlIHRoZSBwaW4gaWRlbnRpZmllciBpcyBwYWNrZWQgd2l0aCBtdXgNCj4gPiBjb25m aWd1cmF0aW9uIHNldHRpbmdzIC1pbiBhIHNpbmdsZSBpbnRlZ2VyLg0KPiA+ICtpbiBhIHNpbmds ZSBpbnRlZ2VyIG9yIGludGVnZXJzIGFycmF5IHdoaWNoIGRlcGVuZHMgb24gcGxhdGZvcm0NCj4g PiArYmluZGluZyBzcGVjaWZpYy4NCj4gPg0KPiANCj4gcy9vciBpbnRlZ2VycyBhcnJheS9vciBh IGdyb3VwIG9mIGludGVnZXJzLyBzaW5jZSB5b3UncmUgdXNpbmcgImdyb3VwIg0KPiBiZWxvdw0K PiANCj4gcy8gd2hpY2ggZGVwZW5kcyBvbiBwbGF0Zm9ybSBiaW5kaW5nIHNwZWNpZmljLy8NCj4g DQo+IEknbSBub3QgYSBuYXRpdmUgc3BlYWtlciwgYnV0IHRoaXMgc291bmRzIHdlaXJkIHRvIG1l LiBJZiBJJ20gdGhlIG9ubHkgb25lLA0KPiBwbGVhc2UgaWdub3JlIG15IGNvbW1lbnQgb3RoZXJ3 aXNlIHBsZWFzZSBkcm9wIHRoaXMNCj4gDQo+IEFjdHVhbGx5LCB0byBhdm9pZCBjb25mdXNpb24g YmV0d2VlbiAiYXJyYXkgb2YgaW50ZWdlcnMiIGFuZCAiZ3JvdXAgb2YNCj4gaW50ZWdlcnMiIEkg d291bGQgcHJvdmlkZSBhIGRlZmluaXRpb24gb2Ygd2hhdCBhICJwaW5tdXggZ3JvdXAiIGlzIGJl Zm9yZQ0KPiBldmVyeXRoaW5nIGVsc2UuDQo+IFRoaXMgaXMgaG93IHRoZSBwYXJhZ3JhcGggd291 bGQgbG9vayBsaWtlOg0KPiANCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gLS0tDQo+ICBGb3IgY2Fz ZXMgbGlrZSB0aGlzLCB0aGUgcGluIGNvbnRyb2xsZXIgZHJpdmVyIG1heSB1c2UgdGhlIHBpbm11 eCBoZWxwZXINCj4gcHJvcGVydHksIHdoZXJlIHRoZSBwaW4gaWRlbnRpZmllciBpcyBwcm92aWRl ZCB3aXRoIG11eCBjb25maWd1cmF0aW9uDQo+IHNldHRpbmdzICBpbiBhIHBpbm11eCBncm91cC4N Cj4gDQo+ICBBIHBpbnVtdXggZ3JvdXAgY29uc2lzdHMgb2YgdGhlIHBpbiBpZGVudGlmaWVyIGFu ZCBtdXggc2V0dGluZ3MNCj4gcmVwcmVzZW50ZWQgYXMgYSBzaW5nbGUgaW50ZWdlciBvciBhbiBh cnJheSBvZiBpbnRlZ2Vycy4NCj4gDQo+ICBUaGUgcGlubXV4IHByb3BlcnR5IGFjY2VwdHMgYW4g YXJyYXkgb2YgcGlubXV4IGdyb3VwcywgZWFjaCBvZiB0aGVtDQo+IGRlc2NyaWJpbmcgIGEgc2lu Z2xlIHBpbiBtdWx0aXBsZXhpbmcgY29uZmlndXJhdGlvbi4NCj4gDQo+ICBwaW5jb250cm9sbGVy IHsNCj4gCXN0YXRlXzBfbm9kZV9hIHsNCj4gCQlwaW5tdXggPSA8UElOTVVYX0dST1VQPiwgPFBJ Tk1VWF9HUk9VUD4sIC4uLjsNCj4gCX07DQo+ICB9Ow0KPiANCj4gIEVhY2ggaW5kaXZpZHVhbCBw aW4gY29udHJvbGxlciBkcml2ZXIgYmluZGluZ3MgZG9jdW1lbnRhdGlvbiBzaGFsbA0KPiBzcGVj aWZ5ICBob3cgcGluIElEcyBhbmQgcGluIG11bHRpcGxleGluZyBjb25maWd1cmF0aW9uIGFyZSBk ZWZpbmVkIGFuZA0KPiBhc3NlbWJsZWQgdG9nZXRoZXIgIGluIGEgcGlubXV4IGdyb3VwLg0KPiAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQ0KPiAtLS0NCg0KVGhpcyBkb2VzIGxvb2sgbXVjaCBiZXR0ZXIuDQpJ IHdpbGwgcmVuZXcgdGhlIHBhdGNoIHdpdGggeW91ciBzaWduLW9mZiBhcyB3ZWxsIHNpbmNlIGl0 IG1vc3RseSBmcm9tIHlvdS4NClRoYW5rcyBmb3IgdGhlIGdyZWF0IHN1Z2dlc3Rpb24uDQoNClJl Z2FyZHMNCkRvbmcgQWlzaGVuZw0KDQo+IA0KPiBUaGFua3MNCj4gICAgag0KPiANCj4gPiAtVGhl IHBpbm11eCBwcm9wZXJ0eSBhY2NlcHRzIGFuIGFycmF5IG9mIGludGVnZXJzLCBlYWNoIG9mIHRo ZW0NCj4gPiBkZXNjcmliaW5nIC1hIHNpbmdsZSBwaW4gbXVsdGlwbGV4aW5nIGNvbmZpZ3VyYXRp b24uDQo+ID4gK1RoZSBwaW5tdXggcHJvcGVydHkgYWNjZXB0cyBhbiBhcnJheSBvZiBncm91cCBv ZiBpbnRlZ2VycywgZWFjaCBncm91cA0KPiA+ICtkZXNjcmliaW5nIGEgc2luZ2xlIHBpbiBtdWx0 aXBsZXhpbmcgY29uZmlndXJhdGlvbi4NCj4gPg0KPiA+ICBwaW5jb250cm9sbGVyIHsNCj4gPiAg CXN0YXRlXzBfbm9kZV9hIHsNCj4gPiBAQCAtMzAwLDcgKzMwMSw3IEBAIGFyZ3VtZW50cyBhcmUg ZGVzY3JpYmVkIGJlbG93Lg0KPiA+ICAtIHBpbm11eCB0YWtlcyBhIGxpc3Qgb2YgcGluIElEcyBh bmQgbXV4IHNldHRpbmdzIGFzIHJlcXVpcmVkIGFyZ3VtZW50Lg0KPiBUaGUNCj4gPiAgICBzcGVj aWZpYyBiaW5kaW5ncyBmb3IgdGhlIGhhcmR3YXJlIGRlZmluZXM6DQo+ID4gICAgLSBIb3cgcGlu IElEcyBhbmQgbXV4IHNldHRpbmdzIGFyZSBkZWZpbmVkIGFuZCBhc3NlbWJsZWQgdG9nZXRoZXIg aW4NCj4gYSBzaW5nbGUNCj4gPiAtICAgIGludGVnZXIuDQo+ID4gKyAgICBpbnRlZ2VyIG9yIGlu dGVnZXJzIGFycmF5Lg0KPiA+DQo+ID4gIC0gYmlhcy1wdWxsLXVwLCAtZG93biBhbmQgLXBpbi1k ZWZhdWx0IHRha2UgYXMgb3B0aW9uYWwgYXJndW1lbnQgb24NCj4gaGFyZHdhcmUNCj4gPiAgICBz dXBwb3J0aW5nIGl0IHRoZSBwdWxsIHN0cmVuZ3RoIGluIE9obS4gYmlhcy1kaXNhYmxlIHdpbGwg ZGlzYWJsZSB0aGUNCj4gcHVsbC4NCj4gPiAtLQ0KPiA+IDIuNy40DQo+ID4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong@nxp.com (A.s. Dong) Date: Thu, 22 Jun 2017 14:35:02 +0000 Subject: [PATCH V4 1/7] dt-bindings: pinctrl: extend the pinmux property to support integers array In-Reply-To: <20170621215059.GA14826@w540> References: <1498046395-30001-1-git-send-email-aisheng.dong@nxp.com> <1498046395-30001-2-git-send-email-aisheng.dong@nxp.com> <20170621215059.GA14826@w540> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jacopo, > -----Original Message----- > From: jmondi [mailto:jacopo at jmondi.org] > Sent: Thursday, June 22, 2017 5:51 AM > To: A.s. Dong > Cc: linux-gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org; > linus.walleij at linaro.org; shawnguo at kernel.org; stefan at agner.ch; Jacky Bai; > Andy Duan; kernel at pengutronix.de; Rob Herring; Mark Rutland; > devicetree at vger.kernel.org; Jacopo Mondi > Subject: Re: [PATCH V4 1/7] dt-bindings: pinctrl: extend the pinmux > property to support integers array > > Hi Dong, > thanks for this > > On Wed, Jun 21, 2017 at 07:59:49PM +0800, Dong Aisheng wrote: > > Some platforms may need more than one integer to represent a complete > > pinmux binding, so let's extend the pinmux property to allow to accept > > integer array instead of only a single integer. > > > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: devicetree at vger.kernel.org > > Cc: Linus Walleij > > Cc: Shawn Guo > > Cc: Jacopo Mondi > > Signed-off-by: Dong Aisheng > > > > --- > > ChangeLog: > > * new patch > > --- > > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 9 > > +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > index f01d154..1b954b5 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > @@ -205,10 +205,11 @@ maintain. > > > > For cases like this, the pin controller driver may use the pinmux > > helper property, where the pin identifier is packed with mux > > configuration settings -in a single integer. > > +in a single integer or integers array which depends on platform > > +binding specific. > > > > s/or integers array/or a group of integers/ since you're using "group" > below > > s/ which depends on platform binding specific// > > I'm not a native speaker, but this sounds weird to me. If I'm the only one, > please ignore my comment otherwise please drop this > > Actually, to avoid confusion between "array of integers" and "group of > integers" I would provide a definition of what a "pinmux group" is before > everything else. > This is how the paragraph would look like: > > -------------------------------------------------------------------------- > --- > For cases like this, the pin controller driver may use the pinmux helper > property, where the pin identifier is provided with mux configuration > settings in a pinmux group. > > A pinumux group consists of the pin identifier and mux settings > represented as a single integer or an array of integers. > > The pinmux property accepts an array of pinmux groups, each of them > describing a single pin multiplexing configuration. > > pincontroller { > state_0_node_a { > pinmux = , , ...; > }; > }; > > Each individual pin controller driver bindings documentation shall > specify how pin IDs and pin multiplexing configuration are defined and > assembled together in a pinmux group. > -------------------------------------------------------------------------- > --- This does look much better. I will renew the patch with your sign-off as well since it mostly from you. Thanks for the great suggestion. Regards Dong Aisheng > > Thanks > j > > > -The pinmux property accepts an array of integers, each of them > > describing -a single pin multiplexing configuration. > > +The pinmux property accepts an array of group of integers, each group > > +describing a single pin multiplexing configuration. > > > > pincontroller { > > state_0_node_a { > > @@ -300,7 +301,7 @@ arguments are described below. > > - pinmux takes a list of pin IDs and mux settings as required argument. > The > > specific bindings for the hardware defines: > > - How pin IDs and mux settings are defined and assembled together in > a single > > - integer. > > + integer or integers array. > > > > - bias-pull-up, -down and -pin-default take as optional argument on > hardware > > supporting it the pull strength in Ohm. bias-disable will disable the > pull. > > -- > > 2.7.4 > >