All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shahar Salzman <shahar.salzman at kaminario.com>
To: spdk@lists.01.org
Subject: [SPDK] Building spdk on CentOS6
Date: Sun, 22 Apr 2018 13:40:45 +0000	[thread overview]
Message-ID: <AM3PR04MB3704B43C81A6ECA5EFDEE05898A0@AM3PR04MB370.eurprd04.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

Hi,


Finally got to looking at support of spdk build on CentOS6, things look good, except for one issue.

spdk is latest 18.01.x version, dpdk is 16.07 (+3 dpdk patches to allow compilation) and some minor patches (mainly some memory configuration stuff), kernel is a patched 4.9.6.


build succeeded except for the usage of the dpdk function pci_vfio_is_enabled.

I had to apply the patch bellow, removing the usage of this function and then compilation completed without any issues.


It seems that I am missing some sort of dpdk configuration as I see that the function is built, but not packaged into the generated archive.


I went back to square one and ran the instructions in http://www.spdk.io/doc/getting_started.html, but I see no mention of dpdk there. Actually the ./configure requires it.


My next step is to use a more recent dpdk, but shouldn't this work with my version? Am I missing some dpdk configuration?

BTW, as we are not using vhost, on our 17.07 version we simply use CONFIG_VHOST=n in order to skip this, but I would be happier if we used a better solution.


Shahar

P.S. Here is the patch to remove use of this function:
diff --git a/lib/env_dpdk/vtophys.c b/lib/env_dpdk/vtophys.c
index 92aa256..f38929f 100644
--- a/lib/env_dpdk/vtophys.c
+++ b/lib/env_dpdk/vtophys.c
@@ -53,8 +53,10 @@
 #define SPDK_VFIO_ENABLED 1
 #include <linux/vfio.h>

+#if 0
 /* Internal DPDK function forward declaration */
 int pci_vfio_is_enabled(void);
+#endif

 struct spdk_vfio_dma_map {
        struct vfio_iommu_type1_dma_map map;
@@ -341,9 +343,11 @@ spdk_vtophys_iommu_init(void)
        DIR *dir;
        struct dirent *d;

+#if 0
        if (!pci_vfio_is_enabled()) {
                return;
        }
+#endif

        dir = opendir("/proc/self/fd");
        if (!dir) {



[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 4539 bytes --]

             reply	other threads:[~2018-04-22 13:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 13:40 Shahar Salzman [this message]
2018-04-23 18:40 [SPDK] Building spdk on CentOS6 Verkamp, Daniel
2018-04-24  6:57 Shahar Salzman
2018-04-24 12:40 Shahar Salzman
2018-05-08 12:23 Shahar Salzman
2018-05-08 12:56 Wodkowski, PawelX
2018-05-08 13:25 Luse, Paul E
2018-05-08 14:04 Shahar Salzman
2018-05-08 14:14 Luse, Paul E
2018-05-08 14:34 Shahar Salzman
2018-05-08 14:41 Luse, Paul E
2018-05-08 16:49 Walker, Benjamin
2018-05-09  9:00 Shahar Salzman
2018-05-09 12:51 Luse, Paul E
2018-05-09 13:11 Shahar Salzman
2018-05-09 16:43 Verkamp, Daniel
2018-05-09 17:19 Luse, Paul E
2018-05-10 13:39 Shahar Salzman
2018-05-10 17:31 Verkamp, Daniel
2018-05-13  8:44 Shahar Salzman
2018-08-24 22:00 Gyan Prakash
2018-08-24 22:23 Walker, Benjamin
2018-08-24 22:25 Harris, James R
2018-08-24 23:38 Gyan Prakash
2018-08-24 23:40 Gyan Prakash
2018-08-24 23:41 Harris, James R
2018-08-24 23:50 Gyan Prakash
2018-08-25  0:14 Harris, James R
2018-08-27 20:42 Gyan Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR04MB3704B43C81A6ECA5EFDEE05898A0@AM3PR04MB370.eurprd04.prod.outlook.com \
    --to=spdk@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.