From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacky Bai Subject: RE: [PATCH 2/3] devicetree: bindings: nvmem: Add compatible string for imx6ul Date: Tue, 15 Nov 2016 07:25:01 +0000 Message-ID: References: <1478497281-5477-1-git-send-email-ping.bai@nxp.com> <1478497281-5477-2-git-send-email-ping.bai@nxp.com> <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "srinivas.kandagatla@linaro.org" , "kernel@pengutronix.de" , Fabio Estevam , "maxime.ripard@free-electrons.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > > Add new compatible string for i.MX6UL SOC. > > > > Signed-off-by: Bai Ping > > --- > > Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > index 383d588..a7ff65d 100644 > > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > @@ -1,13 +1,14 @@ > > Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings > > > > This binding represents the on-chip eFuse OTP controller found on > > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs. > > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs. > > > > Required properties: > > - compatible: should be one of > > "fsl,imx6q-ocotp" (i.MX6Q/D/DL/S), > > - "fsl,imx6sl-ocotp" (i.MX6SL), or > > - "fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon". > > + "fsl,imx6sl-ocotp" (i.MX6SL), > > + "fsl,imx6sx-ocotp" (i.MX6SX), or > > + "fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon". > > This should be reformatted such that it's not a 5 line change to add a > compatible. "one of" defines this is an OR relationship, so drop that. > Move 'followed by "syscon"' to below the list of compatibles. > Thanks for review, I will adopt in V2. Jacky Bai > > - reg: Should contain the register base and length. > > - clocks: Should contain a phandle pointing to the gated peripheral clock. > > > > -- > > 2.8.2 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: ping.bai@nxp.com (Jacky Bai) Date: Tue, 15 Nov 2016 07:25:01 +0000 Subject: [PATCH 2/3] devicetree: bindings: nvmem: Add compatible string for imx6ul In-Reply-To: <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop> References: <1478497281-5477-1-git-send-email-ping.bai@nxp.com> <1478497281-5477-2-git-send-email-ping.bai@nxp.com> <20161114161423.fs7dlt5firmj4q3s@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > Add new compatible string for i.MX6UL SOC. > > > > Signed-off-by: Bai Ping > > --- > > Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > index 383d588..a7ff65d 100644 > > --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt > > @@ -1,13 +1,14 @@ > > Freescale i.MX6 On-Chip OTP Controller (OCOTP) device tree bindings > > > > This binding represents the on-chip eFuse OTP controller found on > > -i.MX6Q/D, i.MX6DL/S, i.MX6SL, and i.MX6SX SoCs. > > +i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX and i.MX6UL SoCs. > > > > Required properties: > > - compatible: should be one of > > "fsl,imx6q-ocotp" (i.MX6Q/D/DL/S), > > - "fsl,imx6sl-ocotp" (i.MX6SL), or > > - "fsl,imx6sx-ocotp" (i.MX6SX), followed by "syscon". > > + "fsl,imx6sl-ocotp" (i.MX6SL), > > + "fsl,imx6sx-ocotp" (i.MX6SX), or > > + "fsl,imx6ul-ocotp" (i.MX6UL), followed by "syscon". > > This should be reformatted such that it's not a 5 line change to add a > compatible. "one of" defines this is an OR relationship, so drop that. > Move 'followed by "syscon"' to below the list of compatibles. > Thanks for review, I will adopt in V2. Jacky Bai > > - reg: Should contain the register base and length. > > - clocks: Should contain a phandle pointing to the gated peripheral clock. > > > > -- > > 2.8.2 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel