All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzeminski, Marcin (Nokia - PL/Wroclaw)" <marcin.krzeminski@nokia.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "crosthwaitepeter@gmail.com" <crosthwaitepeter@gmail.com>,
	"pawel.lenkow@itlen.com" <pawel.lenkow@itlen.com>,
	"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
	"clg@fr.ibm.com" <clg@fr.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 08/10] m25p80: Fast read commands family changes.
Date: Fri, 24 Jun 2016 07:53:38 +0000	[thread overview]
Message-ID: <AM3PR07MB0629A754A8F09460618EAA58FE2E0@AM3PR07MB0629.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <b68dada4-8821-02c1-4fea-505b6c4ba734@kaod.org>



> -----Original Message-----
> From: Cédric Le Goater [mailto:clg@kaod.org]
> Sent: Friday, June 17, 2016 2:31 PM
> To: Krzeminski, Marcin (Nokia - PL/Wroclaw)
> <marcin.krzeminski@nokia.com>; qemu-devel@nongnu.org
> Cc: crosthwaitepeter@gmail.com; pawel.lenkow@itlen.com;
> peter.maydell@linaro.org; clg@fr.ibm.com
> Subject: Re: [PATCH v2 08/10] m25p80: Fast read commands family changes.
> 
> On 06/17/2016 12:28 PM, marcin.krzeminski@nokia.com wrote:
> > From: Marcin Krzeminski <marcin.krzeminski@nokia.com>
> >
> > Support for Spansion and Macronix flashes.
> > Additionally Numonyx(Micron) moved from default in fast read commands
> > family. Also moved fast read command decoding to functions.
> >
> > Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com>
> 
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> 
> Thanks, it looks better.
> 
> C.
> 
> > ---
> >  hw/block/m25p80.c | 145
> > ++++++++++++++++++++++++++++++++++++++++--------------
> >  1 file changed, 108 insertions(+), 37 deletions(-)
> >
> > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index
> > 21998db..f40fa99 100644
> > --- a/hw/block/m25p80.c
> > +++ b/hw/block/m25p80.c
> > @@ -719,6 +719,111 @@ static void reset_memory(Flash *s)
> >      DB_PRINT_L(0, "Reset done.\n");
> >  }
> >
> > +static void decode_fast_read_cmd(Flash *s) {
> > +    s->needed_bytes = get_addr_length(s);
> > +    switch (get_man(s)) {
> > +    /* Dummy cycles - modeled with bytes writes instead of bits */
> > +    case MAN_NUMONYX:
> > +        s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > +        break;
> > +    case MAN_MACRONIX:
> > +        if (extract32(s->volatile_cfg, 6, 2) == 1) {
> > +            s->needed_bytes += 6;
> > +        } else {
> > +            s->needed_bytes += 8;
> > +        }
> > +        break;
> > +    case MAN_SPANSION:
> > +        s->needed_bytes += extract32(s->spansion_cr2v,
> > +                                    SPANSION_DUMMY_CLK_POS,
> > +                                    SPANSION_DUMMY_CLK_LEN
> > +                                    );
> > +        break;
> > +    default:
> > +        break;
> > +    }
> > +    s->pos = 0;
> > +    s->len = 0;
> > +    s->state = STATE_COLLECTING_DATA; }
> > +
> > +static void decode_dio_read_cmd(Flash *s) {
> > +    s->needed_bytes = get_addr_length(s);
> > +    /* Dummy cycles modeled with bytes writes instead of bits */
> > +    switch (get_man(s)) {
> > +    case MAN_WINBOND:
> > +        s->needed_bytes = 4;
> > +        break;
> > +    case MAN_SPANSION:
> > +        s->needed_bytes += extract32(s->spansion_cr2v,
> > +                                    SPANSION_DUMMY_CLK_POS,
> > +                                    SPANSION_DUMMY_CLK_LEN
> > +                                    );
Here and in QuadIO function handling of read mode bytes is missing.
I will add it in v3.
Thanks for review.

Regards,
Marcin
> > +        break;
> > +    case MAN_NUMONYX:
> > +        s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > +        break;
> > +    case MAN_MACRONIX:
> > +        switch (extract32(s->volatile_cfg, 6, 2)) {
> > +        case 1:
> > +            s->needed_bytes += 6;
> > +            break;
> > +        case 2:
> > +            s->needed_bytes += 8;
> > +            break;
> > +        default:
> > +            s->needed_bytes += 4;
> > +            break;
> > +        }
> > +        break;
> > +    default:
> > +        break;
> > +    }
> > +    s->pos = 0;
> > +    s->len = 0;
> > +    s->state = STATE_COLLECTING_DATA; }
> > +
> > +static void decode_qio_read_cmd(Flash *s) {
> > +    s->needed_bytes = get_addr_length(s);
> > +    /* Dummy cycles modeled with bytes writes instead of bits */
> > +    switch (get_man(s)) {
> > +    case MAN_WINBOND:
> > +        s->needed_bytes = 6;
> > +        break;
> > +    case MAN_SPANSION:
> > +        s->needed_bytes += extract32(s->spansion_cr2v,
> > +                                    SPANSION_DUMMY_CLK_POS,
> > +                                    SPANSION_DUMMY_CLK_LEN
> > +                                    );
> > +        break;
> > +    case MAN_NUMONYX:
> > +        s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > +        break;
> > +    case MAN_MACRONIX:
> > +        switch (extract32(s->volatile_cfg, 6, 2)) {
> > +        case 1:
> > +            s->needed_bytes += 4;
> > +            break;
> > +        case 2:
> > +            s->needed_bytes += 8;
> > +            break;
> > +        default:
> > +            s->needed_bytes += 6;
> > +            break;
> > +        }
> > +        break;
> > +    default:
> > +        break;
> > +    }
> > +    s->pos = 0;
> > +    s->len = 0;
> > +    s->state = STATE_COLLECTING_DATA; }
> > +
> >  static void decode_new_cmd(Flash *s, uint32_t value)  {
> >      s->cmd_in_progress = value;
> > @@ -756,51 +861,17 @@ static void decode_new_cmd(Flash *s, uint32_t
> value)
> >      case DOR4:
> >      case QOR:
> >      case QOR4:
> > -        s->needed_bytes = get_addr_length(s);
> > -        switch (get_man(s)) {
> > -        case MAN_NUMONYX:
> > -            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > -            break;
> > -        default:
> > -            break;
> > -        }
> > -        s->pos = 0;
> > -        s->len = 0;
> > -        s->state = STATE_COLLECTING_DATA;
> > +        decode_fast_read_cmd(s);
> >          break;
> >
> >      case DIOR:
> >      case DIOR4:
> > -        switch (get_man(s)) {
> > -        case MAN_WINBOND:
> > -        case MAN_SPANSION:
> > -            s->needed_bytes = 4;
> > -            break;
> > -        default:
> > -            s->needed_bytes = get_addr_length(s);
> > -            /* Dummy cycles modeled with bytes writes instead of bits */
> > -            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > -        }
> > -        s->pos = 0;
> > -        s->len = 0;
> > -        s->state = STATE_COLLECTING_DATA;
> > +        decode_dio_read_cmd(s);
> >          break;
> >
> >      case QIOR:
> >      case QIOR4:
> > -        switch (get_man(s)) {
> > -        case MAN_WINBOND:
> > -        case MAN_SPANSION:
> > -            s->needed_bytes = 6;
> > -            break;
> > -        default:
> > -            s->needed_bytes = get_addr_length(s);
> > -            /* Dummy cycles modeled with bytes writes instead of bits */
> > -            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
> > -        }
> > -        s->pos = 0;
> > -        s->len = 0;
> > -        s->state = STATE_COLLECTING_DATA;
> > +        decode_qio_read_cmd(s);
> >          break;
> >
> >      case WRSR:
> >

  reply	other threads:[~2016-06-24  7:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 10:28 [Qemu-devel] [PATCH v2 00/10] m25p80: Add new 512Mbit and 1Gbit devices marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 01/10] m25p80: Replace JEDEC ID masking with function marcin.krzeminski
2016-06-17 12:19   ` Cédric Le Goater
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 02/10] m25p80: Make a table for JEDEC ID marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 03/10] m25p80: Allow more than four banks marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 04/10] m25p80: Introduce COLLECTING_VAR_LEN_DATA state marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 05/10] m25p80: Add additional flash commands: marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 06/10] m25p80: Introduce quad and equad modes marcin.krzeminski
2016-06-17 12:33   ` Cédric Le Goater
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 07/10] m25p80: Introduce configuration registers marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 08/10] m25p80: Fast read commands family changes marcin.krzeminski
2016-06-17 12:30   ` Cédric Le Goater
2016-06-24  7:53     ` Krzeminski, Marcin (Nokia - PL/Wroclaw) [this message]
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 09/10] m25p80: New flash devices marcin.krzeminski
2016-06-17 10:28 ` [Qemu-devel] [PATCH v2 10/10] m25p80.c: Fix WINBOND fast read command handling marcin.krzeminski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR07MB0629A754A8F09460618EAA58FE2E0@AM3PR07MB0629.eurprd07.prod.outlook.com \
    --to=marcin.krzeminski@nokia.com \
    --cc=clg@fr.ibm.com \
    --cc=clg@kaod.org \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pawel.lenkow@itlen.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.