All of lore.kernel.org
 help / color / mirror / Atom feed
From: york sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2][v2] driver: net: ldpaa_eth: Add support of PHY framework
Date: Fri, 18 Mar 2016 16:25:09 +0000	[thread overview]
Message-ID: <AM4PR0401MB17324218589D5ACF91BA41789A8C0@AM4PR0401MB1732.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1456313531-14536-1-git-send-email-prabhakar.kushwaha@nxp.com

On 02/24/2016 03:32 AM, Prabhakar Kushwaha wrote:
> This patch integrate DPAA2 ethernet driver existing PHY framework.
> 
> Call phy_connect and phy_config as per available DPMAC id defined
> in SerDes Protcol.
> 
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> Changes for v2: Incorporated Joe Hershberger's comments
> 

Since Joe didn't comment on this version, I presume he is OK with this one.

<snip>

> @@ -914,15 +970,12 @@ static int ldpaa_eth_netdev_init(struct eth_device *net_dev,
>  	net_dev->halt = ldpaa_eth_stop;
>  	net_dev->send = ldpaa_eth_tx;
>  	net_dev->recv = ldpaa_eth_pull_dequeue_rx;
> -/*
> -	TODO: PHY MDIO information
> -	priv->bus = info->bus;
> -	priv->phyaddr = info->phy_addr;
> -	priv->enet_if = info->enet_if;
> -*/
>  
> -	if (init_phy(net_dev))
> -		return 0;
> +#ifdef CONFIG_PHYLIB
> +	err = init_phy(net_dev); 

Extra white space at the end of line. No need to respin. I can fix this when
merging.

> +	if (err < 0)
> +		return err;
> +#endif
>  
>  	err = eth_register(net_dev);
>  	if (err < 0) {
> 

York

  parent reply	other threads:[~2016-03-18 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 11:32 [U-Boot] [PATCH 1/2][v2] driver: net: ldpaa_eth: Add support of PHY framework Prabhakar Kushwaha
2016-03-08  2:36 ` Prabhakar Kushwaha
2016-03-18 16:25 ` york sun [this message]
2016-03-22 15:43 ` york sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR0401MB17324218589D5ACF91BA41789A8C0@AM4PR0401MB1732.eurprd04.prod.outlook.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.