All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config
@ 2017-01-04 18:32 York Sun
  2017-01-14 17:13 ` Simon Glass
  2017-01-19 17:38 ` [U-Boot] " york sun
  0 siblings, 2 replies; 4+ messages in thread
From: York Sun @ 2017-01-04 18:32 UTC (permalink / raw)
  To: u-boot

Without a prompt in Kconfig, SECURE_BOOT cannot be selected by
defconfig. The option was dropped unintentionally when defconfig
files were cleaned up. Three targets were impacted
ls1043ardb_SECURE_BOOT, ls2080ardb_SECURE_BOOT,
ls2080aqds_SECURE_BOOT.

Signed-off-by: York Sun <york.sun@nxp.com>

---

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 +-
 configs/ls1043ardb_SECURE_BOOT_defconfig  | 1 +
 configs/ls2080aqds_SECURE_BOOT_defconfig  | 1 +
 configs/ls2080ardb_SECURE_BOOT_defconfig  | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
index cc0dc88..b78db03 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
@@ -93,7 +93,7 @@ config NUM_DDR_CONTROLLERS
 	default 1
 
 config SECURE_BOOT
-	bool
+	bool "Secure Boot"
 	help
 		Enable Freescale Secure Boot feature
 
diff --git a/configs/ls1043ardb_SECURE_BOOT_defconfig b/configs/ls1043ardb_SECURE_BOOT_defconfig
index ae2efeb..3f2e0db 100644
--- a/configs/ls1043ardb_SECURE_BOOT_defconfig
+++ b/configs/ls1043ardb_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1043ARDB=y
+CONFIG_SECURE_BOOT=y
 CONFIG_SYS_FSL_DDR4=y
 CONFIG_DEFAULT_DEVICE_TREE="fsl-ls1043a-rdb"
 CONFIG_FIT=y
diff --git a/configs/ls2080aqds_SECURE_BOOT_defconfig b/configs/ls2080aqds_SECURE_BOOT_defconfig
index 1ed6e05..358457e 100644
--- a/configs/ls2080aqds_SECURE_BOOT_defconfig
+++ b/configs/ls2080aqds_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS2080AQDS=y
+CONFIG_SECURE_BOOT=y
 CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-qds"
 # CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
diff --git a/configs/ls2080ardb_SECURE_BOOT_defconfig b/configs/ls2080ardb_SECURE_BOOT_defconfig
index 848abbc..1f13f6c 100644
--- a/configs/ls2080ardb_SECURE_BOOT_defconfig
+++ b/configs/ls2080ardb_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS2080ARDB=y
+CONFIG_SECURE_BOOT=y
 CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb"
 # CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config
  2017-01-04 18:32 [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config York Sun
@ 2017-01-14 17:13 ` Simon Glass
  2017-01-16 22:09   ` york sun
  2017-01-19 17:38 ` [U-Boot] " york sun
  1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2017-01-14 17:13 UTC (permalink / raw)
  To: u-boot

On 4 January 2017 at 11:32, York Sun <york.sun@nxp.com> wrote:
> Without a prompt in Kconfig, SECURE_BOOT cannot be selected by
> defconfig. The option was dropped unintentionally when defconfig
> files were cleaned up. Three targets were impacted
> ls1043ardb_SECURE_BOOT, ls2080ardb_SECURE_BOOT,
> ls2080aqds_SECURE_BOOT.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
>
> ---
>
>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 +-
>  configs/ls1043ardb_SECURE_BOOT_defconfig  | 1 +
>  configs/ls2080aqds_SECURE_BOOT_defconfig  | 1 +
>  configs/ls2080ardb_SECURE_BOOT_defconfig  | 1 +
>  4 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

It might be worth pointing to your README in the Kconfig help.

- Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config
  2017-01-14 17:13 ` Simon Glass
@ 2017-01-16 22:09   ` york sun
  0 siblings, 0 replies; 4+ messages in thread
From: york sun @ 2017-01-16 22:09 UTC (permalink / raw)
  To: u-boot

On 01/14/2017 09:13 AM, Simon Glass wrote:
> On 4 January 2017 at 11:32, York Sun <york.sun@nxp.com> wrote:
>> Without a prompt in Kconfig, SECURE_BOOT cannot be selected by
>> defconfig. The option was dropped unintentionally when defconfig
>> files were cleaned up. Three targets were impacted
>> ls1043ardb_SECURE_BOOT, ls2080ardb_SECURE_BOOT,
>> ls2080aqds_SECURE_BOOT.
>>
>> Signed-off-by: York Sun <york.sun@nxp.com>
>>
>> ---
>>
>>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 +-
>>  configs/ls1043ardb_SECURE_BOOT_defconfig  | 1 +
>>  configs/ls2080aqds_SECURE_BOOT_defconfig  | 1 +
>>  configs/ls2080ardb_SECURE_BOOT_defconfig  | 1 +
>>  4 files changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> It might be worth pointing to your README in the Kconfig help.

You meant the README for secure boot, didn't you? I wish there is such file.

York

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] armv8: fsl-layerscape: Fix SECURE_BOOT config
  2017-01-04 18:32 [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config York Sun
  2017-01-14 17:13 ` Simon Glass
@ 2017-01-19 17:38 ` york sun
  1 sibling, 0 replies; 4+ messages in thread
From: york sun @ 2017-01-19 17:38 UTC (permalink / raw)
  To: u-boot

On 01/04/2017 10:32 AM, York Sun wrote:
> Without a prompt in Kconfig, SECURE_BOOT cannot be selected by
> defconfig. The option was dropped unintentionally when defconfig
> files were cleaned up. Three targets were impacted
> ls1043ardb_SECURE_BOOT, ls2080ardb_SECURE_BOOT,
> ls2080aqds_SECURE_BOOT.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---

Applied to fsl-qoriq master, awaiting upstream.

York

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-19 17:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-04 18:32 [U-Boot] [PATCH] armv8: fsl-layerscape: Fix SECURE_BOOT config York Sun
2017-01-14 17:13 ` Simon Glass
2017-01-16 22:09   ` york sun
2017-01-19 17:38 ` [U-Boot] " york sun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.