[U-Boot] [PATCH 3/5][v2] armv8: fsl-layerscape : Check SVR for initializing TZASC

[york sun <york.sun@nxp.com>]

On 10/24/2016 01:33 AM, Priyanka Jain wrote:
> LS2080 SoC and its personalities does not support TZASC
> But other new SoCs like LS2088A, LS1088A supports TASC
>
> Hence, skip initializing TZASC for Ls2080A based on SVR
>
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> ---
>  arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S       |   19 ++++++++++++++++++-
>  .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |    4 ++++
>  arch/arm/include/asm/arch-fsl-layerscape/soc.h     |    6 ++++++
>  3 files changed, 28 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S b/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S
> index 3274cad..82b7696 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S
> @@ -10,6 +10,8 @@
>  #include <linux/linkage.h>
>  #include <asm/gic.h>
>  #include <asm/macro.h>
> +#include <asm/arch-fsl-layerscape/immap_lsch3.h>
> +#include <asm/arch-fsl-layerscape/soc.h>
>  #ifdef CONFIG_MP
>  #include <asm/arch/mp.h>
>  #endif
> @@ -137,6 +139,15 @@ ENTRY(lowlevel_init)
>  #endif
>
>  #ifdef CONFIG_FSL_TZASC_400
> +	bl	svr_dev_id		/* get high 16 bits of SVR */
> +	/*
> +	 * LS2080 and its personalities does not support TZASC
> +	 * So skip TZASC related operations
> +	 */
> +	ldr	x1, =SVR_DEV_LS2080A
> +	cmp	x0, x1

It will be better to consolidate the get_svr() function to implemente in 
assembly code.

> +	b.eq	1f
> +

Please clarify, before this patch the code runs through this section for 
LS2080A but actually it has no effect, correct?

York