All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-22 14:27 ` Leonard Crestez
  0 siblings, 0 replies; 16+ messages in thread
From: Leonard Crestez @ 2017-03-22 14:27 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer
  Cc: Leonard Crestez, linux-arm-kernel, Fabio Estevam, Fugang Duan,
	Octavian Purdila, Florian Fainelli, linux-kernel

The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
Add this driver to the default imx config since the device is present on
one of the evaluation boards.

This used to work mostly fine with the generic phy driver but since
commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
performs a soft reset on startup. This causes netboot to sometimes
timeout on DHCP because RX doesn't work right. DHCP is eventually retried and
it works the second time but it takes 90+ seconds to get a login prompt.

This was generated with "make savedefconfig" and it includes a few
additional minor cleanups.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---

I also tried to do some debugging in the fec driver and it apparently receives
corrupted packets when this happens. If I hack it to go into promiscuous mode
unconditionally it gets a whole bunch of rx errors (crc errors, length errors
and so on). So the phy config is probably wrong and is confusing the mac?

In theory it might be possible to make that driver "just work" with phy
settings from uboot but it's not clear it's worthwhile.

 arch/arm/configs/imx_v6_v7_defconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index eaba3b1..e605389 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
 # CONFIG_NET_VENDOR_STMICRO is not set
 CONFIG_AT803X_PHY=y
 CONFIG_MICREL_PHY=y
+CONFIG_SMSC_PHY=y
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m
 CONFIG_USB_RTL8152=m
@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
 CONFIG_WL12XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
-# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
 CONFIG_INPUT_EVDEV=y
 CONFIG_INPUT_EVBUG=m
 CONFIG_KEYBOARD_GPIO=y
@@ -376,7 +376,6 @@ CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_ISO8859_15=m
 CONFIG_NLS_UTF8=y
 CONFIG_PRINTK_TIME=y
-CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_PROVE_LOCKING=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-22 14:27 ` Leonard Crestez
  0 siblings, 0 replies; 16+ messages in thread
From: Leonard Crestez @ 2017-03-22 14:27 UTC (permalink / raw)
  To: linux-arm-kernel

The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
Add this driver to the default imx config since the device is present on
one of the evaluation boards.

This used to work mostly fine with the generic phy driver but since
commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
performs a soft reset on startup. This causes netboot to sometimes
timeout on DHCP because RX doesn't work right. DHCP is eventually retried and
it works the second time but it takes 90+ seconds to get a login prompt.

This was generated with "make savedefconfig" and it includes a few
additional minor cleanups.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---

I also tried to do some debugging in the fec driver and it apparently receives
corrupted packets when this happens. If I hack it to go into promiscuous mode
unconditionally it gets a whole bunch of rx errors (crc errors, length errors
and so on). So the phy config is probably wrong and is confusing the mac?

In theory it might be possible to make that driver "just work" with phy
settings from uboot but it's not clear it's worthwhile.

 arch/arm/configs/imx_v6_v7_defconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index eaba3b1..e605389 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
 # CONFIG_NET_VENDOR_STMICRO is not set
 CONFIG_AT803X_PHY=y
 CONFIG_MICREL_PHY=y
+CONFIG_SMSC_PHY=y
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m
 CONFIG_USB_RTL8152=m
@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
 CONFIG_WL12XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
-# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
 CONFIG_INPUT_EVDEV=y
 CONFIG_INPUT_EVBUG=m
 CONFIG_KEYBOARD_GPIO=y
@@ -376,7 +376,6 @@ CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_ISO8859_15=m
 CONFIG_NLS_UTF8=y
 CONFIG_PRINTK_TIME=y
-CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_PROVE_LOCKING=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-22 14:27 ` Leonard Crestez
@ 2017-03-22 15:28   ` Fabio Estevam
  -1 siblings, 0 replies; 16+ messages in thread
From: Fabio Estevam @ 2017-03-22 15:28 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Shawn Guo, Sascha Hauer, Florian Fainelli, Fugang Duan,
	linux-kernel, Octavian Purdila, Fabio Estevam, linux-arm-kernel

On Wed, Mar 22, 2017 at 11:27 AM, Leonard Crestez
<leonard.crestez@nxp.com> wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.
>
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer

The prefer format when referring to a commit is:
0878fff1f42c  ("net: phy: Do not perform software reset for Generic PHY")

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-22 15:28   ` Fabio Estevam
  0 siblings, 0 replies; 16+ messages in thread
From: Fabio Estevam @ 2017-03-22 15:28 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Mar 22, 2017 at 11:27 AM, Leonard Crestez
<leonard.crestez@nxp.com> wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.
>
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer

The prefer format when referring to a commit is:
0878fff1f42c  ("net: phy: Do not perform software reset for Generic PHY")

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-22 14:27 ` Leonard Crestez
@ 2017-03-22 21:09   ` Florian Fainelli
  -1 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2017-03-22 21:09 UTC (permalink / raw)
  To: Leonard Crestez, Shawn Guo, Sascha Hauer
  Cc: linux-arm-kernel, Fabio Estevam, Fugang Duan, Octavian Purdila,
	linux-kernel

On 03/22/2017 07:27 AM, Leonard Crestez wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.
> 
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> performs a soft reset on startup. This causes netboot to sometimes
> timeout on DHCP because RX doesn't work right. DHCP is eventually retried and
> it works the second time but it takes 90+ seconds to get a login prompt.
> 
> This was generated with "make savedefconfig" and it includes a few
> additional minor cleanups.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-22 21:09   ` Florian Fainelli
  0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2017-03-22 21:09 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/22/2017 07:27 AM, Leonard Crestez wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.
> 
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> performs a soft reset on startup. This causes netboot to sometimes
> timeout on DHCP because RX doesn't work right. DHCP is eventually retried and
> it works the second time but it takes 90+ seconds to get a login prompt.
> 
> This was generated with "make savedefconfig" and it includes a few
> additional minor cleanups.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-22 14:27 ` Leonard Crestez
@ 2017-03-23  1:17   ` Andy Duan
  -1 siblings, 0 replies; 16+ messages in thread
From: Andy Duan @ 2017-03-23  1:17 UTC (permalink / raw)
  To: Leonard Crestez, Shawn Guo, Sascha Hauer
  Cc: Leonard Crestez, linux-arm-kernel, Fabio Estevam,
	Octavian Purdila, Florian Fainelli, linux-kernel

From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Wednesday, March 22, 2017 10:28 PM
>To: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
><kernel@pengutronix.de>
>Cc: Leonard Crestez <leonard.crestez@nxp.com>; linux-arm-
>kernel@lists.infradead.org; Fabio Estevam <fabio.estevam@nxp.com>; Andy
>Duan <fugang.duan@nxp.com>; Octavian Purdila
><octavian.purdila@nxp.com>; Florian Fainelli <f.fainelli@gmail.com>; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
>
>The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
>Add this driver to the default imx config since the device is present on one of
>the evaluation boards.
>
>This used to work mostly fine with the generic phy driver but since commit
>0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer performs a
>soft reset on startup. This causes netboot to sometimes timeout on DHCP
>because RX doesn't work right. DHCP is eventually retried and it works the
>second time but it takes 90+ seconds to get a login prompt.
>
>This was generated with "make savedefconfig" and it includes a few additional
>minor cleanups.
>
>Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>---
>
>I also tried to do some debugging in the fec driver and it apparently receives
>corrupted packets when this happens. If I hack it to go into promiscuous mode
>unconditionally it gets a whole bunch of rx errors (crc errors, length errors and
>so on). So the phy config is probably wrong and is confusing the mac?
>
>In theory it might be possible to make that driver "just work" with phy settings
>from uboot but it's not clear it's worthwhile.
>
> arch/arm/configs/imx_v6_v7_defconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/arch/arm/configs/imx_v6_v7_defconfig
>b/arch/arm/configs/imx_v6_v7_defconfig
>index eaba3b1..e605389 100644
>--- a/arch/arm/configs/imx_v6_v7_defconfig
>+++ b/arch/arm/configs/imx_v6_v7_defconfig
>@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
> # CONFIG_NET_VENDOR_STMICRO is not set
> CONFIG_AT803X_PHY=y
> CONFIG_MICREL_PHY=y
>+CONFIG_SMSC_PHY=y
> CONFIG_USB_PEGASUS=m
> CONFIG_USB_RTL8150=m
> CONFIG_USB_RTL8152=m
>@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
> CONFIG_WL12XX=m
> CONFIG_WLCORE_SDIO=m
> # CONFIG_WILINK_PLATFORM_DATA is not set -#
>CONFIG_INPUT_MOUSEDEV_PSAUX is not set  CONFIG_INPUT_EVDEV=y
>CONFIG_INPUT_EVBUG=m  CONFIG_KEYBOARD_GPIO=y @@ -376,7 +376,6
>@@ CONFIG_NLS_ISO8859_1=y  CONFIG_NLS_ISO8859_15=m
>CONFIG_NLS_UTF8=y  CONFIG_PRINTK_TIME=y -CONFIG_DEBUG_FS=y
>CONFIG_MAGIC_SYSRQ=y  # CONFIG_SCHED_DEBUG is not set
>CONFIG_PROVE_LOCKING=y
>--
>2.7.4

Acked-by: Fugang Duan <fugang.duan@nxp.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-23  1:17   ` Andy Duan
  0 siblings, 0 replies; 16+ messages in thread
From: Andy Duan @ 2017-03-23  1:17 UTC (permalink / raw)
  To: linux-arm-kernel

From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Wednesday, March 22, 2017 10:28 PM
>To: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
><kernel@pengutronix.de>
>Cc: Leonard Crestez <leonard.crestez@nxp.com>; linux-arm-
>kernel at lists.infradead.org; Fabio Estevam <fabio.estevam@nxp.com>; Andy
>Duan <fugang.duan@nxp.com>; Octavian Purdila
><octavian.purdila@nxp.com>; Florian Fainelli <f.fainelli@gmail.com>; linux-
>kernel at vger.kernel.org
>Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
>
>The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
>Add this driver to the default imx config since the device is present on one of
>the evaluation boards.
>
>This used to work mostly fine with the generic phy driver but since commit
>0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer performs a
>soft reset on startup. This causes netboot to sometimes timeout on DHCP
>because RX doesn't work right. DHCP is eventually retried and it works the
>second time but it takes 90+ seconds to get a login prompt.
>
>This was generated with "make savedefconfig" and it includes a few additional
>minor cleanups.
>
>Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>---
>
>I also tried to do some debugging in the fec driver and it apparently receives
>corrupted packets when this happens. If I hack it to go into promiscuous mode
>unconditionally it gets a whole bunch of rx errors (crc errors, length errors and
>so on). So the phy config is probably wrong and is confusing the mac?
>
>In theory it might be possible to make that driver "just work" with phy settings
>from uboot but it's not clear it's worthwhile.
>
> arch/arm/configs/imx_v6_v7_defconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/arch/arm/configs/imx_v6_v7_defconfig
>b/arch/arm/configs/imx_v6_v7_defconfig
>index eaba3b1..e605389 100644
>--- a/arch/arm/configs/imx_v6_v7_defconfig
>+++ b/arch/arm/configs/imx_v6_v7_defconfig
>@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
> # CONFIG_NET_VENDOR_STMICRO is not set
> CONFIG_AT803X_PHY=y
> CONFIG_MICREL_PHY=y
>+CONFIG_SMSC_PHY=y
> CONFIG_USB_PEGASUS=m
> CONFIG_USB_RTL8150=m
> CONFIG_USB_RTL8152=m
>@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
> CONFIG_WL12XX=m
> CONFIG_WLCORE_SDIO=m
> # CONFIG_WILINK_PLATFORM_DATA is not set -#
>CONFIG_INPUT_MOUSEDEV_PSAUX is not set  CONFIG_INPUT_EVDEV=y
>CONFIG_INPUT_EVBUG=m  CONFIG_KEYBOARD_GPIO=y @@ -376,7 +376,6
>@@ CONFIG_NLS_ISO8859_1=y  CONFIG_NLS_ISO8859_15=m
>CONFIG_NLS_UTF8=y  CONFIG_PRINTK_TIME=y -CONFIG_DEBUG_FS=y
>CONFIG_MAGIC_SYSRQ=y  # CONFIG_SCHED_DEBUG is not set
>CONFIG_PROVE_LOCKING=y
>--
>2.7.4

Acked-by: Fugang Duan <fugang.duan@nxp.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-22 14:27 ` Leonard Crestez
@ 2017-03-24  6:43   ` Dong Aisheng
  -1 siblings, 0 replies; 16+ messages in thread
From: Dong Aisheng @ 2017-03-24  6:43 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Shawn Guo, Sascha Hauer, linux-arm-kernel, Fabio Estevam,
	Fugang Duan, Octavian Purdila, Florian Fainelli, linux-kernel

Hi Leonard,

On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.

Upstream currently no evaluation board support.

This may leave to Shawn to decide whether apply it.

> 
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer

I guess you should get a checkpatch error here.

> performs a soft reset on startup. This causes netboot to sometimes
> timeout on DHCP because RX doesn't work right. DHCP is eventually retried and

Probably another checkpatch warning.

> it works the second time but it takes 90+ seconds to get a login prompt.
> 
> This was generated with "make savedefconfig" and it includes a few
> additional minor cleanups.
> 

It is a bit strange, after apply your patch, i still get a lot difference
as follows when savedefconfig:
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index bb6fa56..64e5f4b 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -163,9 +163,9 @@ CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_INPUT_TOUCHSCREEN=y
 CONFIG_TOUCHSCREEN_ADS7846=y
 CONFIG_TOUCHSCREEN_EGALAX=y
+CONFIG_TOUCHSCREEN_MAX11801=y
 CONFIG_TOUCHSCREEN_IMX6UL_TSC=y
 CONFIG_TOUCHSCREEN_EDT_FT5X06=y
-CONFIG_TOUCHSCREEN_MAX11801=y
 CONFIG_TOUCHSCREEN_MC13783=y
 CONFIG_TOUCHSCREEN_TSC2004=y
 CONFIG_TOUCHSCREEN_TSC2007=y
@@ -174,7 +174,6 @@ CONFIG_TOUCHSCREEN_SX8654=y
 CONFIG_TOUCHSCREEN_COLIBRI_VF50=y
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_MMA8450=y
-CONFIG_HID_MULTITOUCH=y
 CONFIG_SERIO_SERPORT=m
 # CONFIG_LEGACY_PTYS is not set
 CONFIG_SERIAL_IMX=y
@@ -268,6 +267,7 @@ CONFIG_SND_SOC_CS42XX8_I2C=y
 CONFIG_SND_SOC_TLV320AIC3X=y
 CONFIG_SND_SOC_WM8960=y
 CONFIG_SND_SIMPLE_CARD=y
+CONFIG_HID_MULTITOUCH=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_MXC=y

I don't know what's wrong. Toolchains difference?
Quite strange...

Regards
Dong Aisheng

> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> 
> I also tried to do some debugging in the fec driver and it apparently receives
> corrupted packets when this happens. If I hack it to go into promiscuous mode
> unconditionally it gets a whole bunch of rx errors (crc errors, length errors
> and so on). So the phy config is probably wrong and is confusing the mac?
> 
> In theory it might be possible to make that driver "just work" with phy
> settings from uboot but it's not clear it's worthwhile.
> 
>  arch/arm/configs/imx_v6_v7_defconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index eaba3b1..e605389 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
>  # CONFIG_NET_VENDOR_STMICRO is not set
>  CONFIG_AT803X_PHY=y
>  CONFIG_MICREL_PHY=y
> +CONFIG_SMSC_PHY=y
>  CONFIG_USB_PEGASUS=m
>  CONFIG_USB_RTL8150=m
>  CONFIG_USB_RTL8152=m
> @@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
>  CONFIG_WL12XX=m
>  CONFIG_WLCORE_SDIO=m
>  # CONFIG_WILINK_PLATFORM_DATA is not set
> -# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_INPUT_EVBUG=m
>  CONFIG_KEYBOARD_GPIO=y
> @@ -376,7 +376,6 @@ CONFIG_NLS_ISO8859_1=y
>  CONFIG_NLS_ISO8859_15=m
>  CONFIG_NLS_UTF8=y
>  CONFIG_PRINTK_TIME=y
> -CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  # CONFIG_SCHED_DEBUG is not set
>  CONFIG_PROVE_LOCKING=y
> -- 
> 2.7.4
> 

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-24  6:43   ` Dong Aisheng
  0 siblings, 0 replies; 16+ messages in thread
From: Dong Aisheng @ 2017-03-24  6:43 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Leonard,

On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> Add this driver to the default imx config since the device is present on
> one of the evaluation boards.

Upstream currently no evaluation board support.

This may leave to Shawn to decide whether apply it.

> 
> This used to work mostly fine with the generic phy driver but since
> commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer

I guess you should get a checkpatch error here.

> performs a soft reset on startup. This causes netboot to sometimes
> timeout on DHCP because RX doesn't work right. DHCP is eventually retried and

Probably another checkpatch warning.

> it works the second time but it takes 90+ seconds to get a login prompt.
> 
> This was generated with "make savedefconfig" and it includes a few
> additional minor cleanups.
> 

It is a bit strange, after apply your patch, i still get a lot difference
as follows when savedefconfig:
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index bb6fa56..64e5f4b 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -163,9 +163,9 @@ CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_INPUT_TOUCHSCREEN=y
 CONFIG_TOUCHSCREEN_ADS7846=y
 CONFIG_TOUCHSCREEN_EGALAX=y
+CONFIG_TOUCHSCREEN_MAX11801=y
 CONFIG_TOUCHSCREEN_IMX6UL_TSC=y
 CONFIG_TOUCHSCREEN_EDT_FT5X06=y
-CONFIG_TOUCHSCREEN_MAX11801=y
 CONFIG_TOUCHSCREEN_MC13783=y
 CONFIG_TOUCHSCREEN_TSC2004=y
 CONFIG_TOUCHSCREEN_TSC2007=y
@@ -174,7 +174,6 @@ CONFIG_TOUCHSCREEN_SX8654=y
 CONFIG_TOUCHSCREEN_COLIBRI_VF50=y
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_MMA8450=y
-CONFIG_HID_MULTITOUCH=y
 CONFIG_SERIO_SERPORT=m
 # CONFIG_LEGACY_PTYS is not set
 CONFIG_SERIAL_IMX=y
@@ -268,6 +267,7 @@ CONFIG_SND_SOC_CS42XX8_I2C=y
 CONFIG_SND_SOC_TLV320AIC3X=y
 CONFIG_SND_SOC_WM8960=y
 CONFIG_SND_SIMPLE_CARD=y
+CONFIG_HID_MULTITOUCH=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_MXC=y

I don't know what's wrong. Toolchains difference?
Quite strange...

Regards
Dong Aisheng

> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> 
> I also tried to do some debugging in the fec driver and it apparently receives
> corrupted packets when this happens. If I hack it to go into promiscuous mode
> unconditionally it gets a whole bunch of rx errors (crc errors, length errors
> and so on). So the phy config is probably wrong and is confusing the mac?
> 
> In theory it might be possible to make that driver "just work" with phy
> settings from uboot but it's not clear it's worthwhile.
> 
>  arch/arm/configs/imx_v6_v7_defconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index eaba3b1..e605389 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -143,6 +143,7 @@ CONFIG_SMSC911X=y
>  # CONFIG_NET_VENDOR_STMICRO is not set
>  CONFIG_AT803X_PHY=y
>  CONFIG_MICREL_PHY=y
> +CONFIG_SMSC_PHY=y
>  CONFIG_USB_PEGASUS=m
>  CONFIG_USB_RTL8150=m
>  CONFIG_USB_RTL8152=m
> @@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m
>  CONFIG_WL12XX=m
>  CONFIG_WLCORE_SDIO=m
>  # CONFIG_WILINK_PLATFORM_DATA is not set
> -# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_INPUT_EVBUG=m
>  CONFIG_KEYBOARD_GPIO=y
> @@ -376,7 +376,6 @@ CONFIG_NLS_ISO8859_1=y
>  CONFIG_NLS_ISO8859_15=m
>  CONFIG_NLS_UTF8=y
>  CONFIG_PRINTK_TIME=y
> -CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  # CONFIG_SCHED_DEBUG is not set
>  CONFIG_PROVE_LOCKING=y
> -- 
> 2.7.4
> 

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-24  6:43   ` Dong Aisheng
@ 2017-03-28 11:16     ` Leonard Crestez
  -1 siblings, 0 replies; 16+ messages in thread
From: Leonard Crestez @ 2017-03-28 11:16 UTC (permalink / raw)
  To: Dong Aisheng
  Cc: Shawn Guo, Sascha Hauer, linux-arm-kernel, Fabio Estevam,
	Fugang Duan, Octavian Purdila, Florian Fainelli, linux-kernel

On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> Hi Leonard,
> 
> On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > 
> > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > Add this driver to the default imx config since the device is present on
> > one of the evaluation boards.
> Upstream currently no evaluation board support.
> 
> This may leave to Shawn to decide whether apply it.

Really? But the dts for this eval board is included in upstream. Shouldn't the
default config try to work with the default imx*.dts files included?

> > This used to work mostly fine with the generic phy driver but since
> > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> I guess you should get a checkpatch error here.

Because I didn't reference that other commit right? Sorry about this.

Should I submit again with an improved commit message?

> > performs a soft reset on startup. This causes netboot to sometimes
> > timeout on DHCP because RX doesn't work right. DHCP is eventually retried
> > and
> Probably another checkpatch warning.

Why, line too long?

> > This was generated with "make savedefconfig" and it includes a few
> > additional minor cleanups.
> > 
> It is a bit strange, after apply your patch, i still get a lot difference
> as follows when savedefconfig:
> 
> I don't know what's wrong. Toolchains difference?

Maybe, kconfig acts strangely sometimes. It's not clear option ordering is
guaranteed to be stable. I don't think it matters though.

--
Regards,
Leonard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-28 11:16     ` Leonard Crestez
  0 siblings, 0 replies; 16+ messages in thread
From: Leonard Crestez @ 2017-03-28 11:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> Hi Leonard,
> 
> On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > 
> > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > Add this driver to the default imx config since the device is present on
> > one of the evaluation boards.
> Upstream currently no evaluation board support.
> 
> This may leave to Shawn to decide whether apply it.

Really? But the dts for this eval board is included in upstream. Shouldn't the
default config try to work with the default imx*.dts files included?

> > This used to work mostly fine with the generic phy driver but since
> > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> I guess you should get a checkpatch error here.

Because I didn't reference that other commit right? Sorry about this.

Should I submit again with an improved commit message?

> > performs a soft reset on startup. This causes netboot to sometimes
> > timeout on DHCP because RX doesn't work right. DHCP is eventually retried
> > and
> Probably another checkpatch warning.

Why, line too long?

> > This was generated with "make savedefconfig" and it includes a few
> > additional minor cleanups.
> > 
> It is a bit strange, after apply your patch, i still get a lot difference
> as follows when savedefconfig:
>?
> I don't know what's wrong. Toolchains difference?

Maybe, kconfig acts strangely sometimes. It's not clear option ordering is
guaranteed to be stable. I don't think it matters though.

--
Regards,
Leonard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-28 11:16     ` Leonard Crestez
@ 2017-03-29  2:57       ` Shawn Guo
  -1 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2017-03-29  2:57 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Dong Aisheng, Sascha Hauer, linux-arm-kernel, Fabio Estevam,
	Fugang Duan, Octavian Purdila, Florian Fainelli, linux-kernel

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 
> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?

Yes, please, and make sure that checkpatch.pl is happy about the patch.

Shawn

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-29  2:57       ` Shawn Guo
  0 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2017-03-29  2:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 
> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?

Yes, please, and make sure that checkpatch.pl is happy about the patch.

Shawn

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
  2017-03-28 11:16     ` Leonard Crestez
@ 2017-03-30  6:47       ` Dong Aisheng
  -1 siblings, 0 replies; 16+ messages in thread
From: Dong Aisheng @ 2017-03-30  6:47 UTC (permalink / raw)
  To: Leonard Crestez
  Cc: Shawn Guo, Sascha Hauer, linux-arm-kernel, Fabio Estevam,
	Fugang Duan, Octavian Purdila, Florian Fainelli, linux-kernel

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 

Oh.. i saw the board wrong, sorry for the noise.

Regards
Dong Aisheng

> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?
> 
> > > performs a soft reset on startup. This causes netboot to sometimes
> > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried
> > > and
> > Probably another checkpatch warning.
> 
> Why, line too long?
> 
> > > This was generated with "make savedefconfig" and it includes a few
> > > additional minor cleanups.
> > > 
> > It is a bit strange, after apply your patch, i still get a lot difference
> > as follows when savedefconfig:
> > 
> > I don't know what's wrong. Toolchains difference?
> 
> Maybe, kconfig acts strangely sometimes. It's not clear option ordering is
> guaranteed to be stable. I don't think it matters though.
> 
> --
> Regards,
> Leonard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
@ 2017-03-30  6:47       ` Dong Aisheng
  0 siblings, 0 replies; 16+ messages in thread
From: Dong Aisheng @ 2017-03-30  6:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 

Oh.. i saw the board wrong, sorry for the noise.

Regards
Dong Aisheng

> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?
> 
> > > performs a soft reset on startup. This causes netboot to sometimes
> > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried
> > > and
> > Probably another checkpatch warning.
> 
> Why, line too long?
> 
> > > This was generated with "make savedefconfig" and it includes a few
> > > additional minor cleanups.
> > > 
> > It is a bit strange, after apply your patch, i still get a lot difference
> > as follows when savedefconfig:
> >?
> > I don't know what's wrong. Toolchains difference?
> 
> Maybe, kconfig acts strangely sometimes. It's not clear option ordering is
> guaranteed to be stable. I don't think it matters though.
> 
> --
> Regards,
> Leonard

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-03-30  6:47 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 14:27 [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Leonard Crestez
2017-03-22 14:27 ` Leonard Crestez
2017-03-22 15:28 ` Fabio Estevam
2017-03-22 15:28   ` Fabio Estevam
2017-03-22 21:09 ` Florian Fainelli
2017-03-22 21:09   ` Florian Fainelli
2017-03-23  1:17 ` Andy Duan
2017-03-23  1:17   ` Andy Duan
2017-03-24  6:43 ` Dong Aisheng
2017-03-24  6:43   ` Dong Aisheng
2017-03-28 11:16   ` Leonard Crestez
2017-03-28 11:16     ` Leonard Crestez
2017-03-29  2:57     ` Shawn Guo
2017-03-29  2:57       ` Shawn Guo
2017-03-30  6:47     ` Dong Aisheng
2017-03-30  6:47       ` Dong Aisheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.