From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdCWBRb (ORCPT ); Wed, 22 Mar 2017 21:17:31 -0400 Received: from mail-db5eur01on0057.outbound.protection.outlook.com ([104.47.2.57]:54250 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751633AbdCWBRX (ORCPT ); Wed, 22 Mar 2017 21:17:23 -0400 From: Andy Duan To: Leonard Crestez , Shawn Guo , Sascha Hauer CC: Leonard Crestez , "linux-arm-kernel@lists.infradead.org" , Fabio Estevam , Octavian Purdila , "Florian Fainelli" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Thread-Topic: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Thread-Index: AQHSoxiJxLm11mbJ1E28PoBoJsyn0qGhn5kg Date: Thu, 23 Mar 2017 01:17:19 +0000 Message-ID: References: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> In-Reply-To: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1;DB6PR04MB2982;7:cA5d4Dtv5/RAnLARUeebgpWtQ4o9OaEfTLCWweyF/M+wjLXyIVaiSqwIkyoxg8Vs+5vBIV6dpiDSErBt6I19vTkU+OOB0fTRQtopX+PZvUtQNZbGs2SOlW0u6aNRiFI8bQGYbf/EnxeAoJyP37/wzwERo4JTuWN3/FxZ2D+1BSBBui99b9lRH25cco38d99OY2cnUxiCDxhUSDLkP+wukiwqdQBIsxzQOF/J+mU8Ig2+zKz3FL7LGOypdETrB1xxwzhyPJ0GFJh5UlLNODwoisvXaZv4qz2akIwKIKfH2mw65nn2Ca2f1mFOzMvtcLBnf9xoStTWBX5vvJVXtnwlsA== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39850400002)(39410400002)(39450400003)(39860400002)(377454003)(5660300001)(6436002)(55016002)(74316002)(2900100001)(6506006)(54906002)(77096006)(102836003)(66066001)(38730400002)(54356999)(76176999)(86362001)(189998001)(7736002)(305945005)(9686003)(122556002)(8936002)(7696004)(3846002)(6116002)(99286003)(39060400002)(2950100002)(53936002)(81166006)(6246003)(25786009)(8676002)(50986999)(2906002)(4326008)(229853002)(33656002)(3660700001)(3280700002)(15760500002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR04MB2982;H:AM4PR0401MB2260.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: 8a284551-4f74-46ad-2499-08d4718a5a02 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081);SRVR:DB6PR04MB2982; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558025)(20161123562025)(20161123564025)(6072148);SRVR:DB6PR04MB2982;BCL:0;PCL:0;RULEID:;SRVR:DB6PR04MB2982; x-forefront-prvs: 0255DF69B9 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2017 01:17:19.4527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2982 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2N1HY1A017488 From: Leonard Crestez Sent: Wednesday, March 22, 2017 10:28 PM >To: Shawn Guo ; Sascha Hauer > >Cc: Leonard Crestez ; linux-arm- >kernel@lists.infradead.org; Fabio Estevam ; Andy >Duan ; Octavian Purdila >; Florian Fainelli ; linux- >kernel@vger.kernel.org >Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY > >The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. >Add this driver to the default imx config since the device is present on one of >the evaluation boards. > >This used to work mostly fine with the generic phy driver but since commit >0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer performs a >soft reset on startup. This causes netboot to sometimes timeout on DHCP >because RX doesn't work right. DHCP is eventually retried and it works the >second time but it takes 90+ seconds to get a login prompt. > >This was generated with "make savedefconfig" and it includes a few additional >minor cleanups. > >Signed-off-by: Leonard Crestez >--- > >I also tried to do some debugging in the fec driver and it apparently receives >corrupted packets when this happens. If I hack it to go into promiscuous mode >unconditionally it gets a whole bunch of rx errors (crc errors, length errors and >so on). So the phy config is probably wrong and is confusing the mac? > >In theory it might be possible to make that driver "just work" with phy settings >from uboot but it's not clear it's worthwhile. > > arch/arm/configs/imx_v6_v7_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/arch/arm/configs/imx_v6_v7_defconfig >b/arch/arm/configs/imx_v6_v7_defconfig >index eaba3b1..e605389 100644 >--- a/arch/arm/configs/imx_v6_v7_defconfig >+++ b/arch/arm/configs/imx_v6_v7_defconfig >@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y > # CONFIG_NET_VENDOR_STMICRO is not set > CONFIG_AT803X_PHY=y > CONFIG_MICREL_PHY=y >+CONFIG_SMSC_PHY=y > CONFIG_USB_PEGASUS=m > CONFIG_USB_RTL8150=m > CONFIG_USB_RTL8152=m >@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m > CONFIG_WL12XX=m > CONFIG_WLCORE_SDIO=m > # CONFIG_WILINK_PLATFORM_DATA is not set -# >CONFIG_INPUT_MOUSEDEV_PSAUX is not set CONFIG_INPUT_EVDEV=y >CONFIG_INPUT_EVBUG=m CONFIG_KEYBOARD_GPIO=y @@ -376,7 +376,6 >@@ CONFIG_NLS_ISO8859_1=y CONFIG_NLS_ISO8859_15=m >CONFIG_NLS_UTF8=y CONFIG_PRINTK_TIME=y -CONFIG_DEBUG_FS=y >CONFIG_MAGIC_SYSRQ=y # CONFIG_SCHED_DEBUG is not set >CONFIG_PROVE_LOCKING=y >-- >2.7.4 Acked-by: Fugang Duan From mboxrd@z Thu Jan 1 00:00:00 1970 From: fugang.duan@nxp.com (Andy Duan) Date: Thu, 23 Mar 2017 01:17:19 +0000 Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY In-Reply-To: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> References: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Leonard Crestez Sent: Wednesday, March 22, 2017 10:28 PM >To: Shawn Guo ; Sascha Hauer > >Cc: Leonard Crestez ; linux-arm- >kernel at lists.infradead.org; Fabio Estevam ; Andy >Duan ; Octavian Purdila >; Florian Fainelli ; linux- >kernel at vger.kernel.org >Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY > >The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. >Add this driver to the default imx config since the device is present on one of >the evaluation boards. > >This used to work mostly fine with the generic phy driver but since commit >0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer performs a >soft reset on startup. This causes netboot to sometimes timeout on DHCP >because RX doesn't work right. DHCP is eventually retried and it works the >second time but it takes 90+ seconds to get a login prompt. > >This was generated with "make savedefconfig" and it includes a few additional >minor cleanups. > >Signed-off-by: Leonard Crestez >--- > >I also tried to do some debugging in the fec driver and it apparently receives >corrupted packets when this happens. If I hack it to go into promiscuous mode >unconditionally it gets a whole bunch of rx errors (crc errors, length errors and >so on). So the phy config is probably wrong and is confusing the mac? > >In theory it might be possible to make that driver "just work" with phy settings >from uboot but it's not clear it's worthwhile. > > arch/arm/configs/imx_v6_v7_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/arch/arm/configs/imx_v6_v7_defconfig >b/arch/arm/configs/imx_v6_v7_defconfig >index eaba3b1..e605389 100644 >--- a/arch/arm/configs/imx_v6_v7_defconfig >+++ b/arch/arm/configs/imx_v6_v7_defconfig >@@ -143,6 +143,7 @@ CONFIG_SMSC911X=y > # CONFIG_NET_VENDOR_STMICRO is not set > CONFIG_AT803X_PHY=y > CONFIG_MICREL_PHY=y >+CONFIG_SMSC_PHY=y > CONFIG_USB_PEGASUS=m > CONFIG_USB_RTL8150=m > CONFIG_USB_RTL8152=m >@@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m > CONFIG_WL12XX=m > CONFIG_WLCORE_SDIO=m > # CONFIG_WILINK_PLATFORM_DATA is not set -# >CONFIG_INPUT_MOUSEDEV_PSAUX is not set CONFIG_INPUT_EVDEV=y >CONFIG_INPUT_EVBUG=m CONFIG_KEYBOARD_GPIO=y @@ -376,7 +376,6 >@@ CONFIG_NLS_ISO8859_1=y CONFIG_NLS_ISO8859_15=m >CONFIG_NLS_UTF8=y CONFIG_PRINTK_TIME=y -CONFIG_DEBUG_FS=y >CONFIG_MAGIC_SYSRQ=y # CONFIG_SCHED_DEBUG is not set >CONFIG_PROVE_LOCKING=y >-- >2.7.4 Acked-by: Fugang Duan