From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bough Chen Subject: RE: [PATCH V5 00/13] mmc: Add Command Queue support Date: Thu, 17 Aug 2017 07:45:16 +0000 Message-ID: References: <1502366898-23691-1-git-send-email-adrian.hunter@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ve1eur01on0052.outbound.protection.outlook.com ([104.47.1.52]:46448 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751744AbdHQHpS (ORCPT ); Thu, 17 Aug 2017 03:45:18 -0400 In-Reply-To: <1502366898-23691-1-git-send-email-adrian.hunter@intel.com> Content-Language: en-US Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Adrian Hunter , Ulf Hansson , Shawn Lin Cc: linux-mmc , Alex Lemberg , Mateusz Nowak , Yuliy Izrailov , Jaehoon Chung , Dong Aisheng , Das Asutosh , Zhangfei Gao , Sahitya Tummala , Harjani Ritesh , Venu Byravarasu , Linus Walleij > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Adrian Hunter > Sent: Thursday, August 10, 2017 8:08 PM > To: Ulf Hansson > Cc: linux-mmc ; Bough Chen > ; Alex Lemberg ; > Mateusz Nowak ; Yuliy Izrailov > ; Jaehoon Chung ; > Dong Aisheng ; Das Asutosh > ; Zhangfei Gao ; > Sahitya Tummala ; Harjani Ritesh > ; Venu Byravarasu ; > Linus Walleij ; Shawn Lin > Subject: [PATCH V5 00/13] mmc: Add Command Queue support >=20 > Hi >=20 > Here is V5 of the hardware command queue patches without the software > command queue patches. >=20 > HW CMDQ offers 25% - 50% better random multi-threaded I/O. I see a sligh= t 2% > drop in sequential read speed but no change to sequential write. >=20 >=20 Hi Adrian, I test the performance on the i.MX8. Here in my side, I use 'dd' to test t= he sequential read/write speed, see a slight 3% drop for both read and write. --------------------------------------------- | | read (KB/s)| write (KB/s) | --------------------------------------------- |CMDQ in HS400ES| 257 | 94.5 | --------------------------------------------- | HS400ES | 265 | 96.6 | ---------------------------------------------=20 For random multi-threaded I/O, I use 'fio' to test, the test command: fio -filename=3D/mnt/test -direct=3D1 -iodepth 1 -thread -rw=3Drandread - i= oengine=3Dpsync -bs=3D4k -size=3D2G -numjobs=3D10 -runtime=3D60 -group_re= porting - name=3Dmytest I test 5 times, and get the average value. For CMDQ in HS400ES ---------------------------------------------------- | block size | 4KB | 8KB | 16KB | ---------------------------------------------------- | random read | 26340KB/s | 51844KB/s | 85738KB/s | ---------------------------------------------------- | random write | 12691KB/s | 15879KB/s | 17535KB/s | ---------------------------------------------------- HS400ES without CMDQ ---------------------------------------------------- | block size | 4KB | 8KB | 16KB | ---------------------------------------------------- | random read | 18585KB/s | 35041KB/s | 63880KB/s | ---------------------------------------------------- | random write | 16465KB/s | 19210KB/s | 22672KB/s | ---------------------------------------------------- For random write from the test, I find every test value differ greatly no m= atter enable CMDQ or not. >>From the test, I see CMDQ random read speed increase 34%~48%, but for rando= m write, the speed=20 drop 17.4% ~ 33%. =20 When you send software cmdq V5 patch, you give some explanation for the ran= dom write. But the average random write speed also drops a lot, I think it is now a good news,= which need attention! Maybe Shawn Lin can double test this random write performance. Best Regards Haibo Chen > Changes since V4: > mmc: core: Add mmc_retune_hold_now() > Add explanation to commit message. > mmc: host: Add CQE interface > Add comments to callback declarations. > mmc: core: Turn off CQE before sending commands > Add explanation to commit message. > mmc: core: Add support for handling CQE requests > Add comments as requested by Ulf. > mmc: core: Remove unused MMC_CAP2_PACKED_CMD > New patch. > mmc: mmc: Enable Command Queuing > Adjust for removal of MMC_CAP2_PACKED_CMD. > Add a comment about Packed Commands. > mmc: mmc: Enable CQE's > Remove un-necessary check for MMC_CAP2_CQE > mmc: block: Use local variables in mmc_blk_data_prep() > New patch. > mmc: block: Prepare CQE data > Adjust due to "mmc: block: Use local variables in > mmc_blk_data_prep()" > Remove priority setting. > Add explanation to commit message. > mmc: cqhci: support for command queue enabled host > Fix transfer descriptor setting in cqhci_set_tran_desc() for 32-bit DMA >=20 > Changes since V3: > Adjusted ...blk_end_request...() for new block status codes > Fixed CQHCI transaction descriptor for "no DCMD" case >=20 > Changes since V2: > Dropped patches that have been applied. > Re-based > Added "mmc: sdhci-pci: Add CQHCI support for Intel GLK" >=20 > Changes since V1: >=20 > "Share mmc request array between partitions" is dependent > on changes in "Introduce queue semantics", so added that > and block fixes: >=20 > Added "Fix is_waiting_last_req set incorrectly" > Added "Fix cmd error reset failure path" > Added "Use local var for mqrq_cur" > Added "Introduce queue semantics" >=20 > Changes since RFC: >=20 > Re-based on next. > Added comment about command queue priority. > Added some acks and reviews. >=20 >=20 > Adrian Hunter (12): > mmc: core: Add mmc_retune_hold_now() > mmc: core: Add members to mmc_request and mmc_data for CQE's > mmc: host: Add CQE interface > mmc: core: Turn off CQE before sending commands > mmc: core: Add support for handling CQE requests > mmc: core: Remove unused MMC_CAP2_PACKED_CMD > mmc: mmc: Enable Command Queuing > mmc: mmc: Enable CQE's > mmc: block: Use local variables in mmc_blk_data_prep() > mmc: block: Prepare CQE data > mmc: block: Add CQE support > mmc: sdhci-pci: Add CQHCI support for Intel GLK >=20 > Venkat Gopalakrishnan (1): > mmc: cqhci: support for command queue enabled host >=20 > drivers/mmc/core/block.c | 238 +++++++- > drivers/mmc/core/block.h | 7 + > drivers/mmc/core/bus.c | 7 + > drivers/mmc/core/core.c | 178 +++++- > drivers/mmc/core/host.c | 6 + > drivers/mmc/core/host.h | 1 + > drivers/mmc/core/mmc.c | 42 +- > drivers/mmc/core/queue.c | 273 ++++++++- > drivers/mmc/core/queue.h | 42 +- > drivers/mmc/host/Kconfig | 14 + > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/cqhci.c | 1154 > +++++++++++++++++++++++++++++++++++++ > drivers/mmc/host/cqhci.h | 240 ++++++++ > drivers/mmc/host/sdhci-pci-core.c | 153 ++++- > include/linux/mmc/core.h | 18 +- > include/linux/mmc/host.h | 63 +- > include/trace/events/mmc.h | 36 +- > 17 files changed, 2412 insertions(+), 61 deletions(-) create mode 10064= 4 > drivers/mmc/host/cqhci.c create mode 100644 drivers/mmc/host/cqhci.h >=20 >=20 > Regards > Adrian > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in t= he > body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html