From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 01526E00C0B; Mon, 1 Feb 2016 01:25:40 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [157.55.234.59 listed in list.dnswl.org] * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0059.outbound.protection.outlook.com [157.55.234.59]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0D63AE00BE1 for ; Mon, 1 Feb 2016 01:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-nxp-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qZQAN0GE+icgaP8AcQ/Ufg4u6y/xUKj1cu10kgpqbck=; b=PvSpSMCql58EP6gJukAEZ++mEnD6GXphgPvrX94xVJZdEJUH0I/KXGeIaWttZbLX2pU/SxcidMfXKjcRoprpAm+yNBROxCCFlQY6AopTqPHPnBTo+YDcC3fYF5sKMzG8ggdYxPSzBuUGluPg5t5gucWvhaH57mJmmUxvff/quOM= Received: from AM4PR04MB1635.eurprd04.prod.outlook.com (10.164.78.157) by AM4PR04MB1635.eurprd04.prod.outlook.com (10.164.78.157) with Microsoft SMTP Server (TLS) id 15.1.396.15; Mon, 1 Feb 2016 09:25:33 +0000 Received: from AM4PR04MB1635.eurprd04.prod.outlook.com ([10.164.78.157]) by AM4PR04MB1635.eurprd04.prod.outlook.com ([10.164.78.157]) with mapi id 15.01.0396.020; Mon, 1 Feb 2016 09:25:33 +0000 From: Yuqing Zhu To: Carlos Rafael Giani , "meta-freescale@yoctoproject.org" Thread-Topic: [meta-freescale] [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugins-bad: Fix gleffects fisheye shader compile error Thread-Index: AQHRWOdmRQyrbMrHGU6nGJ9UqNiEp58PRcSAgAE719CABlCkAIAAHFvQ Date: Mon, 1 Feb 2016 09:25:33 +0000 Message-ID: References: <1453887720-16863-1-git-send-email-b54851@freescale.com> <1453887720-16863-9-git-send-email-b54851@freescale.com> <56A8B3D5.4020800@pseudoterminal.org> <56AF08EA.9070501@pseudoterminal.org> In-Reply-To: <56AF08EA.9070501@pseudoterminal.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pseudoterminal.org; dkim=none (message not signed) header.d=none; pseudoterminal.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.53] x-microsoft-exchange-diagnostics: 1; AM4PR04MB1635; 5:57kNGtHOKBhFurBm1a7rEkvRihmtMuRO356rV2tDkKBKwbFP3uFVk5rCtTMbB9Vk42KMIjgoucHVDBf69ZeNJTjmgpUBjbcyGO3s3TD+pXjTjvP14rBpvCiaUuXeQnXMx5/5XoBTNvMxHOFk80Upnw==; 24:yaHB04hwyQdayd/2He33YlRwOb5x1PTXnCxGd8JRA3jq8y5vFwZsH++QiwMWHQO9qIje9LOr7q8eXmTY6CTjHPZ7eAtJzOeas8+Iupiasys= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1635; x-ms-office365-filtering-correlation-id: 908a164e-cb1d-4350-81da-08d32ae9a2fb x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:AM4PR04MB1635; BCL:0; PCL:0; RULEID:; SRVR:AM4PR04MB1635; x-forefront-prvs: 0839D067E7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(377424004)(479174004)(13464003)(24454002)(87936001)(189998001)(2950100001)(107886002)(5001960100002)(106116001)(66066001)(54356999)(10400500002)(33656002)(76176999)(230783001)(74316001)(50986999)(15975445007)(5001770100001)(77096005)(3280700002)(76576001)(5004730100002)(19580405001)(586003)(5003600100002)(19580395003)(92566002)(93886004)(40100003)(5002640100001)(102836003)(1220700001)(1096002)(3470700001)(3846002)(86362001)(11100500001)(3660700001)(2906002)(5008740100001)(2501003)(122556002)(151743001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR04MB1635; H:AM4PR04MB1635.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2016 09:25:33.8103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1635 Subject: Re: [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugins-bad: Fix gleffects fisheye shader compile error X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 09:25:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Carlos, Thanks for your good suggestion. We have created a ticket to GST Bugzi= lla, and it has been accepted in 1.6.4 release. So I will upstream it to poky. Thanks! B.R. Yuqing Zhu -----Original Message----- From: Carlos Rafael Giani [mailto:dv@pseudoterminal.org]=20 Sent: Monday, February 01, 2016 3:28 PM To: Yuqing Zhu ; meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugin= s-bad: Fix gleffects fisheye shader compile error True, it is less readable. But adding a comment should suffice. normcoord *=3D r * 1.414; // not using sqrt(2), since some GPUs do not sup= port sqrt() On 2016-01-28 08:25, Yuqing Zhu wrote: > Hi Carlos, > > > The float number will diminishes readability, but we will create a= ticket to GStreamer bugzilla. > If they accept it, I will push the patch to poky. > > B.R. > Yuqing Zhu > > > > -----Original Message----- > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-boun= ces@yoctoproject.org] On Behalf Of Carlos Rafael Giani > Sent: Wednesday, January 27, 2016 8:11 PM > To: meta-freescale@yoctoproject.org > Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plug= ins-bad: Fix gleffects fisheye shader compile error > > This commit is acceptable. I can also live with the "i.MX specific" > part, since this is a Vivante GPU problem. > > I think this could be upstreamed, though, because having "sqrt(2)" in the= shader does not actually gain anybody anything. It would be perfectly acce= ptable to replace it with 1.414213562 instead. I recommend posting this to = GStreamer bugzilla. > > > On 01/27/2016 10:41 AM, Yuqing Zhu wrote: >> shader function "sqrt" is not support, use float number 1.414 >> >> Signed-off-by: Yuqing Zhu >> --- >> ...-glplugin-fix-gleffects-fisheye-shader-co.patch | 31 +++++++++++++= +++++++++ >> .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend | 1 + >> 2 files changed, 32 insertions(+) >> create mode 100755 >> recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fi >> x-gleffects-fisheye-shader-co.patch >> >> diff --git >> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin- >> fix-gleffects-fisheye-shader-co.patch >> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin- >> fix-gleffects-fisheye-shader-co.patch >> new file mode 100755 >> index 0000000..d017a1f >> --- /dev/null >> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplu >> +++ gin-fix-gleffects-fisheye-shader-co.patch >> @@ -0,0 +1,31 @@ >> +From de919fc1cf4250db240757a94f302d81620b451c Mon Sep 17 00:00:00 >> +2001 >> +From: Haihua Hu >> +Date: Tue, 8 Dec 2015 14:09:58 +0800 >> +Subject: [PATCH 5/5] [MMFMWK-6966] [glplugin] fix gleffects fisheye >> +shader compile error >> + >> +shader function "sqrt" is not support, use float number 1.414 >> + >> +Upstream-Status: Inappropriate [i.MX specific] >> + >> +Signed-off-by: Haihua Hu >> +--- >> + ext/gl/effects/gstgleffectssources.c | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/ext/gl/effects/gstgleffectssources.c >> +b/ext/gl/effects/gstgleffectssources.c >> +index 3da856c..076e21b 100644 >> +--- a/ext/gl/effects/gstgleffectssources.c >> ++++ b/ext/gl/effects/gstgleffectssources.c >> +@@ -152,7 +152,7 @@ const gchar *fisheye_fragment_source_gles2 =3D >> + " vec2 normcoord;" >> + " normcoord =3D texturecoord - 0.5;" >> + " float r =3D length (normcoord);" >> +- " normcoord *=3D r * sqrt(2);" >> ++ " normcoord *=3D r * 1.414;" >> + " texturecoord =3D normcoord + 0.5;" >> + " gl_FragColor =3D texture2D (tex, texturecoord);" >> + "}"; >> +-- >> +1.7.9.5 >> + >> diff --git >> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend >> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend >> index d3b8c2d..ce8a158 100644 >> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend >> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend >> @@ -18,6 +18,7 @@ IMX_PATCHES =3D " file://0001-PATCH-install-gstaggrega= tor-and-gstvideoaggregator-h >> file://0006-glplugin-Support-fb-backend-for-gl-plugin= s.patch \ >> file://0007-glplugin-Change-wayland-default-res-to-10= 24x768.patch \ >> =20 >> file://0008-glplugin-Add-fps-print-in-glimagesink.patch \ >> + >> + file://0009-glplugin-fix-gleffects-fisheye-shader-co.patch \ >> " >> =20 >> SRC_URI_append_mx6 =3D "${IMX_PATCHES}" > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale