From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758817AbcC3IlZ (ORCPT ); Wed, 30 Mar 2016 04:41:25 -0400 Received: from mail-db3on0069.outbound.protection.outlook.com ([157.55.234.69]:7008 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753926AbcC3IlO (ORCPT ); Wed, 30 Mar 2016 04:41:14 -0400 From: Jun Li To: Baolin Wang CC: Peter Chen , Felipe Balbi , "Greg KH" , Sebastian Reichel , "Dmitry Eremin-Solenikov" , David Woodhouse , Peter Chen , Alan Stern , "r.baldyga@samsung.com" , Yoshihiro Shimoda , Lee Jones , Mark Brown , Charles Keepax , "patches@opensource.wolfsonmicro.com" , Linux PM list , USB , "device-mainlining@lists.linuxfoundation.org" , LKML Subject: RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Thread-Topic: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Thread-Index: AQHRhcncDPeno7bqik6en7wacMJBHJ9pvwGAgASx+gCAAa8+QIAAFJIAgAEXTJCAAD9RgIAAF0Aw Date: Wed, 30 Mar 2016 08:07:44 +0000 Message-ID: References: <20160325070937.GA22398@peterchendt> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.51] x-ms-office365-filtering-correlation-id: 5d5f34f1-ed10-4dd8-0ecc-08d358725fe3 x-microsoft-exchange-diagnostics: 1;AM4PR04MB1665;5:dL0+/phpWsETpYnpfLDSAnsXv8+2DMkjiGoM49QYYcM6ii4zC+tiYOWxeebGmrVG9uIXRWhLrYpfjBMY4cYchmSmvU/n5sCXJRiMwJt9IiownoB79I3cELXe74IUy+OkHrHDI3xRcBggiY7Tjgluyg==;24:jienrefDXlBXtSRxIOfqI4CAdKo6HNPZkKAX9F7vPcDaPa0If+vpwTF+FPTNMQ6BN46RLkSukg18Sy589hBrXXX70NdmhFtYSCwM6EAhvso= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1665; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:AM4PR04MB1665;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1665; x-forefront-prvs: 08978A8F5C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(13464003)(24454002)(377454003)(87936001)(5008740100001)(92566002)(76576001)(5003600100002)(50986999)(586003)(19580395003)(2906002)(1220700001)(1096002)(5890100001)(5250100002)(19580405001)(189998001)(4326007)(3280700002)(110136002)(3660700001)(93886004)(5002640100001)(5004730100002)(86362001)(11100500001)(66066001)(106116001)(54356999)(33656002)(81166005)(76176999)(2900100001)(2950100001)(6116002)(102836003)(74316001)(3846002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR04MB1665;H:AM4PR04MB1665.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2016 08:07:44.6353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1665 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2U8fVCA020984 Hi > -----Original Message----- > From: Baolin Wang [mailto:baolin.wang@linaro.org] > Sent: Wednesday, March 30, 2016 2:15 PM > To: Jun Li > Cc: Peter Chen ; Felipe Balbi ; > Greg KH ; Sebastian Reichel ; > Dmitry Eremin-Solenikov ; David Woodhouse > ; Peter Chen ; Alan Stern > ; r.baldyga@samsung.com; Yoshihiro Shimoda > ; Lee Jones ; Mark > Brown ; Charles Keepax > ; patches@opensource.wolfsonmicro.com; > Linux PM list ; USB ; > device-mainlining@lists.linuxfoundation.org; LKML kernel@vger.kernel.org> > Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with > the usb gadget power negotation > > On 30 March 2016 at 10:54, Jun Li wrote: > >> >> It is not for udc driver but for power users who want to negotiate > >> >> with USB subsystem. > >> >> > >> > > >> > Seems you don't want to guarantee charger type detection is done > >> > before gadget connection(pullup DP), right? > >> > I see you call usb_charger_detect_type() in each gadget usb state > >> changes. > >> > >> I am not sure I get your point correctly, please correct me if I > >> misunderstand you. > >> We need to check the charger type at every event comes from the usb > >> gadget state changes or the extcon device state changes, which means > >> a new charger plugin or pullup. > >> > > > > According to usb charger spec, my understanding is you can't do real > > charger detection procedure *after* gadget _connection_(pullup DP), > > also I don't > > Why can not? Charger detection is usually from PMIC. Charger detection process will impact DP/DM line state, see usb charger spec v1.2 for detail detection process, section 4.6.3 says: "A PD is allowed to *disconnect* and repeat the charger detection process multiple times while attached. The PD is required to wait for a time of at least TCP_VDM_EN max between disconnecting and restarting the charger detection process." As Peter mentioned, the charger detection should happen between VBUS detection and gadget pull up DP for first plug in case. So when&after gadget connect (pullup DP), you should already know the charger type. Li Jun > > > think it's necessary to check charger type at every event from usb > gadget. > > My meaning is not every event from usb gadget. When the usb gadget state > changes or the extcon device (maybe GPIO detection) state changes, which > means charger plugin or pullup, we need to check the charger type to set > current. >>From your below code, you call usb_charger_notify_others() in every state change. if (uchger->old_gadget_state != state) { uchger->old_gadget_state = state; if (state >= USB_STATE_ATTACHED) uchger_state = USB_CHARGER_PRESENT; else if (state == USB_STATE_NOTATTACHED) uchger_state = USB_CHARGER_REMOVE; else /* this else will never happen */ uchger_state = USB_CHARGER_DEFAULT; usb_charger_notify_others(uchger, uchger_state); } > > > Something in gadget driver you can utilize is only vbus detection, and > > report diff current by diff usb state if it's a SDP. > > -- > Baolin.wang > Best Regards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jun Li Subject: RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Date: Wed, 30 Mar 2016 08:07:44 +0000 Message-ID: References: <20160325070937.GA22398@peterchendt> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-db3on0069.outbound.protection.outlook.com ([157.55.234.69]:7008 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753926AbcC3IlO (ORCPT ); Wed, 30 Mar 2016 04:41:14 -0400 In-Reply-To: Content-Language: en-US Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Baolin Wang Cc: Peter Chen , Felipe Balbi , Greg KH , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Peter Chen , Alan Stern , "r.baldyga@samsung.com" , Yoshihiro Shimoda , Lee Jones , Mark Brown , Charles Keepax , "patches@opensource.wolfsonmicro.com" , Linux PM list , USB , "device-mainlining@lists.linuxfoundation.org" , LKML SGkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCYW9saW4gV2FuZyBb bWFpbHRvOmJhb2xpbi53YW5nQGxpbmFyby5vcmddDQo+IFNlbnQ6IFdlZG5lc2RheSwgTWFyY2gg MzAsIDIwMTYgMjoxNSBQTQ0KPiBUbzogSnVuIExpIDxqdW4ubGlAbnhwLmNvbT4NCj4gQ2M6IFBl dGVyIENoZW4gPGh6cGV0ZXJjaGVuQGdtYWlsLmNvbT47IEZlbGlwZSBCYWxiaSA8YmFsYmlAa2Vy bmVsLm9yZz47DQo+IEdyZWcgS0ggPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPjsgU2ViYXN0 aWFuIFJlaWNoZWwgPHNyZUBrZXJuZWwub3JnPjsNCj4gRG1pdHJ5IEVyZW1pbi1Tb2xlbmlrb3Yg PGRiYXJ5c2hrb3ZAZ21haWwuY29tPjsgRGF2aWQgV29vZGhvdXNlDQo+IDxkd213MkBpbmZyYWRl YWQub3JnPjsgUGV0ZXIgQ2hlbiA8cGV0ZXIuY2hlbkBmcmVlc2NhbGUuY29tPjsgQWxhbiBTdGVy bg0KPiA8c3Rlcm5Acm93bGFuZC5oYXJ2YXJkLmVkdT47IHIuYmFsZHlnYUBzYW1zdW5nLmNvbTsg WW9zaGloaXJvIFNoaW1vZGENCj4gPHlvc2hpaGlyby5zaGltb2RhLnVoQHJlbmVzYXMuY29tPjsg TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz47IE1hcmsNCj4gQnJvd24gPGJyb29uaWVA a2VybmVsLm9yZz47IENoYXJsZXMgS2VlcGF4DQo+IDxja2VlcGF4QG9wZW5zb3VyY2Uud29sZnNv bm1pY3JvLmNvbT47IHBhdGNoZXNAb3BlbnNvdXJjZS53b2xmc29ubWljcm8uY29tOw0KPiBMaW51 eCBQTSBsaXN0IDxsaW51eC1wbUB2Z2VyLmtlcm5lbC5vcmc+OyBVU0IgPGxpbnV4LXVzYkB2Z2Vy Lmtlcm5lbC5vcmc+Ow0KPiBkZXZpY2UtbWFpbmxpbmluZ0BsaXN0cy5saW51eGZvdW5kYXRpb24u b3JnOyBMS01MIDxsaW51eC0NCj4ga2VybmVsQHZnZXIua2VybmVsLm9yZz4NCj4gU3ViamVjdDog UmU6IFtQQVRDSCB2OCAwLzRdIEludHJvZHVjZSB1c2IgY2hhcmdlciBmcmFtZXdvcmsgdG8gZGVh bCB3aXRoDQo+IHRoZSB1c2IgZ2FkZ2V0IHBvd2VyIG5lZ290YXRpb24NCj4gDQo+IE9uIDMwIE1h cmNoIDIwMTYgYXQgMTA6NTQsIEp1biBMaSA8anVuLmxpQG54cC5jb20+IHdyb3RlOg0KPiA+PiA+ PiBJdCBpcyBub3QgZm9yIHVkYyBkcml2ZXIgYnV0IGZvciBwb3dlciB1c2VycyB3aG8gd2FudCB0 byBuZWdvdGlhdGUNCj4gPj4gPj4gd2l0aCBVU0Igc3Vic3lzdGVtLg0KPiA+PiA+Pg0KPiA+PiA+ DQo+ID4+ID4gU2VlbXMgeW91IGRvbid0IHdhbnQgdG8gZ3VhcmFudGVlIGNoYXJnZXIgdHlwZSBk ZXRlY3Rpb24gaXMgZG9uZQ0KPiA+PiA+IGJlZm9yZSBnYWRnZXQgY29ubmVjdGlvbihwdWxsdXAg RFApLCByaWdodD8NCj4gPj4gPiBJIHNlZSB5b3UgY2FsbCB1c2JfY2hhcmdlcl9kZXRlY3RfdHlw ZSgpIGluIGVhY2ggZ2FkZ2V0IHVzYiBzdGF0ZQ0KPiA+PiBjaGFuZ2VzLg0KPiA+Pg0KPiA+PiBJ IGFtIG5vdCBzdXJlIEkgZ2V0IHlvdXIgcG9pbnQgY29ycmVjdGx5LCBwbGVhc2UgY29ycmVjdCBt ZSBpZiBJDQo+ID4+IG1pc3VuZGVyc3RhbmQgeW91Lg0KPiA+PiBXZSBuZWVkIHRvIGNoZWNrIHRo ZSBjaGFyZ2VyIHR5cGUgYXQgZXZlcnkgZXZlbnQgY29tZXMgZnJvbSB0aGUgdXNiDQo+ID4+IGdh ZGdldCBzdGF0ZSBjaGFuZ2VzIG9yIHRoZSBleHRjb24gZGV2aWNlIHN0YXRlIGNoYW5nZXMsIHdo aWNoIG1lYW5zDQo+ID4+IGEgbmV3IGNoYXJnZXIgcGx1Z2luIG9yIHB1bGx1cC4NCj4gPj4NCj4g Pg0KPiA+IEFjY29yZGluZyB0byB1c2IgY2hhcmdlciBzcGVjLCBteSB1bmRlcnN0YW5kaW5nIGlz IHlvdSBjYW4ndCBkbyByZWFsDQo+ID4gY2hhcmdlciBkZXRlY3Rpb24gcHJvY2VkdXJlICphZnRl ciogZ2FkZ2V0IF9jb25uZWN0aW9uXyhwdWxsdXAgRFApLA0KPiA+IGFsc28gSSBkb24ndA0KPiAN Cj4gV2h5IGNhbiBub3Q/IENoYXJnZXIgZGV0ZWN0aW9uIGlzIHVzdWFsbHkgZnJvbSBQTUlDLg0K DQpDaGFyZ2VyIGRldGVjdGlvbiBwcm9jZXNzIHdpbGwgaW1wYWN0IERQL0RNIGxpbmUgc3RhdGUs IHNlZSB1c2IgY2hhcmdlcg0Kc3BlYyB2MS4yIGZvciBkZXRhaWwgZGV0ZWN0aW9uIHByb2Nlc3Ms IHNlY3Rpb24gNC42LjMgc2F5czoNCg0KIkEgUEQgaXMgYWxsb3dlZCB0byAqZGlzY29ubmVjdCog YW5kIHJlcGVhdCB0aGUgY2hhcmdlciBkZXRlY3Rpb24gcHJvY2Vzcw0KbXVsdGlwbGUgdGltZXMg d2hpbGUgYXR0YWNoZWQuIFRoZSBQRCBpcyByZXF1aXJlZCB0byB3YWl0IGZvciBhIHRpbWUgb2Yg YXQNCmxlYXN0IFRDUF9WRE1fRU4gbWF4IGJldHdlZW4gZGlzY29ubmVjdGluZyBhbmQgcmVzdGFy dGluZyB0aGUgY2hhcmdlcg0KZGV0ZWN0aW9uIHByb2Nlc3MuIg0KDQpBcyBQZXRlciBtZW50aW9u ZWQsIHRoZSBjaGFyZ2VyIGRldGVjdGlvbiBzaG91bGQgaGFwcGVuIGJldHdlZW4gVkJVUw0KZGV0 ZWN0aW9uIGFuZCBnYWRnZXQgcHVsbCB1cCBEUCBmb3IgZmlyc3QgcGx1ZyBpbiBjYXNlLiBTbyB3 aGVuJmFmdGVyDQpnYWRnZXQgY29ubmVjdCAocHVsbHVwIERQKSwgeW91IHNob3VsZCBhbHJlYWR5 IGtub3cgdGhlIGNoYXJnZXIgdHlwZS4NCg0KTGkgSnVuDQogDQo+IA0KPiA+IHRoaW5rIGl0J3Mg bmVjZXNzYXJ5IHRvIGNoZWNrIGNoYXJnZXIgdHlwZSBhdCBldmVyeSBldmVudCBmcm9tIHVzYg0K PiBnYWRnZXQuDQo+IA0KPiBNeSBtZWFuaW5nIGlzIG5vdCBldmVyeSBldmVudCBmcm9tIHVzYiBn YWRnZXQuIFdoZW4gdGhlIHVzYiBnYWRnZXQgc3RhdGUNCj4gY2hhbmdlcyBvciB0aGUgZXh0Y29u IGRldmljZSAobWF5YmUgR1BJTyBkZXRlY3Rpb24pIHN0YXRlIGNoYW5nZXMsIHdoaWNoDQo+IG1l YW5zIGNoYXJnZXIgcGx1Z2luIG9yIHB1bGx1cCwgd2UgbmVlZCB0byBjaGVjayB0aGUgY2hhcmdl ciB0eXBlIHRvIHNldA0KPiBjdXJyZW50Lg0KDQpGcm9tIHlvdXIgYmVsb3cgY29kZSwgeW91IGNh bGwgdXNiX2NoYXJnZXJfbm90aWZ5X290aGVycygpIGluDQpldmVyeSBzdGF0ZSBjaGFuZ2UuDQoN CmlmICh1Y2hnZXItPm9sZF9nYWRnZXRfc3RhdGUgIT0gc3RhdGUpIHsNCgl1Y2hnZXItPm9sZF9n YWRnZXRfc3RhdGUgPSBzdGF0ZTsNCg0KCWlmIChzdGF0ZSA+PSBVU0JfU1RBVEVfQVRUQUNIRUQp DQoJCXVjaGdlcl9zdGF0ZSA9IFVTQl9DSEFSR0VSX1BSRVNFTlQ7DQoJZWxzZSBpZiAoc3RhdGUg PT0gVVNCX1NUQVRFX05PVEFUVEFDSEVEKQ0KCQl1Y2hnZXJfc3RhdGUgPSBVU0JfQ0hBUkdFUl9S RU1PVkU7DQoJZWxzZQ0KLyogdGhpcyBlbHNlIHdpbGwgbmV2ZXIgaGFwcGVuICovDQoJCXVjaGdl cl9zdGF0ZSA9IFVTQl9DSEFSR0VSX0RFRkFVTFQ7DQoNCgl1c2JfY2hhcmdlcl9ub3RpZnlfb3Ro ZXJzKHVjaGdlciwgdWNoZ2VyX3N0YXRlKTsNCn0NCg0KPiANCj4gPiBTb21ldGhpbmcgaW4gZ2Fk Z2V0IGRyaXZlciB5b3UgY2FuIHV0aWxpemUgaXMgb25seSB2YnVzIGRldGVjdGlvbiwgYW5kDQo+ ID4gcmVwb3J0IGRpZmYgY3VycmVudCBieSBkaWZmIHVzYiBzdGF0ZSBpZiBpdCdzIGEgU0RQLg0K PiANCj4gLS0NCj4gQmFvbGluLndhbmcNCj4gQmVzdCBSZWdhcmRzDQo=