From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vasily Philipov <vasilyf@mellanox.com>
Subject: Re: [PATCH v4 4/4] app/testpmd: add isolated mode
 parameter
Date: Wed, 21 Jun 2017 09:43:45 +0000
Message-ID: <AM4PR0501MB26896736C1579D254960D25FDBDA0@AM4PR0501MB2689.eurprd05.prod.outlook.com>
References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com>
 <96c3dca8015a755afb37bf35ae85e6fa16282c0c.1496583000.git.vasilyf@mellanox.com>
 <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0085.outbound.protection.outlook.com [104.47.2.85])
 by dpdk.org (Postfix) with ESMTP id 7BDFA559A
 for <dev@dpdk.org>; Wed, 21 Jun 2017 11:43:46 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Wu, Jingjing [mailto:jingjing.wu@intel.com]
> Sent: Tuesday, June 20, 2017 04:27
> To: Vasily Philipov <vasilyf@mellanox.com>; dev@dpdk.org
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; N=E9lio Laranjeiro
> <nelio.laranjeiro@6wind.com>
> Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
> parameter
>=20
>=20
> > +/*
> >   * Avoids to check link status when starting/stopping a port.
> >   */
> >  uint8_t no_link_check =3D 0; /* check by default */ @@ -1422,6 +1427,1=
5
> > @@ static void eth_event_callback(uint8_t port_id,
> >  		if (port->need_reconfig > 0) {
> >  			port->need_reconfig =3D 0;
> >
> > +			if (isolated_mode) {
> > +				int ret =3D port_flow_isolate(pi, 1);
> > +				if (ret) {
> > +					printf("Failed to apply isolated"
> > +					       " mode on port %d\n", pi);
> > +					return -1;
> > +				}
> > +			}
> > +
> Should it block the app startup if isolated-mode setting fails?

if isolated mode cannot be enabled on any port, that port cannot be initial=
ized
and that causes testpmd to quit, at least it won't go against the user's wi=
shes