From: Eli Cohen <eli@mellanox.com>
To: Or Gerlitz <gerlitz.or@gmail.com>, Tariq Toukan <tariqt@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Linux Netdev List <netdev@vger.kernel.org>,
Eran Ben Elisha <eranbe@mellanox.com>
Subject: RE: [PATCH iproute2] iplink: Update usage in help message
Date: Thu, 1 Jun 2017 18:06:09 +0000 [thread overview]
Message-ID: <AM4PR0501MB2787D4D88D0BC744C1B8CEDAC5F60@AM4PR0501MB2787.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAJ3xEMh9qgGF9LbyNriPafiz3cgdiV8wQ9_A9Zbb4tU3oQ9agg@mail.gmail.com>
Sure, will do.
-----Original Message-----
From: Or Gerlitz [mailto:gerlitz.or@gmail.com]
Sent: Thursday, June 1, 2017 5:56 AM
To: Tariq Toukan <tariqt@mellanox.com>; Eli Cohen <eli@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>; Linux Netdev List <netdev@vger.kernel.org>; Eran Ben Elisha <eranbe@mellanox.com>
Subject: Re: [PATCH iproute2] iplink: Update usage in help message
On Thu, Jun 1, 2017 at 11:00 AM, Tariq Toukan <tariqt@mellanox.com> wrote:
> From: Eli Cohen <eli@mellanox.com>
>
> Add to usage message a description of how to configure Infiniband node
> and port GUIDs.
>
> Fixes: d91fb3f4c7e4 ('Add support for configuring Infiniband GUIDs')
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
> ip/iplink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ip/iplink.c b/ip/iplink.c index
> da3f9a779351..ea112f71befc 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -91,6 +91,8 @@ void iplink_usage(void)
> " [ query_rss { on | off} ]\n"
> " [ state { auto | enable | disable} ] ]\n"
> " [ trust { on | off} ] ]\n"
> + " [ node_guid { eui64 } ]\n"
> + " [ port_guid { eui64 } ]\n"
> " [ xdp { off |\n"
> " object FILE [ section NAME ] [ verbose ] |\n"
> " pinned FILE } ]\n"
Eli,
I see now that your original patch touched the man page but the word infiniband isn't mentioned:
@@ -1196,6 +1200,12 @@ sent by the VF.
.BI trust " on|off"
- trust the specified VF user. This enables that VF user can set a specific feature which may impact security and/or performance. (e.g. VF multicast promiscuous mode)
+.sp
+.BI node_guid " eui64"
+- configure node GUID for the VF.
+.sp
+.BI port_guid " eui64"
+- configure port GUID for the VF.
would be good if you enhance this patch to spell something like
configure node GUID for infiniband VFs.
configure port GUID for infiniband VFs.
Or.
prev parent reply other threads:[~2017-06-01 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 8:00 [PATCH iproute2] iplink: Update usage in help message Tariq Toukan
2017-06-01 10:55 ` Or Gerlitz
2017-06-01 18:06 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0501MB2787D4D88D0BC744C1B8CEDAC5F60@AM4PR0501MB2787.eurprd05.prod.outlook.com \
--to=eli@mellanox.com \
--cc=eranbe@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.