From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A46C74A2B for ; Wed, 10 Jul 2019 14:36:01 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BEA8B20651 for ; Wed, 10 Jul 2019 14:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="f/dyjKGZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA8B20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC0CA14E8; Wed, 10 Jul 2019 16:35:59 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by dpdk.org (Postfix) with ESMTP id 6BFE9F04 for ; Wed, 10 Jul 2019 16:35:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yj8aIqY5p+6NIMCdwO2+vjOW082vLDubSN9ZZc526w=; b=f/dyjKGZGP0avlHL9RMuLyzM2m9SfTa1OZv1CuZoLEAuaHWX7ZVue5lS7D6JZhH6lZDegCYGuXgejvtryfpiset1TIVzQwr19c6fzpvPDejVxDgSDWrtmFZqJKv7vBCESw8YdGlJBRNh8cnsc8ANZ5KC13cvdQiNeGP+7UQUkYY= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3283.eurprd05.prod.outlook.com (10.170.125.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Wed, 10 Jul 2019 14:35:56 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 14:35:56 +0000 From: Slava Ovsiienko To: Slava Ovsiienko , Jack Min , Raslan Darawsheh , Shahaf Shuler , Yongseok Koh , John McNamara , Marko Kovacevic CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel Thread-Index: AQHVNyzI7rxH1KZgxUyJNguxie5Ghg== Date: Wed, 10 Jul 2019 14:35:55 +0000 Message-ID: References: <20190528020426.18638-1-jackmin@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe0585f6-13c9-499d-a020-08d70543eb1e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3283; x-ms-traffictypediagnostic: AM4PR05MB3283: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(199004)(13464003)(189003)(71190400001)(71200400001)(33656002)(76116006)(7736002)(66446008)(66946007)(66476007)(66556008)(64756008)(14454004)(478600001)(4326008)(486006)(11346002)(8936002)(86362001)(476003)(6436002)(2940100002)(81156014)(446003)(316002)(110136005)(81166006)(25786009)(229853002)(74316002)(99286004)(6116002)(2906002)(9686003)(186003)(26005)(6506007)(53936002)(76176011)(256004)(14444005)(3846002)(102836004)(6246003)(53546011)(305945005)(66066001)(52536014)(68736007)(5660300002)(55016002)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3283; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: OmozP5MqrCWWrLZB07tFPJdVP/3mLoY9VJcBcsRM83O9WRiwLmtW+WXZ8QeoFdH2Mlih1i61ZXgrqnADJEAnpmGeKB27iW6/JkPwP9+drnYz+dfOzx+JdU4VBbUIyQiZGitZW6mGcv4PhhTy6RkIFJa04r+YC+SgMLJo/So1frJ3yZ81J7EH5Kiyn4gvCtRpKzBu07dvz+M2X2W8Me1sE0efVGeC5kgI6CydCxc6fMNmTzCe2rWoYAkuxhFOjnLEMTwRDvMWnY+ocldHe17FHsKSL4ML54CNXYjjsWQkXf9Q+DdTJSuemuEFEfHIbEbiGig6sEP0QvfDDVgWyNPGKVOlKi1aLhwsmMv7MgOaxHaO8zz5kskcjL7jnDngV/erY7BOpj+2UCGy5rgRZgY4aSDcKMEsBSoL6zWM0STt/rs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe0585f6-13c9-499d-a020-08d70543eb1e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 14:35:56.0156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3283 Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Regarding point 2) - it is OK, there is common flags update in the item val= idation loop. So, after update point 1) - you can add my Acked-by to the patch, thanks. WBR, Slava > -----Original Message----- > From: dev On Behalf Of Slava Ovsiienko > Sent: Wednesday, July 10, 2019 17:20 > To: Jack Min ; Raslan Darawsheh > ; Shahaf Shuler ; > Yongseok Koh ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support > IP-in-IP tunnel >=20 > Hi, Xiaoyu >=20 > There is a couple of small points to note: > 1) It would be good to have the testpmd flow create command sample with > new tunnels in commit log. > 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ? > It looks like a bug, should the second parameter be "&item_flags" ? (= if so - > please, fix all > calls of mlx5_flow_tunnel_ip_check()) >=20 > WBR, > Slava >=20 > > -----Original Message----- > > From: Xiaoyu Min > > Sent: Wednesday, July 10, 2019 13:15 > > To: Raslan Darawsheh ; Slava Ovsiienko > > ; Shahaf Shuler ; > > Yongseok Koh ; John McNamara > > ; Marko Kovacevic > > > Cc: dev@dpdk.org > > Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP > > tunnel > > > > Enabled IP-in-IP tunnel type support on DV/DR flow engine. > > This includes the following combination: > > - IPv4 over IPv4 > > - IPv4 over IPv6 > > - IPv6 over IPv4 > > - IPv6 over IPv6 > > > > MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure > > fw using FLEX Paser profile 0. > > > > mlxconfig -d -y set FLEX_PARSER_PROFILE_ENABLE=3D0 > > > > Signed-off-by: Xiaoyu Min > > --- > > v2: > > * updated release note > > v3: > > * rebased on 19.08-rc1 > > --- > > doc/guides/nics/mlx5.rst | 15 ++++++++++- > > doc/guides/rel_notes/release_19_08.rst | 1 + > > drivers/net/mlx5/mlx5_flow.c | 35 ++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_flow.h | 6 ++++- > > drivers/net/mlx5/mlx5_flow_dv.c | 37 ++++++++++++++++++++++++++ > > 5 files changed, 92 insertions(+), 2 deletions(-) > >