From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ori Kam Subject: Re: [PATCH] examples/flow_filtering: add rte_fdir_conf initialization Date: Tue, 17 Jul 2018 05:15:47 +0000 Message-ID: References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <0E78D399C70DA940A335608C6ED296D73A13DA82@SHSMSX104.ccr.corp.intel.com> <0E78D399C70DA940A335608C6ED296D73A13FDB8@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Yigit, Ferruh" , "stable@dpdk.org" , "Gilmore, Walter E" To: "Xu, Rosen" , "dev@dpdk.org" Return-path: In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A13FDB8@SHSMSX104.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sorry for the late response, > -----Original Message----- > From: Xu, Rosen [mailto:rosen.xu@intel.com] > Sent: Thursday, July 12, 2018 9:23 AM > To: Ori Kam ; dev@dpdk.org > Cc: Yigit, Ferruh ; stable@dpdk.org; Gilmore, Wal= ter > E > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_con= f > initialization >=20 > Hi Ori, >=20 > Pls see my reply. >=20 > Hi Walter and Ferruh, >=20 > I need your voice :) >=20 > > -----Original Message----- > > From: Ori Kam [mailto:orika@mellanox.com] > > Sent: Thursday, July 12, 2018 13:58 > > To: Xu, Rosen ; dev@dpdk.org > > Cc: Yigit, Ferruh ; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add > rte_fdir_conf > > initialization > > > > Hi, > > > > PSB > > > > > -----Original Message----- > > > From: Xu, Rosen [mailto:rosen.xu@intel.com] > > > Sent: Thursday, July 12, 2018 8:27 AM > > > To: Ori Kam ; dev@dpdk.org > > > Cc: Yigit, Ferruh ; stable@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add > > > rte_fdir_conf initialization > > > > > > Hi Ori, > > > > > > examples/flow_filtering sample app fails on i40e [1] because i40e > > > requires explicit FDIR configuration. > > > > > > But rte_flow in and hardware independent ways of describing > > > flow-action, it shouldn't require specific config options for specifi= c > > hardware. > > > > > > > I don't understand why using rte flow require the use of fdir. > > it doesn't make sense to me, that new API will need old one. >=20 > It's a good question, I also have this question about Mellanox NIC Driver > mlx5_flow.c. > In this file many flow functions call fdir. :) The only functions that are calling fdir are fdir function, and you can see that inside of the create function we convert the fdir=20 Into rte flow. >=20 > > > Is there any chance driver select the FDIR config automatically based > > > on rte_flow rule, unless explicitly a FDIR config set by user? > > > > I don't know how the i40e driver is implemented but I know that Mellano= x > > convert the other way around, if fdir is given it is converted to rte_f= low. >=20 > Firstly, rte_fdir_conf is part of rte_eth_conf definition. > struct rte_eth_conf { > ...... > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. */ > ...... > }; > Secondly, default value of rte_eth_conf.fdir_conf.mode is > RTE_FDIR_MODE_NONE, which means Disable FDIR support. > Thirdly, flow_filtering should align with test-pmd, in test-pmd all fdir_= conf is > initialized. >=20 This sounds to me correct we don't want to enable fdir. Why should the example app for rte flow use fdir? And align to=20 testpmd which support everything in in all modes? > > > > > > > > [1] > > > Flow can't be created 1 message: Check the mode in fdir_conf. > > > EAL: Error - exiting with code: 1 > > > > > > > -----Original Message----- > > > > From: Ori Kam [mailto:orika@mellanox.com] > > > > Sent: Thursday, July 12, 2018 13:17 > > > > To: Xu, Rosen ; dev@dpdk.org > > > > Cc: Yigit, Ferruh ; stable@dpdk.org; Ori Ka= m > > > > > > > > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add > > > rte_fdir_conf > > > > initialization > > > > > > > > Hi Rosen, > > > > > > > > Why do the fdir_conf must be initialized? > > > > > > > > What is the issue you are seeing? > > > > > > > > Best, > > > > Ori > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > > > > > Sent: Thursday, July 12, 2018 5:10 AM > > > > > To: dev@dpdk.org > > > > > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > > > > > ; stable@dpdk.org > > > > > Subject: [dpdk-dev] [PATCH] examples/flow_filtering: add > rte_fdir_conf > > > > > initialization > > > > > > > > > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > > > > initialization. > > > > > > > > > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of > > flow > > > > > API") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Rosen Xu > > > > > --- > > > > > examples/flow_filtering/main.c | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git a/examples/flow_filtering/main.c > > > > > b/examples/flow_filtering/main.c index f595034..aa03e23 100644 > > > > > --- a/examples/flow_filtering/main.c > > > > > +++ b/examples/flow_filtering/main.c > > > > > @@ -132,6 +132,12 @@ > > > > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > > > > DEV_TX_OFFLOAD_TCP_TSO, > > > > > }, > > > > > + .fdir_conf =3D { > > > > > + .mode =3D RTE_FDIR_MODE_PERFECT, > > > > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > > > > + .status =3D RTE_FDIR_REPORT_STATUS, > > > > > + .drop_queue =3D 127, > > > > > + }, > > > > > }; > > > > > struct rte_eth_txconf txq_conf; > > > > > struct rte_eth_rxconf rxq_conf; > > > > > -- > > > > > 1.8.3.1 Best, Ori