From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B934C4338F for ; Thu, 5 Aug 2021 09:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09D066104F for ; Thu, 5 Aug 2021 09:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239852AbhHEJxz (ORCPT ); Thu, 5 Aug 2021 05:53:55 -0400 Received: from mail-eopbgr80058.outbound.protection.outlook.com ([40.107.8.58]:36678 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232930AbhHEJxy (ORCPT ); Thu, 5 Aug 2021 05:53:54 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcVleGBjevBoTWWC5U9gt3alTcPK0G48ggMf1QxTpxN2EXJM491DeUvWdzQ0TKyAHanUdrlMRaqan/7X/JjfccVjxUbceXdpaUpRj6Fp+dkcCD3hKDXyjC3dp+FZldrQ4vwvqIbpLRIqqq6jMrpzVE0YgoM8kiLgsBSV6VBxdSksfAfjbyxEPWA63EvCgETtMu2UJcRQekghkr2zUYkUTqNUTzPsrH0BYD0AJbQLXzEQVuMejevOdvasvMDRNKGIjgghShgaqGz0ykzGqcMDnphB15hYEDz/O5mP7KkhjiSKT409Ak48aKQ7R6ryhPaV/3bWO0AAn0MimuuxkFqUYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUW7tjRMirqEC0b2nFhDW42b0CS8G6tm/tDTlpHSOko=; b=GhmtMXa6aOsADQBZU6yk3wwvbx61dodVg2V63akqFk5wyVEbQwN5k3Q1EcHPXQFueA/bOF78AJ0Lyi5Lr+nDZvtTXyqv9LhnNIJqLf02HkMG0JOwkKJ4abHdaiwhGUqJyKgeMvqV4Rx3taf47upFO5Rfi7wP3a/P7oE+tqwrZyHMTZYvE/7x/N0ijw/oowvVEcYrcR05i7gkqwaPnV0IvUQSRYfJpIznAXCzPELL5qMSx1/KZKXMWF3QrvzwA+5wZ1HecXQXThmccuCnccFY23W2rjlaLtnNiQpNkCzOXhPOfOh2o4yF2Tv0AY1BJcq40ltKWQMR/9fBE1oI6k8zNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUW7tjRMirqEC0b2nFhDW42b0CS8G6tm/tDTlpHSOko=; b=ogKBuIZPprvmIlxZaAZyj4ty+0yDSoSlhW9svlUxw86iZalEZJD4pHjIHe+bS3LG4fnm46dD7bMoNY/rQagT4FZx6HBamqZi8kI1EGhSMteZZ+mtKjmrr0NOJ0bs8mmBusAGe3MZG/7nKmuaBDoQEoIjHucop8xIjWb87YU5+yY= Received: from AM5PR0402MB2756.eurprd04.prod.outlook.com (2603:10a6:203:99::22) by AM6PR04MB6744.eurprd04.prod.outlook.com (2603:10a6:20b:f6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Thu, 5 Aug 2021 09:53:38 +0000 Received: from AM5PR0402MB2756.eurprd04.prod.outlook.com ([fe80::3839:217:6252:b1f8]) by AM5PR0402MB2756.eurprd04.prod.outlook.com ([fe80::3839:217:6252:b1f8%11]) with mapi id 15.20.4373.026; Thu, 5 Aug 2021 09:53:38 +0000 From: Peng Fan To: Lucas Stach , Shawn Guo , Rob Herring CC: dl-linux-imx , Adam Ford , Frieder Schrempf , Marek Vasut , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "patchwork-lst@pengutronix.de" Subject: RE: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl Thread-Topic: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl Thread-Index: AQHXfnGYlmXWK493wkWeB+pH7SXYi6tkwouA Date: Thu, 5 Aug 2021 09:53:38 +0000 Message-ID: References: <20210716232916.3572966-1-l.stach@pengutronix.de> <20210721204703.1424034-1-l.stach@pengutronix.de> <20210721204703.1424034-14-l.stach@pengutronix.de> In-Reply-To: <20210721204703.1424034-14-l.stach@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa4aa240-134b-4be4-3a1e-08d957f6e65d x-ms-traffictypediagnostic: AM6PR04MB6744: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:962; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BAE5lOBKeg0yPoNiTqK9wuXJDWzhS/+T6WV1jO3uccXB4lOcv43fh2nyswWWUPJaXoEOrtokaXpzhI0PAP/s4MxVFp/5xfXuwwPB7w6Nz9mbCNIsn5SmrYDPcIaqdnazYkfpD42r2FVbPWFlyTAFYL4dzAy+SoFguWuwB0HpDH3p35KnlVYFZEs2ct2xKIM+BlKIPfzx8+3/2OxbnI3LQ9iduv3PMq0yZK+66VfJmCGzEUDMkxDdZ5TPYzLlvBjnXnxmYLTl0ZLtm6ZKv+XOM56/yIDy0w7MJSecrCH8cDn85ywYFeLAVXmqN657ZZQCb3LCo/hP/L3Bp7DaHSnfp8QwGAzspeE2WqcWaDKuIjg9TyT77WTqnFBnhO8YTBHjEgQnQhSvOE/KGx52AUbqsgQFHZotjmTaf2bICJHUw92q8h9z5jahgdvUmQXOV1xa2QRjjOdt/cRu60tt+BnQFNbuZnxm4CeBi06WbgzM9tnnkPtoXbQcU2KxVniZwGOjbB6WXSAzJr0Vhz6p8vu0eTvWvLCiZy1ijhLuhgxd/n888DWr/BBQiLJM9+QK1Jzxc16z43OJXDV6svP5NeTeNyOr+CIakY0cfO3xKeho0Mys/qnRGUX93I95R+AV1/x3bNeP6dR/LpjHLgvHwFGnvTUIFGlIMCPLUlIAfvPKANThC7O3Tme4lnI1AVRgsHbPordfiWRt7jyy+/Gir3ThENAGySmQ72aqdPLFYwmWfVw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0402MB2756.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(6506007)(8936002)(33656002)(66476007)(83380400001)(186003)(66946007)(4326008)(26005)(8676002)(66556008)(5660300002)(64756008)(66446008)(9686003)(86362001)(52536014)(7416002)(316002)(71200400001)(55016002)(478600001)(76116006)(44832011)(54906003)(2906002)(122000001)(110136005)(7696005)(38100700002)(38070700005)(32563001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zWNjxRxBxW9cgfv9FvfxJFlrPqj91QwO8lS6wMbT9/6ZZ0VPPqlFqRu6FM6N?= =?us-ascii?Q?+GtGnByN5iMe/kTZ1xOfwGXJtTKqA6I2OZIQ2e6eELKxnFC11dtBt/6cxJXb?= =?us-ascii?Q?qNf6DD+0UBqGe/wFzXbF/o9vEtQgGNNk5U3aX2/kp/7JFjVuDan8kyZN0E0R?= =?us-ascii?Q?qX8iMDTTNnQU/6LrG1rHey6t/95MfgeeAXJJtBCjRQ1RKu//75014d/GimCc?= =?us-ascii?Q?NBClzQty6Q4sBzKm0Wb06QnYsfvIbBfUapJ7V/9VGx3JTcfw3dqEES5JIG3+?= =?us-ascii?Q?KJ2r/OxnumK009pTdXGVcXHoBXisy2Gqm8iYdVeuv/oKFFr9kcXzAgJRfYEl?= =?us-ascii?Q?fvJBOsBNLcTyyPSen0uz4EIumOekRE6AY6ZH9nErauZJvgIGjhHJKbYEqrmD?= =?us-ascii?Q?y9f73ssUg8LsD4VeDFprK56C5Y5WNryz+jHogZrl654xBrNuT7kaOJYmpQn3?= =?us-ascii?Q?Ob3y3T1bZ+IZs5cBeSn18KUkFjU8iw6UppKENYrI835Sfb75hsyCMAtOFUCc?= =?us-ascii?Q?vh8y9MnzJjUKgZyrIJ5mELimc9xmFMxbvtB4iqtUx2XkXYz0G79zZNR4p4Za?= =?us-ascii?Q?rerWxZeRU3eysSSQddsKACG3I/3iTimARxsx/tDWeWPfMLAsPyRSNfs0YCVK?= =?us-ascii?Q?VFBIMzX7i/e6TH0xvFF5S9daB/nJYN9dh03E5sx+hxyEVaUsgfT5vxh++uLp?= =?us-ascii?Q?5k593300g7OPVX4+wkr9xtTYIBPe2tHgEf853HM+vPhwKLvqhntODWuroBAb?= =?us-ascii?Q?pzHhhTIgicqlS2Mgz1zoPxdX2rGptT+anaUDTEvuSQpHEnjAwzGLZqhDnPwZ?= =?us-ascii?Q?H+rwhlPFBlAJURJL64Wopr3GQhaEWf0GuSstPzRkxq2XeSv8QN48bMUPZpnE?= =?us-ascii?Q?VnxGj5XyWe8oR6mpHt0zilW4RB0SZoiS/d+vWDLWq7SqMcb121ohGSFOvRy1?= =?us-ascii?Q?PopssXPcW56Ba+6TmuCee/rxRenk2ZvjKwYCA0ArgzPvCyZ7DU2stGHBgmch?= =?us-ascii?Q?9w6x+WOsJV6YM3Rv422J49zc3UfutCbhyPaw/yiynAnTplH0XHDqg9kX56RZ?= =?us-ascii?Q?GBJDk4adMyjDb56gGM5P2iGBWLBNJ55jAkZbEOFExfvWoWmyFxJ6vrsZY7d7?= =?us-ascii?Q?tEzt1jEk32OGfM1jAbTTVqWI+VCYDLY0yINtcTpL0mPBjqh7vP3C6C3Q23Zw?= =?us-ascii?Q?/8R9C+jN4TKqy5mYWkgnfJp2uktVV9XHR8AWuTPyg3hb8anFORRAdYspJqvv?= =?us-ascii?Q?UWiWExDEEM+5mpAsHgyx6HbQF7r75Z1C803O5gcO5p9P7UVV3Z5zOy/U8JiS?= =?us-ascii?Q?vGgrU5p0HSfIYVSX4m/OQFIx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0402MB2756.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa4aa240-134b-4be4-3a1e-08d957f6e65d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 09:53:38.7536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 43vdmleiybBMEUuZDYvvW6hPFriumnjLT+aSU4vSOf3As6Id+S69c1OBYzub9XJ7hBuzE8Jw+tpXXlsB5RDi3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6744 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Subject: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl >=20 > This adds the description for the i.MX8MM disp blk-ctrl. >=20 > Signed-off-by: Lucas Stach Reviewed-by: Peng Fan > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 70 > ++++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) >=20 > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c > b/drivers/soc/imx/imx8m-blk-ctrl.c > index 3dd17b903636..32eab800a3c6 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -433,11 +433,81 @@ static const struct imx8m_blk_ctrl_data > imx8m_vpu_blk_ctl_dev_data =3D { > .num_domains =3D ARRAY_SIZE(imx8m_vpu_blk_ctl_domain_data), > }; >=20 > +static int imx8mm_disp_power_notifier(struct notifier_block *nb, > + unsigned long action, void *data) { > + struct imx8m_blk_ctrl *bc =3D container_of(nb, struct imx8m_blk_ctrl, > + power_nb); > + > + if (action !=3D GENPD_NOTIFY_ON && action !=3D > GENPD_NOTIFY_PRE_OFF) > + return NOTIFY_OK; > + > + /* Enable bus clock and deassert bus reset */ > + regmap_set_bits(bc->regmap, BLK_CLK_EN, BIT(12)); > + regmap_set_bits(bc->regmap, BLK_SFT_RSTN, BIT(6)); > + > + /* > + * On power up we have no software backchannel to the GPC to > + * wait for the ADB handshake to happen, so we just delay for a > + * bit. On power down the GPC driver waits for the handshake. > + */ > + if (action =3D=3D GENPD_NOTIFY_ON) > + udelay(5); > + > + > + return NOTIFY_OK; > +} > + > +static const struct imx8m_blk_ctrl_domain_data > imx8m_disp_blk_ctl_domain_data[] =3D { > + [IMX8MM_DISPBLK_CSI_BRIDGE] =3D { > + .name =3D "dispblk-csi-bridge", > + .clk_names =3D (const char *[]){ "csi-bridge-axi", "csi-bridge-apb", > + "csi-bridge-core", }, > + .num_clks =3D 3, > + .gpc_name =3D "csi-bridge", > + .rst_mask =3D BIT(0) | BIT(1) | BIT(2), > + .clk_mask =3D BIT(0) | BIT(1) | BIT(2) | BIT(3) | BIT(4) | BIT(5), > + }, > + [IMX8MM_DISPBLK_LCDIF] =3D { > + .name =3D "dispblk-lcdif", > + .clk_names =3D (const char *[]){ "lcdif-axi", "lcdif-apb", "lcdif-pix"= , }, > + .num_clks =3D 3, > + .gpc_name =3D "lcdif", > + .clk_mask =3D BIT(6) | BIT(7), > + }, > + [IMX8MM_DISPBLK_MIPI_DSI] =3D { > + .name =3D "dispblk-mipi-dsi", > + .clk_names =3D (const char *[]){ "dsi-pclk", "dsi-ref", }, > + .num_clks =3D 2, > + .gpc_name =3D "mipi-dsi", > + .rst_mask =3D BIT(5), > + .clk_mask =3D BIT(8) | BIT(9), > + }, > + [IMX8MM_DISPBLK_MIPI_CSI] =3D { > + .name =3D "dispblk-mipi-csi", > + .clk_names =3D (const char *[]){ "csi-aclk", "csi-pclk" }, > + .num_clks =3D 2, > + .gpc_name =3D "mipi-csi", > + .rst_mask =3D BIT(3) | BIT(4), > + .clk_mask =3D BIT(10) | BIT(11), > + }, > +}; > + > +static const struct imx8m_blk_ctrl_data imx8m_disp_blk_ctl_dev_data =3D = { > + .max_reg =3D 0x2c, > + .power_notifier_fn =3D imx8mm_disp_power_notifier, > + .domains =3D imx8m_disp_blk_ctl_domain_data, > + .num_domains =3D ARRAY_SIZE(imx8m_disp_blk_ctl_domain_data), > +}; > + > static const struct of_device_id imx8m_blk_ctrl_of_match[] =3D { > { > .compatible =3D "fsl,imx8mm-vpu-blk-ctrl", > .data =3D &imx8m_vpu_blk_ctl_dev_data > }, { > + .compatible =3D "fsl,imx8mm-disp-blk-ctrl", > + .data =3D &imx8m_disp_blk_ctl_dev_data > + } ,{ > /* Sentinel */ > } > }; > -- > 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9984C4338F for ; Thu, 5 Aug 2021 09:56:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC1B560462 for ; Thu, 5 Aug 2021 09:56:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC1B560462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mUnk0t/8URNDuLq6UT+m/DQx09k7pGYaEpo2/YV9yeE=; b=nj8gGrBxgsPi3D 50D0wWpRuRgq4v93eDBU34Xw7y993li6GOUxcPmrUhEmkt70CYTWFcwYyBMgFH7XcqDn2TVLlJmQc nH14/MKaqA5E678+rLRMQkL0wxFW3Q4OjBaBZKhOpLX8VEoy3Yq/BAcUBdteiCyzy0Qzc/sOt1hK6 p/uQpe1PnVqpsJF/MpfzVksyGLF9BExCYnVYXCC4P0iDfjhIxF/BeXKSSfLvH677+OsQ0U0BMGKdT 8oJxZMW/zQ0zn3XdUUFc278yI5ahdN8CPYOXEkFPbNwshnjJz0yd3WoOX0TRqXQr3+xB1YicB62YO ZAco/zKD8VNG2W8gny8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBa4R-008zOG-2o; Thu, 05 Aug 2021 09:53:48 +0000 Received: from mail-eopbgr80083.outbound.protection.outlook.com ([40.107.8.83] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBa4L-008zMp-PY for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 09:53:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcVleGBjevBoTWWC5U9gt3alTcPK0G48ggMf1QxTpxN2EXJM491DeUvWdzQ0TKyAHanUdrlMRaqan/7X/JjfccVjxUbceXdpaUpRj6Fp+dkcCD3hKDXyjC3dp+FZldrQ4vwvqIbpLRIqqq6jMrpzVE0YgoM8kiLgsBSV6VBxdSksfAfjbyxEPWA63EvCgETtMu2UJcRQekghkr2zUYkUTqNUTzPsrH0BYD0AJbQLXzEQVuMejevOdvasvMDRNKGIjgghShgaqGz0ykzGqcMDnphB15hYEDz/O5mP7KkhjiSKT409Ak48aKQ7R6ryhPaV/3bWO0AAn0MimuuxkFqUYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUW7tjRMirqEC0b2nFhDW42b0CS8G6tm/tDTlpHSOko=; b=GhmtMXa6aOsADQBZU6yk3wwvbx61dodVg2V63akqFk5wyVEbQwN5k3Q1EcHPXQFueA/bOF78AJ0Lyi5Lr+nDZvtTXyqv9LhnNIJqLf02HkMG0JOwkKJ4abHdaiwhGUqJyKgeMvqV4Rx3taf47upFO5Rfi7wP3a/P7oE+tqwrZyHMTZYvE/7x/N0ijw/oowvVEcYrcR05i7gkqwaPnV0IvUQSRYfJpIznAXCzPELL5qMSx1/KZKXMWF3QrvzwA+5wZ1HecXQXThmccuCnccFY23W2rjlaLtnNiQpNkCzOXhPOfOh2o4yF2Tv0AY1BJcq40ltKWQMR/9fBE1oI6k8zNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUW7tjRMirqEC0b2nFhDW42b0CS8G6tm/tDTlpHSOko=; b=ogKBuIZPprvmIlxZaAZyj4ty+0yDSoSlhW9svlUxw86iZalEZJD4pHjIHe+bS3LG4fnm46dD7bMoNY/rQagT4FZx6HBamqZi8kI1EGhSMteZZ+mtKjmrr0NOJ0bs8mmBusAGe3MZG/7nKmuaBDoQEoIjHucop8xIjWb87YU5+yY= Received: from AM5PR0402MB2756.eurprd04.prod.outlook.com (2603:10a6:203:99::22) by AM6PR04MB6744.eurprd04.prod.outlook.com (2603:10a6:20b:f6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Thu, 5 Aug 2021 09:53:38 +0000 Received: from AM5PR0402MB2756.eurprd04.prod.outlook.com ([fe80::3839:217:6252:b1f8]) by AM5PR0402MB2756.eurprd04.prod.outlook.com ([fe80::3839:217:6252:b1f8%11]) with mapi id 15.20.4373.026; Thu, 5 Aug 2021 09:53:38 +0000 From: Peng Fan To: Lucas Stach , Shawn Guo , Rob Herring CC: dl-linux-imx , Adam Ford , Frieder Schrempf , Marek Vasut , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "patchwork-lst@pengutronix.de" Subject: RE: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl Thread-Topic: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl Thread-Index: AQHXfnGYlmXWK493wkWeB+pH7SXYi6tkwouA Date: Thu, 5 Aug 2021 09:53:38 +0000 Message-ID: References: <20210716232916.3572966-1-l.stach@pengutronix.de> <20210721204703.1424034-1-l.stach@pengutronix.de> <20210721204703.1424034-14-l.stach@pengutronix.de> In-Reply-To: <20210721204703.1424034-14-l.stach@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa4aa240-134b-4be4-3a1e-08d957f6e65d x-ms-traffictypediagnostic: AM6PR04MB6744: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:962; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BAE5lOBKeg0yPoNiTqK9wuXJDWzhS/+T6WV1jO3uccXB4lOcv43fh2nyswWWUPJaXoEOrtokaXpzhI0PAP/s4MxVFp/5xfXuwwPB7w6Nz9mbCNIsn5SmrYDPcIaqdnazYkfpD42r2FVbPWFlyTAFYL4dzAy+SoFguWuwB0HpDH3p35KnlVYFZEs2ct2xKIM+BlKIPfzx8+3/2OxbnI3LQ9iduv3PMq0yZK+66VfJmCGzEUDMkxDdZ5TPYzLlvBjnXnxmYLTl0ZLtm6ZKv+XOM56/yIDy0w7MJSecrCH8cDn85ywYFeLAVXmqN657ZZQCb3LCo/hP/L3Bp7DaHSnfp8QwGAzspeE2WqcWaDKuIjg9TyT77WTqnFBnhO8YTBHjEgQnQhSvOE/KGx52AUbqsgQFHZotjmTaf2bICJHUw92q8h9z5jahgdvUmQXOV1xa2QRjjOdt/cRu60tt+BnQFNbuZnxm4CeBi06WbgzM9tnnkPtoXbQcU2KxVniZwGOjbB6WXSAzJr0Vhz6p8vu0eTvWvLCiZy1ijhLuhgxd/n888DWr/BBQiLJM9+QK1Jzxc16z43OJXDV6svP5NeTeNyOr+CIakY0cfO3xKeho0Mys/qnRGUX93I95R+AV1/x3bNeP6dR/LpjHLgvHwFGnvTUIFGlIMCPLUlIAfvPKANThC7O3Tme4lnI1AVRgsHbPordfiWRt7jyy+/Gir3ThENAGySmQ72aqdPLFYwmWfVw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0402MB2756.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(6506007)(8936002)(33656002)(66476007)(83380400001)(186003)(66946007)(4326008)(26005)(8676002)(66556008)(5660300002)(64756008)(66446008)(9686003)(86362001)(52536014)(7416002)(316002)(71200400001)(55016002)(478600001)(76116006)(44832011)(54906003)(2906002)(122000001)(110136005)(7696005)(38100700002)(38070700005)(32563001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zWNjxRxBxW9cgfv9FvfxJFlrPqj91QwO8lS6wMbT9/6ZZ0VPPqlFqRu6FM6N?= =?us-ascii?Q?+GtGnByN5iMe/kTZ1xOfwGXJtTKqA6I2OZIQ2e6eELKxnFC11dtBt/6cxJXb?= =?us-ascii?Q?qNf6DD+0UBqGe/wFzXbF/o9vEtQgGNNk5U3aX2/kp/7JFjVuDan8kyZN0E0R?= =?us-ascii?Q?qX8iMDTTNnQU/6LrG1rHey6t/95MfgeeAXJJtBCjRQ1RKu//75014d/GimCc?= =?us-ascii?Q?NBClzQty6Q4sBzKm0Wb06QnYsfvIbBfUapJ7V/9VGx3JTcfw3dqEES5JIG3+?= =?us-ascii?Q?KJ2r/OxnumK009pTdXGVcXHoBXisy2Gqm8iYdVeuv/oKFFr9kcXzAgJRfYEl?= =?us-ascii?Q?fvJBOsBNLcTyyPSen0uz4EIumOekRE6AY6ZH9nErauZJvgIGjhHJKbYEqrmD?= =?us-ascii?Q?y9f73ssUg8LsD4VeDFprK56C5Y5WNryz+jHogZrl654xBrNuT7kaOJYmpQn3?= =?us-ascii?Q?Ob3y3T1bZ+IZs5cBeSn18KUkFjU8iw6UppKENYrI835Sfb75hsyCMAtOFUCc?= =?us-ascii?Q?vh8y9MnzJjUKgZyrIJ5mELimc9xmFMxbvtB4iqtUx2XkXYz0G79zZNR4p4Za?= =?us-ascii?Q?rerWxZeRU3eysSSQddsKACG3I/3iTimARxsx/tDWeWPfMLAsPyRSNfs0YCVK?= =?us-ascii?Q?VFBIMzX7i/e6TH0xvFF5S9daB/nJYN9dh03E5sx+hxyEVaUsgfT5vxh++uLp?= =?us-ascii?Q?5k593300g7OPVX4+wkr9xtTYIBPe2tHgEf853HM+vPhwKLvqhntODWuroBAb?= =?us-ascii?Q?pzHhhTIgicqlS2Mgz1zoPxdX2rGptT+anaUDTEvuSQpHEnjAwzGLZqhDnPwZ?= =?us-ascii?Q?H+rwhlPFBlAJURJL64Wopr3GQhaEWf0GuSstPzRkxq2XeSv8QN48bMUPZpnE?= =?us-ascii?Q?VnxGj5XyWe8oR6mpHt0zilW4RB0SZoiS/d+vWDLWq7SqMcb121ohGSFOvRy1?= =?us-ascii?Q?PopssXPcW56Ba+6TmuCee/rxRenk2ZvjKwYCA0ArgzPvCyZ7DU2stGHBgmch?= =?us-ascii?Q?9w6x+WOsJV6YM3Rv422J49zc3UfutCbhyPaw/yiynAnTplH0XHDqg9kX56RZ?= =?us-ascii?Q?GBJDk4adMyjDb56gGM5P2iGBWLBNJ55jAkZbEOFExfvWoWmyFxJ6vrsZY7d7?= =?us-ascii?Q?tEzt1jEk32OGfM1jAbTTVqWI+VCYDLY0yINtcTpL0mPBjqh7vP3C6C3Q23Zw?= =?us-ascii?Q?/8R9C+jN4TKqy5mYWkgnfJp2uktVV9XHR8AWuTPyg3hb8anFORRAdYspJqvv?= =?us-ascii?Q?UWiWExDEEM+5mpAsHgyx6HbQF7r75Z1C803O5gcO5p9P7UVV3Z5zOy/U8JiS?= =?us-ascii?Q?vGgrU5p0HSfIYVSX4m/OQFIx?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0402MB2756.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa4aa240-134b-4be4-3a1e-08d957f6e65d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 09:53:38.7536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 43vdmleiybBMEUuZDYvvW6hPFriumnjLT+aSU4vSOf3As6Id+S69c1OBYzub9XJ7hBuzE8Jw+tpXXlsB5RDi3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6744 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_025341_914264_31C4B7C7 X-CRM114-Status: GOOD ( 22.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: [PATCH v2 13/18] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl > > This adds the description for the i.MX8MM disp blk-ctrl. > > Signed-off-by: Lucas Stach Reviewed-by: Peng Fan > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 70 > ++++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c > b/drivers/soc/imx/imx8m-blk-ctrl.c > index 3dd17b903636..32eab800a3c6 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -433,11 +433,81 @@ static const struct imx8m_blk_ctrl_data > imx8m_vpu_blk_ctl_dev_data = { > .num_domains = ARRAY_SIZE(imx8m_vpu_blk_ctl_domain_data), > }; > > +static int imx8mm_disp_power_notifier(struct notifier_block *nb, > + unsigned long action, void *data) { > + struct imx8m_blk_ctrl *bc = container_of(nb, struct imx8m_blk_ctrl, > + power_nb); > + > + if (action != GENPD_NOTIFY_ON && action != > GENPD_NOTIFY_PRE_OFF) > + return NOTIFY_OK; > + > + /* Enable bus clock and deassert bus reset */ > + regmap_set_bits(bc->regmap, BLK_CLK_EN, BIT(12)); > + regmap_set_bits(bc->regmap, BLK_SFT_RSTN, BIT(6)); > + > + /* > + * On power up we have no software backchannel to the GPC to > + * wait for the ADB handshake to happen, so we just delay for a > + * bit. On power down the GPC driver waits for the handshake. > + */ > + if (action == GENPD_NOTIFY_ON) > + udelay(5); > + > + > + return NOTIFY_OK; > +} > + > +static const struct imx8m_blk_ctrl_domain_data > imx8m_disp_blk_ctl_domain_data[] = { > + [IMX8MM_DISPBLK_CSI_BRIDGE] = { > + .name = "dispblk-csi-bridge", > + .clk_names = (const char *[]){ "csi-bridge-axi", "csi-bridge-apb", > + "csi-bridge-core", }, > + .num_clks = 3, > + .gpc_name = "csi-bridge", > + .rst_mask = BIT(0) | BIT(1) | BIT(2), > + .clk_mask = BIT(0) | BIT(1) | BIT(2) | BIT(3) | BIT(4) | BIT(5), > + }, > + [IMX8MM_DISPBLK_LCDIF] = { > + .name = "dispblk-lcdif", > + .clk_names = (const char *[]){ "lcdif-axi", "lcdif-apb", "lcdif-pix", }, > + .num_clks = 3, > + .gpc_name = "lcdif", > + .clk_mask = BIT(6) | BIT(7), > + }, > + [IMX8MM_DISPBLK_MIPI_DSI] = { > + .name = "dispblk-mipi-dsi", > + .clk_names = (const char *[]){ "dsi-pclk", "dsi-ref", }, > + .num_clks = 2, > + .gpc_name = "mipi-dsi", > + .rst_mask = BIT(5), > + .clk_mask = BIT(8) | BIT(9), > + }, > + [IMX8MM_DISPBLK_MIPI_CSI] = { > + .name = "dispblk-mipi-csi", > + .clk_names = (const char *[]){ "csi-aclk", "csi-pclk" }, > + .num_clks = 2, > + .gpc_name = "mipi-csi", > + .rst_mask = BIT(3) | BIT(4), > + .clk_mask = BIT(10) | BIT(11), > + }, > +}; > + > +static const struct imx8m_blk_ctrl_data imx8m_disp_blk_ctl_dev_data = { > + .max_reg = 0x2c, > + .power_notifier_fn = imx8mm_disp_power_notifier, > + .domains = imx8m_disp_blk_ctl_domain_data, > + .num_domains = ARRAY_SIZE(imx8m_disp_blk_ctl_domain_data), > +}; > + > static const struct of_device_id imx8m_blk_ctrl_of_match[] = { > { > .compatible = "fsl,imx8mm-vpu-blk-ctrl", > .data = &imx8m_vpu_blk_ctl_dev_data > }, { > + .compatible = "fsl,imx8mm-disp-blk-ctrl", > + .data = &imx8m_disp_blk_ctl_dev_data > + } ,{ > /* Sentinel */ > } > }; > -- > 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel