[U-Boot] [PATCH 3/4] fsl-layerscape/ls1046aqds: Integrate FSL PPA

[Z.Q. Hou <zhiqiang.hou@nxp.com>]

Hi York,

Thanks a lot for your comments!

> -----Original Message-----
> From: York Sun [mailto:york.sun at nxp.com]
> Sent: 2017年4月19日 0:46
> To: Z.Q. Hou <zhiqiang.hou@nxp.com>; u-boot at lists.denx.de; Mingkai Hu
> <mingkai.hu@nxp.com>
> Subject: Re: [PATCH 3/4] fsl-layerscape/ls1046aqds: Integrate FSL PPA
> 
> On 04/14/2017 12:03 AM, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The PPA is a EL3 firmware, which support PSCI, hotplug,
> > power-management features etc.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  board/freescale/ls1046aqds/ls1046aqds.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/board/freescale/ls1046aqds/ls1046aqds.c
> > b/board/freescale/ls1046aqds/ls1046aqds.c
> > index af3f70a..595b1e8 100644
> > --- a/board/freescale/ls1046aqds/ls1046aqds.c
> > +++ b/board/freescale/ls1046aqds/ls1046aqds.c
> > @@ -10,6 +10,7 @@
> >  #include <asm/io.h>
> >  #include <asm/arch/clock.h>
> >  #include <asm/arch/fsl_serdes.h>
> > +#include <asm/arch/ppa.h>
> >  #include <asm/arch/fdt.h>
> >  #include <asm/arch/mmu.h>
> >  #include <asm/arch/soc.h>
> > @@ -265,6 +266,10 @@ int board_init(void)
> >  	if (adjust_vdd(0))
> >  		printf("Warning: Adjusting core voltage failed.\n");
> >
> > +#ifdef CONFIG_FSL_LS_PPA
> > +	ppa_init();
> > +#endif
> > +
> 
> Zhiqiang,
> 
> This patch looks OK. While you are verifying PPA, can you check if you can
> remove the calling of enable_layerscape_ns_access() in the same file? It is
> required for PPA to work, but I believe it is already called in
> board_early_init_f(), by calling fsl_lsch2_early_init_f().

Yes, you're right, and I will send another patch to remove the duplicate call.

Thanks,
Zhiqiang