All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Camelia Alexandra Groza (OSS)" <camelia.groza@oss.nxp.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
Date: Thu, 12 Aug 2021 08:42:29 +0000	[thread overview]
Message-ID: <AM6PR04MB3976A72707A65CB74B11AFFCECF99@AM6PR04MB3976.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210812083806.28434-4-lukas.bulwahn@gmail.com>

> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Sent: 12 August 2021 11:38
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; netdev@vger.kernel.org
> Cc: Madalin Bucur <madalin.bucur@nxp.com>; Randy Dunlap
> <rdunlap@infradead.org>; kernel-janitors@vger.kernel.org; linux-
> kernel@vger.kernel.org; Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
> FSL_DPAA_ETH
> 
> The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
> FSL_FMAN_MAC never existed in the kernel tree.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
> FSL_FMAN_MAC
> Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
> 
> Remove this dead select in menuconfig FSL_DPAA_ETH.
> 
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig
> b/drivers/net/ethernet/freescale/dpaa/Kconfig
> index 626ec58a0afc..0e1439fd00bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> @@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
>  	depends on FSL_DPAA && FSL_FMAN
>  	select PHYLIB
>  	select FIXED_PHY
> -	select FSL_FMAN_MAC
>  	help
>  	  Data Path Acceleration Architecture Ethernet driver,
>  	  supporting the Freescale QorIQ chips.
> --
> 2.17.1

Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>

  reply	other threads:[~2021-08-12  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  8:38 [PATCH 0/3] Kconfig symbol clean-up on net Lukas Bulwahn
2021-08-12  8:38 ` [PATCH 1/3] net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES Lukas Bulwahn
2021-08-12  8:38 ` [PATCH 2/3] net: 802: remove dead leftover after ipx driver removal Lukas Bulwahn
2021-08-12  8:38 ` [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH Lukas Bulwahn
2021-08-12  8:42   ` Madalin Bucur (OSS) [this message]
2021-08-13 23:34 ` [PATCH 0/3] Kconfig symbol clean-up on net Jakub Kicinski
2021-08-13 23:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB3976A72707A65CB74B11AFFCECF99@AM6PR04MB3976.eurprd04.prod.outlook.com \
    --to=madalin.bucur@oss.nxp.com \
    --cc=camelia.groza@oss.nxp.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.