From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D9ECC433EF for ; Wed, 2 Feb 2022 09:06:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1EC7C838A8; Wed, 2 Feb 2022 10:06:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="f81Dznaq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 79800838A7; Wed, 2 Feb 2022 10:06:37 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on061c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::61c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 82E108388D for ; Wed, 2 Feb 2022 10:06:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=priyanka.jain@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eD9FNUH9xpRznltdwwWQCuYqTiqqL6+GpwLvoFDlcFzydov0rc/hfnJHyz+anUcrQ+JKXB70IyrD365gD2IbX/FsvE3+PZi7FzHivsGFg6PxjC2WJEKaM+mDDdvAV2pV4U7H5GIPCnXSUi4EwBJM5R1nCXsNHSc3GK7xSzNDKxdgrnEvbEqmkz/XovhtdZal6ir6QFXimZy/FD/pA/a41r88V2TzPtyVvKRaJ83cLOBOCEf5quuwdX/q496YV048TAzEHvFU71P3gMoB87TzAi7HO/SUBkDYic2u9IaBAoSDk1PSD8+gNiDjWjLsJN6bBrRHEB5FKkbGTPWgyzvVzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCcROLp2DXtRjsWrgj4yMjwIkfLlg7hYy1CZzWCbqQ4=; b=Hdz7QO1xA9xygRZ+tygWzfCjX52KKLh0YZCmS3NtWFwDuF9Qt/kg6IrfeFd4netbRkaytJDMxUZdfW6GxlkeOk4gvz+ZxUzIQgfx7vk0KsWCVBqORcAhoSzpIPKe4g5dnb4kyBVwPnvGi9at0coEpSmp4FAwYO4rgCYXETnkx90rCcOUPzFXjqfi18/6hAfDkfvfdNLNG2V/3CL3wvLZZ/RuNx9U3Goi0afTV27Agv8dbXAfBL/AVDDKRcPsWM9kqTRZBAzsqgrcUqBbbtaEm0iodzNfe02O7RldOq0xLYzpK0NrE1UCzSdxnNoxdJOEvf6PuvN81SzvyDeu/hDE6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCcROLp2DXtRjsWrgj4yMjwIkfLlg7hYy1CZzWCbqQ4=; b=f81Dznaq3q2by0nYLk74GiF88dX8OTZxMeAcyUG00JvFpJVlGUw+Vr6448RrLsePRdz4H3NshxrxI7/+cSokkwxt7tkJJ8N3HYVidz7w2aeNUP5JPMMM3OKpJrs7vMJUCj7WF44ACu8ulBHLf+nVa/KcuuJABm5WtszbbhpJ7Tg= Received: from AM6PR04MB5144.eurprd04.prod.outlook.com (2603:10a6:20b:a::32) by VI1PR04MB4000.eurprd04.prod.outlook.com (2603:10a6:803:4c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb 2022 09:06:31 +0000 Received: from AM6PR04MB5144.eurprd04.prod.outlook.com ([fe80::7:3119:7803:a86b]) by AM6PR04MB5144.eurprd04.prod.outlook.com ([fe80::7:3119:7803:a86b%6]) with mapi id 15.20.4930.021; Wed, 2 Feb 2022 09:06:30 +0000 From: Priyanka Jain To: Tom Rini , =?iso-8859-1?Q?Pali_Roh=E1r?= , Alison Wang , Mingkai Hu , Rajesh Bhagat , Jiafei Pan CC: Simon Glass , Alexandru Gagniuc , Yann Dirson , Stefan Roese , =?iso-8859-1?Q?Marek_Beh=FAn?= , "u-boot@lists.denx.de" Subject: RE: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk Thread-Topic: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk Thread-Index: AQHYCW0eoP7EYSWntEaeuYoRAPq43axuBt+AgABJbgCAAAjDgIAA7wwAgAABCwCAEKbdIA== Date: Wed, 2 Feb 2022 09:06:30 +0000 Message-ID: References: <20220114173443.9877-1-pali@kernel.org> <20220121212133.GA2826984@bill-the-cat> <20220122014422.4hir3y4a6ipqic42@pali> <20220122021543.GP7004@bill-the-cat> <20220122163118.5puevbiklty6xb5d@pali> <20220122163502.GR7004@bill-the-cat> In-Reply-To: <20220122163502.GR7004@bill-the-cat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8772c519-3aa9-49c7-9052-08d9e62b4d8b x-ms-traffictypediagnostic: VI1PR04MB4000:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wSgSLCcm6hyq/bGzuFtODLDkGzY4wH8j7e+PJwvZzgP4RAmLcP1qd9K7vd2lMHSqun2nUFeLkFfHA8oTn62Gy8PBTmyE+0FQqZPfuV3bkolGcBf8MnNOisdwZgIcnf6aNaAE/lHKG+igFbeHaCxqx9azjbPB2HLJ3TdHrR5OC+oLxcAaVgF4zhtiKJihOKq+CVuLE5uX0epz2y7MEcNOi21ETOAxZhy9NRsTz75QsgJl/k9uTpWUsFRaUSs/MQDO+UX078C1wJp0pAsanwGDl2zOgZa7D0gFl5wgnS1W82Ya+zItyTA9hfb/xh6cA/83/F37U+TtL+z/lHv/VH4EDfqlrHLUH5iA03dy60418KAhts+IiOkHFI8f4T9BH0/FgNTLkIUZHczijJG9rjffnN6NpCVqdvwiFlpgCD5noSVhbnMXsorntBcnD361e15KXcvIHeIvmVBHx905W7Hf4SQq3qAPLOmsPSu9jUb6KrfODRoqYoIKIJ1OjGe5SLTLq/v9qF8zwKtT4OQ0IUXneCMpmfx4TK3jbFawR5zgzEYgTLNavxMr+CjYBtMo6d++rTU7AzvOWoleMkGi9Dja+uF/mVS3OVzWb+dMlQgLTQ24c4IH1pQ4eAup9YXhNbRElI52NKKIsYuJQ5Exff3N2C6fHoqZHZhym5hFPr9JOSGu1I+yd38AifjPzkndKtPwZQB2yS/onzm7Phuuo7bscg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5144.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(44832011)(66476007)(55236004)(122000001)(9686003)(4326008)(6636002)(66446008)(33656002)(8936002)(186003)(26005)(15650500001)(64756008)(66556008)(71200400001)(7696005)(8676002)(6506007)(54906003)(38100700002)(110136005)(66946007)(508600001)(86362001)(2906002)(52536014)(5660300002)(316002)(83380400001)(76116006)(55016003)(38070700005)(66574015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?n4H9SxrzWA7kWAdO1Sgycj0nQGvxLFku8iL7uLtjHuL2+ymHIZbfthBj6B?= =?iso-8859-1?Q?8Vi+AptDL6VHb3+nBl3iBTGNMtxjrmAok4uqtxsPX6MbFd/uUoMOz/gqb1?= =?iso-8859-1?Q?sVTsLq5MiBx2gWeqlNQodI1OU/jLLZI8sLRdOb0HmbPC2DUWSnYDR38m9F?= =?iso-8859-1?Q?cKUJCDuE+7leHCx9BO7qGTwIGtyFOw415F+4uxB0HB9A0w7wU0NcGtFLZ9?= =?iso-8859-1?Q?N7v8l+Dp/Khop+AkU0gO3PFwpUcf1uu+ZunHcLGFfXLYb6y5tFJ5WKi7s6?= =?iso-8859-1?Q?VkjkXlkB67bbfXUqHyAy8jttMS76B/pL6YkDVyc3UHCovf8Q13nP7ePrhK?= =?iso-8859-1?Q?qbehy/gTerLcvnQHcaL9voooCLpO16Kuo4mOoLYB/3CM32+aRaWXGbsbFQ?= =?iso-8859-1?Q?DuoX8NrLJWIEcWvNyrHdwVwa42zZ2k9MkA70kYJYkr/MOZzF0RVEoGXhmd?= =?iso-8859-1?Q?CeUbOAKoAiwyO3JwbKirQcVRrsgzuyWhoJZ9G1FhhBKAz5gzVmDXqhTxTO?= =?iso-8859-1?Q?anyBc0oGtkmBHmovzuc2IOUYO0N8UuZbAeCUsrJmqV/K1VE40V4drN1F82?= =?iso-8859-1?Q?mLW5t7iRJeElW3oH7V+n6QzaTEP02KpoaF9SC3ZJlS8x9eTkClRgOlM6ZV?= =?iso-8859-1?Q?vOHGCm6cLx7mwydCJNehGpqlXZYBjnn+N6/6fv6MhXiXwsJ73mj8UfCNoM?= =?iso-8859-1?Q?a5qQnRxYRZ1RnO0wkIwt2DXqvpCbW01LKPZRDH4oIvN1d3ttHV2wuPT5gx?= =?iso-8859-1?Q?Et1aZm3fjF7KynqCFh1Ofd3Kvosf9N0QnELz8iUsyk9oiDYmok3j1oIwWu?= =?iso-8859-1?Q?daoulCL+WdMEraSwpkoh1yAzKoW/Jk4KFy6fkQhsKmM5e1qWx6OYU2ve8l?= =?iso-8859-1?Q?Y79e+LEISFOcIGwfH2flPDg4f/pUXvswQHACaNt60TOQdo+nfVF7EkFh45?= =?iso-8859-1?Q?9oNehdU6pSZeuhWX1u9hw23Tv+Y4DFKgOR6BYunVxM96Z9XX9QlR271r6A?= =?iso-8859-1?Q?Ii89C2KkoiJwcNFPygtS6oG0+A9v1e7TwajiiR+eYW7QLT9h2FbkoihQtW?= =?iso-8859-1?Q?+UeXl2mRlKaqGllnH52bQ/r50uJUBZm83+9LUJl4zQrtQFKcJVMJMapjvx?= =?iso-8859-1?Q?/bnxFszGArrfKj/6Ogb7EWFpyKrbXqtHvyssz014KPGQ9FOwlDOq0Y0KnI?= =?iso-8859-1?Q?MCEcwTsXTRpklBEUudX+Fy5WWCNctXNVF+YY8TihzlQeVANlkcodXpAojh?= =?iso-8859-1?Q?OlOmBauVVnD//G2Uz+mR1de1h9epD5HHWzmme96XcDnFAQV9I+a1+0rWOK?= =?iso-8859-1?Q?q0BBLKpGpS4ZlcEmhAIAmwkdrVzqoRJ/cqG9Qo8nGr9ruYrvWy3R9cUc8C?= =?iso-8859-1?Q?MIHywkqjiV2Ksm50sYcKi08drcSwl+Qr35PF4tfh54Lv04OgURVS/uDF6z?= =?iso-8859-1?Q?DiPd7TD82T7jvcFTwUENL3UUQ8Z3iIR28d4fmiVbF2gGCGORigSvIi5jpe?= =?iso-8859-1?Q?CLUZx6LbKLml6AaeO9arJ4/3j9IZ/Nf1HsNxOM6bBfYlyMhS9dSvIQ8BlO?= =?iso-8859-1?Q?Gzv2ggdME8xVptqBtcvOzl0KrtHsoWVyKIKBLWOzaMRmb16rzkhjsQfe/S?= =?iso-8859-1?Q?IZDgCBJAVpD+gSYla7Os4s6+0RkVXO81d1mkZRdIR2ZiiWgjp+Yed9dRzN?= =?iso-8859-1?Q?Cu2xL1x+/mLMNyBRUD8=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5144.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8772c519-3aa9-49c7-9052-08d9e62b4d8b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 09:06:30.7203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4SUQWMVFBh3/2FOwBKTEw6ZmBhg2SZW1u2DqDIFf+tRoUCSeLYFpBfyb/BGbKzbmWzyIM8RdKTZevDqPMCR1WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4000 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean >-----Original Message----- >From: Tom Rini >Sent: Saturday, January 22, 2022 10:05 PM >To: Pali Roh=E1r ; Alison Wang ; >Priyanka Jain ; Mingkai Hu ; >Rajesh Bhagat >Cc: Simon Glass ; Alexandru Gagniuc >; Yann Dirson ; Stefan >Roese ; Marek Beh=FAn ; u- >boot@lists.denx.de >Subject: Re: [PATCH v2] tools: mkimage: Call verify_header after writing i= mage >to disk > >On Sat, Jan 22, 2022 at 05:31:18PM +0100, Pali Roh=E1r wrote: >> On Friday 21 January 2022 21:15:43 Tom Rini wrote: >> > On Sat, Jan 22, 2022 at 02:44:22AM +0100, Pali Roh=E1r wrote: >> > > On Friday 21 January 2022 16:21:33 Tom Rini wrote: >> > > > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Roh=E1r wrote: >> > > > >> > > > > If image backend provides verify_header callback then call it >> > > > > after writing image to disk. This ensures that written image is = correct. >> > > > > >> > > > > Signed-off-by: Pali Roh=E1r >> > > > > Reviewed-by: Stefan Roese >> > > > > Reviewed-by: Simon Glass >> > > > > --- >> > > > > tools/mkimage.c | 41 >> > > > > +++++++++++++++++++++++++++++++++++++++++ >> > > > > 1 file changed, 41 insertions(+) >> > > > >> > > > This breaks a number of platforms such as ls1021atwr_sdcard_qspi >> > > > and it's not clear to me why exactly. >> > > >> > > Maybe they were already broken and this patch just detected it? >> > > Or verify_header callback for particular image type is reject >> > > valid image? >> > > >> > > Do you have some pointers to failed build logs? >> > >> > Try building for ls1021atwr_sdcard_qspi with your patch applied, the >> > only new thing that's shown in the logs is the error message. >> >> So... I have tried following without this patch: >> >> $ make ls1021atwr_sdcard_qspi_defconfig $ make >> CROSS_COMPILE=3Darm-linux-gnueabi- -j8 >> >> It generated file spl/u-boot-spl.pbl without error. Now I called -l on >> this generated file for type pblimage and I got following output: >> >> $ ./tools/dumpimage -T pblimage -l spl/u-boot-spl.pbl GP Header: Size >> aa55aa55 LoadAddr 1ee0100 >> >> $ ./tools/mkimage -T pblimage -l spl/u-boot-spl.pbl GP Header: Size >> aa55aa55 LoadAddr 1ee0100 >> >> "GP Header:" line is from the TI OMAP image backend type gpimage or >> type omapimage (implemented in file gpimage-common.c). >> >> So it means that files generated by ls1021atwr_sdcard_qspi are already >> broken and my patch just detected it. Or it is also possible that >> validation code in pblimage.c file is incorrect and broken. >> >> What to do with it now? > >Thanks for digging. This is a problem for a number of the ls1021, >ls1043 and ls1046 platforms, so lets add some maintainers there. > >-- >Tom I will ask NXP-platform owners to check on this. Thanks Priyanka