All of lore.kernel.org
 help / color / mirror / Atom feed
From: Priyanka Jain <priyanka.jain@nxp.com>
To: "Wasim Khan (OSS)" <wasim.khan@oss.nxp.com>,
	Varun Sethi <V.Sethi@nxp.com>,
	"Bedel, Alban" <alban.bedel@aerq.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Wasim Khan <wasim.khan@nxp.com>
Subject: RE: [PATCH] armv8: fsl : create bootcmd and mcinitcmd as per boot source
Date: Mon, 12 Jul 2021 08:06:31 +0000	[thread overview]
Message-ID: <AM6PR04MB5144CD37AA9C2A427D3663A8E6159@AM6PR04MB5144.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210708070542.1022155-1-wasim.khan@oss.nxp.com>



>-----Original Message-----
>From: Wasim Khan (OSS) <wasim.khan@oss.nxp.com>
>Sent: Thursday, July 8, 2021 12:36 PM
>To: Priyanka Jain <priyanka.jain@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
>Bedel, Alban <alban.bedel@aerq.com>
>Cc: u-boot@lists.denx.de; Wasim Khan <wasim.khan@nxp.com>
>Subject: [PATCH] armv8: fsl : create bootcmd and mcinitcmd as per boot
>source
>
>From: Wasim Khan <wasim.khan@nxp.com>
>
>NXP platforms expect custom bootcmd and mcinitcmd to be updated as per
>boot source with default environment.
>Check env variable fsl_bootcmd_mcinitcmd_set to prepare bootcmd and
>mcinitcmd
>
>Fixes cbf77d2018
>
>Suggested-by: Alban Bedel <alban.bedel@aerq.com>
>Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
>---
> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>index c3cd6c7ac7..f804a7f68d 100644
>--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>@@ -953,12 +953,15 @@ int board_late_init(void)  #endif  #ifdef
>CONFIG_TFABOOT
> 	/*
>-	 * Set bootcmd and mcinitcmd if they don't exist in the environment.
>+	 * Set bootcmd and mcinitcmd if "fsl_bootcmd_mcinitcmd_set" does
>+	 * not exists in env
> 	 */
>-	if (!env_get("bootcmd"))
>+	if (env_get_yesno("fsl_bootcmd_mcinitcmd_set") <= 0) {
>+		// Set bootcmd and mcinitcmd as per boot source
> 		fsl_setenv_bootcmd();
>-	if (!env_get("mcinitcmd"))
> 		fsl_setenv_mcinitcmd();
>+		env_set("fsl_bootcmd_mcinitcmd_set", "y");
>+	}
> #endif
> #ifdef CONFIG_QSPI_AHB_INIT
> 	qspi_ahb_init();
>--
>2.25.1

Alban,

Is it possible for you to test this if it works fine in your environment?

Regards
Priyanka


  reply	other threads:[~2021-07-12  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  7:05 [PATCH] armv8: fsl : create bootcmd and mcinitcmd as per boot source Wasim Khan
2021-07-12  8:06 ` Priyanka Jain [this message]
2021-07-20  9:01   ` Priyanka Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB5144CD37AA9C2A427D3663A8E6159@AM6PR04MB5144.eurprd04.prod.outlook.com \
    --to=priyanka.jain@nxp.com \
    --cc=V.Sethi@nxp.com \
    --cc=alban.bedel@aerq.com \
    --cc=u-boot@lists.denx.de \
    --cc=wasim.khan@nxp.com \
    --cc=wasim.khan@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.