All of lore.kernel.org
 help / color / mirror / Atom feed
From: fin4478@hotmail.com (fin4478 fin4478)
Subject: A kernel warning when entering suspend
Date: Sat, 6 Apr 2019 16:12:12 +0000	[thread overview]
Message-ID: <AM6PR06MB50635FC76FFD74DA6C423182A1520@AM6PR06MB5063.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <5088f9f9-678d-4e67-daf0-c8f9629baeea@oracle.com>

On Sat, 6 Apr 2019 23:31:51 +0800
Dongli Zhang <dongli.zhang@oracle.com> wrote:


> I am not able to reproduce anymore with below patch:
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index a90cf5d..90f6e80 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1083,6 +1083,9 @@ static int nvme_poll_irqdisable(struct
> nvme_queue *nvmeq, unsigned int tag)
>         u16 start, end;
>         int found;
> 
> +       if (!nvme_cqe_pending(nvmeq))
> +               return 0;
> +
>         /*
>          * For a poll queue we need to protect against the polling
> thread
>          * using the CQ lock.  For normal interrupt driven threads we
> have
> 
> Dongli Zhang

Confirming. This bug is fixed with this patch.
[   48.690299] PM: suspend entry (deep)
[   48.690300] PM: Syncing filesystems ... done.
[   48.691215] Freezing user space processes ... (elapsed 0.000
seconds) done. [   48.692025] OOM killer disabled.
[   48.692025] Freezing remaining freezable tasks ... (elapsed 0.000
seconds) done. [   48.693033] printk: Suspending console(s) (use
no_console_suspend to debug) [   48.693569] r8169 0000:07:00.0 enp7s0:
Link is Down [   48.693586] serial 00:03: disabled
[   48.702049] sd 5:0:0:0: [sda] Synchronizing SCSI cache
[   48.702076] sd 5:0:0:0: [sda] Stopping disk
[   49.049134] ACPI: Preparing to enter system sleep state S3
[   49.353355] PM: Saving platform NVS memory
[   49.353362] Disabling non-boot CPUs ...
[   49.354764] smpboot: CPU 1 is now offline

Thank You.

  reply	other threads:[~2019-04-06 16:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04  8:23 A kernel warning when entering suspend fin4478 fin4478
2019-04-04  8:55 ` Ming Lei
2019-04-04 11:14   ` Thomas Gleixner
2019-12-23 14:52     ` Maxim Levitsky
2020-01-16 13:58       ` Maxim Levitsky
2019-04-04 15:37   ` Dongli Zhang
2019-04-04 16:18     ` Thomas Gleixner
2019-04-04 22:19       ` Ming Lei
2019-04-04 22:29         ` Keith Busch
2019-04-04 22:50           ` Ming Lei
2019-04-04 22:50             ` Ming Lei
2019-04-05 11:35             ` Thomas Gleixner
2019-04-05 11:35               ` Thomas Gleixner
2019-04-06 14:29         ` Dongli Zhang
2019-04-06 15:31           ` Dongli Zhang
2019-04-06 16:12             ` fin4478 fin4478 [this message]
2019-04-08 15:07               ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR06MB50635FC76FFD74DA6C423182A1520@AM6PR06MB5063.eurprd06.prod.outlook.com \
    --to=fin4478@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.