From mboxrd@z Thu Jan 1 00:00:00 1970 From: Honnappa Nagarahalli Subject: Re: [PATCH v3 1/3] ring: read tail using atomic load Date: Fri, 5 Oct 2018 15:11:44 +0000 Message-ID: References: <20180807031943.5331-1-gavin.hu@arm.com> <1537172244-64874-1-git-send-email-gavin.hu@arm.com> <20180929104857.GA30457@jerin> <2601191342CEEE43887BDE71AB9772580102FE261A@IRSMSX106.ger.corp.intel.com> <621E373E-048D-4808-8CE8-84373EA98D2F@arm.com> <2601191342CEEE43887BDE71AB9772580102FE2951@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , Steve Capper , nd , "stable@dpdk.org" To: "Ananyev, Konstantin" , Ola Liljedahl , "Gavin Hu (Arm Technology China)" , Jerin Jacob Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE2951@IRSMSX106.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PiA+ICAgICAgICAgPg0KPiA+ICAgICAgICAgPiBIaSBKZXJpbiwNCj4gPiAgICAgICAgID4NCj4g PiAgICAgICAgID4gVGhhbmtzIGZvciB5b3VyIHJldmlldywgaW5saW5lIGNvbW1lbnRzIGZyb20g b3VyIGludGVybmFsDQo+IGRpc2N1c3Npb25zLg0KPiA+ICAgICAgICAgPg0KPiA+ICAgICAgICAg PiBCUi4gR2F2aW4NCj4gPiAgICAgICAgID4NCj4gPiAgICAgICAgID4gPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiA+ICAgICAgICAgPiA+IEZyb206IEplcmluIEphY29iIDxqZXJpbi5q YWNvYkBjYXZpdW1uZXR3b3Jrcy5jb20+DQo+ID4gICAgICAgICA+ID4gU2VudDogU2F0dXJkYXks IFNlcHRlbWJlciAyOSwgMjAxOCA2OjQ5IFBNDQo+ID4gICAgICAgICA+ID4gVG86IEdhdmluIEh1 IChBcm0gVGVjaG5vbG9neSBDaGluYSkgPEdhdmluLkh1QGFybS5jb20+DQo+ID4gICAgICAgICA+ ID4gQ2M6IGRldkBkcGRrLm9yZzsgSG9ubmFwcGEgTmFnYXJhaGFsbGkNCj4gPiAgICAgICAgID4g PiA8SG9ubmFwcGEuTmFnYXJhaGFsbGlAYXJtLmNvbT47IFN0ZXZlIENhcHBlcg0KPiA+ICAgICAg ICAgPiA+IDxTdGV2ZS5DYXBwZXJAYXJtLmNvbT47IE9sYSBMaWxqZWRhaGwgPE9sYS5MaWxqZWRh aGxAYXJtLmNvbT47DQo+IG5kDQo+ID4gICAgICAgICA+ID4gPG5kQGFybS5jb20+OyBzdGFibGVA ZHBkay5vcmcNCj4gPiAgICAgICAgID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDEvM10gcmlu ZzogcmVhZCB0YWlsIHVzaW5nIGF0b21pYyBsb2FkDQo+ID4gICAgICAgICA+ID4NCj4gPiAgICAg ICAgID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ICAgICAgICAgPiA+ID4gRGF0 ZTogTW9uLCAxNyBTZXAgMjAxOCAxNjoxNzoyMiArMDgwMA0KPiA+ICAgICAgICAgPiA+ID4gRnJv bTogR2F2aW4gSHUgPGdhdmluLmh1QGFybS5jb20+DQo+ID4gICAgICAgICA+ID4gPiBUbzogZGV2 QGRwZGsub3JnDQo+ID4gICAgICAgICA+ID4gPiBDQzogZ2F2aW4uaHVAYXJtLmNvbSwgSG9ubmFw cGEuTmFnYXJhaGFsbGlAYXJtLmNvbSwNCj4gPiAgICAgICAgID4gPiA+IHN0ZXZlLmNhcHBlckBh cm0uY29tLCAgT2xhLkxpbGplZGFobEBhcm0uY29tLA0KPiA+ICAgICAgICAgPiA+ID4gamVyaW4u amFjb2JAY2F2aXVtbmV0d29ya3MuY29tLCBuZEBhcm0uY29tLA0KPiBzdGFibGVAZHBkay5vcmcN Cj4gPiAgICAgICAgID4gPiA+IFN1YmplY3Q6IFtQQVRDSCB2MyAxLzNdIHJpbmc6IHJlYWQgdGFp bCB1c2luZyBhdG9taWMgbG9hZA0KPiA+ICAgICAgICAgPiA+ID4gWC1NYWlsZXI6IGdpdC1zZW5k LWVtYWlsIDIuNy40DQo+ID4gICAgICAgICA+ID4gPg0KPiA+ICAgICAgICAgPiA+ID4gRXh0ZXJu YWwgRW1haWwNCj4gPiAgICAgICAgID4gPiA+DQo+ID4gICAgICAgICA+ID4gPiBJbiB1cGRhdGVf dGFpbCwgcmVhZCBodC0+dGFpbCB1c2luZyBfX2F0b21pY19sb2FkLkFsdGhvdWdoIHRoZQ0KPiA+ ICAgICAgICAgPiA+ID4gY29tcGlsZXIgY3VycmVudGx5IHNlZW1zIHRvIGJlIGRvaW5nIHRoZSBy aWdodCB0aGluZyBldmVuIHdpdGhvdXQNCj4gPiAgICAgICAgID4gPiA+IF9hdG9taWNfbG9hZCwg d2UgZG9uJ3Qgd2FudCB0byBnaXZlIHRoZSBjb21waWxlciBmcmVlZG9tIHRvDQo+IG9wdGltaXNl DQo+ID4gICAgICAgICA+ID4gPiB3aGF0IHNob3VsZCBiZSBhbiBhdG9taWMgbG9hZCwgaXQgc2hv dWxkIG5vdCBiZSBhcmJpdGFyaWx5IG1vdmVkDQo+ID4gICAgICAgICA+ID4gPiBhcm91bmQuDQo+ ID4gICAgICAgICA+ID4gPg0KPiA+ICAgICAgICAgPiA+ID4gRml4ZXM6IDM5MzY4ZWJmYzYgKCJy aW5nOiBpbnRyb2R1Y2UgQzExIG1lbW9yeSBtb2RlbCBiYXJyaWVyDQo+IG9wdGlvbiIpDQo+ID4g ICAgICAgICA+ID4gPiBDYzogc3RhYmxlQGRwZGsub3JnDQo+ID4gICAgICAgICA+ID4gPg0KPiA+ ICAgICAgICAgPiA+ID4gU2lnbmVkLW9mZi1ieTogR2F2aW4gSHUgPGdhdmluLmh1QGFybS5jb20+ DQo+ID4gICAgICAgICA+ID4gPiBSZXZpZXdlZC1ieTogSG9ubmFwcGEgTmFnYXJhaGFsbGkNCj4g PEhvbm5hcHBhLk5hZ2FyYWhhbGxpQGFybS5jb20+DQo+ID4gICAgICAgICA+ID4gPiBSZXZpZXdl ZC1ieTogU3RldmUgQ2FwcGVyIDxzdGV2ZS5jYXBwZXJAYXJtLmNvbT4NCj4gPiAgICAgICAgID4g PiA+IFJldmlld2VkLWJ5OiBPbGEgTGlsamVkYWhsIDxPbGEuTGlsamVkYWhsQGFybS5jb20+DQo+ ID4gICAgICAgICA+ID4gPiAtLS0NCj4gPiAgICAgICAgID4gPiA+ICBsaWIvbGlicnRlX3Jpbmcv cnRlX3JpbmdfYzExX21lbS5oIHwgMyArKy0NCj4gPiAgICAgICAgID4gPiA+ICAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4gICAgICAgICA+ID4gPg0K PiA+ICAgICAgICAgPiBUaGUgcmVhZCBvZiBodC0+dGFpbCBuZWVkcyB0byBiZSBhdG9taWMsIGEg bm9uLWF0b21pYyByZWFkIHdvdWxkIG5vdA0KPiBiZSBjb3JyZWN0Lg0KPiA+DQo+ID4gICAgICAg ICBUaGF0J3MgYSAzMmJpdCB2YWx1ZSBsb2FkLg0KPiA+ICAgICAgICAgQUZBSUsgb24gYWxsIENQ VXMgdGhhdCB3ZSBzdXBwb3J0IGl0IGlzIGFuIGF0b21pYyBvcGVyYXRpb24uDQo+ID4gICAgIFtP bGFdIEJ1dCB0aGF0IHRoZSBvcmRpbmFyeSBDIGxvYWQgaXMgdHJhbnNsYXRlZCB0byBhbiBhdG9t aWMgbG9hZCBmb3IgdGhlDQo+IHRhcmdldCBhcmNoaXRlY3R1cmUgaXMgaW5jaWRlbnRhbC4NCj4g Pg0KPiA+ICAgICBJZiB0aGUgZGVzaWduIHJlcXVpcmVzIGFuIGF0b21pYyBsb2FkICh3aGljaCBp cyB0aGUgY2FzZSBoZXJlKSwgd2UNCj4gPiBzaG91bGQgdXNlIGFuIGF0b21pYyBsb2FkIG9uIHRo ZSBsYW5ndWFnZSBsZXZlbC4gVGhlbiB3ZSBjYW4gYmUgc3VyZSBpdCB3aWxsDQo+IGFsd2F5cyBi ZSB0cmFuc2xhdGVkIHRvIGFuIGF0b21pYyBsb2FkIGZvciB0aGUgdGFyZ2V0IGluIHF1ZXN0aW9u IG9yDQo+IGNvbXBpbGF0aW9uIHdpbGwgZmFpbC4gV2UgZG9uJ3QgaGF2ZSB0byBkZXBlbmQgb24g YXNzdW1wdGlvbnMuDQo+IA0KPiBXZSBhbGwga25vdyB0aGF0IDMyYml0IGxvYWQvc3RvcmUgb24g Y3B1IHdlIHN1cHBvcnQgLSBhcmUgYXRvbWljLg0KPiBJZiBpdCB3b3VsZG4ndCBiZSB0aGUgY2Fz ZSAtIERQREsgd291bGQgYmUgYnJva2VuIGluIGRvemVuIHBsYWNlcy4NCj4gU28gd2hhdCB0aGUg cG9pbnQgdG8gcHJldGVuZCB0aGF0ICJpdCBtaWdodCBiZSBub3QgYXRvbWljIiBpZiB3ZSBkbyBr bm93IGZvcg0KPiBzdXJlIHRoYXQgaXQgaXM/DQo+IEkgZG8gdW5kZXJzdGFuZCB0aGF0IHlvdSB3 YW50IHRvIHVzZSBhdG9taWNfbG9hZChyZWxheGVkKSBoZXJlIGZvcg0KPiBjb25zaXN0ZW5jeSwg YW5kIHRvIGNvbmZvcm0gd2l0aCBDMTEgbWVtLW1vZGVsIGFuZCBJIGRvbid0IHNlZSBhbnkgaGFy bSBpbg0KPiB0aGF0Lg0KV2UgY2FuIGNvbnRpbnVlIHRvIGRpc2N1c3MgdGhlIHRvcGljLCBpdCBp cyBhIGdvb2QgZGlzY3Vzc2lvbi4gQnV0LCBhcyBmYXIgdGhpcyBwYXRjaCBpcyBjb25jZXJuZWQs IGNhbiBJIGNvbnNpZGVyIHRoaXMgYXMgdXMgaGF2aW5nIGEgY29uc2Vuc3VzPyBUaGUgZmlsZSBy dGVfcmluZ19jMTFfbWVtLmggaXMgc3BlY2lmaWNhbGx5IGZvciBDMTEgbWVtb3J5IG1vZGVsIGFu ZCBJIGFsc28gZG8gbm90IHNlZSBhbnkgaGFybSBpbiBoYXZpbmcgY29kZSB0aGF0IGNvbXBsZXRl bHkgY29uZm9ybXMgdG8gQzExIG1lbW9yeSBtb2RlbC4NCg0KPiBCdXQgYXJndW1lbnQgdGhhdCB3 ZSBzaG91bGRuJ3QgYXNzdW1lIDMyYml0IGxvYWQvc3RvcmUgb3BzIGFzIGF0b21pYw0KPiBzb3Vu ZHMgYSBiaXQgZmxha3kgdG8gbWUuDQo+IEtvbnN0YW50aW4NCj4gDQo+IA0KPiA+DQo+ID4NCj4g Pg0KPiA+ICAgICAgICAgPiBCdXQgdGhlcmUgYXJlIG5vIG1lbW9yeSBvcmRlcmluZyByZXF1aXJl bWVudHMgKHdpdGgNCj4gPiAgICAgICAgID4gcmVnYXJkcyB0byBvdGhlciBsb2FkcyBhbmQvb3Ig c3RvcmVzIGJ5IHRoaXMgdGhyZWFkKSBzbyByZWxheGVkDQo+IG1lbW9yeSBvcmRlciBpcyBzdWZm aWNpZW50Lg0KPiA+ICAgICAgICAgPiBBbm90aGVyIGFzcGVjdCBvZiB1c2luZyBfX2F0b21pY19s b2FkX24oKSBpcyB0aGF0IHRoZQ0KPiA+IGNvbXBpbGVyIGNhbm5vdCAib3B0aW1pc2UiIHRoaXMg bG9hZCAoZS5nLiBjb21iaW5lLCBob2lzdCBldGMpLCBpdCBoYXMgdG8gYmUNCj4gZG9uZSBhcw0K PiA+ICAgICAgICAgPiBzcGVjaWZpZWQgaW4gdGhlIHNvdXJjZSBjb2RlIHdoaWNoIGlzIGFsc28g d2hhdCB3ZSBuZWVkIGhlcmUuDQo+ID4NCj4gPiAgICAgICAgIEkgdGhpbmsgSmVyaW4gcG9pbnRz IHRoYXQgcnRlX3BhdXNlKCkgYWN0cyBoZXJlIGFzIGNvbXBpbGVyIGJhcnJpZXIgdG9vLA0KPiA+ ICAgICAgICAgc28gbm8gbmVlZCB0byB3b3JyeSB0aGF0IGNvbXBpbGVyIHdvdWxkIG9wdGltaXpl IG91dCB0aGUgbG9vcC4NCj4gPiAgICAgW09sYV0gU29ycnkgbWlzc2VkIHRoYXQuIEJ1dCB0aGUg YmFycmllciBiZWhhdmlvdXIgb2YgcnRlX3BhdXNlKCkNCj4gPiBpcyBub3QgcGFydCBvZiBDMTEs IGlzIGl0IGVzc2VudGlhbGx5IGEgaGFuZC1tYWRlIGZlYXR1cmUgdG8gc3VwcG9ydA0KPiA+IHRo ZSBsZWdhY3kgbXVsdGl0aHJlYWRlZCBtZW1vcnkgbW9kZWwgKHdoaWNoIHVzZXMgZXhwbGljaXQg SFcgYW5kDQo+IGNvbXBpbGVyIGJhcnJpZXJzKS4gSSdkIHByZWZlciBjb2RlIHVzaW5nIHRoZSBD MTEgbWVtb3J5IG1vZGVsIG5vdCB0bw0KPiBkZXBlbmQgb24gc3VjaCBsZWdhY3kgZmVhdHVyZXMu DQo+ID4NCj4gPg0KPiA+DQo+ID4gICAgICAgICBLb25zdGFudGluDQo+ID4NCj4gPiAgICAgICAg ID4NCj4gPiAgICAgICAgID4gT25lIHBvaW50IHdvcnRoIG1lbnRpb25pbmcgdGhvdWdoIGlzIHRo YXQgdGhpcyBjaGFuZ2UgaXMgZm9yDQo+ID4gdGhlIHJ0ZV9yaW5nX2MxMV9tZW0uaCBmaWxlLCBu b3QgdGhlIGxlZ2FjeSByaW5nLiBJdCBtYXkgYmUgd29ydGggcGVyc2lzdGluZw0KPiA+ICAgICAg ICAgPiB3aXRoIGdldHRpbmcgdGhlIEMxMSBjb2RlIHJpZ2h0IHdoZW4gcGVvcGxlIGFyZSBsZXNz IGV4Y2l0ZWQgYWJvdXQNCj4gc2VuZGluZyBhIHJlbGVhc2Ugb3V0Pw0KPiA+ICAgICAgICAgPg0K PiA+ICAgICAgICAgPiBXZSBjYW4gZXhwbGFpbiB0aGF0IGZvciBDMTEgd2Ugd291bGQgcHJlZmVy IHRvIGRvIGxvYWRzIGFuZCBzdG9yZXMNCj4gYXMgcGVyIHRoZSBDMTEgbWVtb3J5IG1vZGVsLiBJ biB0aGUgY2FzZSBvZiBydGVfcmluZywgdGhlIGNvZGUgaXMNCj4gPiAgICAgICAgID4gc2VwYXJh dGVkIGNsZWFubHkgaW50byBDMTEgc3BlY2lmaWMgZmlsZXMgYW55d2F5Lg0KPiA+ICAgICAgICAg Pg0KPiA+ICAgICAgICAgPiBJIHRoaW5rIHJlYWRpbmcgaHQtPnRhaWwgdXNpbmcgX19hdG9taWNf bG9hZF9uKCkgaXMgdGhlIG1vc3QNCj4gYXBwcm9wcmlhdGUgd2F5LiBXZSBzaG93IHRoYXQgaHQt PnRhaWwgaXMgdXNlZCBmb3Igc3luY2hyb25pemF0aW9uLCB3ZQ0KPiA+ICAgICAgICAgPiBhY2tu b3dsZWRnZSB0aGF0IGh0LT50YWlsIG1heSBiZSB3cml0dGVuIGJ5IG90aGVyIHRocmVhZHMNCj4g PiB3aXRob3V0IGFueSBvdGhlciBraW5kIG9mIHN5bmNocm9uaXphdGlvbiAoZS5nLiBubyBsb2Nr IGludm9sdmVkKSBhbmQgd2UNCj4gcmVxdWlyZQ0KPiA+ICAgICAgICAgPiBhbiBhdG9taWMgbG9h ZCAoYW55IHdyaXRlIHRvIGh0LT50YWlsIG11c3QgYWxzbyBiZSBhdG9taWMpLg0KPiA+ICAgICAg ICAgPg0KPiA+ICAgICAgICAgPiBVc2luZyB2b2xhdGlsZSBhbmQgZXhwbGljaXQgY29tcGlsZXIg KG9yIHByb2Nlc3NvcikgbWVtb3J5IGJhcnJpZXJzDQo+IChmZW5jZXMpIGlzIHRoZSBsZWdhY3kg cHJlLUMxMSB3YXkgb2YgYWNjb21wbGlzaGluZyB0aGVzZSB0aGluZ3MuDQo+ID4gVGhlcmUncw0K PiA+ICAgICAgICAgPiBhIHJlYXNvbiB3aHkgQzExL0MrKzExIG1vdmVkIGF3YXkgZnJvbSB0aGUg b2xkIHdheXMuDQo+ID4gICAgICAgICA+ID4gPg0KPiA+ICAgICAgICAgPiA+ID4gICAgICAgICBf X2F0b21pY19zdG9yZV9uKCZodC0+dGFpbCwgbmV3X3ZhbCwgX19BVE9NSUNfUkVMRUFTRSk7DQo+ ID4gICAgICAgICA+ID4gPiAtLQ0KPiA+ICAgICAgICAgPiA+ID4gMi43LjQNCj4gPiAgICAgICAg ID4gPiA+DQo+ID4NCj4gPg0KPiA+DQoNCg==