From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD48C433FE for ; Thu, 9 Sep 2021 12:57:15 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E5AA7611BD for ; Thu, 9 Sep 2021 12:57:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5AA7611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 61BB34B11E; Thu, 9 Sep 2021 08:57:14 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armh.onmicrosoft.com Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armh.onmicrosoft.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N90zgqKpky3j; Thu, 9 Sep 2021 08:57:13 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1706A4B106; Thu, 9 Sep 2021 08:57:13 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 281F44B104 for ; Thu, 9 Sep 2021 08:57:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EtisflZXXLOL for ; Thu, 9 Sep 2021 08:57:09 -0400 (EDT) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 95E144B0BA for ; Thu, 9 Sep 2021 08:57:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from DB3PR06CA0027.eurprd06.prod.outlook.com (2603:10a6:8:1::40) by DBBPR08MB4474.eurprd08.prod.outlook.com (2603:10a6:10:c2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 9 Sep 2021 12:57:06 +0000 Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::a4) by DB3PR06CA0027.outlook.office365.com (2603:10a6:8:1::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.cs.columbia.edu; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.cs.columbia.edu; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Thu, 09 Sep 2021 12:57:06 +0000 X-CR-MTA-TID: 64aa7808 Received: from e5ca704b8e4e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49F901FA-2EE5-4EDC-AE89-1DEF0FFC46DB.1; Thu, 09 Sep 2021 12:56:56 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5ca704b8e4e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Sep 2021 12:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGA52oiosLKDNqbLMSZ4Nt+pg2XzNnWF3tEe4T/W8y6Y3yGTm1M8Gy5Tm4oZjFqiz4LJADGuyrM+eyS5XoUAAb7ym9guMor0o/YoBtkotIiH5YZXDQ5zaimbj1mXITpDQ3ksiUJDdaHIHHtSXlHmCDIbwDVJOfqY23eTuumirbU4riLgHvHVXcMHFQi4BGs8sASMLYjjXRME7glztkqke38RRPxXuZZRvO2pcqajHnnT39B1hXZMxOUmnhW8XTq5OubppDz3IYC+PN2FcsonXtdQQ7MsSV127lNGombLb1P4ga99zYwkEayoGOM/YmIbxGvFR5XT8OH5gEU7UAjKnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=gHcKpql9yt+jLGxju7jEB7mGDjeky//COgn2IhHFIK9vKYp8VlfeKr8CUerG6GaNLgfvmfOv5eBxh2Y8Z4nyY0+MIIiFd3zHl45Oy6tU8hGDVnbZW6Ie+pUU54j4DBQffxaxztheqS5BwkMPbphiE7/XCCmxsDd43h/63rGQKhbrXFTBH52/5sJ2sdmqdwP01Gklg3RR9K114D6Fmtjc7d2G2T08clhZR4gktnkLc0OWlDZ85GGh0BypjMHjc8EN5JAmSRdr1ZD2qUgthMwdwlM62Rf9nnAsA4wTndZrgoz26CpvgBEuBz1v7j59r68XKPVRhqq3FehncAhGRiQVQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from AM6PR08MB4376.eurprd08.prod.outlook.com (2603:10a6:20b:bb::21) by AM6PR08MB2951.eurprd08.prod.outlook.com (2603:10a6:209:4e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep 2021 12:56:54 +0000 Received: from AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85]) by AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85%5]) with mapi id 15.20.4500.016; Thu, 9 Sep 2021 12:56:54 +0000 From: Justin He To: Oliver Upton Subject: RE: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Topic: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Index: AQHXo+SXY1+Y7PRqPEOtXG6vaRVv1auZJ8aAgAI+QxA= Date: Thu, 9 Sep 2021 12:56:53 +0000 Message-ID: References: <20210907123112.10232-1-justin.he@arm.com> <20210907123112.10232-3-justin.he@arm.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8C57A8ADD3029A4887FFE0F106D44668.0 x-checkrecipientchecked: true Authentication-Results-Original: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4afc6bab-1869-4954-0c1a-08d9739153ae x-ms-traffictypediagnostic: AM6PR08MB2951:|DBBPR08MB4474: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RXnSsvJKQI1XTJ2kESnnX1x9sagZJwq+s/YGfS2he5v14ZyYr0x0NhopD3uptwAS2nXUqUi/Xl8XLptmcMWYR4PYgpViRIGpQi4nUbVgcrtqjQRnerci3f61jd5xwmSCj1BsyYiLhFuTF3y2UYStXvsjG/HlM4EkXUnO03DBdzwoq/QLEbw52TOnaY3WsdlLtj4ocCQhgB29ZelUn2Cup2fB7m+fiHH2YHF5W9f2mbdQ1iOWyNi++T2a65yv9citzbNvubAcbsEowPf9uAMTPBi6jJO0ymHhhHk+jlLbp6KjwXA/0RokDB7EmtAL/HwWmlZg9nPuDWZFUe7H7soD42ySpHAH9R250k79kEqrnpgL8b7LDd566xwUBenlMXJs9brewwywS5NukITthmAURJH19S+3WnslMifOqo5yYP6/gR8srieIPhWn/z547xshNWsX8nDUmYpYmx5iKTiLRNIKjCLyMqCVmKpA6zQ44qN7gM9zSI+zDWdn2R+w2Gjdg4YTBS/dugTawLoi+HJHLhxFAccdILiFU2X2/k/QGl/nNF9kux5g5Ckt+ylry7s864pv8gLPcNKKCFmtMl0YXScsx5BsoD4oHdxDHBCNWrhu5TLZgUixC/KqUBn5lCwAGzaGPyeSgQsbt6MUZ4auebRT2tSU+Zz5rkzhlm89UVP9hJftu8NnNhrvJ9J/+PoYlJ/YWq3VVbrU7tpl7ISEOvbhUMPwoJ6cW+wv3oCPMmU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4376.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(122000001)(5660300002)(71200400001)(38100700002)(86362001)(2906002)(83380400001)(316002)(38070700005)(26005)(52536014)(66556008)(54906003)(33656002)(8936002)(6916009)(478600001)(66946007)(186003)(9686003)(7416002)(8676002)(55016002)(66476007)(15650500001)(7696005)(76116006)(53546011)(4326008)(6506007)(64756008)(66446008)(21314003); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2951 Original-Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 441c2f1a-f5b3-4d4f-435e-08d973914c7b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jo/Z6kllQjqkF0h9g+/9fO082EzcdMO2COYiR/eWE/dCOXWt6lR6QeTUCTdMhlMA023+J8bpn/huZH0GgJPzeV61gVOTtQprzl4HGVfF9CPv2ktqHdmgAXHLkLNlFrfT3ZAYDVrYTZXx54LD0CCgo7drmRv1SVIswPoixyt7gJmopxMpkCe7iZ4WbxTsRsQ2+1RSQ6kt/KiekDWHqfnBLA2eFBzqQYyQd5dq9ftMRUIRV3538naHjJ/wAM2AXaqfq1pTemb82KmiedOXWZrarpQrRAk7EsRR2Stcxm9crKEdPg4gtMYowMV6SN76bZ8dWtzEsdusLzpuy2B17DyzZjrri6KpbI3HPvHQjjHKcyGzLBD8hfO1Jd9keJCbUx/vAE9hW/ajAcSl5IBF7SzHDWQVIsAHSt9BNF67VnkkywzuSRbsCkjrSi44hBHhoODB1MPrMzK78pq9isiAGaIgj8B3sGvPh6kXHgEM6tQQzHIDqaZlGxdPU58LmijH2ra0NY7BzyS4PT8m5pFUWF3IwoIJevp4ElfC3PgwnF7mBHiZNprQ3ON6K1u2Ue2DInFVjOqG56Ew4cqN0QDZa8OLvQNadOfJcIPB7agGicZ8Kc2919YQv381/Ylo3wSHQlq3h5vkflJXa4Tp3uce2pS9ZMauKyrcBfGnRvVTli/AJ2FHstyhVsuozh1Mb7W2NXdkoCBe/5ogZM3IGFmjI+N1d5i1rKetz3VWY2jYWow+HMA= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(346002)(136003)(46966006)(36840700001)(33656002)(26005)(9686003)(55016002)(336012)(47076005)(83380400001)(186003)(54906003)(70586007)(86362001)(5660300002)(52536014)(107886003)(82310400003)(70206006)(316002)(6506007)(4326008)(356005)(8676002)(6862004)(478600001)(2906002)(7696005)(8936002)(53546011)(82740400003)(15650500001)(81166007)(36860700001)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 12:57:06.0933 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4afc6bab-1869-4954-0c1a-08d9739153ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4474 Cc: Nick Desaulniers , Lorenzo Pieralisi , Kees Cook , Will Deacon , Marc Zyngier , "linux-kernel@vger.kernel.org" , Liu Shixin , Sami Tolvanen , Catalin Marinas , Xiaoming Ni , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Oliver, thanks for the review, please my comments below: > -----Original Message----- > From: Oliver Upton > Sent: Wednesday, September 8, 2021 6:29 AM > To: Justin He > Cc: Marc Zyngier ; James Morse ; > Alexandru Elisei ; Suzuki Poulose > ; Xiaoming Ni ; Lorenzo > Pieralisi ; Kees Cook ; > Catalin Marinas ; Nick Desaulniers > ; linux-kernel@vger.kernel.org; Liu Shixin > ; Sami Tolvanen ; Will > Deacon ; kvmarm@lists.cs.columbia.edu; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM > allocations > > Hi Jia, > > On Tue, Sep 7, 2021 at 7:33 AM Jia He wrote: > > > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > > allocations"), it would be better to make arm64 KVM consistent with > > common kvm codes. > > > > The memory allocations of VM scope should be charged into VM process > > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > > > There remain a few cases since these allocations are global, not in VM > > scope. > > I believe there are more memory allocations that could be switched to > GFP_KERNEL_ACCOUNT. For non-pKVM kernels, we probably should charge > all stage-2 paging structure allocations to the VM process. Your patch > appears to only change the allocation of the kvm_pgtable structure, > but not descendent paging structures. > Do you mean kvm_hyp_zalloc_page() here? Seems kvm_hyp_zalloc_page() is in both global and VM scopes. I will replace GFP_KERNEL with XXX_ACCOUNT in next version if no one objects that. -- Cheers, Justin (Jia He) _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEBEC28CA5 for ; Thu, 9 Sep 2021 13:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5A17611AF for ; Thu, 9 Sep 2021 13:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358792AbhIINJi (ORCPT ); Thu, 9 Sep 2021 09:09:38 -0400 Received: from mail-eopbgr140049.outbound.protection.outlook.com ([40.107.14.49]:26081 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236787AbhIIM6S (ORCPT ); Thu, 9 Sep 2021 08:58:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from AM6PR05CA0031.eurprd05.prod.outlook.com (2603:10a6:20b:2e::44) by AS8PR08MB5880.eurprd08.prod.outlook.com (2603:10a6:20b:29f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep 2021 12:57:06 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::c8) by AM6PR05CA0031.outlook.office365.com (2603:10a6:20b:2e::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Thu, 09 Sep 2021 12:57:06 +0000 X-CR-MTA-TID: 64aa7808 Received: from e5ca704b8e4e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49F901FA-2EE5-4EDC-AE89-1DEF0FFC46DB.1; Thu, 09 Sep 2021 12:56:56 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5ca704b8e4e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Sep 2021 12:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGA52oiosLKDNqbLMSZ4Nt+pg2XzNnWF3tEe4T/W8y6Y3yGTm1M8Gy5Tm4oZjFqiz4LJADGuyrM+eyS5XoUAAb7ym9guMor0o/YoBtkotIiH5YZXDQ5zaimbj1mXITpDQ3ksiUJDdaHIHHtSXlHmCDIbwDVJOfqY23eTuumirbU4riLgHvHVXcMHFQi4BGs8sASMLYjjXRME7glztkqke38RRPxXuZZRvO2pcqajHnnT39B1hXZMxOUmnhW8XTq5OubppDz3IYC+PN2FcsonXtdQQ7MsSV127lNGombLb1P4ga99zYwkEayoGOM/YmIbxGvFR5XT8OH5gEU7UAjKnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=gHcKpql9yt+jLGxju7jEB7mGDjeky//COgn2IhHFIK9vKYp8VlfeKr8CUerG6GaNLgfvmfOv5eBxh2Y8Z4nyY0+MIIiFd3zHl45Oy6tU8hGDVnbZW6Ie+pUU54j4DBQffxaxztheqS5BwkMPbphiE7/XCCmxsDd43h/63rGQKhbrXFTBH52/5sJ2sdmqdwP01Gklg3RR9K114D6Fmtjc7d2G2T08clhZR4gktnkLc0OWlDZ85GGh0BypjMHjc8EN5JAmSRdr1ZD2qUgthMwdwlM62Rf9nnAsA4wTndZrgoz26CpvgBEuBz1v7j59r68XKPVRhqq3FehncAhGRiQVQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from AM6PR08MB4376.eurprd08.prod.outlook.com (2603:10a6:20b:bb::21) by AM6PR08MB2951.eurprd08.prod.outlook.com (2603:10a6:209:4e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep 2021 12:56:54 +0000 Received: from AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85]) by AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85%5]) with mapi id 15.20.4500.016; Thu, 9 Sep 2021 12:56:54 +0000 From: Justin He To: Oliver Upton CC: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki Poulose , Xiaoming Ni , Lorenzo Pieralisi , Kees Cook , Catalin Marinas , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Liu Shixin , Sami Tolvanen , Will Deacon , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Topic: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Index: AQHXo+SXY1+Y7PRqPEOtXG6vaRVv1auZJ8aAgAI+QxA= Date: Thu, 9 Sep 2021 12:56:53 +0000 Message-ID: References: <20210907123112.10232-1-justin.he@arm.com> <20210907123112.10232-3-justin.he@arm.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8C57A8ADD3029A4887FFE0F106D44668.0 x-checkrecipientchecked: true Authentication-Results-Original: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: cb839bf6-643c-43ff-7586-08d973915403 x-ms-traffictypediagnostic: AM6PR08MB2951:|AS8PR08MB5880: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RXnSsvJKQI1XTJ2kESnnX1x9sagZJwq+s/YGfS2he5v14ZyYr0x0NhopD3uptwAS2nXUqUi/Xl8XLptmcMWYR4PYgpViRIGpQi4nUbVgcrtqjQRnerci3f61jd5xwmSCj1BsyYiLhFuTF3y2UYStXvsjG/HlM4EkXUnO03DBdzwoq/QLEbw52TOnaY3WsdlLtj4ocCQhgB29ZelUn2Cup2fB7m+fiHH2YHF5W9f2mbdQ1iOWyNi++T2a65yv9citzbNvubAcbsEowPf9uAMTPBi6jJO0ymHhhHk+jlLbp6KjwXA/0RokDB7EmtAL/HwWmlZg9nPuDWZFUe7H7soD42ySpHAH9R250k79kEqrnpgL8b7LDd566xwUBenlMXJs9brewwywS5NukITthmAURJH19S+3WnslMifOqo5yYP6/gR8srieIPhWn/z547xshNWsX8nDUmYpYmx5iKTiLRNIKjCLyMqCVmKpA6zQ44qN7gM9zSI+zDWdn2R+w2Gjdg4YTBS/dugTawLoi+HJHLhxFAccdILiFU2X2/k/QGl/nNF9kux5g5Ckt+ylry7s864pv8gLPcNKKCFmtMl0YXScsx5BsoD4oHdxDHBCNWrhu5TLZgUixC/KqUBn5lCwAGzaGPyeSgQsbt6MUZ4auebRT2tSU+Zz5rkzhlm89UVP9hJftu8NnNhrvJ9J/+PoYlJ/YWq3VVbrU7tpl7ISEOvbhUMPwoJ6cW+wv3oCPMmU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB4376.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(122000001)(5660300002)(71200400001)(38100700002)(86362001)(2906002)(83380400001)(316002)(38070700005)(26005)(52536014)(66556008)(54906003)(33656002)(8936002)(6916009)(478600001)(66946007)(186003)(9686003)(7416002)(8676002)(55016002)(66476007)(15650500001)(7696005)(76116006)(53546011)(4326008)(6506007)(64756008)(66446008)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2951 Original-Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 441c2f1a-f5b3-4d4f-435e-08d973914c7b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TlMhVk+Oaat5ItUgTTQxhmMAFSImZ92JEuOEF9+YEhMFu99nvdR5v3SRSAEby0BOfBnHE2meDY3g4YBEUOUg+qV3q5l0ax9GLdqtu8cyQz6tYpqUyaWeyEBFlEHboMqQkjgqZazUOmZRbtkaW28nJYBMqAIJ9LWmf4PMrwK/SLDVM1WjyAOvs07ZAgzHsR4eH8lS8PMkxS1tgk6+8H/Wat4fKuEIQ7YowjSNqj2zUxTwxI2LqMXD9HWz9hhrevKUvBbt2p7DDwZiBmqp+l8ckljuPw2+W1kUxT7/3YNIPby6F49/HAUM4rfppx53qB+HfCTHJBmfJGxR0EgNCpSBoSFTWpjdTBC285WOwpb8x9lhrRKfVpchWbWZ0CAxrSsDeA2BMRpQmsxSLuL1/gr4f/NXIdy0FI5AethuNmmBBGLBCNnnGPDdm+ZqCjO06kMobWIAhZLV/X0KQHP22wSHNL3rMhq0O3qH40eKgXv8GW6YjLDBpFcVGu/cYHIuzNAvw9H9gbX1o/D42+Q24NiCMY3CMoKHqX/bUcfD481oFU9iOCN/ljFTWVKVc5yagCzEMHADnPy49n+lvEUJCyznz13cIFTNGhk/3y8vpFLj77AjOs5fsk1WLaqZ0UlF13Iu2ZPeQJVH/sWpZRMobXU8vcVjGizufn3mw0HAVTgEchoKMqfRYrqe+7pkfv5tnrc3dP6/j80UNySPVDQQQJo5NPvaF5EQalm7J3jr1ZzJVEM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36860700001)(53546011)(86362001)(83380400001)(15650500001)(2906002)(6862004)(26005)(8936002)(6506007)(82310400003)(7696005)(4326008)(47076005)(33656002)(52536014)(186003)(9686003)(70206006)(5660300002)(107886003)(8676002)(316002)(81166007)(54906003)(70586007)(508600001)(336012)(55016002)(356005)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 12:57:06.5531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb839bf6-643c-43ff-7586-08d973915403 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5880 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgT2xpdmVyLCB0aGFua3MgZm9yIHRoZSByZXZpZXcsIHBsZWFzZSBteSBjb21tZW50cyBiZWxv dzoNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBPbGl2ZXIgVXB0b24g PG91cHRvbkBnb29nbGUuY29tPg0KPiBTZW50OiBXZWRuZXNkYXksIFNlcHRlbWJlciA4LCAyMDIx IDY6MjkgQU0NCj4gVG86IEp1c3RpbiBIZSA8SnVzdGluLkhlQGFybS5jb20+DQo+IENjOiBNYXJj IFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPjsgSmFtZXMgTW9yc2UgPEphbWVzLk1vcnNlQGFybS5j b20+Ow0KPiBBbGV4YW5kcnUgRWxpc2VpIDxBbGV4YW5kcnUuRWxpc2VpQGFybS5jb20+OyBTdXp1 a2kgUG91bG9zZQ0KPiA8U3V6dWtpLlBvdWxvc2VAYXJtLmNvbT47IFhpYW9taW5nIE5pIDxuaXhp YW9taW5nQGh1YXdlaS5jb20+OyBMb3JlbnpvDQo+IFBpZXJhbGlzaSA8TG9yZW56by5QaWVyYWxp c2lAYXJtLmNvbT47IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPjsNCj4gQ2F0YWxp biBNYXJpbmFzIDxDYXRhbGluLk1hcmluYXNAYXJtLmNvbT47IE5pY2sgRGVzYXVsbmllcnMNCj4g PG5kZXNhdWxuaWVyc0Bnb29nbGUuY29tPjsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsg TGl1IFNoaXhpbg0KPiA8bGl1c2hpeGluMkBodWF3ZWkuY29tPjsgU2FtaSBUb2x2YW5lbiA8c2Ft aXRvbHZhbmVuQGdvb2dsZS5jb20+OyBXaWxsDQo+IERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPjsg a3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdTsgbGludXgtYXJtLQ0KPiBrZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDIvMl0gS1ZNOiBhcm02NDog QWRkIG1lbWNnIGFjY291bnRpbmcgdG8gS1ZNDQo+IGFsbG9jYXRpb25zDQo+IA0KPiBIaSBKaWEs DQo+IA0KPiBPbiBUdWUsIFNlcCA3LCAyMDIxIGF0IDc6MzMgQU0gSmlhIEhlIDxqdXN0aW4uaGVA YXJtLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiBJbnNwaXJlZCBieSBjb21taXQgMjU0MjcyY2U2NTA1 ICgia3ZtOiB4ODY6IEFkZCBtZW1jZyBhY2NvdW50aW5nIHRvIEtWTQ0KPiA+IGFsbG9jYXRpb25z IiksIGl0IHdvdWxkIGJlIGJldHRlciB0byBtYWtlIGFybTY0IEtWTSBjb25zaXN0ZW50IHdpdGgN Cj4gPiBjb21tb24ga3ZtIGNvZGVzLg0KPiA+DQo+ID4gVGhlIG1lbW9yeSBhbGxvY2F0aW9ucyBv ZiBWTSBzY29wZSBzaG91bGQgYmUgY2hhcmdlZCBpbnRvIFZNIHByb2Nlc3MNCj4gPiBjZ3JvdXAs IGhlbmNlIGNoYW5nZSBHRlBfS0VSTkVMIHRvIEdGUF9LRVJORUxfQUNDT1VOVC4NCj4gPg0KPiA+ IFRoZXJlIHJlbWFpbiBhIGZldyBjYXNlcyBzaW5jZSB0aGVzZSBhbGxvY2F0aW9ucyBhcmUgZ2xv YmFsLCBub3QgaW4gVk0NCj4gPiBzY29wZS4NCj4gDQo+IEkgYmVsaWV2ZSB0aGVyZSBhcmUgbW9y ZSBtZW1vcnkgYWxsb2NhdGlvbnMgdGhhdCBjb3VsZCBiZSBzd2l0Y2hlZCB0bw0KPiBHRlBfS0VS TkVMX0FDQ09VTlQuIEZvciBub24tcEtWTSBrZXJuZWxzLCB3ZSBwcm9iYWJseSBzaG91bGQgY2hh cmdlDQo+IGFsbCBzdGFnZS0yIHBhZ2luZyBzdHJ1Y3R1cmUgYWxsb2NhdGlvbnMgdG8gdGhlIFZN IHByb2Nlc3MuIFlvdXIgcGF0Y2gNCj4gYXBwZWFycyB0byBvbmx5IGNoYW5nZSB0aGUgYWxsb2Nh dGlvbiBvZiB0aGUga3ZtX3BndGFibGUgc3RydWN0dXJlLA0KPiBidXQgbm90IGRlc2NlbmRlbnQg cGFnaW5nIHN0cnVjdHVyZXMuDQo+IA0KRG8geW91IG1lYW4ga3ZtX2h5cF96YWxsb2NfcGFnZSgp IGhlcmU/DQpTZWVtcyBrdm1faHlwX3phbGxvY19wYWdlKCkgaXMgaW4gYm90aCBnbG9iYWwgYW5k IFZNIHNjb3Blcy4NCg0KSSB3aWxsIHJlcGxhY2UgR0ZQX0tFUk5FTCB3aXRoIFhYWF9BQ0NPVU5U IGluIG5leHQgdmVyc2lvbiBpZiBubyBvbmUgDQpvYmplY3RzIHRoYXQuDQoNCi0tDQpDaGVlcnMs DQpKdXN0aW4gKEppYSBIZSkNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406D5C433EF for ; Thu, 9 Sep 2021 13:39:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08F9A611C9 for ; Thu, 9 Sep 2021 13:39:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08F9A611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AfpFlWIsO4SbScD+vv4u4LAV971BMJ4/0VJhs4BpEZc=; b=dsUe5XQ1cH3LvL acmTj3OztkGnELnadlCFW9RHa3uoIlWeFMjxvmmviDr1NnneWcCLO/cXEhJvZQDQCybu8a7FBrRCN DLM5OhapEJWk1jvMq1ZpPJsRNuv3e4erALETrpjePTRjkagju/keyB3Yl9gykPNLRwuCRNpkoQbMU JUUoA/4J2Ygoumpxjyt4rZ//CLzYyeo7bmlbJf8KmWnV493BIO6R3vmNeabp3R647oB4Ru0VVwvow 32qhA6XzYHkgiX91kSE5Y/+et0Cu88iZq7nQyOnGGHKuxqVbtD6KlNuW/SaoqvVScqMqyF4plmdwL FWjeMxhwVuGD7aLkZrZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOKFC-009wG4-BE; Thu, 09 Sep 2021 13:37:35 +0000 Received: from mail-eopbgr80089.outbound.protection.outlook.com ([40.107.8.89] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOJc9-009dxI-Hz for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 12:57:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from AM5PR04CA0013.eurprd04.prod.outlook.com (2603:10a6:206:1::26) by PAXPR08MB7295.eurprd08.prod.outlook.com (2603:10a6:102:216::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 12:57:06 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::4a) by AM5PR04CA0013.outlook.office365.com (2603:10a6:206:1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 9 Sep 2021 12:57:06 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Thu, 09 Sep 2021 12:57:06 +0000 X-CR-MTA-TID: 64aa7808 Received: from e5ca704b8e4e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49F901FA-2EE5-4EDC-AE89-1DEF0FFC46DB.1; Thu, 09 Sep 2021 12:56:56 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5ca704b8e4e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Sep 2021 12:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGA52oiosLKDNqbLMSZ4Nt+pg2XzNnWF3tEe4T/W8y6Y3yGTm1M8Gy5Tm4oZjFqiz4LJADGuyrM+eyS5XoUAAb7ym9guMor0o/YoBtkotIiH5YZXDQ5zaimbj1mXITpDQ3ksiUJDdaHIHHtSXlHmCDIbwDVJOfqY23eTuumirbU4riLgHvHVXcMHFQi4BGs8sASMLYjjXRME7glztkqke38RRPxXuZZRvO2pcqajHnnT39B1hXZMxOUmnhW8XTq5OubppDz3IYC+PN2FcsonXtdQQ7MsSV127lNGombLb1P4ga99zYwkEayoGOM/YmIbxGvFR5XT8OH5gEU7UAjKnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=gHcKpql9yt+jLGxju7jEB7mGDjeky//COgn2IhHFIK9vKYp8VlfeKr8CUerG6GaNLgfvmfOv5eBxh2Y8Z4nyY0+MIIiFd3zHl45Oy6tU8hGDVnbZW6Ie+pUU54j4DBQffxaxztheqS5BwkMPbphiE7/XCCmxsDd43h/63rGQKhbrXFTBH52/5sJ2sdmqdwP01Gklg3RR9K114D6Fmtjc7d2G2T08clhZR4gktnkLc0OWlDZ85GGh0BypjMHjc8EN5JAmSRdr1ZD2qUgthMwdwlM62Rf9nnAsA4wTndZrgoz26CpvgBEuBz1v7j59r68XKPVRhqq3FehncAhGRiQVQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5C0FhhB88kzm/EoFfVRgA3kdYjY0oNY4Gkc/K7LWM0=; b=xrDY5yG2Yk8rS7krj6k/4zuekkVluZHQy4GL4IEYgSRvPAnBIEsSarSmTs0t0J4xq+37AMt4ZEr8CTxiTST/vHCkyMBj8Oydz3Vt1C1XC8kBX5MAM9ISSs+aSbuIo/w+1cEkMUISZw0JHpHhqkkK+RADRQUSCjDdKTQvYeYsa2M= Received: from AM6PR08MB4376.eurprd08.prod.outlook.com (2603:10a6:20b:bb::21) by AM6PR08MB2951.eurprd08.prod.outlook.com (2603:10a6:209:4e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep 2021 12:56:54 +0000 Received: from AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85]) by AM6PR08MB4376.eurprd08.prod.outlook.com ([fe80::a443:3fd9:42c2:4b85%5]) with mapi id 15.20.4500.016; Thu, 9 Sep 2021 12:56:54 +0000 From: Justin He To: Oliver Upton CC: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki Poulose , Xiaoming Ni , Lorenzo Pieralisi , Kees Cook , Catalin Marinas , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Liu Shixin , Sami Tolvanen , Will Deacon , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Topic: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Thread-Index: AQHXo+SXY1+Y7PRqPEOtXG6vaRVv1auZJ8aAgAI+QxA= Date: Thu, 9 Sep 2021 12:56:53 +0000 Message-ID: References: <20210907123112.10232-1-justin.he@arm.com> <20210907123112.10232-3-justin.he@arm.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8C57A8ADD3029A4887FFE0F106D44668.0 x-checkrecipientchecked: true Authentication-Results-Original: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9281043a-ff48-47ab-4bed-08d9739153ea x-ms-traffictypediagnostic: AM6PR08MB2951:|PAXPR08MB7295: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RXnSsvJKQI1XTJ2kESnnX1x9sagZJwq+s/YGfS2he5v14ZyYr0x0NhopD3uptwAS2nXUqUi/Xl8XLptmcMWYR4PYgpViRIGpQi4nUbVgcrtqjQRnerci3f61jd5xwmSCj1BsyYiLhFuTF3y2UYStXvsjG/HlM4EkXUnO03DBdzwoq/QLEbw52TOnaY3WsdlLtj4ocCQhgB29ZelUn2Cup2fB7m+fiHH2YHF5W9f2mbdQ1iOWyNi++T2a65yv9citzbNvubAcbsEowPf9uAMTPBi6jJO0ymHhhHk+jlLbp6KjwXA/0RokDB7EmtAL/HwWmlZg9nPuDWZFUe7H7soD42ySpHAH9R250k79kEqrnpgL8b7LDd566xwUBenlMXJs9brewwywS5NukITthmAURJH19S+3WnslMifOqo5yYP6/gR8srieIPhWn/z547xshNWsX8nDUmYpYmx5iKTiLRNIKjCLyMqCVmKpA6zQ44qN7gM9zSI+zDWdn2R+w2Gjdg4YTBS/dugTawLoi+HJHLhxFAccdILiFU2X2/k/QGl/nNF9kux5g5Ckt+ylry7s864pv8gLPcNKKCFmtMl0YXScsx5BsoD4oHdxDHBCNWrhu5TLZgUixC/KqUBn5lCwAGzaGPyeSgQsbt6MUZ4auebRT2tSU+Zz5rkzhlm89UVP9hJftu8NnNhrvJ9J/+PoYlJ/YWq3VVbrU7tpl7ISEOvbhUMPwoJ6cW+wv3oCPMmU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4376.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(122000001)(5660300002)(71200400001)(38100700002)(86362001)(2906002)(83380400001)(316002)(38070700005)(26005)(52536014)(66556008)(54906003)(33656002)(8936002)(6916009)(478600001)(66946007)(186003)(9686003)(7416002)(8676002)(55016002)(66476007)(15650500001)(7696005)(76116006)(53546011)(4326008)(6506007)(64756008)(66446008)(21314003); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2951 Original-Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 441c2f1a-f5b3-4d4f-435e-08d973914c7b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V8h6qGFhjqpkNcpKBMRCKPKWY/V4036ssQEBqHknc0x1oRbDSonQj0SSUPe+/r3+5RTs7igq8IyJxG6wrpCrf6ll4XebPgEdH7po/q2tOxysIG/kscpobMjKHTYBW2sNsaeBJxz27AWGpEVEXx53Q7ppzdbP88zpCW5SBhsPtBcxc4qLMnwbjOpKx++MrnqJdvAJYASfoBHjTqrsaIiGQ5WqEfvKWO81cS6F9ip97/JJ4JQEOyuoQsbyZz0ykB6CbJKjm3m4YyXKqoXpbDtjDovvcf9OxF9WWfdev1q++0rCzo1uiUPhSvFHMoSkYeWUYF5tnnB8uD57wjbefyGIo00g//876OE9AenTv2pPSNJH29o4oa/F0mMGMUNNmvf/J80NWqN19yGKeH6lPGGgnfnogEii/Sa4ZGrwUvnhxMIg2V+/lQJGPa5t+0jIpEmmcL2/Z+uWJODuBWF6qq0Ubtp2/2Ud4TMQfScdh4EPGJjlPQyhoZyiRhzyWQx9b9qJjr3aTdMZOLZ09yqMd2D0undj3UYfPdkW6jQffSe8iQd+XDZC1S/IiAfPTNFXbRrtAMp7/7otRs91xrLh903bftnpw9XFZQGpPkt+/Doh4KVt3FL5Db7YPfiW29La9x7Fp9uGsan7ecwU4CcUepns0Qb1DPvhmHaQZT0eNLITI5xhWZPllrXiMjMgGL0YHOdz8IOXmGNZ5t/fwKCqeG3VbFuldzYv0eWZvdzHUiMleEE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(33656002)(4326008)(82310400003)(36860700001)(2906002)(336012)(81166007)(70586007)(70206006)(8676002)(52536014)(8936002)(47076005)(5660300002)(186003)(7696005)(356005)(6506007)(6862004)(26005)(55016002)(86362001)(54906003)(83380400001)(9686003)(316002)(53546011)(15650500001)(508600001)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 12:57:06.3892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9281043a-ff48-47ab-4bed-08d9739153ea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7295 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_055713_751388_DA13EDF0 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oliver, thanks for the review, please my comments below: > -----Original Message----- > From: Oliver Upton > Sent: Wednesday, September 8, 2021 6:29 AM > To: Justin He > Cc: Marc Zyngier ; James Morse ; > Alexandru Elisei ; Suzuki Poulose > ; Xiaoming Ni ; Lorenzo > Pieralisi ; Kees Cook ; > Catalin Marinas ; Nick Desaulniers > ; linux-kernel@vger.kernel.org; Liu Shixin > ; Sami Tolvanen ; Will > Deacon ; kvmarm@lists.cs.columbia.edu; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM > allocations > > Hi Jia, > > On Tue, Sep 7, 2021 at 7:33 AM Jia He wrote: > > > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > > allocations"), it would be better to make arm64 KVM consistent with > > common kvm codes. > > > > The memory allocations of VM scope should be charged into VM process > > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > > > There remain a few cases since these allocations are global, not in VM > > scope. > > I believe there are more memory allocations that could be switched to > GFP_KERNEL_ACCOUNT. For non-pKVM kernels, we probably should charge > all stage-2 paging structure allocations to the VM process. Your patch > appears to only change the allocation of the kvm_pgtable structure, > but not descendent paging structures. > Do you mean kvm_hyp_zalloc_page() here? Seems kvm_hyp_zalloc_page() is in both global and VM scopes. I will replace GFP_KERNEL with XXX_ACCOUNT in next version if no one objects that. -- Cheers, Justin (Jia He) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel